)]}'
{"ironic_inspector/conf/discovery.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4edbf3af1be57e9d6d948ee64a5d063214521b5f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               help\u003d_(\u0027The name of the Ironic driver used by the enroll \u0027"},{"line_number":23,"context_line":"                      \u0027hook when creating a new node in Ironic.\u0027)),"},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027ip_version\u0027,"},{"line_number":25,"context_line":"                default\u003d[\u00274\u0027, \u00276\u0027],"},{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_460c5540","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":34},"updated":"2019-05-29 04:08:52.000000000","message":"The default value \u00274,6\u0027 here seems misleading, do we both support both v4 and v6 addresses? From _extract_node_driver_info we only chose one of address if IPv4 and IPv6 enabled.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"e6488111acfc8ffe158ea1f21e42b514259e1e81","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               help\u003d_(\u0027The name of the Ironic driver used by the enroll \u0027"},{"line_number":23,"context_line":"                      \u0027hook when creating a new node in Ironic.\u0027)),"},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027ip_version\u0027,"},{"line_number":25,"context_line":"                default\u003d[\u00274\u0027, \u00276\u0027],"},{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_52c96ba9","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":34},"in_reply_to":"bfb3d3c7_460c5540","updated":"2019-05-29 08:40:09.000000000","message":"I see there is one \u0027ipmi_address\u0027 property used everywhere. I assume  ironic can store only one address and it does not pay attention to version of that address. I mean ironic blindly puts the address to ipmitool like commands as far as ipmi driver is concerned. I do not know about behaviour of other popular drivers/interfaces. \nYes, maybe, ironic can use/store both v4 and v6 address. But I am afraid I am not allowed to make such improvement or redesign without broad team discussion. One popular approach is https://en.wikipedia.org/wiki/Happy_Eyeballs.\nHere I wanted to gently update existing code","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1b0fad7ccc13eb81e36549311b1c510612222f12","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               help\u003d_(\u0027The name of the Ironic driver used by the enroll \u0027"},{"line_number":23,"context_line":"                      \u0027hook when creating a new node in Ironic.\u0027)),"},{"line_number":24,"context_line":"    cfg.ListOpt(\u0027ip_version\u0027,"},{"line_number":25,"context_line":"                default\u003d[\u00274\u0027, \u00276\u0027],"},{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_12d21301","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":34},"in_reply_to":"bfb3d3c7_52c96ba9","updated":"2019-05-29 08:55:10.000000000","message":"Right, we don\u0027t support duel bmc address, it\u0027s also true for other vendor bmc addresses.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5b0b2bce53d590eb8305e19c67afc4d4d0e20640","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_6e594733","line":29,"updated":"2019-05-28 03:43:49.000000000","message":"the option is talking about ipmi address types, ip_version seems to be a bit broad, maybe change to something like enable_ipmi_address_version?\n\nsince the order of the option value matters, I think we need to make it obvious in the help message.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"e1801cd0cc3c9a8894613626ebdcb0d9f0076ab6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_c37cb784","line":29,"in_reply_to":"bfb3d3c7_544e4d6f","updated":"2019-05-29 01:20:28.000000000","message":"I\u0027d use enabled_ipmi_address_version, cause ip address not in the specified protocols will be ignored, I am not good at naming anyway :/","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"03885d6d1e59a0b14bb53142beacc74f2e8c48de","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_544e4d6f","line":29,"in_reply_to":"bfb3d3c7_6e594733","updated":"2019-05-28 10:36:39.000000000","message":"\u003e the option is talking about ipmi address types, ip_version seems to\n \u003e be a bit broad, maybe change to something like enable_ipmi_address_version?\n \u003e \n \u003e since the order of the option value matters, I think we need to\n \u003e make it obvious in the help message.\n\n\n\"enabled_ipmi_address_version\" ? Or maybe \"preferred_bmc_address_version\" ?","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"a26b9906ae072f1cdb33d76af881c4446e5af55a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database.\u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\", \"4,6\", \"6,4\", \"6\"\u0027)),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_3b3dccdc","line":29,"in_reply_to":"bfb3d3c7_6e594733","updated":"2019-05-28 08:39:57.000000000","message":"Ok. I will change it.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c9c6b0fc0e849f666fd7a9aabbdb0971db4f5ec4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address, \u0027"},{"line_number":32,"context_line":"                       \u0027opposite to \"4,6\"), \"6\" (use v6 address only and \u0027"},{"line_number":33,"context_line":"                       \u0027ignore v4 version). \u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_15ccef87","line":31,"range":{"start_line":31,"start_character":49,"end_line":31,"end_character":71},"updated":"2019-06-03 06:15:12.000000000","message":"What does the fall back to v4 means here?","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"08432d9d2488b22d8261e0d93a5318057c56c9d2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address, \u0027"},{"line_number":32,"context_line":"                       \u0027opposite to \"4,6\"), \"6\" (use v6 address only and \u0027"},{"line_number":33,"context_line":"                       \u0027ignore v4 version). \u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_5fcb61a4","line":31,"range":{"start_line":31,"start_character":49,"end_line":31,"end_character":71},"in_reply_to":"9fb8cfa7_15ccef87","updated":"2019-06-03 09:00:01.000000000","message":"Let say there are two or more BMCs. Almost all of them have v6 and v4 addresses but there could one with only v4 address. Inspector will choose v6 address if possible but for the one particular BMC inspector will take v4 address.  \nCould you propose better help text ?","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3e5f6e28f77ed46ec8b31b205f2638d54f91ed2b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address, \u0027"},{"line_number":32,"context_line":"                       \u0027opposite to \"4,6\"), \"6\" (use v6 address only and \u0027"},{"line_number":33,"context_line":"                       \u0027ignore v4 version). \u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_b2b72287","line":31,"range":{"start_line":31,"start_character":49,"end_line":31,"end_character":71},"in_reply_to":"9fb8cfa7_5fcb61a4","updated":"2019-06-04 05:42:06.000000000","message":"This looks fine. But may be:\n\ns/fall back to v4 address/fall back to v4 address for BMCs having v4 address/","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d3f77a0e1db404159b4a2293be3b463a04c0f6bb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address, \u0027"},{"line_number":32,"context_line":"                       \u0027opposite to \"4,6\"), \"6\" (use v6 address only and \u0027"},{"line_number":33,"context_line":"                       \u0027ignore v4 version). \u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_8f9e7405","line":31,"range":{"start_line":31,"start_character":49,"end_line":31,"end_character":71},"in_reply_to":"9fb8cfa7_b2b72287","updated":"2019-06-04 09:18:17.000000000","message":"Ok.","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.ListOpt(\u0027enabled_bmc_address_version\u0027,"},{"line_number":25,"context_line":"                default\u003d[\u00274\u0027, \u00276\u0027],"},{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database. \u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_cda4620b","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":42},"updated":"2019-06-05 04:06:39.000000000","message":"nit: s/creating/enrolling/","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.ListOpt(\u0027enabled_bmc_address_version\u0027,"},{"line_number":25,"context_line":"                default\u003d[\u00274\u0027, \u00276\u0027],"},{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database. \u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_2da09ef4","line":27,"range":{"start_line":27,"start_character":64,"end_line":27,"end_character":72},"updated":"2019-06-05 04:06:39.000000000","message":"nit: s/database//","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d9070d906015344c66f832dac29ac2c04becb2a6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    cfg.ListOpt(\u0027enabled_bmc_address_version\u0027,"},{"line_number":25,"context_line":"                default\u003d[\u00274\u0027, \u00276\u0027],"},{"line_number":26,"context_line":"                help\u003d_(\u0027IP version of BMC address that will be \u0027"},{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database. \u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_b2ece629","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":42},"in_reply_to":"9fb8cfa7_cda4620b","updated":"2019-06-05 09:26:26.000000000","message":"Thanks","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database. \u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address \u0027"},{"line_number":32,"context_line":"                       \u0027for BMCs having v4 address, opposite to \"4,6\"), \u0027"},{"line_number":33,"context_line":"                       \u0027\"6\" (use v6 address only and ignore v4 version).\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_0d84ba5d","line":30,"range":{"start_line":30,"start_character":70,"end_line":30,"end_character":71},"updated":"2019-06-05 04:06:39.000000000","message":"nit: extra space","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d9070d906015344c66f832dac29ac2c04becb2a6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                       \u0027used when creating a new node in Ironic database. \u0027"},{"line_number":28,"context_line":"                       \u0027Defaults to \"4,6\". Could be \"4\" (use v4 address \u0027"},{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address \u0027"},{"line_number":32,"context_line":"                       \u0027for BMCs having v4 address, opposite to \"4,6\"), \u0027"},{"line_number":33,"context_line":"                       \u0027\"6\" (use v6 address only and ignore v4 version).\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_52f32a0b","line":30,"range":{"start_line":30,"start_character":70,"end_line":30,"end_character":71},"in_reply_to":"9fb8cfa7_0d84ba5d","updated":"2019-06-05 09:26:26.000000000","message":"Thanks","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address \u0027"},{"line_number":32,"context_line":"                       \u0027for BMCs having v4 address, opposite to \"4,6\"), \u0027"},{"line_number":33,"context_line":"                       \u0027\"6\" (use v6 address only and ignore v4 version).\u0027)),"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_cdcb02a3","line":32,"updated":"2019-06-05 04:06:39.000000000","message":"The help message is a bit redundant, do you have any idea to simplify it? Like: Use the first available bmc address in the order of specified IP version(s).","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d9070d906015344c66f832dac29ac2c04becb2a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \u0027only), \"4,6\" (v4 address have higher priority and \u0027"},{"line_number":30,"context_line":"                       \u0027if both addresses found v6 version is ignored) , \u0027"},{"line_number":31,"context_line":"                       \u0027\"6,4\" (v6 is desired but fall back to v4 address \u0027"},{"line_number":32,"context_line":"                       \u0027for BMCs having v4 address, opposite to \"4,6\"), \u0027"},{"line_number":33,"context_line":"                       \u0027\"6\" (use v6 address only and ignore v4 version).\u0027)),"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_af98011b","line":32,"in_reply_to":"9fb8cfa7_cdcb02a3","updated":"2019-06-05 09:26:26.000000000","message":"I do not mind to change to whatever text. \nI like long stories with happy end.","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"}],"ironic_inspector/plugins/discovery.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5b0b2bce53d590eb8305e19c67afc4d4d0e20640","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_0eb0cb42","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":42},"updated":"2019-05-28 03:43:49.000000000","message":"I think we should assign ipv6 address to \u0027ipmi_v6address\u0027.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"03885d6d1e59a0b14bb53142beacc74f2e8c48de","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_141f755b","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":42},"in_reply_to":"bfb3d3c7_0eb0cb42","updated":"2019-05-28 10:36:39.000000000","message":"\u003e I think we should assign ipv6 address to \u0027ipmi_v6address\u0027.\n\nHmm. \"node_driver_info\" assigned to \u0027driver_info\u0027 as is. If we start using  ipmi_v6address together with ipmi_address we will need to add IFs everywhere in ironic-inspector and ironic projects.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"a26b9906ae072f1cdb33d76af881c4446e5af55a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_5b1be07f","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":42},"in_reply_to":"bfb3d3c7_0eb0cb42","updated":"2019-05-28 08:39:57.000000000","message":"Ok","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"e1801cd0cc3c9a8894613626ebdcb0d9f0076ab6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_43f767d4","line":39,"range":{"start_line":39,"start_character":30,"end_line":39,"end_character":42},"in_reply_to":"bfb3d3c7_141f755b","updated":"2019-05-29 01:20:28.000000000","message":"Oh, I commented the wrong place, please ignore above comment, sorry.\nWhat I mean is https://opendev.org/openstack/ironic-inspector/src/commit/9819bf3012668a81d374aa9256812bf2446083fb/ironic_inspector/plugins/standard.py#L245-L250\nWe\u0027ll need to add ipmi_v6address support there.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c9c6b0fc0e849f666fd7a9aabbdb0971db4f5ec4","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"},{"line_number":43,"context_line":"                    \u0027created without ipmi address\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_95a53fb8","line":40,"updated":"2019-06-03 06:15:12.000000000","message":"The method doesn\u0027t cover the case:\n\n  CONF.discovery.enabled_bmc_address_version \u003d\u003d \"4,6\"\n  CONF.discovery.enabled_bmc_address_version \u003d\u003d \"6,4\"","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d3f77a0e1db404159b4a2293be3b463a04c0f6bb","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"},{"line_number":43,"context_line":"                    \u0027created without ipmi address\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_6fd780c1","line":40,"in_reply_to":"9fb8cfa7_5204a617","updated":"2019-06-04 09:18:17.000000000","message":"Code handles all four use cases. Check it out here https://repl.it/@NikolayFedotov/SlightAquaLicense","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"efdbfef30bd34f103fa477abed3a03d6c8fe851f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"},{"line_number":43,"context_line":"                    \u0027created without ipmi address\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_96269bb7","line":40,"in_reply_to":"9fb8cfa7_95a53fb8","updated":"2019-06-03 17:26:23.000000000","message":"I guess you have not noticed FOR loop at line #31. It iterates [4 , 6] or [6, 4] list and breaks the loops as soon as non None address is found. \nELSE (line #41 - 43) called if FOR loop is not get interrupted by BREAK. I hope FOR-ELSE looks good here.","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"3e5f6e28f77ed46ec8b31b205f2638d54f91ed2b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if address:"},{"line_number":39,"context_line":"            node_driver_info[\u0027ipmi_address\u0027] \u003d address"},{"line_number":40,"context_line":"            break"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"        LOG.warning(\u0027No BMC address provided, discovered node will be \u0027"},{"line_number":43,"context_line":"                    \u0027created without ipmi address\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_5204a617","line":40,"in_reply_to":"9fb8cfa7_96269bb7","updated":"2019-06-04 05:42:06.000000000","message":"As per the config definition in ironic_inspector/conf/discovery.py file, it seems the CONF.discovery.enabled_bmc_address_version can have these values:\n - 4\n - 6\n - 4,6\n - 6,4\n\nThe code above handles the first two values and not the second two.\nIs that correct?","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"}],"ironic_inspector/plugins/standard.py":[{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"8914bdb40eab485619841931cf7600d53c29dee1","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        bmc_address \u003d utils.get_ipmi_address_from_data(introspection_data)"},{"line_number":246,"context_line":"        bmc_v6address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":247,"context_line":"        # Overwrite the old ipmi_address field to avoid inconsistency"},{"line_number":248,"context_line":"        introspection_data[\u0027ipmi_address\u0027] \u003d bmc_address"},{"line_number":249,"context_line":"        introspection_data[\u0027ipmi_v6address\u0027] \u003d bmc_v6address"},{"line_number":250,"context_line":"        if not (bmc_address or bmc_v6address):"},{"line_number":251,"context_line":"            LOG.debug(\u0027No BMC address provided in introspection data, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_e8b15d45","line":248,"updated":"2019-05-31 14:19:35.000000000","message":"Can someone explain what is this line for ? \nI added similar line below (line #249). Ok?","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3ad4a04a6ffef6614383c8fa94481b103eed8fda","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        bmc_address \u003d utils.get_ipmi_address_from_data(introspection_data)"},{"line_number":246,"context_line":"        bmc_v6address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":247,"context_line":"        # Overwrite the old ipmi_address field to avoid inconsistency"},{"line_number":248,"context_line":"        introspection_data[\u0027ipmi_address\u0027] \u003d bmc_address"},{"line_number":249,"context_line":"        introspection_data[\u0027ipmi_v6address\u0027] \u003d bmc_v6address"},{"line_number":250,"context_line":"        if not (bmc_address or bmc_v6address):"},{"line_number":251,"context_line":"            LOG.debug(\u0027No BMC address provided in introspection data, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_1a217cb5","line":248,"in_reply_to":"bfb3d3c7_e8b15d45","updated":"2019-06-03 06:11:27.000000000","message":"My guessing on the purpose is compatibility, maybe in old IPA we used ipmi_address and later we put it under inventory field someday thereafter.","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"}],"ironic_inspector/process.py":[{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"8914bdb40eab485619841931cf7600d53c29dee1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        address \u003d utils.get_ipmi_address_from_data(introspection_data)"},{"line_number":83,"context_line":"        v6address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":84,"context_line":"        return node_cache.find_node("},{"line_number":85,"context_line":"            bmc_address\u003d[address, v6address],"},{"line_number":86,"context_line":"            mac\u003dutils.get_valid_macs(introspection_data))"},{"line_number":87,"context_line":"    except utils.NotFoundInCacheError as exc:"},{"line_number":88,"context_line":"        not_found_hook \u003d plugins_base.node_not_found_hook_manager()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_c8e4993e","line":85,"updated":"2019-05-31 14:19:35.000000000","message":"Use tuple instead of list?","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3ad4a04a6ffef6614383c8fa94481b103eed8fda","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        address \u003d utils.get_ipmi_address_from_data(introspection_data)"},{"line_number":83,"context_line":"        v6address \u003d utils.get_ipmi_v6address_from_data(introspection_data)"},{"line_number":84,"context_line":"        return node_cache.find_node("},{"line_number":85,"context_line":"            bmc_address\u003d[address, v6address],"},{"line_number":86,"context_line":"            mac\u003dutils.get_valid_macs(introspection_data))"},{"line_number":87,"context_line":"    except utils.NotFoundInCacheError as exc:"},{"line_number":88,"context_line":"        not_found_hook \u003d plugins_base.node_not_found_hook_manager()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_ba2dd0a9","line":85,"in_reply_to":"bfb3d3c7_c8e4993e","updated":"2019-06-03 06:11:27.000000000","message":"it needs to be either a primitive type or a list.","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"}],"ironic_inspector/test/unit/test_plugins_discovery.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"5b0b2bce53d590eb8305e19c67afc4d4d0e20640","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        introspection_data \u003d {\u0027ipmi_v6address\u0027: ipmi_v6address}"},{"line_number":85,"context_line":"        expected_data \u003d introspection_data.copy()"},{"line_number":86,"context_line":"        mock_check_existing \u003d copy_call_args(mock_check_existing)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        discovery.enroll_node_not_found_hook(introspection_data)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        mock_create_node.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_ae7c1f83","line":87,"updated":"2019-05-28 03:43:49.000000000","message":"let\u0027s have a test for the case ipv4/6 addresses are both available, and the chosen one is the first available in the order.","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"a26b9906ae072f1cdb33d76af881c4446e5af55a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        introspection_data \u003d {\u0027ipmi_v6address\u0027: ipmi_v6address}"},{"line_number":85,"context_line":"        expected_data \u003d introspection_data.copy()"},{"line_number":86,"context_line":"        mock_check_existing \u003d copy_call_args(mock_check_existing)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        discovery.enroll_node_not_found_hook(introspection_data)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        mock_create_node.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_9b2b9893","line":87,"in_reply_to":"bfb3d3c7_ae7c1f83","updated":"2019-05-28 08:39:57.000000000","message":"Ok","commit_id":"2ff6847a8ac94eaac39927d5b159907d0f869dd7"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"8914bdb40eab485619841931cf7600d53c29dee1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                      mock_create_node):"},{"line_number":62,"context_line":"        mock_client.return_value \u003d self.ironic"},{"line_number":63,"context_line":"        ipmi_v6address \u003d \u00272001:1234:1234:1234:1234:1234:1234:1234/64\u0027"},{"line_number":64,"context_line":"        introspection_data \u003d {\u0027ipmi_address\u0027: \u00271.2.3.4\u0027, \u0027ipmi_v6address\u0027: ipmi_v6address}"},{"line_number":65,"context_line":"        expected_data \u003d introspection_data.copy()"},{"line_number":66,"context_line":"        mock_check_existing \u003d copy_call_args(mock_check_existing)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_483f4986","line":64,"updated":"2019-05-31 14:19:35.000000000","message":"Both ipmi addresses are set but mock_create_node called with first one.","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"15190644f1be750785b2a75ba623f5479dd4a62a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        mock_create_node.assert_called_once_with("},{"line_number":72,"context_line":"            \u0027fake-hardware\u0027, ironic\u003dself.ironic,"},{"line_number":73,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: \u00271.2.3.4\u0027})"},{"line_number":74,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":75,"context_line":"            expected_data, {\u0027ipmi_address\u0027: \u00271.2.3.4\u0027}, self.ironic)"},{"line_number":76,"context_line":"        self.assertEqual({\u0027ipmi_address\u0027: \u00271.2.3.4\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_ec62a316","line":73,"range":{"start_line":73,"start_character":41,"end_line":73,"end_character":50},"updated":"2019-06-04 02:11:01.000000000","message":"Although it\u0027s not related to this patch, if you are not mind, I think this also can changed to self.bmc_address","commit_id":"084615ba91794af3af5de3e4b8b57f5bf81c15df"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"15190644f1be750785b2a75ba623f5479dd4a62a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027fake-hardware\u0027, ironic\u003dself.ironic,"},{"line_number":73,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: \u00271.2.3.4\u0027})"},{"line_number":74,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":75,"context_line":"            expected_data, {\u0027ipmi_address\u0027: \u00271.2.3.4\u0027}, self.ironic)"},{"line_number":76,"context_line":"        self.assertEqual({\u0027ipmi_address\u0027: \u00271.2.3.4\u0027,"},{"line_number":77,"context_line":"                          \u0027ipmi_v6address\u0027: ipmi_v6address,"},{"line_number":78,"context_line":"                          \u0027auto_discovered\u0027: True},"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_0c6857f3","line":75,"range":{"start_line":75,"start_character":44,"end_line":75,"end_character":53},"updated":"2019-06-04 02:11:01.000000000","message":"ditto","commit_id":"084615ba91794af3af5de3e4b8b57f5bf81c15df"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"15190644f1be750785b2a75ba623f5479dd4a62a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: \u00271.2.3.4\u0027})"},{"line_number":74,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":75,"context_line":"            expected_data, {\u0027ipmi_address\u0027: \u00271.2.3.4\u0027}, self.ironic)"},{"line_number":76,"context_line":"        self.assertEqual({\u0027ipmi_address\u0027: \u00271.2.3.4\u0027,"},{"line_number":77,"context_line":"                          \u0027ipmi_v6address\u0027: ipmi_v6address,"},{"line_number":78,"context_line":"                          \u0027auto_discovered\u0027: True},"},{"line_number":79,"context_line":"                         introspection_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_ac6cab08","line":76,"range":{"start_line":76,"start_character":42,"end_line":76,"end_character":51},"updated":"2019-06-04 02:11:01.000000000","message":"ditto","commit_id":"084615ba91794af3af5de3e4b8b57f5bf81c15df"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"15190644f1be750785b2a75ba623f5479dd4a62a","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        mock_create_node.assert_called_once_with("},{"line_number":98,"context_line":"            \u0027fake-hardware\u0027, ironic\u003dself.ironic,"},{"line_number":99,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: ipmi_v6address})"},{"line_number":100,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":101,"context_line":"            expected_data, {\u0027ipmi_address\u0027: self.bmc_v6address}, self.ironic)"},{"line_number":102,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_6cb1d38f","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":55},"updated":"2019-06-04 02:11:01.000000000","message":"Is this also self.bmc_v6address?","commit_id":"084615ba91794af3af5de3e4b8b57f5bf81c15df"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"c6dbb1919ec087df4d239e513c2c4fd75ebef4d0","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        mock_create_node.assert_called_once_with("},{"line_number":98,"context_line":"            \u0027fake-hardware\u0027, ironic\u003dself.ironic,"},{"line_number":99,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: ipmi_v6address})"},{"line_number":100,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":101,"context_line":"            expected_data, {\u0027ipmi_address\u0027: self.bmc_v6address}, self.ironic)"},{"line_number":102,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_3b9b01ca","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":55},"updated":"2019-06-04 15:39:15.000000000","message":"I would prefer to use self.bmc_v6address here, though these values are equal.\n\nThe _check_existing_nodes and create_node functions using node_driver_info,\nthis value is a result of utils.get_ipmi_address_from_data.\nSo it\u0027s better to use the value you had defined in Inventory test.","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        mock_create_node.assert_called_once_with("},{"line_number":98,"context_line":"            \u0027fake-hardware\u0027, ironic\u003dself.ironic,"},{"line_number":99,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: ipmi_v6address})"},{"line_number":100,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":101,"context_line":"            expected_data, {\u0027ipmi_address\u0027: self.bmc_v6address}, self.ironic)"},{"line_number":102,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_4dbf12fb","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":55},"in_reply_to":"9fb8cfa7_3b9b01ca","updated":"2019-06-05 04:06:39.000000000","message":"follow up: https://review.opendev.org/663062","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d9070d906015344c66f832dac29ac2c04becb2a6","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        mock_create_node.assert_called_once_with("},{"line_number":98,"context_line":"            \u0027fake-hardware\u0027, ironic\u003dself.ironic,"},{"line_number":99,"context_line":"            driver_info\u003d{\u0027ipmi_address\u0027: ipmi_v6address})"},{"line_number":100,"context_line":"        mock_check_existing.assert_called_once_with("},{"line_number":101,"context_line":"            expected_data, {\u0027ipmi_address\u0027: self.bmc_v6address}, self.ironic)"},{"line_number":102,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_d2915a9b","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":55},"in_reply_to":"9fb8cfa7_4dbf12fb","updated":"2019-06-05 09:26:26.000000000","message":"\u003e follow up: https://review.opendev.org/663062\n\nI left comment there.","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"}],"ironic_inspector/utils.py":[{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"8914bdb40eab485619841931cf7600d53c29dee1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        result \u003d introspection_data[\u0027inventory\u0027][\u0027bmc_v6address\u0027]"},{"line_number":49,"context_line":"    except KeyError:"},{"line_number":50,"context_line":"        result \u003d introspection_data.get(\u0027ipmi_v6address\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if result in (\u0027\u0027, \u0027::/0\u0027):"},{"line_number":53,"context_line":"        # ipmitool can return these values, if it does not know the address"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_4858a9f8","line":50,"updated":"2019-05-31 14:19:35.000000000","message":"Nothing strange here? Getting ipmi_v6address is ok?","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3ad4a04a6ffef6614383c8fa94481b103eed8fda","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        result \u003d introspection_data[\u0027inventory\u0027][\u0027bmc_v6address\u0027]"},{"line_number":49,"context_line":"    except KeyError:"},{"line_number":50,"context_line":"        result \u003d introspection_data.get(\u0027ipmi_v6address\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if result in (\u0027\u0027, \u0027::/0\u0027):"},{"line_number":53,"context_line":"        # ipmitool can return these values, if it does not know the address"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7589ab24","line":50,"in_reply_to":"bfb3d3c7_4858a9f8","updated":"2019-06-03 06:11:27.000000000","message":"I think it\u0027s ok. ipmi_v6address will be available after plugin preprocessing, but before that, only inventory/bmc_v6address is available.","commit_id":"6d2a3ed8328800e069065ffca3c6415c6d9b1440"}],"releasenotes/notes/enroll-nodes-with-bmc-v6address-ba224f4a8a151c53.yaml":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c9c6b0fc0e849f666fd7a9aabbdb0971db4f5ec4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enroll node with BMC IPv6 address. Configuration option"},{"line_number":5,"context_line":"    discovery.enabled_bmc_address_version allows to tune which"},{"line_number":6,"context_line":"    IP version is desired or completely disable one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_f57cbb21","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":41},"updated":"2019-06-03 06:15:12.000000000","message":"s/discovery.enabled_bmc_address_version/``[discovery]/enabled_bmc_address_version``/","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d3f77a0e1db404159b4a2293be3b463a04c0f6bb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enroll node with BMC IPv6 address. Configuration option"},{"line_number":5,"context_line":"    discovery.enabled_bmc_address_version allows to tune which"},{"line_number":6,"context_line":"    IP version is desired or completely disable one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_f66277d8","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":41},"in_reply_to":"9fb8cfa7_f57cbb21","updated":"2019-06-04 09:18:17.000000000","message":"\u003e s/discovery.enabled_bmc_address_version/``[discovery]/enabled_bmc_address_version``/","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"efdbfef30bd34f103fa477abed3a03d6c8fe851f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enroll node with BMC IPv6 address. Configuration option"},{"line_number":5,"context_line":"    discovery.enabled_bmc_address_version allows to tune which"},{"line_number":6,"context_line":"    IP version is desired or completely disable one."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_1632abf2","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":41},"in_reply_to":"9fb8cfa7_f57cbb21","updated":"2019-06-03 17:26:23.000000000","message":"Thanks!","commit_id":"a366a505a2c0fc59591916e276d26c627f4cb7b9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Enroll node with BMC IPv6 address. Configuration option"},{"line_number":5,"context_line":"    \"[discovery]/enabled_bmc_address_version\" allows to tune which"},{"line_number":6,"context_line":"    IP version is desired or completely disable one."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_4d02b2b6","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":5},"updated":"2019-06-05 04:06:39.000000000","message":"nit: we use ``words here`` for mono text.","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9b009d84c7fc26b22e69b32eb302b398cc9dbb0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_cd0ea2e4","line":7,"updated":"2019-06-05 04:06:39.000000000","message":"Maybe reword like this:\n\nAdds support to enroll node with IPv6 BMC address. Introduces a configuration option ``[discovery]enabled_bmc_address_version`` to specify the order of preferred IP version of the BMC address.","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"},{"author":{"_account_id":8767,"name":"Nikolay Fedotov","email":"nfedotov@cisco.com","username":"nfedotov"},"change_message_id":"d9070d906015344c66f832dac29ac2c04becb2a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fb8cfa7_32d8f67d","line":7,"in_reply_to":"9fb8cfa7_cd0ea2e4","updated":"2019-06-05 09:26:26.000000000","message":"\u003e Maybe reword like this:\n \u003e \n \u003e Adds support to enroll node with IPv6 BMC address. Introduces a\n \u003e configuration option ``[discovery]enabled_bmc_address_version`` to\n \u003e specify the order of preferred IP version of the BMC address.\n\nOk","commit_id":"294e7f047465bfc3fe2e2bedf210e197ba33d3fa"}]}