)]}'
{"ironic_inspector/common/ironic.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"bad6b8ec8386f577b708dce63d6798548d93ab9f","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def lookup_node(macs\u003dNone, bmc_addresses\u003dNone, introspection_data\u003dNone,"},{"line_number":273,"context_line":"                ironic\u003dNone):"},{"line_number":274,"context_line":"    \"\"\"Lookup a node in the ironic database.\"\"\""},{"line_number":275,"context_line":"    node \u003d node2 \u003d None"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6e0c713b","side":"PARENT","line":273,"updated":"2019-07-23 01:32:24.000000000","message":"Actually it\u0027s used for logging/exception in the lookup_node_by_macs and bmc_addresses.\nWe could pass this argument down, this restores the code piece extracted from discovery, or we remove them all (also my preference).","commit_id":"0c9447d53b092c1b057998d9a159fbe88a3b881e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c135ee56f17f0ea38d25c19bddfebf8466e91a14","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def lookup_node(macs\u003dNone, bmc_addresses\u003dNone, introspection_data\u003dNone,"},{"line_number":273,"context_line":"                ironic\u003dNone):"},{"line_number":274,"context_line":"    \"\"\"Lookup a node in the ironic database.\"\"\""},{"line_number":275,"context_line":"    node \u003d node2 \u003d None"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3b3096e8","side":"PARENT","line":273,"in_reply_to":"7faddb67_55a764a8","updated":"2019-07-30 00:53:39.000000000","message":"okay.. ideally I think we\u0027ll remove the introspection_data argument as it\u0027s always None.","commit_id":"0c9447d53b092c1b057998d9a159fbe88a3b881e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ad3b4e676c1f48f0f0f86d582372a1fff9818889","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def lookup_node(macs\u003dNone, bmc_addresses\u003dNone, introspection_data\u003dNone,"},{"line_number":273,"context_line":"                ironic\u003dNone):"},{"line_number":274,"context_line":"    \"\"\"Lookup a node in the ironic database.\"\"\""},{"line_number":275,"context_line":"    node \u003d node2 \u003d None"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_55a764a8","side":"PARENT","line":273,"in_reply_to":"7faddb67_6e0c713b","updated":"2019-07-29 18:43:03.000000000","message":"I could have sworn I dug through the code and didn\u0027t see that getting used. In that case, I\u0027ll just leave this as-is.","commit_id":"0c9447d53b092c1b057998d9a159fbe88a3b881e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c135ee56f17f0ea38d25c19bddfebf8466e91a14","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        elif fail:"},{"line_number":223,"context_line":"            raise utils.Error("},{"line_number":224,"context_line":"                _(\u0027Port %(mac)s already exists, uuid: %(uuid)s\u0027) %"},{"line_number":225,"context_line":"                {\u0027mac\u0027: mac, \u0027uuid\u0027: ports[0].uuid}, data\u003dintrospection_data)"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            nodes.update(p.node_uuid for p in ports)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9b218aa2","line":225,"range":{"start_line":225,"start_character":53,"end_line":225,"end_character":76},"updated":"2019-07-30 00:53:39.000000000","message":"here is the reference code.","commit_id":"53463ca6d7957c0449dc39910479d7ca8b99d746"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c135ee56f17f0ea38d25c19bddfebf8466e91a14","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                            \u0027one node: %(nodes)s\u0027) %"},{"line_number":232,"context_line":"                          {\u0027macs\u0027: \u0027, \u0027.join(macs),"},{"line_number":233,"context_line":"                           \u0027nodes\u0027: \u0027, \u0027.join(nodes)},"},{"line_number":234,"context_line":"                          data\u003dintrospection_data)"},{"line_number":235,"context_line":"    elif nodes:"},{"line_number":236,"context_line":"        return nodes.pop()"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bb2486b0","line":234,"range":{"start_line":234,"start_character":26,"end_line":234,"end_character":49},"updated":"2019-07-30 00:53:39.000000000","message":"and here","commit_id":"53463ca6d7957c0449dc39910479d7ca8b99d746"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"c135ee56f17f0ea38d25c19bddfebf8466e91a14","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        return nodes.pop()"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"def lookup_node_by_bmc_addresses(addresses, introspection_data\u003dNone,"},{"line_number":240,"context_line":"                                 ironic\u003dNone, fail\u003dFalse):"},{"line_number":241,"context_line":"    \"\"\"Find a node by its BMC address.\"\"\""},{"line_number":242,"context_line":"    if ironic is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_7b360eea","line":239,"range":{"start_line":239,"start_character":4,"end_line":239,"end_character":32},"updated":"2019-07-30 00:53:39.000000000","message":"similar to function above.","commit_id":"53463ca6d7957c0449dc39910479d7ca8b99d746"}]}