)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9ed1e6fa9835d64cebb9072c9c5e8a3b038d3a0d","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        iniset \"$IRONIC_CONF_FILE\" inspector require_managed_boot True"},{"line_number":344,"context_line":"        iniset \"$IRONIC_CONF_FILE\" inspector extra_kernel_params \\"},{"line_number":345,"context_line":"            \"ipa-inspection-collectors\u003d\\\"$IRONIC_INSPECTOR_COLLECTORS\\\"\""},{"line_number":346,"context_line":"    fi"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    setup_logging $IRONIC_INSPECTOR_CONF_FILE DEFAULT"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_7d172df0","line":346,"updated":"2019-11-29 02:58:38.000000000","message":"we should set can_manage_boot\u003dFalse here, to be explicit, also set True when IRONIC_INSPECTOR_MANAGED_BOOT\u003dFalse.","commit_id":"3b05591e5c759a7a84558f1308f06ab9998a52ae"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fa17b00d4f7f7cb7a6351b15f9569dba64158a5f","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        sudo ip addr add $IRONIC_INSPECTOR_INTERNAL_IP_WITH_NET dev $IRONIC_INSPECTOR_INTERFACE"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p udp \\"},{"line_number":443,"context_line":"            --dport 69 -j ACCEPT"},{"line_number":444,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p tcp \\"},{"line_number":445,"context_line":"            --dport $IRONIC_INSPECTOR_PORT -j ACCEPT"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_3f8d4935","line":443,"updated":"2019-11-27 08:55:47.000000000","message":"nit: as far as I love staying below the 80 chars, since we\u0027re not strictly checking for it in bash, we could just put all in one line, just for consistency with the rest of the code","commit_id":"3b05591e5c759a7a84558f1308f06ab9998a52ae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4f92e6ecd8c27b09c814721130468a2c9be55bca","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        sudo ip addr add $IRONIC_INSPECTOR_INTERNAL_IP_WITH_NET dev $IRONIC_INSPECTOR_INTERFACE"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p udp \\"},{"line_number":443,"context_line":"            --dport 69 -j ACCEPT"},{"line_number":444,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p tcp \\"},{"line_number":445,"context_line":"            --dport $IRONIC_INSPECTOR_PORT -j ACCEPT"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_9096aaa0","line":443,"in_reply_to":"3fa7e38b_3f8d4935","updated":"2019-11-27 11:25:09.000000000","message":"It\u0027s a copy-paste from former lines 431-434, it was already like that.","commit_id":"3b05591e5c759a7a84558f1308f06ab9998a52ae"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9ed1e6fa9835d64cebb9072c9c5e8a3b038d3a0d","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        sudo ip addr add $IRONIC_INSPECTOR_INTERNAL_IP_WITH_NET dev $IRONIC_INSPECTOR_INTERFACE"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p udp \\"},{"line_number":443,"context_line":"            --dport 69 -j ACCEPT"},{"line_number":444,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p tcp \\"},{"line_number":445,"context_line":"            --dport $IRONIC_INSPECTOR_PORT -j ACCEPT"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_9dfb09bd","line":443,"in_reply_to":"3fa7e38b_9096aaa0","updated":"2019-11-29 02:58:38.000000000","message":"well, something like line too lone against line too long + 4, fine with me.","commit_id":"3b05591e5c759a7a84558f1308f06ab9998a52ae"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fa17b00d4f7f7cb7a6351b15f9569dba64158a5f","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p udp \\"},{"line_number":443,"context_line":"            --dport 69 -j ACCEPT"},{"line_number":444,"context_line":"        sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p tcp \\"},{"line_number":445,"context_line":"            --dport $IRONIC_INSPECTOR_PORT -j ACCEPT"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if [[ \"$IRONIC_INSPECTOR_STANDALONE\" \u003d\u003d \"False\" ]]; then"},{"line_number":448,"context_line":"            sudo iptables -I INPUT -i $IRONIC_INSPECTOR_INTERFACE -p tcp --dport 80 -j ACCEPT"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_df99957a","line":445,"updated":"2019-11-27 08:55:47.000000000","message":"ditto","commit_id":"3b05591e5c759a7a84558f1308f06ab9998a52ae"}]}