)]}'
{"ironic_inspector/plugins/standard.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d77b92dc3a9613f029ad1b803c2592435de4d5","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            expected_macs \u003d set(introspection_data[\u0027macs\u0027])"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        node_provision_state \u003d node_info.node().provision_state"},{"line_number":278,"context_line":"        if (CONF.processing.permit_active_introspection and"},{"line_number":279,"context_line":"                node_provision_state \u003d\u003d \u0027active\u0027):"},{"line_number":280,"context_line":"            return"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1b1cda79","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":55},"updated":"2019-12-03 13:40:15.000000000","message":"You don\u0027t have to check this. If we get to this point, we know that it\u0027s allowed.","commit_id":"a67d5d6676fd2a4f02e24078027f43c93a8221d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d77b92dc3a9613f029ad1b803c2592435de4d5","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        node_provision_state \u003d node_info.node().provision_state"},{"line_number":278,"context_line":"        if (CONF.processing.permit_active_introspection and"},{"line_number":279,"context_line":"                node_provision_state \u003d\u003d \u0027active\u0027):"},{"line_number":280,"context_line":"            return"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if CONF.processing.keep_ports !\u003d \u0027all\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_be31f4ef","line":279,"updated":"2019-12-03 13:40:15.000000000","message":"Let\u0027s use this constant instead https://opendev.org/openstack/ironic-inspector/src/branch/master/ironic_inspector/common/ironic.py#L34 to make sure we don\u0027t miss any state (like rescue in this case).","commit_id":"a67d5d6676fd2a4f02e24078027f43c93a8221d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"56d77b92dc3a9613f029ad1b803c2592435de4d5","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        node_provision_state \u003d node_info.node().provision_state"},{"line_number":278,"context_line":"        if (CONF.processing.permit_active_introspection and"},{"line_number":279,"context_line":"                node_provision_state \u003d\u003d \u0027active\u0027):"},{"line_number":280,"context_line":"            return"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if CONF.processing.keep_ports !\u003d \u0027all\u0027:"},{"line_number":283,"context_line":"            # list is required as we modify underlying dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7e493c64","line":280,"updated":"2019-12-03 13:40:15.000000000","message":"Let\u0027s add debug logging before returning so that an operator understands what is happening.","commit_id":"a67d5d6676fd2a4f02e24078027f43c93a8221d2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d5bb83efa302814cf5b42002e082f8f285c8ceb5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_utils import units"},{"line_number":21,"context_line":"import six"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic_inspector.common.i18n import _"},{"line_number":25,"context_line":"from ironic_inspector.common import ironic as ir_utils"},{"line_number":26,"context_line":"from ironic_inspector.plugins import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_799dd66a","line":23,"updated":"2019-12-03 14:42:34.000000000","message":"nit: 2 blank lines between import blocks","commit_id":"78dbcf603a623de16b3614187cd2c6687d2b9225"}],"releasenotes/notes/short_circuit_port_update_for_manual_inspection-5dc296df9d409c69.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d5bb83efa302814cf5b42002e082f8f285c8ceb5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue happening during manual inspection of"},{"line_number":5,"context_line":"    active nodes where the code attempts to delete or update"},{"line_number":6,"context_line":"    ports, while the only modification allowed for active"},{"line_number":7,"context_line":"    nodes is updating the MAC address if the node is in"},{"line_number":8,"context_line":"    maintenance."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_79863619","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":16},"updated":"2019-12-03 14:42:34.000000000","message":"nit: nodes in valid active state","commit_id":"78dbcf603a623de16b3614187cd2c6687d2b9225"}]}