)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"50c43ae04b54d988b4995cc4d2f7c348b7459180","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Respect driver_info.force_persistent_boot_device"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option has been created to work around flacky hardware that"},{"line_number":10,"context_line":"does not work correctly with temporary boot. However, ironic-inspector"},{"line_number":11,"context_line":"unconditionally uses persistent\u003dFalse. This change fixes it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_5571dd44","line":9,"updated":"2020-01-15 18:18:14.000000000","message":"nit s/flacky/flaky/","commit_id":"f8e26aa088032761e9b521e96b439d9c6a80b050"}],"ironic_inspector/introspect.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"50c43ae04b54d988b4995cc4d2f7c348b7459180","unresolved":false,"context_lines":[{"line_number":86,"context_line":"def _persistent_ramdisk_boot(node):"},{"line_number":87,"context_line":"    \"\"\"If the ramdisk should be configured as a persistent boot device.\"\"\""},{"line_number":88,"context_line":"    value \u003d node.driver_info.get(\u0027force_persistent_boot_device\u0027, \u0027Default\u0027)"},{"line_number":89,"context_line":"    if value in {\u0027Always\u0027, \u0027Default\u0027, \u0027Never\u0027}:"},{"line_number":90,"context_line":"        return value \u003d\u003d \u0027Always\u0027"},{"line_number":91,"context_line":"    else:"},{"line_number":92,"context_line":"        return strutils.bool_from_string(value, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_95f3d5a0","line":89,"updated":"2020-01-15 18:18:14.000000000","message":"wow, did we really do this? I\u0027m surprised we didn\u0027t make it case insensitive. Oh well.","commit_id":"f8e26aa088032761e9b521e96b439d9c6a80b050"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6aa5e8b6610aea45e737d68125ee39505878ea35","unresolved":false,"context_lines":[{"line_number":86,"context_line":"def _persistent_ramdisk_boot(node):"},{"line_number":87,"context_line":"    \"\"\"If the ramdisk should be configured as a persistent boot device.\"\"\""},{"line_number":88,"context_line":"    value \u003d node.driver_info.get(\u0027force_persistent_boot_device\u0027, \u0027Default\u0027)"},{"line_number":89,"context_line":"    if value in {\u0027Always\u0027, \u0027Default\u0027, \u0027Never\u0027}:"},{"line_number":90,"context_line":"        return value \u003d\u003d \u0027Always\u0027"},{"line_number":91,"context_line":"    else:"},{"line_number":92,"context_line":"        return strutils.bool_from_string(value, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_56dc7942","line":89,"in_reply_to":"3fa7e38b_95f3d5a0","updated":"2020-01-16 13:05:38.000000000","message":"This is a copy-paste from ironic, so yeah :(","commit_id":"f8e26aa088032761e9b521e96b439d9c6a80b050"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"50c43ae04b54d988b4995cc4d2f7c348b7459180","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                node_info.uuid, \u0027pxe\u0027,"},{"line_number":119,"context_line":"                persistent\u003d_persistent_ramdisk_boot(node_info.node()))"},{"line_number":120,"context_line":"        except Exception as exc:"},{"line_number":121,"context_line":"            raise utils.Error(_(\u0027Failed to set boot device to PXE: %s\u0027) % exc,"},{"line_number":122,"context_line":"                              node_info\u003dnode_info)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b535b145","line":121,"updated":"2020-01-15 18:18:14.000000000","message":"don\u0027t know if you want to update this to include the persistent value.","commit_id":"f8e26aa088032761e9b521e96b439d9c6a80b050"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6aa5e8b6610aea45e737d68125ee39505878ea35","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                node_info.uuid, \u0027pxe\u0027,"},{"line_number":119,"context_line":"                persistent\u003d_persistent_ramdisk_boot(node_info.node()))"},{"line_number":120,"context_line":"        except Exception as exc:"},{"line_number":121,"context_line":"            raise utils.Error(_(\u0027Failed to set boot device to PXE: %s\u0027) % exc,"},{"line_number":122,"context_line":"                              node_info\u003dnode_info)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b6b60dfc","line":121,"in_reply_to":"3fa7e38b_b535b145","updated":"2020-01-16 13:05:38.000000000","message":"cannot think of an i18n-friendly way to do it..","commit_id":"f8e26aa088032761e9b521e96b439d9c6a80b050"}],"ironic_inspector/test/unit/test_introspect.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"50c43ae04b54d988b4995cc4d2f7c348b7459180","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        self.node_info.acquire_lock.assert_called_once_with()"},{"line_number":261,"context_line":"        self.node_info.release_lock.assert_called_once_with()"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_forced_persistent_boot_compat(self, client_mock, start_mock):"},{"line_number":264,"context_line":"        self.node.driver_info[\u0027force_persistent_boot_device\u0027] \u003d \u0027true\u0027"},{"line_number":265,"context_line":"        cli \u003d self._prepare(client_mock)"},{"line_number":266,"context_line":"        start_mock.return_value \u003d self.node_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1573651e","line":263,"updated":"2020-01-15 18:18:14.000000000","message":"this looks very similar to the above, you could add a helper method that takes \u0027Always\u0027 or \u0027true\u0027 but no big deal.","commit_id":"f8e26aa088032761e9b521e96b439d9c6a80b050"}]}