)]}'
{"ironic_inspector/common/lldp_parsers.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5aac450553cf09423db06591b2c8949df4440994","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self.parser_map \u003d {"},{"line_number":195,"context_line":"            tlv.LLDP_TLV_CHASSIS_ID:"},{"line_number":196,"context_line":"                (self.add_single_value, tlv.ChassisId,"},{"line_number":197,"context_line":"                 LLDP_CHASSIS_ID_NM, False),"},{"line_number":198,"context_line":"            tlv.LLDP_TLV_PORT_ID:"},{"line_number":199,"context_line":"                (self.add_single_value, tlv.PortId, LLDP_PORT_ID_NM, False),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_2a50790a","line":196,"range":{"start_line":196,"start_character":17,"end_line":196,"end_character":38},"updated":"2020-05-13 16:42:56.000000000","message":"Recommend adding a new function:\n    def add_nested_value(self, struct, name, data):\n        \"\"\"Add a single nested name/value pair to the dict\"\"\"\n        self.set_value(name, struct.value.value)\n\nAnd using that here as self.add_nested_value","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"de661a0a659031269c7a3bd25988dccb694e87b7","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self.parser_map \u003d {"},{"line_number":195,"context_line":"            tlv.LLDP_TLV_CHASSIS_ID:"},{"line_number":196,"context_line":"                (self.add_single_value, tlv.ChassisId,"},{"line_number":197,"context_line":"                 LLDP_CHASSIS_ID_NM, False),"},{"line_number":198,"context_line":"            tlv.LLDP_TLV_PORT_ID:"},{"line_number":199,"context_line":"                (self.add_single_value, tlv.PortId, LLDP_PORT_ID_NM, False),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_1288406f","line":196,"range":{"start_line":196,"start_character":17,"end_line":196,"end_character":38},"in_reply_to":"ff570b3c_2a50790a","updated":"2020-05-14 08:21:01.000000000","message":"thanks, I was looking for a better way to write that","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5aac450553cf09423db06591b2c8949df4440994","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                (self.add_single_value, tlv.ChassisId,"},{"line_number":197,"context_line":"                 LLDP_CHASSIS_ID_NM, False),"},{"line_number":198,"context_line":"            tlv.LLDP_TLV_PORT_ID:"},{"line_number":199,"context_line":"                (self.add_single_value, tlv.PortId, LLDP_PORT_ID_NM, False),"},{"line_number":200,"context_line":"            tlv.LLDP_TLV_TTL: (None, None, None, False),"},{"line_number":201,"context_line":"            tlv.LLDP_TLV_PORT_DESCRIPTION:"},{"line_number":202,"context_line":"                (self.add_single_value, tlv.PortDesc, LLDP_PORT_DESC_NM,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_2a799992","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":38},"updated":"2020-05-13 16:42:56.000000000","message":"Recommend using self.add_nested_value","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"de661a0a659031269c7a3bd25988dccb694e87b7","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                (self.add_single_value, tlv.ChassisId,"},{"line_number":197,"context_line":"                 LLDP_CHASSIS_ID_NM, False),"},{"line_number":198,"context_line":"            tlv.LLDP_TLV_PORT_ID:"},{"line_number":199,"context_line":"                (self.add_single_value, tlv.PortId, LLDP_PORT_ID_NM, False),"},{"line_number":200,"context_line":"            tlv.LLDP_TLV_TTL: (None, None, None, False),"},{"line_number":201,"context_line":"            tlv.LLDP_TLV_PORT_DESCRIPTION:"},{"line_number":202,"context_line":"                (self.add_single_value, tlv.PortDesc, LLDP_PORT_DESC_NM,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_5282b850","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":38},"in_reply_to":"ff570b3c_2a799992","updated":"2020-05-14 08:21:01.000000000","message":"done","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"}],"ironic_inspector/plugins/lldp_basic.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5aac450553cf09423db06591b2c8949df4440994","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            nv \u003d self._parse_lldp_tlvs(tlvs, node_info)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            if nv:"},{"line_number":84,"context_line":"                # NOTE(rpittau) take the value out of the Container"},{"line_number":85,"context_line":"                if lldp_parsers.LLDP_CHASSIS_ID_NM in nv:"},{"line_number":86,"context_line":"                    nv[lldp_parsers.LLDP_CHASSIS_ID_NM] \u003d ("},{"line_number":87,"context_line":"                        nv[lldp_parsers.LLDP_CHASSIS_ID_NM].value)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_9f08e92d","line":84,"updated":"2020-05-13 16:42:56.000000000","message":"I think a change can be made to lldp_parsers.py and this wouldn\u0027t be necessary.  See comments in that file.","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"de661a0a659031269c7a3bd25988dccb694e87b7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            nv \u003d self._parse_lldp_tlvs(tlvs, node_info)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            if nv:"},{"line_number":84,"context_line":"                # NOTE(rpittau) take the value out of the Container"},{"line_number":85,"context_line":"                if lldp_parsers.LLDP_CHASSIS_ID_NM in nv:"},{"line_number":86,"context_line":"                    nv[lldp_parsers.LLDP_CHASSIS_ID_NM] \u003d ("},{"line_number":87,"context_line":"                        nv[lldp_parsers.LLDP_CHASSIS_ID_NM].value)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_f292ec9d","line":84,"in_reply_to":"ff570b3c_9f08e92d","updated":"2020-05-14 08:21:01.000000000","message":"done","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"}],"ironic_inspector/plugins/local_link_connection.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"5ad5a8401b4e6ec68b55902000d72f69b62bcdca","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if item and value:"},{"line_number":85,"context_line":"            # NOTE(rpittau) take the value out of the Container"},{"line_number":86,"context_line":"            value \u003d value.value"},{"line_number":87,"context_line":"            if (not CONF.processing.overwrite_existing and"},{"line_number":88,"context_line":"                    item in port.local_link_connection):"},{"line_number":89,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_38dbbeed","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":31},"updated":"2020-05-13 11:13:59.000000000","message":"this looks a bit strange to me .-. ( I know it works )","commit_id":"7402f480708d08f264e240ccebfc532a339fc2f5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b9c01e78e7ff88aed318c62b9495a99f05f72c49","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if item and value:"},{"line_number":85,"context_line":"            # NOTE(rpittau) take the value out of the Container"},{"line_number":86,"context_line":"            value \u003d value.value"},{"line_number":87,"context_line":"            if (not CONF.processing.overwrite_existing and"},{"line_number":88,"context_line":"                    item in port.local_link_connection):"},{"line_number":89,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_ee84dc0e","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":31},"in_reply_to":"ff570b3c_38dbbeed","updated":"2020-05-13 12:28:36.000000000","message":"it probably can be expressed in a different way, so changing the first value for example, probably a deeper refactor might help.\nThe problem here is that the value that we grab before is actually a Container object.","commit_id":"7402f480708d08f264e240ccebfc532a339fc2f5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ae1e694ff80fc5ade18a9ba30f6a4a42421a7e2f","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if item and value:"},{"line_number":85,"context_line":"            # NOTE(rpittau) take the value out of the Container"},{"line_number":86,"context_line":"            value \u003d value.value"},{"line_number":87,"context_line":"            if (not CONF.processing.overwrite_existing and"},{"line_number":88,"context_line":"                    item in port.local_link_connection):"},{"line_number":89,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_eeb21ce6","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":31},"in_reply_to":"ff570b3c_ee84dc0e","updated":"2020-05-13 12:33:01.000000000","message":"Yeah I get that \u003d) I\u0027m not against the fix o/ we can even figure out in a follow-up, just waiting for CI","commit_id":"7402f480708d08f264e240ccebfc532a339fc2f5"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5aac450553cf09423db06591b2c8949df4440994","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                value \u003d chassis_id.value"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if item and value:"},{"line_number":85,"context_line":"            # NOTE(rpittau) take the value out of the Container"},{"line_number":86,"context_line":"            value \u003d value.value"},{"line_number":87,"context_line":"            if (not CONF.processing.overwrite_existing and"},{"line_number":88,"context_line":"                    item in port.local_link_connection):"},{"line_number":89,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_eae1612c","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":31},"updated":"2020-05-13 16:42:56.000000000","message":"I think its better to do this at lines 70 and 82 instead of here, i.e. (line 70) \nvalue \u003d port_id.value.value","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"de661a0a659031269c7a3bd25988dccb694e87b7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                value \u003d chassis_id.value"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if item and value:"},{"line_number":85,"context_line":"            # NOTE(rpittau) take the value out of the Container"},{"line_number":86,"context_line":"            value \u003d value.value"},{"line_number":87,"context_line":"            if (not CONF.processing.overwrite_existing and"},{"line_number":88,"context_line":"                    item in port.local_link_connection):"},{"line_number":89,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_d28d287c","line":86,"range":{"start_line":85,"start_character":12,"end_line":86,"end_character":31},"in_reply_to":"ff570b3c_eae1612c","updated":"2020-05-14 08:21:01.000000000","message":"done","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"}],"releasenotes/notes/constryct-fly-free-fab62c0a5cb71fa5.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5aac450553cf09423db06591b2c8949df4440994","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove upper constraint for python construct library and use the latest"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_8a0f05e0","line":1,"updated":"2020-05-13 16:42:56.000000000","message":"Nit - filename has a typo (contstryct)","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"de661a0a659031269c7a3bd25988dccb694e87b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Remove upper constraint for python construct library and use the latest"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_12ede024","line":1,"in_reply_to":"ff570b3c_8a0f05e0","updated":"2020-05-14 08:21:01.000000000","message":"will change it","commit_id":"be9d93353f79539ddaa72327ec9451707c79a4c0"}]}