)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a2d97da1e8246b8131c2775519d5f457b36bc5f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-11 14:01:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP knob to disable periodic tasks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0036b2cdb7d562e90855ccabd108392f2f97c6f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_1e642db9","line":7,"updated":"2020-06-13 12:52:17.000000000","message":"I\u0027d be curious to know the reasoning, some things may go sideways if you disable these tasks","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"98c843b735f11a40d1c9c20d38f0e00dfb65aed6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-11 14:01:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP knob to disable periodic tasks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0036b2cdb7d562e90855ccabd108392f2f97c6f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_7ff720f7","line":7,"in_reply_to":"bf51134e_1e642db9","updated":"2020-06-15 06:32:05.000000000","message":"I think the idea here was to have a quick fix to mitigate the inherent scalability issue I ran into:\n\nhttps://storyboard.openstack.org/#!/story/2007801","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c6d7bc632705281faac573ecf0c061b22ff6eab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-11 14:01:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP knob to disable periodic tasks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0036b2cdb7d562e90855ccabd108392f2f97c6f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_1f07041f","line":7,"in_reply_to":"bf51134e_7ff720f7","updated":"2020-06-15 07:57:15.000000000","message":"Okay, this is bad, but let\u0027s actually fix it, rather than making another foot-shooting place :(","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"}],"ironic_inspector/conductor/manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a2d97da1e8246b8131c2775519d5f457b36bc5f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        driver \u003d pxe_filter.driver()"},{"line_number":81,"context_line":"        driver.init_filter()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if CONF.sync_with_ironic:"},{"line_number":84,"context_line":"            periodic_clean_up_ \u003d periodics.periodic("},{"line_number":85,"context_line":"                spacing\u003dCONF.clean_up_period"},{"line_number":86,"context_line":"            )(periodic_clean_up)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_7e59e9fc","line":83,"updated":"2020-06-13 12:52:17.000000000","message":"Let\u0027s use clean_up_period \u003d\u003d 0 for that","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"fd49886b078c9c3b5bd06765a6f274e1f3ed63c6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        driver \u003d pxe_filter.driver()"},{"line_number":81,"context_line":"        driver.init_filter()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if CONF.sync_with_ironic:"},{"line_number":84,"context_line":"            periodic_clean_up_ \u003d periodics.periodic("},{"line_number":85,"context_line":"                spacing\u003dCONF.clean_up_period"},{"line_number":86,"context_line":"            )(periodic_clean_up)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_4d76ef08","line":83,"in_reply_to":"bf51134e_7e59e9fc","updated":"2020-06-15 15:47:10.000000000","message":"++","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5a2d97da1e8246b8131c2775519d5f457b36bc5f","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"            callables \u003d [(periodic_clean_up_, None, None),"},{"line_number":93,"context_line":"                         (sync_with_ironic_, None, None)]"},{"line_number":94,"context_line":"            driver_task \u003d driver.get_periodic_sync_task()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            if driver_task is not None:"},{"line_number":97,"context_line":"                callables.append((driver_task, None, None))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5e5ea5e6","line":94,"updated":"2020-06-13 12:52:17.000000000","message":"This should not be disabled","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"7af96897eacca8dcb0c55dba9dfb4df4356a5e3a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        periodic_clean_up_ \u003d periodics.periodic("},{"line_number":84,"context_line":"            spacing\u003dCONF.clean_up_period,"},{"line_number":85,"context_line":"            enabled\u003d(CONF.clean_up_period !\u003d 0)"},{"line_number":86,"context_line":"        )(periodic_clean_up)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        sync_with_ironic_ \u003d periodics.periodic("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_3b77830b","line":85,"updated":"2020-06-30 03:17:46.000000000","message":"it seems we need a clean up in the configuration options, several interval related options don\u0027t have min\u003d0 set.","commit_id":"2f828aed46656a64e0cbb6a4b67f1ea56a57aac6"}],"ironic_inspector/conf/default.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"1cd9b4658b9da8b70ab2d19df4259385770252b6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                help\u003d_(\u0027Whether to run ironic-inspector as a standalone \u0027"},{"line_number":93,"context_line":"                       \u0027service. It\\\u0027s EXPERIMENTAL to set to False.\u0027)),"},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027sync_with_ironic\u0027, default\u003dTrue,"},{"line_number":95,"context_line":"                help\u003d_(\u0027Wheter to disable periodic syncrhonization with \u0027"},{"line_number":96,"context_line":"                       \u0027ironic in terms of nodes added and removed.\u0027)),"},{"line_number":97,"context_line":"]"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_f0102f52","line":95,"range":{"start_line":95,"start_character":24,"end_line":95,"end_character":66},"updated":"2020-06-12 06:40:34.000000000","message":"Nit, 2 typos: \"Whether to disable periodic synchronization ...\"","commit_id":"018c89cd95f93c15bcfd1e6a34de13e58b60dd4f"}],"ironic_inspector/test/unit/test_manager.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"54d505b197fe4fb6eb0f46529a739b43fbf15588","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.mock_executor.return_value.submit.assert_not_called()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # self.mock_ExistingExecutor.assert_called_once_with("},{"line_number":112,"context_line":"        #    self.mock_executor.return_value)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # periodic_worker \u003d self.mock_PeriodicWorker.return_value"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_bf220db9","line":111,"updated":"2020-06-11 20:17:11.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"bbd41778e1738d17032d508c8859996237930656"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"54d505b197fe4fb6eb0f46529a739b43fbf15588","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        #    on_failure\u003dself.manager._periodics_watchdog)"},{"line_number":120,"context_line":"        # self.assertIs(periodic_worker, self.manager._periodics_worker)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        #self.mock_executor.return_value.submit.assert_called_once_with("},{"line_number":123,"context_line":"        #    self.manager._periodics_worker.start)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":" "}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9f1d8979","line":122,"updated":"2020-06-11 20:17:11.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"bbd41778e1738d17032d508c8859996237930656"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"54d505b197fe4fb6eb0f46529a739b43fbf15588","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        #self.mock_executor.return_value.submit.assert_called_once_with("},{"line_number":123,"context_line":"        #    self.manager._periodics_worker.start)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":" "},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_init_host_validate_processing_hooks_exception(self):"},{"line_number":128,"context_line":"        class MyError(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ff2c85ad","line":125,"updated":"2020-06-11 20:17:11.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"bbd41778e1738d17032d508c8859996237930656"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"54d505b197fe4fb6eb0f46529a739b43fbf15588","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":" "},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_init_host_validate_processing_hooks_exception(self):"},{"line_number":128,"context_line":"        class MyError(Exception):"},{"line_number":129,"context_line":"            pass"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_df2701c7","line":127,"updated":"2020-06-11 20:17:11.000000000","message":"pep8: E303 too many blank lines (3)","commit_id":"bbd41778e1738d17032d508c8859996237930656"}]}