)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a07c2f170c67ed13f2dd0d60c1bf1a6d341ff6e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect pxe-enabled was set during introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Morden bare metals usually support PXEs from all NICs, in"},{"line_number":10,"context_line":"our current logic only the port matching mac address in the"},{"line_number":11,"context_line":"BOOTIF will be set to pxe-enabled. This does not work for UEFI"},{"line_number":12,"context_line":"nor user friendly to bonding."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_57eba6da","line":9,"updated":"2020-06-21 12:26:43.000000000","message":"The hardware may support PXE booting for all NICS, but it does not mean that they\u0027re configured to boot from ironic PXE.","commit_id":"d2a196f54af03a69741bbfe1d54bfa615c16227e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9fcfd566f2624de2d6f3552c39e559bbd705a963","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect pxe-enabled was set during introspection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Morden bare metals usually support PXEs from all NICs, in"},{"line_number":10,"context_line":"our current logic only the port matching mac address in the"},{"line_number":11,"context_line":"BOOTIF will be set to pxe-enabled. This does not work for UEFI"},{"line_number":12,"context_line":"nor user friendly to bonding."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_d7adf69b","line":9,"in_reply_to":"bf51134e_57eba6da","updated":"2020-06-21 12:40:22.000000000","message":"Right, but on the other side, current pxe_enabled logic is not telling the truth either.","commit_id":"d2a196f54af03a69741bbfe1d54bfa615c16227e"}],"ironic_inspector/plugins/standard.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a07c2f170c67ed13f2dd0d60c1bf1a6d341ff6e5","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    node_info.delete_port(port)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if (CONF.processing.overwrite_existing"},{"line_number":298,"context_line":"                and CONF.processing.add_ports \u003d\u003d \u0027pxe\u0027):"},{"line_number":299,"context_line":"            # Make sure is_pxe_enabled is up-to-date"},{"line_number":300,"context_line":"            ports \u003d node_info.ports()"},{"line_number":301,"context_line":"            for iface in introspection_data[\u0027interfaces\u0027].values():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_b7bde2d9","line":298,"updated":"2020-06-21 12:26:43.000000000","message":"This is breaking for users with other add_ports. Maybe a new option?","commit_id":"d2a196f54af03a69741bbfe1d54bfa615c16227e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9fcfd566f2624de2d6f3552c39e559bbd705a963","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    node_info.delete_port(port)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if (CONF.processing.overwrite_existing"},{"line_number":298,"context_line":"                and CONF.processing.add_ports \u003d\u003d \u0027pxe\u0027):"},{"line_number":299,"context_line":"            # Make sure is_pxe_enabled is up-to-date"},{"line_number":300,"context_line":"            ports \u003d node_info.ports()"},{"line_number":301,"context_line":"            for iface in introspection_data[\u0027interfaces\u0027].values():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5799e676","line":298,"in_reply_to":"bf51134e_b7bde2d9","updated":"2020-06-21 12:40:22.000000000","message":"Well, it seems good names are in use :( other names like \u0027alive\u0027 seems confusing users.\nHow about an option named update_pxe defaults to True? In our case we need that False :)","commit_id":"d2a196f54af03a69741bbfe1d54bfa615c16227e"}]}