)]}'
{"ironic_inspector/pxe_filter/dnsmasq.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        denylist, allowlist \u003d _get_deny_allow_lists()"},{"line_number":93,"context_line":"        # removedlist are the MACs that are in either in allow or deny list,"},{"line_number":94,"context_line":"        # but not kept in ironic (ironic_macs) any more"},{"line_number":95,"context_line":"        removedlist \u003d denylist.union().difference(ironic_macs)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Add active MACs that are not already in the allow list"},{"line_number":98,"context_line":"        for mac in active_macs.difference():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e3f0396a","line":95,"updated":"2020-07-09 09:19:39.000000000","message":"allowlist ?","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ae832e58b6101e92eecfafc9fa7a5ef2b56085a7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        denylist, allowlist \u003d _get_deny_allow_lists()"},{"line_number":93,"context_line":"        # removedlist are the MACs that are in either in allow or deny list,"},{"line_number":94,"context_line":"        # but not kept in ironic (ironic_macs) any more"},{"line_number":95,"context_line":"        removedlist \u003d denylist.union().difference(ironic_macs)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Add active MACs that are not already in the allow list"},{"line_number":98,"context_line":"        for mac in active_macs.difference():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_19b31c0c","line":95,"in_reply_to":"bf51134e_e3f0396a","updated":"2020-07-09 10:05:01.000000000","message":"Done","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        removedlist \u003d denylist.union().difference(ironic_macs)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Add active MACs that are not already in the allow list"},{"line_number":98,"context_line":"        for mac in active_macs.difference():"},{"line_number":99,"context_line":"            _add_mac_to_allow_list(mac)"},{"line_number":100,"context_line":"        # Add any ironic MACs that is not active for introspection to the"},{"line_number":101,"context_line":"        # deny list unless it is already present"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_03ec4d8d","line":98,"updated":"2020-07-09 09:19:39.000000000","message":"allowlist ?","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ae832e58b6101e92eecfafc9fa7a5ef2b56085a7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        removedlist \u003d denylist.union().difference(ironic_macs)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Add active MACs that are not already in the allow list"},{"line_number":98,"context_line":"        for mac in active_macs.difference():"},{"line_number":99,"context_line":"            _add_mac_to_allow_list(mac)"},{"line_number":100,"context_line":"        # Add any ironic MACs that is not active for introspection to the"},{"line_number":101,"context_line":"        # deny list unless it is already present"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5ee73a13","line":98,"in_reply_to":"bf51134e_03ec4d8d","updated":"2020-07-09 10:05:01.000000000","message":"Done","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    path \u003d os.path.join(CONF.dnsmasq_pxe_filter.dhcp_hostsdir, mac)"},{"line_number":302,"context_line":"    # remove the ,ignore directive"},{"line_number":303,"context_line":"    if _exclusive_write_or_pass(path, \u0027%s\\n\u0027 % mac):"},{"line_number":304,"context_line":"        LOG.debug(\u0027MAC %s removed from the deny list\u0027, mac)"},{"line_number":305,"context_line":"    else:"},{"line_number":306,"context_line":"        LOG.warning(\u0027Failed to remove MAC %s from the deny list; retrying \u0027"},{"line_number":307,"context_line":"                    \u0027next periodic sync time\u0027, mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_435da545","line":304,"range":{"start_line":304,"start_character":43,"end_line":304,"end_character":52},"updated":"2020-07-09 09:19:39.000000000","message":"nit: denylist","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"64f15028ee855217021139f0f91d8b64534c68aa","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    path \u003d os.path.join(CONF.dnsmasq_pxe_filter.dhcp_hostsdir, mac)"},{"line_number":302,"context_line":"    # remove the ,ignore directive"},{"line_number":303,"context_line":"    if _exclusive_write_or_pass(path, \u0027%s\\n\u0027 % mac):"},{"line_number":304,"context_line":"        LOG.debug(\u0027MAC %s removed from the deny list\u0027, mac)"},{"line_number":305,"context_line":"    else:"},{"line_number":306,"context_line":"        LOG.warning(\u0027Failed to remove MAC %s from the deny list; retrying \u0027"},{"line_number":307,"context_line":"                    \u0027next periodic sync time\u0027, mac)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_5e229a53","line":304,"range":{"start_line":304,"start_character":43,"end_line":304,"end_character":52},"in_reply_to":"bf51134e_435da545","updated":"2020-07-09 09:37:05.000000000","message":"It\u0027s probably okay for logging (two actual words)","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    if _exclusive_write_or_pass(path, \u0027%s\\n\u0027 % mac):"},{"line_number":304,"context_line":"        LOG.debug(\u0027MAC %s removed from the deny list\u0027, mac)"},{"line_number":305,"context_line":"    else:"},{"line_number":306,"context_line":"        LOG.warning(\u0027Failed to remove MAC %s from the deny list; retrying \u0027"},{"line_number":307,"context_line":"                    \u0027next periodic sync time\u0027, mac)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_83533d39","line":306,"range":{"start_line":306,"start_character":54,"end_line":306,"end_character":63},"updated":"2020-07-09 09:19:39.000000000","message":"nit: denylist","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"64f15028ee855217021139f0f91d8b64534c68aa","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    if _exclusive_write_or_pass(path, \u0027%s\\n\u0027 % mac):"},{"line_number":304,"context_line":"        LOG.debug(\u0027MAC %s removed from the deny list\u0027, mac)"},{"line_number":305,"context_line":"    else:"},{"line_number":306,"context_line":"        LOG.warning(\u0027Failed to remove MAC %s from the deny list; retrying \u0027"},{"line_number":307,"context_line":"                    \u0027next periodic sync time\u0027, mac)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_3e1fe608","line":306,"range":{"start_line":306,"start_character":54,"end_line":306,"end_character":63},"in_reply_to":"bf51134e_83533d39","updated":"2020-07-09 09:37:05.000000000","message":"ditto","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"}],"ironic_inspector/pxe_filter/iptables.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                      to_deny)"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        LOG.debug(\u0027Adding active MAC\\\u0027s %s to the deny list\u0027, to_deny)"},{"line_number":124,"context_line":"        with self._temporary_chain(self.new_chain, self.chain):"},{"line_number":125,"context_line":"            # Force update on the next iteration if this attempt fails"},{"line_number":126,"context_line":"            self.denylist_cache \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_83285d97","line":123,"range":{"start_line":123,"start_character":50,"end_line":123,"end_character":59},"updated":"2020-07-09 09:19:39.000000000","message":"nit: denylist ?","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"64f15028ee855217021139f0f91d8b64534c68aa","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                      to_deny)"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        LOG.debug(\u0027Adding active MAC\\\u0027s %s to the deny list\u0027, to_deny)"},{"line_number":124,"context_line":"        with self._temporary_chain(self.new_chain, self.chain):"},{"line_number":125,"context_line":"            # Force update on the next iteration if this attempt fails"},{"line_number":126,"context_line":"            self.denylist_cache \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_bed81653","line":123,"range":{"start_line":123,"start_character":50,"end_line":123,"end_character":59},"in_reply_to":"bf51134e_83285d97","updated":"2020-07-09 09:37:05.000000000","message":"ditto re messages in logging (AFAIK \"denylist\" is not a word)","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        with self._temporary_chain(self.new_chain, self.chain):"},{"line_number":125,"context_line":"            # Force update on the next iteration if this attempt fails"},{"line_number":126,"context_line":"            self.denylist_cache \u003d None"},{"line_number":127,"context_line":"            # - Add active macs to the deny list, so that nova can boot them"},{"line_number":128,"context_line":"            for mac in to_deny:"},{"line_number":129,"context_line":"                self._iptables(\u0027-A\u0027, self.new_chain, \u0027-m\u0027, \u0027mac\u0027,"},{"line_number":130,"context_line":"                               \u0027--mac-source\u0027, mac, \u0027-j\u0027, \u0027DROP\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_03160d56","line":127,"range":{"start_line":127,"start_character":38,"end_line":127,"end_character":48},"updated":"2020-07-09 09:19:39.000000000","message":"nit: denylist ?","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bbfa37f0e7d4c9ec54fc34c57335676a1c5979d6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            for mac in to_deny:"},{"line_number":129,"context_line":"                self._iptables(\u0027-A\u0027, self.new_chain, \u0027-m\u0027, \u0027mac\u0027,"},{"line_number":130,"context_line":"                               \u0027--mac-source\u0027, mac, \u0027-j\u0027, \u0027DROP\u0027)"},{"line_number":131,"context_line":"            # - Add everything else to the allow list"},{"line_number":132,"context_line":"            self._iptables(\u0027-A\u0027, self.new_chain, \u0027-j\u0027, \u0027ACCEPT\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Cache result of successful iptables update"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_430be528","line":131,"range":{"start_line":131,"start_character":43,"end_line":131,"end_character":53},"updated":"2020-07-09 09:19:39.000000000","message":"nit: allowlist ?","commit_id":"1aff889c87424d4b3a0af5ccfb3c396146939eba"}]}