)]}'
{"ironic_inspector/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"27f7a595e15b5f153c5468a20519d563d9aaab0f","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        client.call({}, \u0027do_introspection\u0027, node_id\u003dnode_id,"},{"line_number":334,"context_line":"                    manage_boot\u003dmanage_boot,"},{"line_number":335,"context_line":"                    token\u003dflask.request.headers.get(\u0027X-Auth-Token\u0027))"},{"line_number":336,"context_line":"        return flask.make_response({}, 202)"},{"line_number":337,"context_line":"    else:"},{"line_number":338,"context_line":"        node_info \u003d node_cache.get_node(node_id)"},{"line_number":339,"context_line":"        return flask.json.jsonify(generate_introspection_status(node_info))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_fdea4671","line":336,"updated":"2020-07-15 08:58:18.000000000","message":"Also this is technically a breaking change, so we at least need a release note. Or maybe for a backportable fix, leave \u0027\u0027, but add Content-Type: plain/text?","commit_id":"a130bc4365bf7e8867e382f80764f8381d37356e"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4af4b9368be704851a4404171fd8e5d38ae22834","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        client.call({}, \u0027do_introspection\u0027, node_id\u003dnode_id,"},{"line_number":334,"context_line":"                    manage_boot\u003dmanage_boot,"},{"line_number":335,"context_line":"                    token\u003dflask.request.headers.get(\u0027X-Auth-Token\u0027))"},{"line_number":336,"context_line":"        return flask.make_response({}, 202)"},{"line_number":337,"context_line":"    else:"},{"line_number":338,"context_line":"        node_info \u003d node_cache.get_node(node_id)"},{"line_number":339,"context_line":"        return flask.json.jsonify(generate_introspection_status(node_info))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_a9753834","line":336,"updated":"2020-07-15 01:16:27.000000000","message":"I think this is fine, but if we wanted to keep the empty response it might be possible to explicitly set the content-type, see the jsonify_no_content here:\n\nhttps://www.erol.si/2018/03/flask-return-204-no-content-response/","commit_id":"a130bc4365bf7e8867e382f80764f8381d37356e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b59d393e8b9e8632531535e00b8adf710c60117f","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        # when the request was actually successful."},{"line_number":339,"context_line":"        response \u003d flask.make_response(\u0027\u0027, 202)"},{"line_number":340,"context_line":"        response.mimetype \u003d \u0027text/plain\u0027"},{"line_number":341,"context_line":"        return response"},{"line_number":342,"context_line":"    else:"},{"line_number":343,"context_line":"        node_info \u003d node_cache.get_node(node_id)"},{"line_number":344,"context_line":"        return flask.json.jsonify(generate_introspection_status(node_info))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_00c22a85","line":341,"updated":"2020-07-15 14:48:13.000000000","message":"nit: create a helper function","commit_id":"06457f154552a74ab2e373fa35be210b05803364"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b3cb20fa3371fa1054243888ce8fc18c9070af7","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                    token\u003dflask.request.headers.get(\u0027X-Auth-Token\u0027))"},{"line_number":351,"context_line":"        # NOTE(TheJulia): Explicitly set a mime type on the response"},{"line_number":352,"context_line":"        # as some proxies view the lack of a mime type as a failure"},{"line_number":353,"context_line":"        # when the request was actually successful."},{"line_number":354,"context_line":"        return _generate_empty_response(202)"},{"line_number":355,"context_line":"    else:"},{"line_number":356,"context_line":"        node_info \u003d node_cache.get_node(node_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_86a5b2b7","line":353,"updated":"2020-07-15 16:23:14.000000000","message":"nit: no longer needed here","commit_id":"f5cda854d2798e2350f574671e8faf788bd14afe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70d7028df13fe747ff4ce0b98ea0a8c16068f47e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    if code \u003d\u003d 204:"},{"line_number":146,"context_line":"        response \u003d flask.make_response(\u0027\u0027, code)"},{"line_number":147,"context_line":"        response.mimetype \u003d \u0027text/plain\u0027"},{"line_number":148,"context_line":"    return response"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"def convert_exceptions(func):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_ecd8851f","line":148,"updated":"2020-07-21 09:58:43.000000000","message":"I hope we don\u0027t use other codes, but let\u0027s make the code future-proof:\n\n if code \u003d\u003d 204:\n     # plan text\n else:\n     # {}","commit_id":"deb4c145f21c1d008a834fccde1766df9c975bb8"}],"ironic_inspector/test/unit/test_main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"27f7a595e15b5f153c5468a20519d563d9aaab0f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                                                      node_id\u003dself.uuid,"},{"line_number":197,"context_line":"                                                      token\u003d\u0027token\u0027)"},{"line_number":198,"context_line":"        self.assertEqual(202, res.status_code)"},{"line_number":199,"context_line":"        self.assertEqual(b\u0027{}\\n\u0027, res.data)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_no_authentication(self):"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_5d053245","line":199,"updated":"2020-07-15 08:58:18.000000000","message":"Let\u0027s make sure Content-Type is there?","commit_id":"a130bc4365bf7e8867e382f80764f8381d37356e"}],"lower-constraints.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70d7028df13fe747ff4ce0b98ea0a8c16068f47e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"extras\u003d\u003d1.0.0"},{"line_number":24,"context_line":"fasteners\u003d\u003d0.15"},{"line_number":25,"context_line":"fixtures\u003d\u003d3.0.0"},{"line_number":26,"context_line":"Flask\u003d\u003d1.1.0"},{"line_number":27,"context_line":"future\u003d\u003d0.18.2"},{"line_number":28,"context_line":"futurist\u003d\u003d1.2.0"},{"line_number":29,"context_line":"gitdb\u003d\u003d4.0.5"}],"source_content_type":"text/plain","patch_set":8,"id":"bf51134e_2c043d7e","line":26,"updated":"2020-07-21 09:58:43.000000000","message":"You need to update requirements.txt as well","commit_id":"deb4c145f21c1d008a834fccde1766df9c975bb8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c8b8034903ba8c3ad88074a18d6f1aad4d477081","unresolved":false,"context_lines":[{"line_number":23,"context_line":"extras\u003d\u003d1.0.0"},{"line_number":24,"context_line":"fasteners\u003d\u003d0.15"},{"line_number":25,"context_line":"fixtures\u003d\u003d3.0.0"},{"line_number":26,"context_line":"Flask\u003d\u003d1.1.0"},{"line_number":27,"context_line":"future\u003d\u003d0.18.2"},{"line_number":28,"context_line":"futurist\u003d\u003d1.2.0"},{"line_number":29,"context_line":"gitdb\u003d\u003d4.0.5"}],"source_content_type":"text/plain","patch_set":8,"id":"bf51134e_576e4d96","line":26,"in_reply_to":"bf51134e_2c043d7e","updated":"2020-07-21 19:59:48.000000000","message":"Do\u0027OH!","commit_id":"deb4c145f21c1d008a834fccde1766df9c975bb8"}]}