)]}'
{"ironic_inspector/common/ironic.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5dcbaff7b2a096b7f26b514c5deef39c15c277f","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"def _wait_for_power_state(node, state, ironic):"},{"line_number":294,"context_line":"    timeout \u003d CONF.power_timeout"},{"line_number":295,"context_line":"    for count in openstack.utils.iterate_timeout("},{"line_number":296,"context_line":"            timeout,"},{"line_number":297,"context_line":"            \"Timed out waiting for node %(node)s to reach power \""},{"line_number":298,"context_line":"            \"state %(state)s.\" % {\u0027node\u0027: node, \u0027state\u0027: state}):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_955fef0d","line":295,"updated":"2020-09-07 13:03:43.000000000","message":"nit: I wonder if this call is public.. also wait_for_power_state should be moved to openstacksdk.","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d170eab6c14ea5dff52e6b83a246d699769aea27","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"def _wait_for_power_state(node, state, ironic):"},{"line_number":294,"context_line":"    timeout \u003d CONF.power_timeout"},{"line_number":295,"context_line":"    for count in openstack.utils.iterate_timeout("},{"line_number":296,"context_line":"            timeout,"},{"line_number":297,"context_line":"            \"Timed out waiting for node %(node)s to reach power \""},{"line_number":298,"context_line":"            \"state %(state)s.\" % {\u0027node\u0027: node, \u0027state\u0027: state}):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c8bf6da8","line":295,"in_reply_to":"9f560f44_955fef0d","updated":"2020-09-16 10:23:32.000000000","message":"It\u0027s safe to use the iterate_timeout I would say, for now we can have the _wait_for_power_state here (since we would need to wait for an openstacksdk release)","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5dcbaff7b2a096b7f26b514c5deef39c15c277f","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    for count in openstack.utils.iterate_timeout("},{"line_number":296,"context_line":"            timeout,"},{"line_number":297,"context_line":"            \"Timed out waiting for node %(node)s to reach power \""},{"line_number":298,"context_line":"            \"state %(state)s.\" % {\u0027node\u0027: node, \u0027state\u0027: state}):"},{"line_number":299,"context_line":"        latest_node \u003d ironic.get_node(node)"},{"line_number":300,"context_line":"        if latest_node.power_state \u003d\u003d state:"},{"line_number":301,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_755cdb18","line":298,"updated":"2020-09-07 13:03:43.000000000","message":"nit: mention timeout value?","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d170eab6c14ea5dff52e6b83a246d699769aea27","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    for count in openstack.utils.iterate_timeout("},{"line_number":296,"context_line":"            timeout,"},{"line_number":297,"context_line":"            \"Timed out waiting for node %(node)s to reach power \""},{"line_number":298,"context_line":"            \"state %(state)s.\" % {\u0027node\u0027: node, \u0027state\u0027: state}):"},{"line_number":299,"context_line":"        latest_node \u003d ironic.get_node(node)"},{"line_number":300,"context_line":"        if latest_node.power_state \u003d\u003d state:"},{"line_number":301,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a87af921","line":298,"in_reply_to":"9f560f44_755cdb18","updated":"2020-09-16 10:23:32.000000000","message":"++","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5dcbaff7b2a096b7f26b514c5deef39c15c277f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            _wait_for_power_state(node, state, ironic)"},{"line_number":312,"context_line":"    except os_exc.SDKException as exc:"},{"line_number":313,"context_line":"        raise utils.Error("},{"line_number":314,"context_line":"            \u0027Failed to set power state for node %(node)s \u0027"},{"line_number":315,"context_line":"            \u0027Error: %(error)s\u0027 % {\u0027node\u0027: node, \u0027error\u0027: exc})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d59a07c3","line":314,"updated":"2020-09-07 13:03:43.000000000","message":"nit: missing _()","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"}],"ironic_inspector/introspect.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5dcbaff7b2a096b7f26b514c5deef39c15c277f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"             attrs, node_info\u003dnode_info)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    if node_info.manage_boot:"},{"line_number":126,"context_line":"        if ironic_node.power_state \u003d\u003d \u0027power on\u0027:"},{"line_number":127,"context_line":"            ir_utils.set_power_state(node_info.uuid, \u0027power off\u0027)"},{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            ironic.set_node_boot_device("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b59f93b2","line":126,"updated":"2020-09-07 13:03:43.000000000","message":"nit: use node_info.node()","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d170eab6c14ea5dff52e6b83a246d699769aea27","unresolved":false,"context_lines":[{"line_number":123,"context_line":"             attrs, node_info\u003dnode_info)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    if node_info.manage_boot:"},{"line_number":126,"context_line":"        if ironic_node.power_state \u003d\u003d \u0027power on\u0027:"},{"line_number":127,"context_line":"            ir_utils.set_power_state(node_info.uuid, \u0027power off\u0027)"},{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            ironic.set_node_boot_device("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_48b87de4","line":126,"in_reply_to":"9f560f44_b59f93b2","updated":"2020-09-16 10:23:32.000000000","message":"I would say is worth update the patch to address Dmitry\u0027s comment so we don\u0027t add a new parameter to the function \u003d)","commit_id":"34b264ef080272fead07af32c81b5c82b65b2839"}]}