)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f6b81b3ebdd61a73659a0e0dc89bb7c577411c09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     likui \u003clikui@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-09 18:15:09 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bump py37 to py38 in tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"in \u0027victoria\u0027 cycle, we should test py38 by default."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_20016705","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":28},"updated":"2020-10-09 10:18:27.000000000","message":"I don\u0027t see any bump of py37 to py38..","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"32c3be446ae25b70331daae97aabcd2851ef830f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     likui \u003clikui@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-09 18:30:42 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"bump py37 to py38 in tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"in \u0027victoria\u0027 cycle, we should test py38 by default."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_2007a7cb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":28},"updated":"2020-10-09 10:34:18.000000000","message":"This title doesn\u0027t make sense, there is no bump of py37 to py38 on tox.ini","commit_id":"febda8d3dd4a7ae6205b71b76333523fd81f9dc3"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"543cdabbaf151df6e3c8891041a9cce664ea5799","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     likui \u003clikui@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-12 18:05:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add py38 test in tox.ini for victoria"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"in \u0027victoria\u0027 cycle, we should test py38 by default."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://governance.openstack.org/tc/reference/runtimes/victoria.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib10a065105a740450e2c486a88b773b803847bd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_0919d586","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":72},"updated":"2020-10-12 10:16:38.000000000","message":"you\u0027re not changing victoria, master is already wallaby\nplease change the commit message to reflect this","commit_id":"c3e363689dbf8d066fcafee8809df097174b9991"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"39fd5e16424adec2922d58525a934c49cb59d364","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     likui \u003clikui@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-12 19:31:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add py38 test in tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we should test py38 by default."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_aeb54a1b","line":7,"updated":"2020-10-12 12:39:33.000000000","message":"this should be more like \"use py38 for functional tests\"","commit_id":"dc6aa8fe9f443de97e4b6a1450ac63529d81b09b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"39fd5e16424adec2922d58525a934c49cb59d364","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we should test py38 by default."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://governance.openstack.org/tc/reference/runtimes/victoria.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib10a065105a740450e2c486a88b773b803847bd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_2ef13a01","line":11,"updated":"2020-10-12 12:39:33.000000000","message":"one last thing and we\u0027re good, this link should point to wallaby, not victoria\nhttps://governance.openstack.org/tc/reference/runtimes/wallaby.html","commit_id":"dc6aa8fe9f443de97e4b6a1450ac63529d81b09b"}],"tox.ini":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f6b81b3ebdd61a73659a0e0dc89bb7c577411c09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.2.1"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,functional-py36,functional-py38"},{"line_number":4,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_0016e34a","line":3,"range":{"start_line":3,"start_character":35,"end_line":3,"end_character":50},"updated":"2020-10-09 10:18:27.000000000","message":"afaik the functional is for the functional jobs so you will also need to udpate the functional job to run on py38","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"4e139d4359f8eefc376788c4254a54ce3f21e429","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.2.1"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,functional-py36,functional-py38"},{"line_number":4,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_d8ba0409","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":50},"updated":"2020-10-12 10:54:28.000000000","message":"aren\u0027t you updating in the wrong place? Shouldn\u0027t it be like:\n\nenvlist \u003d py36,py38,pep8,functional-py36\n\nand functional-py36 could be just functional at some point.","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"252d0f11284073b5a6f86570c1456c696b84133d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.2.1"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,functional-py36,functional-py38"},{"line_number":4,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_c03d0bbd","line":3,"range":{"start_line":3,"start_character":35,"end_line":3,"end_character":50},"in_reply_to":"9f560f44_0016e34a","updated":"2020-10-09 10:20:22.000000000","message":"++\nthat\u0027s the point on my comment\nthe functional test depends on which python3 version is installed by default in the OS we\u0027re running, so this change has no real effect","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"},{"author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"change_message_id":"a57e67ca8aa2bc70e1e57d7cb8b433107cad5ff8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.2.1"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,functional-py36,functional-py38"},{"line_number":4,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_c047cb1d","line":3,"range":{"start_line":3,"start_character":35,"end_line":3,"end_character":50},"in_reply_to":"9f560f44_0016e34a","updated":"2020-10-12 10:24:06.000000000","message":"Done","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"68ea0f6e9b4d077dd2419b01b0752b68cbe21500","unresolved":false,"context_lines":[{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"    python3 -m ironic_inspector.test.functional {posargs}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"[testenv:functional-py38]"},{"line_number":54,"context_line":"commands \u003d"},{"line_number":55,"context_line":"    python3 -m ironic_inspector.test.functional {posargs}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_6007df18","line":53,"updated":"2020-10-09 10:17:58.000000000","message":"how is this different from functional-py36 ?","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"},{"author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"change_message_id":"a57e67ca8aa2bc70e1e57d7cb8b433107cad5ff8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"    python3 -m ironic_inspector.test.functional {posargs}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"[testenv:functional-py38]"},{"line_number":54,"context_line":"commands \u003d"},{"line_number":55,"context_line":"    python3 -m ironic_inspector.test.functional {posargs}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_a044571a","line":53,"in_reply_to":"9f560f44_6007df18","updated":"2020-10-12 10:24:06.000000000","message":"Done","commit_id":"686c4d6bd88cbbbf73ed60a6f76e631f6ede0306"}]}