)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"900a7b1121415400213743fdfae84f3aeedb46af","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPT_NAME should be used to correctly construct the returned links."},{"line_number":10,"context_line":"This patch also adds ProxyFix from werkzeug to allow using inspector"},{"line_number":11,"context_line":"behind SSL terminating proxy while still keeping the links correct."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4f40e9266a55d237f7aa68324b11f59b667cc940"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_e28d93d4","line":11,"updated":"2020-10-12 16:38:55.000000000","message":"Could you add a unit test showing the changed behavior?","commit_id":"a4e8b1171af6abc7ea45405ef5dbef0461356974"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5ea9690e3332b950ff1d78c5c7959468c4b97215","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPT_NAME should be used to correctly construct the returned links."},{"line_number":10,"context_line":"This patch also adds ProxyFix from werkzeug to allow using inspector"},{"line_number":11,"context_line":"behind SSL terminating proxy while still keeping the links correct."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4f40e9266a55d237f7aa68324b11f59b667cc940"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_cd083f2a","line":11,"in_reply_to":"9f560f44_e28d93d4","updated":"2020-10-14 11:21:22.000000000","message":"Done","commit_id":"a4e8b1171af6abc7ea45405ef5dbef0461356974"}],"ironic_inspector/main.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"900a7b1121415400213743fdfae84f3aeedb46af","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import flask"},{"line_number":20,"context_line":"from oslo_utils import strutils"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":"from werkzeug.middleware.proxy_fix import ProxyFix"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic_inspector import api_tools"},{"line_number":25,"context_line":"from ironic_inspector.common import context"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c2884fc4","line":22,"updated":"2020-10-12 16:38:55.000000000","message":"please import modules, not classes","commit_id":"a4e8b1171af6abc7ea45405ef5dbef0461356974"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5ea9690e3332b950ff1d78c5c7959468c4b97215","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import flask"},{"line_number":20,"context_line":"from oslo_utils import strutils"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":"from werkzeug.middleware.proxy_fix import ProxyFix"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic_inspector import api_tools"},{"line_number":25,"context_line":"from ironic_inspector.common import context"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_6d03eb0e","line":22,"in_reply_to":"9f560f44_c2884fc4","updated":"2020-10-14 11:21:22.000000000","message":"Done","commit_id":"a4e8b1171af6abc7ea45405ef5dbef0461356974"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"900a7b1121415400213743fdfae84f3aeedb46af","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    :returns: None"},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # ensure original root app is restored and wrap it with ProxyFix"},{"line_number":59,"context_line":"    _app.wsgi_app \u003d ProxyFix("},{"line_number":60,"context_line":"        _wsgi_app, x_for\u003d1, x_proto\u003d1, x_host\u003d1, x_port\u003d1, x_prefix\u003d1)"},{"line_number":61,"context_line":"    if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_22bdcb67","line":58,"updated":"2020-10-12 16:38:55.000000000","message":"this is kind of obvious, please rather explain what it does and what these numbers below mean","commit_id":"a4e8b1171af6abc7ea45405ef5dbef0461356974"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5ea9690e3332b950ff1d78c5c7959468c4b97215","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    :returns: None"},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # ensure original root app is restored and wrap it with ProxyFix"},{"line_number":59,"context_line":"    _app.wsgi_app \u003d ProxyFix("},{"line_number":60,"context_line":"        _wsgi_app, x_for\u003d1, x_proto\u003d1, x_host\u003d1, x_port\u003d1, x_prefix\u003d1)"},{"line_number":61,"context_line":"    if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f6b1bfe_8dfe4703","line":58,"in_reply_to":"9f560f44_22bdcb67","updated":"2020-10-14 11:21:22.000000000","message":"Done","commit_id":"a4e8b1171af6abc7ea45405ef5dbef0461356974"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ccfd252c839f91d22661b3768cf260e4c7600955","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # values. The following headers are respected: X-Forwarded-For,"},{"line_number":61,"context_line":"    # X-Forwarded-Proto, X-Forwarded-Host, X-Forwarded-Port,"},{"line_number":62,"context_line":"    # X-Forwarded-Prefix (the last one sets SCRIPT_NAME environment variable"},{"line_number":63,"context_line":"    # that is used to construct links)."},{"line_number":64,"context_line":"    _app.wsgi_app \u003d proxy_fix.ProxyFix("},{"line_number":65,"context_line":"        _wsgi_app, x_for\u003d1, x_proto\u003d1, x_host\u003d1, x_port\u003d1, x_prefix\u003d1)"},{"line_number":66,"context_line":"    if CONF.auth_strategy \u003d\u003d \u0027keystone\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f6b1bfe_f53a1932","line":63,"updated":"2020-10-14 21:43:17.000000000","message":"This comment is very clear, thanks","commit_id":"f23947c6932d07e4b872b9601d1f87cc28325a0b"}]}