)]}'
{"ironic_inspector/cmd/status.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4e89f3dc9ddd123a5f6c641f9a60c42f51fb1654","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _check_policy_json(self):"},{"line_number":36,"context_line":"        \"Checks to see if policy file is JSON-formatted policy file.\""},{"line_number":37,"context_line":"        msg \u003d _(\"Your policy file is JSON-formatted which was \""},{"line_number":38,"context_line":"                \"deprecated in the Victoria development cycle \""},{"line_number":39,"context_line":"                \"(Ironic 15.1.0, 15.2.0, 16.0.x) from the \""},{"line_number":40,"context_line":"                \"olso.policy library during the development cycle. \""},{"line_number":41,"context_line":"                \"You need to switch to YAML-formatted file. You can use the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_a3b185e4","line":38,"range":{"start_line":38,"start_character":35,"end_line":38,"end_character":43},"updated":"2020-11-19 15:58:24.000000000","message":"Wallaby","commit_id":"aecced579f6b3525ff0fc99c6c38457ac0d0cc3c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fc810f40daea762709e2eee32ad57c71e89af653","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_inspector.common.i18n import _"},{"line_number":22,"context_line":"from ironic_inspector import policy  # noqa import for conifugration to load"},{"line_number":23,"context_line":"import ironic_inspector.conf as conf"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"CONF \u003d conf.CONF"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_8f261fb7","line":23,"updated":"2020-11-20 00:05:07.000000000","message":"pep8: H306: imports not in alphabetical order (ironic_inspector.policy, ironic_inspector.conf)","commit_id":"bf750c58c707f1c21d7c3411f034ee060d797c9c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d2f1ca44ca229a3e438c2998002c39c443e05e0","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    and added to _upgrade_checks tuple."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _check_policy_json(self):"},{"line_number":37,"context_line":"        \"Checks to see if policy file is JSON-formatted policy file.\""},{"line_number":38,"context_line":"        msg \u003d _(\"Your policy file is JSON-formatted which was \""},{"line_number":39,"context_line":"                \"deprecated in the Wallaby development cycle. \""},{"line_number":40,"context_line":"                \"This is due to the underlying olso.policy library \""},{"line_number":41,"context_line":"                \"the Victoria development cycle. \""},{"line_number":42,"context_line":"                \"You need to switch to YAML-formatted file. You can use the \""},{"line_number":43,"context_line":"                \"``oslopolicy-convert-json-to-yaml`` tool to convert existing \""},{"line_number":44,"context_line":"                \"JSON-formatted files to YAML-formatted files in a \""},{"line_number":45,"context_line":"                \"backwards-compatible manner: \""},{"line_number":46,"context_line":"                \"https://docs.openstack.org/oslo.policy/\""},{"line_number":47,"context_line":"                \"latest/cli/oslopolicy-convert-json-to-yaml.html.\")"},{"line_number":48,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":49,"context_line":"        # Check if policy file exist and is JSON-formatted."},{"line_number":50,"context_line":"        policy_path \u003d CONF.find_file(CONF.oslo_policy.policy_file)"},{"line_number":51,"context_line":"        if policy_path and fileutils.is_json(policy_path):"},{"line_number":52,"context_line":"            status \u003d upgradecheck.Result(upgradecheck.Code.FAILURE, msg)"},{"line_number":53,"context_line":"        return status"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # A tuple of check tuples of (\u003cname of check\u003e, \u003ccheck function\u003e)."},{"line_number":56,"context_line":"    # The name of the check will be used in the output of this command."}],"source_content_type":"text/x-python","patch_set":5,"id":"fba2bf19_f17f6d71","line":53,"range":{"start_line":36,"start_character":0,"end_line":53,"end_character":21},"updated":"2020-11-26 19:13:16.000000000","message":"this check is defined in oslo.upgradecheck 1.2.0 now. You need to enable that common check from Ironic, example: https://review.opendev.org/c/openstack/glance/+/764074/6/glance/cmd/status.py","commit_id":"bf750c58c707f1c21d7c3411f034ee060d797c9c"}],"ironic_inspector/policy.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d2f1ca44ca229a3e438c2998002c39c443e05e0","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    if _ENFORCER:"},{"line_number":165,"context_line":"        return"},{"line_number":166,"context_line":"    _ENFORCER \u003d policy.Enforcer("},{"line_number":167,"context_line":"        CONF, policy_file\u003dpick_policy_file(policy_file),"},{"line_number":168,"context_line":"        rules\u003drules,"},{"line_number":169,"context_line":"        default_rule\u003ddefault_rule,"},{"line_number":170,"context_line":"        use_conf\u003duse_conf)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6bd39055_36457e11","line":167,"range":{"start_line":167,"start_character":26,"end_line":167,"end_character":55},"updated":"2020-11-26 19:13:16.000000000","message":"this also moved to oslo.policy side from 3.6.0. oslo policy will check for old JSON file is exist and pick that.\n\nhttps://review.opendev.org/c/openstack/oslo.policy/+/763261/3/oslo_policy/policy.py#363","commit_id":"bf750c58c707f1c21d7c3411f034ee060d797c9c"}]}