)]}'
{"ironic_inspector/conf/capabilities.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d598c740ba5daaa9997354a6c73bbd15c11d59da","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    \u0027pse\u0027: \u0027cpu_hugepages\u0027,"},{"line_number":24,"context_line":"    \u0027pdpe1gb\u0027: \u0027cpu_hugepages_1g\u0027,"},{"line_number":25,"context_line":"    \u0027smx\u0027: \u0027cpu_txt\u0027,"},{"line_number":26,"context_line":"    \u0027bf\u0027: \u0027cpu_sst\u0027,"},{"line_number":27,"context_line":"    \u0027avx512_vnni\u0027: \u0027cpu_vnni\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8a737cb0_ce77f3d2","line":26,"updated":"2021-03-16 13:40:07.000000000","message":"Intel Speed Set. Makes sense to add to me.\n\nbf is short for Base Frequency.\nhttps://en.wikichip.org/wiki/intel/speed_select_technology\n\nI think it might be good to add notes, since these are not as commonly known.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":30458,"name":"Rotan","email":"chengluteng@inspur.com","username":"RotanChen"},"change_message_id":"71c0f8e92b27afb16644c390fa5b0f0cd6b908c6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0027pse\u0027: \u0027cpu_hugepages\u0027,"},{"line_number":24,"context_line":"    \u0027pdpe1gb\u0027: \u0027cpu_hugepages_1g\u0027,"},{"line_number":25,"context_line":"    \u0027smx\u0027: \u0027cpu_txt\u0027,"},{"line_number":26,"context_line":"    \u0027bf\u0027: \u0027cpu_sst\u0027,"},{"line_number":27,"context_line":"    \u0027avx512_vnni\u0027: \u0027cpu_vnni\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"15b9e9a2_4eec5e91","line":26,"in_reply_to":"8a737cb0_ce77f3d2","updated":"2021-03-17 06:36:25.000000000","message":"let me add this notes.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d598c740ba5daaa9997354a6c73bbd15c11d59da","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    \u0027pdpe1gb\u0027: \u0027cpu_hugepages_1g\u0027,"},{"line_number":25,"context_line":"    \u0027smx\u0027: \u0027cpu_txt\u0027,"},{"line_number":26,"context_line":"    \u0027bf\u0027: \u0027cpu_sst\u0027,"},{"line_number":27,"context_line":"    \u0027avx512_vnni\u0027: \u0027cpu_vnni\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9700850d_62c4c3e0","line":27,"updated":"2021-03-16 13:40:07.000000000","message":"https://en.wikichip.org/wiki/x86/avx512_vnni I guess it makes sense to add for some audiences, but I\u0027m unsure of how many may actually use it.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":30458,"name":"Rotan","email":"chengluteng@inspur.com","username":"RotanChen"},"change_message_id":"71c0f8e92b27afb16644c390fa5b0f0cd6b908c6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027pdpe1gb\u0027: \u0027cpu_hugepages_1g\u0027,"},{"line_number":25,"context_line":"    \u0027smx\u0027: \u0027cpu_txt\u0027,"},{"line_number":26,"context_line":"    \u0027bf\u0027: \u0027cpu_sst\u0027,"},{"line_number":27,"context_line":"    \u0027avx512_vnni\u0027: \u0027cpu_vnni\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"262e9296_2f86810b","line":27,"in_reply_to":"9700850d_62c4c3e0","updated":"2021-03-17 06:36:25.000000000","message":"let me add this nodes.\nthanks.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b5b34a51c1f1c4268fd0fc6471b3477c49c3889f","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    \u0027pse\u0027: \u0027cpu_hugepages\u0027,"},{"line_number":24,"context_line":"    \u0027pdpe1gb\u0027: \u0027cpu_hugepages_1g\u0027,"},{"line_number":25,"context_line":"    \u0027smx\u0027: \u0027cpu_txt\u0027,"},{"line_number":26,"context_line":"    \u0027bf\u0027: \u0027cpu_sst\u0027,  # bf is short for Base Frequency."},{"line_number":27,"context_line":"    \u0027avx512_vnni\u0027: \u0027cpu_vnni\u0027,  # AVX-512 Vector Neural Network Instructions"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"46141f4c_db4d9ad0","line":26,"updated":"2021-08-10 15:28:00.000000000","message":"Maybe instead say \"Speed Step\" ?","commit_id":"79fe002b2eac039c2b40f1f4e5c5416aa76f0b73"}],"ironic_inspector/plugins/standard.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d598c740ba5daaa9997354a6c73bbd15c11d59da","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                node_info.node().properties.get(\u0027local_gb\u0027)):"},{"line_number":98,"context_line":"            node_info.update_properties(local_gb\u003dstr(local_gb))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if \"aep\" in inventory.keys():"},{"line_number":101,"context_line":"            aep_dict \u003d {\u0027aep_enable\u0027: inventory[\u0027aep\u0027][\u0027enable\u0027]}"},{"line_number":102,"context_line":"            node_info.update_capabilities(**aep_dict)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"b3285af9_42d29477","line":100,"updated":"2021-03-16 13:40:07.000000000","message":"Intel Optane memory.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":30458,"name":"Rotan","email":"chengluteng@inspur.com","username":"RotanChen"},"change_message_id":"71c0f8e92b27afb16644c390fa5b0f0cd6b908c6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                node_info.node().properties.get(\u0027local_gb\u0027)):"},{"line_number":98,"context_line":"            node_info.update_properties(local_gb\u003dstr(local_gb))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if \"aep\" in inventory.keys():"},{"line_number":101,"context_line":"            aep_dict \u003d {\u0027aep_enable\u0027: inventory[\u0027aep\u0027][\u0027enable\u0027]}"},{"line_number":102,"context_line":"            node_info.update_capabilities(**aep_dict)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"476bff2e_f1a9458a","line":100,"in_reply_to":"b3285af9_42d29477","updated":"2021-03-17 06:36:25.000000000","message":"yes,it is.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d598c740ba5daaa9997354a6c73bbd15c11d59da","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            node_info.update_properties(local_gb\u003dstr(local_gb))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if \"aep\" in inventory.keys():"},{"line_number":101,"context_line":"            aep_dict \u003d {\u0027aep_enable\u0027: inventory[\u0027aep\u0027][\u0027enable\u0027]}"},{"line_number":102,"context_line":"            node_info.update_capabilities(**aep_dict)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d49abb15_81a72255","line":101,"range":{"start_line":101,"start_character":48,"end_line":101,"end_character":65},"updated":"2021-03-16 13:40:07.000000000","message":"Are we absolutely sure \u0027enabled\u0027 will always be present in a dictionary inside of \"aep\"?","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":30458,"name":"Rotan","email":"chengluteng@inspur.com","username":"RotanChen"},"change_message_id":"71c0f8e92b27afb16644c390fa5b0f0cd6b908c6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            node_info.update_properties(local_gb\u003dstr(local_gb))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if \"aep\" in inventory.keys():"},{"line_number":101,"context_line":"            aep_dict \u003d {\u0027aep_enable\u0027: inventory[\u0027aep\u0027][\u0027enable\u0027]}"},{"line_number":102,"context_line":"            node_info.update_capabilities(**aep_dict)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7102721b_4eded0ab","line":101,"range":{"start_line":101,"start_character":48,"end_line":101,"end_character":65},"in_reply_to":"d49abb15_81a72255","updated":"2021-03-17 06:36:25.000000000","message":"when running ironic-python-agent, we have made the \u0027aep\u0027 dictionary .\nso I am sure that \u0027enable\u0027 is always in the dictionory inside of \u0027aep\u0027.\nThanks again.","commit_id":"c0797236175bea88d873adccf33e0e8b85f6dee2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b5b34a51c1f1c4268fd0fc6471b3477c49c3889f","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        if (CONF.processing.overwrite_existing or not"},{"line_number":97,"context_line":"                node_info.node().properties.get(\u0027local_gb\u0027)):"},{"line_number":98,"context_line":"            node_info.update_properties(local_gb\u003dstr(local_gb))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if \"aep\" in inventory.keys():"},{"line_number":101,"context_line":"            aep_dict \u003d {\u0027aep_enable\u0027: inventory[\u0027aep\u0027][\u0027enable\u0027]}"},{"line_number":102,"context_line":"            node_info.update_capabilities(**aep_dict)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class SchedulerHook(base.ProcessingHook):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1b84679d_70b87b6f","line":102,"range":{"start_line":99,"start_character":0,"end_line":102,"end_character":53},"updated":"2021-08-10 15:28:00.000000000","message":"two things:\n1) Openstack doesn\u0027t do scheduling this way anymore, at least by default. It would be a *trait* that would be important to expose this capability.\n2) There should at *least* be a unit test for this.","commit_id":"79fe002b2eac039c2b40f1f4e5c5416aa76f0b73"}]}
