)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"46e0fb4de196418fa5b8211aea8d62d19e8b4b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"316675d1_00301999","updated":"2022-01-07 13:40:02.000000000","message":"\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e I think we should remove all parameters with non-default values, not add them. Having these here means that if oslo.rootwrap changes the default value, we will never get it.\n\nThe current description is based on the example file provided by oslo.rootwrap.\n https://github.com/openstack/oslo.rootwrap/blob/master/etc/rootwrap.conf.sample\n\nHaving these defaults have a different benefit that any change in defaults doesn\u0027t cause direct breakage and I tend to keep the current strategy to hard-code defaults.","commit_id":"8b5c35b987b56614868df90531e1fa8c2ca77606"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5f86d7e0d81e9179fc8dfed1cc235436fcc8a51f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2cf122b9_24501829","updated":"2022-01-03 11:55:15.000000000","message":"I don\u0027t think those parameters are actually needed as they have a default value, so unless we modify them for some reason, we don\u0027t need to explicit them in our custom rootwrap.conf","commit_id":"8b5c35b987b56614868df90531e1fa8c2ca77606"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd5b063833eadca27a9b4fa5efbc891f73f97afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"02fa1310_45aec619","updated":"2022-01-04 17:13:57.000000000","message":"I think this is fine to merge. They are the defaults and Takashi is following the existing form of the example files.","commit_id":"8b5c35b987b56614868df90531e1fa8c2ca77606"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a81da0a7ed20b6a627054fbf8c0158ce4fb17abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81340b52_6d722e55","in_reply_to":"2cf122b9_24501829","updated":"2022-01-03 12:19:57.000000000","message":"My point here is not to change any behavior but to have more complete list of parameters.\n\nThe current rootwrap.conf defines both specific values(ex. filters_path) and default values (syslog_log_level). If we intend to define parameters to be overridden then IMO we should remove parameters which don\u0027t require customization completely.","commit_id":"8b5c35b987b56614868df90531e1fa8c2ca77606"}],"rootwrap.conf":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd5b063833eadca27a9b4fa5efbc891f73f97afc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"syslog_log_level\u003dERROR"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Rootwrap daemon exits after this seconds of inactivity"},{"line_number":30,"context_line":"daemon_timeout\u003d600"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Rootwrap daemon limits itself to that many file descriptors (Linux only)"},{"line_number":33,"context_line":"rlimit_nofile\u003d1024"}],"source_content_type":"text/plain","patch_set":2,"id":"d7220203_0c4ebe5b","line":30,"updated":"2022-01-04 17:13:57.000000000","message":"https://github.com/openstack/oslo.rootwrap/blob/273e42928d37fd799c82c69403c62a69b99c01b7/oslo_rootwrap/wrapper.py#L96","commit_id":"8b5c35b987b56614868df90531e1fa8c2ca77606"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd5b063833eadca27a9b4fa5efbc891f73f97afc","unresolved":true,"context_lines":[{"line_number":30,"context_line":"daemon_timeout\u003d600"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Rootwrap daemon limits itself to that many file descriptors (Linux only)"},{"line_number":33,"context_line":"rlimit_nofile\u003d1024"}],"source_content_type":"text/plain","patch_set":2,"id":"b0ee5100_6968c957","line":33,"updated":"2022-01-04 17:13:57.000000000","message":"https://github.com/openstack/oslo.rootwrap/blob/273e42928d37fd799c82c69403c62a69b99c01b7/oslo_rootwrap/wrapper.py#L102","commit_id":"8b5c35b987b56614868df90531e1fa8c2ca77606"}]}