)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"92baf4ea0f326684dfb002ab0eaccd01174d7446","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-15 01:36:57 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support configdrive in iscsi deploy for raw images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will work for UEFI only or BIOS only images. It will not"},{"line_number":10,"context_line":"work for hybrid images; which are capable of boot from BIOS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a122d0e_9fe436ad","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":50},"updated":"2016-04-21 14:35:35.000000000","message":"You mean whole disk images right? \n\nRaw images \u003d Images without a given format such as QCOW. So it\u0027s not compressed or anything like that, it\u0027s just a binary blob","commit_id":"fd07b9f0a6552ee7daa0d85a93fc97b32f73b056"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f917ee6abe613eb09d17c7b1af324869064a5a63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-15 01:36:57 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support configdrive in iscsi deploy for raw images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will work for UEFI only or BIOS only images. It will not"},{"line_number":10,"context_line":"work for hybrid images; which are capable of boot from BIOS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a122d0e_3e1d9bbe","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":50},"in_reply_to":"1a122d0e_9fe436ad","updated":"2016-05-05 06:59:40.000000000","message":"Done","commit_id":"fd07b9f0a6552ee7daa0d85a93fc97b32f73b056"}],"etc/rootwrap.d/ironic-lib.filters":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"81e2dde357fe8864d39f84f6fee93362efe1157c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# ironic_lib/disk_partitioner.py"},{"line_number":18,"context_line":"fuser: CommandFilter, fuser, root"},{"line_number":19,"context_line":"parted: CommandFilter, parted, root"},{"line_number":20,"context_line":"gdisk: CommandFilter, gdisk, root"},{"line_number":21,"context_line":"sgdisk: CommandFilter, sgdisk, root"},{"line_number":22,"context_line":"partprobe: CommandFilter, partprobe, root"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"5a5ae5dd_72a54fb3","line":20,"updated":"2016-02-05 00:33:46.000000000","message":"Seems like these should be in the section at Line 6 \u0027disk_utils.py\u0027 as changes are being made to disk_utils.py","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"976182db70b24801e4219b9c8fa22b2f2a84355f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# ironic_lib/disk_partitioner.py"},{"line_number":18,"context_line":"fuser: CommandFilter, fuser, root"},{"line_number":19,"context_line":"parted: CommandFilter, parted, root"},{"line_number":20,"context_line":"gdisk: CommandFilter, gdisk, root"},{"line_number":21,"context_line":"sgdisk: CommandFilter, sgdisk, root"},{"line_number":22,"context_line":"partprobe: CommandFilter, partprobe, root"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"5a5ae5dd_5c0cafec","line":20,"in_reply_to":"5a5ae5dd_72a54fb3","updated":"2016-02-06 05:40:23.000000000","message":"Done","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b06fb0b8b4090d3f259c1b42b20db3128eaa4ae8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"hexdump: CommandFilter, hexdump, root"},{"line_number":14,"context_line":"qemu-img: CommandFilter, qemu-img, root"},{"line_number":15,"context_line":"wipefs: CommandFilter, wipefs, root"},{"line_number":16,"context_line":"gdisk: CommandFilter, gdisk, root"},{"line_number":17,"context_line":"sgdisk: CommandFilter, sgdisk, root"},{"line_number":18,"context_line":"partprobe: CommandFilter, partprobe, root"},{"line_number":19,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"fa0719c6_92c2c5e7","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":33},"updated":"2016-03-23 18:45:59.000000000","message":"this is not needed now.","commit_id":"241f89d99e1f444a88264a41ea78bbdc2713a1db"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bd695ffc301515f87c6a012b87e284f8918b8055","unresolved":false,"context_lines":[{"line_number":13,"context_line":"hexdump: CommandFilter, hexdump, root"},{"line_number":14,"context_line":"qemu-img: CommandFilter, qemu-img, root"},{"line_number":15,"context_line":"wipefs: CommandFilter, wipefs, root"},{"line_number":16,"context_line":"gdisk: CommandFilter, gdisk, root"},{"line_number":17,"context_line":"sgdisk: CommandFilter, sgdisk, root"},{"line_number":18,"context_line":"partprobe: CommandFilter, partprobe, root"},{"line_number":19,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"fa0719c6_c8d92924","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":33},"in_reply_to":"fa0719c6_92c2c5e7","updated":"2016-03-23 20:10:23.000000000","message":"I think this is fine to do as a follow-up rev, but I would like to see the follow-up rev before this lands.","commit_id":"241f89d99e1f444a88264a41ea78bbdc2713a1db"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":525,"context_line":"    :returns: block device file for partition if it exists; otherwise it"},{"line_number":526,"context_line":"              returns None."},{"line_number":527,"context_line":"    \"\"\""},{"line_number":528,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":529,"context_line":"    label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"},{"line_number":530,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":531,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_efd081f8","line":528,"updated":"2015-10-08 01:15:35.000000000","message":"nit: check_exit_code\u003d[0] is not needed as that is the default.","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":525,"context_line":"    :returns: block device file for partition if it exists; otherwise it"},{"line_number":526,"context_line":"              returns None."},{"line_number":527,"context_line":"    \"\"\""},{"line_number":528,"context_line":"    utils.execute(\u0027partprobe\u0027, device, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":529,"context_line":"    label_arg \u003d \u0027LABEL\u003d%s\u0027 % label"},{"line_number":530,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":531,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_d5b2f693","line":528,"in_reply_to":"7a2fa921_efd081f8","updated":"2015-10-08 04:47:10.000000000","message":"Done","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":531,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":532,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":533,"context_line":"    if output is None:"},{"line_number":534,"context_line":"        return None"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    if isinstance(output, bytes):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_4f14159f","line":533,"updated":"2015-10-08 01:15:35.000000000","message":"In what situations will utils.execute() return None? Is that if it has an error and returns 2?","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":531,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":532,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":533,"context_line":"    if output is None:"},{"line_number":534,"context_line":"        return None"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    if isinstance(output, bytes):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_95a8fe21","line":533,"in_reply_to":"7a2fa921_4f14159f","updated":"2015-10-08 04:47:10.000000000","message":"yes.","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":532,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":533,"context_line":"    if output is None:"},{"line_number":534,"context_line":"        return None"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    if isinstance(output, bytes):"},{"line_number":537,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_ef3e4127","line":534,"updated":"2015-10-08 01:15:35.000000000","message":"nit: Just return will return None\n\n return","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":532,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":533,"context_line":"    if output is None:"},{"line_number":534,"context_line":"        return None"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    if isinstance(output, bytes):"},{"line_number":537,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_5565861b","line":534,"in_reply_to":"7a2fa921_ef3e4127","updated":"2015-10-08 04:47:10.000000000","message":"Done","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"def create_config_drive_partition(device, size_mb, gpt\u003dFalse):"},{"line_number":577,"context_line":"    \"\"\"Create GPT based partition for config drive"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    :param device: The device path."},{"line_number":580,"context_line":"    :param size_mb: Size of disk in MB"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_4fc97525","line":577,"updated":"2015-10-08 01:15:35.000000000","message":"Create GPT or ??? based partition....\n\nSeems like it can create two different types","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"def create_config_drive_partition(device, size_mb, gpt\u003dFalse):"},{"line_number":577,"context_line":"    \"\"\"Create GPT based partition for config drive"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    :param device: The device path."},{"line_number":580,"context_line":"    :param size_mb: Size of disk in MB"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_d57996c9","line":577,"in_reply_to":"7a2fa921_4fc97525","updated":"2015-10-08 04:47:10.000000000","message":"Done","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    updated_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"},{"line_number":597,"context_line":"    new_part \u003d list(set(updated_parts) - set(current_parts))"},{"line_number":598,"context_line":"    if len(new_part) !\u003d 1:"},{"line_number":599,"context_line":"        raise exception.InstanceDeployFailure("},{"line_number":600,"context_line":"            _(\u0027Disk partitioning failed on device %(device)s. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_efdac1e7","line":597,"updated":"2015-10-08 01:15:35.000000000","message":"nit: Not sure why convert to a list?","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                      check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    updated_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"},{"line_number":597,"context_line":"    new_part \u003d list(set(updated_parts) - set(current_parts))"},{"line_number":598,"context_line":"    if len(new_part) !\u003d 1:"},{"line_number":599,"context_line":"        raise exception.InstanceDeployFailure("},{"line_number":600,"context_line":"            _(\u0027Disk partitioning failed on device %(device)s. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b5017a08","line":597,"in_reply_to":"7a2fa921_efdac1e7","updated":"2015-10-08 04:47:10.000000000","message":"Done","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f4ecec0718104b7d214df2acf53622c3d5345ba0","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        LOG.debug(\"Configdrive for node %(node)s exists at \""},{"line_number":590,"context_line":"                  \"%(part)s\","},{"line_number":591,"context_line":"                  {\u0027node\u0027: node_uuid, \u0027part\u0027: part})"},{"line_number":592,"context_line":"        return"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    try:"},{"line_number":595,"context_line":"        confdrive_file \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_b81c2278","line":592,"range":{"start_line":592,"start_character":8,"end_line":592,"end_character":14},"updated":"2016-01-04 13:55:00.000000000","message":"I think that the partition, should ideally be re-used because the partition could have stale data potentially, especially if cleaning is not in use.  Additionally, re-using the configdrive would match IPA behavior.\n\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh#L57\n\nThere is the fundamental difference of using the size of the drive here and IPA writing a static partition size, although that partition size is, AFAIK, the maximum.","commit_id":"be5beddb7fc0ba1f451e8e0e6f8443c822a7a1b4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b3025691512416d2a77dcd8ae09a466434ea635","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"            if _is_disk_gpt_partitioned(device):"},{"line_number":604,"context_line":"                _fix_gpt_structs(device)"},{"line_number":605,"context_line":"                create_option \u003d \u00270:-%dMB:0\u0027 % confdrive_mb"},{"line_number":606,"context_line":"                utils.execute(\u0027sgdisk\u0027, \u0027-n\u0027, create_option, device,"},{"line_number":607,"context_line":"                              check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":608,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_f06b2ab5","line":605,"range":{"start_line":605,"start_character":46,"end_line":605,"end_character":58},"updated":"2016-01-06 13:01:04.000000000","message":"Using the size of the config drive for the size of the partition would be incompatible with IPA.","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bd3f789d70bb52b0c940f60102e6e731f4319de8","unresolved":false,"context_lines":[{"line_number":602,"context_line":""},{"line_number":603,"context_line":"            if _is_disk_gpt_partitioned(device):"},{"line_number":604,"context_line":"                _fix_gpt_structs(device)"},{"line_number":605,"context_line":"                create_option \u003d \u00270:-%dMB:0\u0027 % confdrive_mb"},{"line_number":606,"context_line":"                utils.execute(\u0027sgdisk\u0027, \u0027-n\u0027, create_option, device,"},{"line_number":607,"context_line":"                              check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":608,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_67a821dc","line":605,"range":{"start_line":605,"start_character":46,"end_line":605,"end_character":58},"in_reply_to":"fa69d971_f06b2ab5","updated":"2016-01-14 04:30:09.000000000","message":"Done","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b3025691512416d2a77dcd8ae09a466434ea635","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                confdrive_mb \u003d \u0027-%dMiB\u0027 % confdrive_mb"},{"line_number":610,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":611,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, confdrive_mb, \u0027-0\u0027,"},{"line_number":612,"context_line":"                              check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_f0e00a2b","line":611,"range":{"start_line":611,"start_character":59,"end_line":611,"end_character":71},"updated":"2016-01-06 13:01:04.000000000","message":"Same as above, dynamic size is incompatible with IPA.","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b3025691512416d2a77dcd8ae09a466434ea635","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                confdrive_mb \u003d \u0027-%dMiB\u0027 % confdrive_mb"},{"line_number":610,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":611,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, confdrive_mb, \u0027-0\u0027,"},{"line_number":612,"context_line":"                              check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_901e6e6e","line":611,"range":{"start_line":611,"start_character":73,"end_line":611,"end_character":77},"updated":"2016-01-06 13:01:04.000000000","message":"So we can\u0027t always put the config drive at the end of the disk.  If the disk is larger than 2TB, parted will still attempt to address and create the partition, but it will fail as MBR only supports 2TB.\n\n See:\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh#L39\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh#L91\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh#L103","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bd3f789d70bb52b0c940f60102e6e731f4319de8","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                confdrive_mb \u003d \u0027-%dMiB\u0027 % confdrive_mb"},{"line_number":610,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":611,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, confdrive_mb, \u0027-0\u0027,"},{"line_number":612,"context_line":"                              check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_27af89e3","line":611,"range":{"start_line":611,"start_character":73,"end_line":611,"end_character":77},"in_reply_to":"fa69d971_901e6e6e","updated":"2016-01-14 04:30:09.000000000","message":"Done","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bd3f789d70bb52b0c940f60102e6e731f4319de8","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            else:"},{"line_number":609,"context_line":"                confdrive_mb \u003d \u0027-%dMiB\u0027 % confdrive_mb"},{"line_number":610,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":611,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, confdrive_mb, \u0027-0\u0027,"},{"line_number":612,"context_line":"                              check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_c7b78d38","line":611,"range":{"start_line":611,"start_character":59,"end_line":611,"end_character":71},"in_reply_to":"fa69d971_f0e00a2b","updated":"2016-01-14 04:30:09.000000000","message":"Done","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b3025691512416d2a77dcd8ae09a466434ea635","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"            config_drive_part \u003d \u0027%s-part%s\u0027 % (device, new_part.pop())"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        dd(confdrive_file, config_drive_part)"},{"line_number":625,"context_line":"        LOG.info(_LI(\"Configdrive for node %(node)s successfully \""},{"line_number":626,"context_line":"                     \"copied onto partition %(part)s\"),"},{"line_number":627,"context_line":"                 {\u0027node\u0027: node_uuid, \u0027part\u0027: config_drive_part})"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_10711e76","line":624,"range":{"start_line":624,"start_character":7,"end_line":624,"end_character":45},"updated":"2016-01-06 13:01:04.000000000","message":"So we should check that the pre-existing configuration drive partition size is sufficiently large for the configuration drive.  That or use fixed partition sizes.","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bd3f789d70bb52b0c940f60102e6e731f4319de8","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"            config_drive_part \u003d \u0027%s-part%s\u0027 % (device, new_part.pop())"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"        dd(confdrive_file, config_drive_part)"},{"line_number":625,"context_line":"        LOG.info(_LI(\"Configdrive for node %(node)s successfully \""},{"line_number":626,"context_line":"                     \"copied onto partition %(part)s\"),"},{"line_number":627,"context_line":"                 {\u0027node\u0027: node_uuid, \u0027part\u0027: config_drive_part})"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_e7b41136","line":624,"range":{"start_line":624,"start_character":7,"end_line":624,"end_character":45},"in_reply_to":"fa69d971_10711e76","updated":"2016-01-14 04:30:09.000000000","message":"Done","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"81e2dde357fe8864d39f84f6fee93362efe1157c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                              \"([\\d\\.]+)MiB:([\\d\\.]+)MiB:(\\w*)::(\\w*)\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"CONFDRIVE_LABEL \u003d \"config-2\""},{"line_number":70,"context_line":"MAX_MBR_SIZE_MB \u003d 2097152"},{"line_number":71,"context_line":"MAX_CONFIG_DRIVE_SIZE_MB \u003d 64"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_f2737fe5","line":70,"updated":"2016-02-05 00:33:46.000000000","message":"I don\u0027t understand this name?\n\nMAXimum Master Boot Record Size Megabytes??\n\nAn MBR is 512 bytes, which makes me confused.","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"976182db70b24801e4219b9c8fa22b2f2a84355f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                              \"([\\d\\.]+)MiB:([\\d\\.]+)MiB:(\\w*)::(\\w*)\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"CONFDRIVE_LABEL \u003d \"config-2\""},{"line_number":70,"context_line":"MAX_MBR_SIZE_MB \u003d 2097152"},{"line_number":71,"context_line":"MAX_CONFIG_DRIVE_SIZE_MB \u003d 64"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_dc1f3f06","line":70,"in_reply_to":"5a5ae5dd_f2737fe5","updated":"2016-02-06 05:40:23.000000000","message":"Its been leveraged from \nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh#L39\n\nBut I agree, it gives incorrect impression.","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"81e2dde357fe8864d39f84f6fee93362efe1157c","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    return uuids_to_return"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"def _is_disk_exceeds_2T(device):"},{"line_number":526,"context_line":"    \"\"\"Check if total disk size exceeds 2TB msdos limit"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    :param device: device path."}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_2d2456ad","line":525,"updated":"2016-02-05 00:33:46.000000000","message":"Maybe:\n\n_is_disk_larger_than_2T\n\nSounds better to me.","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"976182db70b24801e4219b9c8fa22b2f2a84355f","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    return uuids_to_return"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"def _is_disk_exceeds_2T(device):"},{"line_number":526,"context_line":"    \"\"\"Check if total disk size exceeds 2TB msdos limit"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    :param device: device path."}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_7cef2be9","line":525,"in_reply_to":"5a5ae5dd_2d2456ad","updated":"2016-02-06 05:40:23.000000000","message":"Done","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"81e2dde357fe8864d39f84f6fee93362efe1157c","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                                        check_exit_code\u003d[0],"},{"line_number":533,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    disksize_mb \u003d int(disksize_bytes) / 1024 / 1024"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    if disksize_mb \u003e MAX_MBR_SIZE_MB:"},{"line_number":538,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_129adb63","line":535,"updated":"2016-02-05 00:33:46.000000000","message":"Use \u0027//\u0027 for integer division (Python 3)","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"976182db70b24801e4219b9c8fa22b2f2a84355f","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                                        check_exit_code\u003d[0],"},{"line_number":533,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    disksize_mb \u003d int(disksize_bytes) / 1024 / 1024"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    if disksize_mb \u003e MAX_MBR_SIZE_MB:"},{"line_number":538,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_3cbc53db","line":535,"in_reply_to":"5a5ae5dd_129adb63","updated":"2016-02-06 05:40:23.000000000","message":"Done","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"81e2dde357fe8864d39f84f6fee93362efe1157c","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    disksize_mb \u003d int(disksize_bytes) / 1024 / 1024"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    if disksize_mb \u003e MAX_MBR_SIZE_MB:"},{"line_number":538,"context_line":"        return True"},{"line_number":539,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_2d0d3637","line":536,"updated":"2016-02-05 00:33:46.000000000","message":"I\u0027m not sure the MAX_MBR_SIZE_MB is making it that readable. Maybe a constant called:\n\nTWO_TERABYTES \u003d 2 * 1024 * 1024 * 1024 * 1024\n\nCould be set at top of file.","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"976182db70b24801e4219b9c8fa22b2f2a84355f","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    disksize_mb \u003d int(disksize_bytes) / 1024 / 1024"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    if disksize_mb \u003e MAX_MBR_SIZE_MB:"},{"line_number":538,"context_line":"        return True"},{"line_number":539,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_3ca3f3b3","line":536,"in_reply_to":"5a5ae5dd_2d0d3637","updated":"2016-02-06 05:40:23.000000000","message":"Have changed the name and added a comment for the same.","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"996be01eedd76192de3c86f54718da4e910563b5","unresolved":false,"context_lines":[{"line_number":539,"context_line":"    if disksize_mb \u003e MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR:"},{"line_number":540,"context_line":"        return True"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    return False"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"def _get_labelled_partition(device, label):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_0aa47b05","line":542,"updated":"2016-02-08 13:48:21.000000000","message":"nit:\n\nreturn disksize_mb \u003e MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR","commit_id":"81bee6022fda8412bf5b2f96db97df6935b0450a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"37b1e50ea2bdf40da581f0aa342863745396042f","unresolved":false,"context_lines":[{"line_number":539,"context_line":"    if disksize_mb \u003e MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR:"},{"line_number":540,"context_line":"        return True"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    return False"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"def _get_labelled_partition(device, label):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_7e804c8b","line":542,"in_reply_to":"5a5ae5dd_0aa47b05","updated":"2016-02-08 17:38:17.000000000","message":"Done","commit_id":"81bee6022fda8412bf5b2f96db97df6935b0450a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"996be01eedd76192de3c86f54718da4e910563b5","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    :param device: The device path."},{"line_number":604,"context_line":"    :param configdrive: Base64 encoded Gzipped configdrive content or"},{"line_number":605,"context_line":"        configdrive HTTP URL."},{"line_number":606,"context_line":"    \"\"\""},{"line_number":607,"context_line":"    confdrive_file \u003d None"},{"line_number":608,"context_line":"    try:"},{"line_number":609,"context_line":"        config_drive_part \u003d _get_labelled_partition(device,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_eaf6bf8d","line":606,"updated":"2016-02-08 13:48:21.000000000","message":"I don\u0027t see where this function is being called? Shouldn\u0027t it be called as part of the work_on_disk() function?","commit_id":"81bee6022fda8412bf5b2f96db97df6935b0450a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"37b1e50ea2bdf40da581f0aa342863745396042f","unresolved":false,"context_lines":[{"line_number":603,"context_line":"    :param device: The device path."},{"line_number":604,"context_line":"    :param configdrive: Base64 encoded Gzipped configdrive content or"},{"line_number":605,"context_line":"        configdrive HTTP URL."},{"line_number":606,"context_line":"    \"\"\""},{"line_number":607,"context_line":"    confdrive_file \u003d None"},{"line_number":608,"context_line":"    try:"},{"line_number":609,"context_line":"        config_drive_part \u003d _get_labelled_partition(device,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_63daf518","line":606,"in_reply_to":"5a5ae5dd_eaf6bf8d","updated":"2016-02-08 17:38:17.000000000","message":"Whole disk image are deployed using deploy_disk_image()\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L354-L373\n\nCorresponding Ironic side review is at :-\nhttps://review.openstack.org/#/c/225115/11/ironic/drivers/modules/deploy_utils.py","commit_id":"81bee6022fda8412bf5b2f96db97df6935b0450a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"996be01eedd76192de3c86f54718da4e910563b5","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                    endlimit \u003d MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR - 1"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":648,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, startlimit,"},{"line_number":649,"context_line":"                              endlimit, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_e724ba0d","line":648,"updated":"2016-02-08 13:48:21.000000000","message":"I think this code will fail if the disk already have 4 primary partitions (or 3 primary partitons and 1 extended). Is it something we could check?","commit_id":"81bee6022fda8412bf5b2f96db97df6935b0450a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"37b1e50ea2bdf40da581f0aa342863745396042f","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                    endlimit \u003d MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR - 1"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":648,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, startlimit,"},{"line_number":649,"context_line":"                              endlimit, check_exit_code\u003d[0], run_as_root\u003dTrue)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_7e8fec74","line":648,"in_reply_to":"5a5ae5dd_e724ba0d","updated":"2016-02-08 17:38:17.000000000","message":"Have added a check.","commit_id":"81bee6022fda8412bf5b2f96db97df6935b0450a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"43a36afda06dbd6b2b4b01036b84eff04c8f0451","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    :param device: The device path."},{"line_number":564,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":565,"context_line":"    \"\"\""},{"line_number":566,"context_line":"    output, err \u003d utils.execute(\u0027gdisk\u0027, \u0027-l\u0027, device, check_exit_code\u003d[0],"},{"line_number":567,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":568,"context_line":"    if isinstance(output, bytes):"},{"line_number":569,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa0719c6_53d18956","line":566,"range":{"start_line":566,"start_character":32,"end_line":566,"end_character":45},"updated":"2016-03-22 22:57:17.000000000","message":"is there a reason you didn\u0027t use something like blkid here? in testing I get this:\n\nsudo blkid -p /dev/sda\n/dev/sda: PTTYPE\u003d\"dos\"\n\nsudo blkid -p /dev/sdc\n/dev/sdc: PTTYPE\u003d\"gpt\"","commit_id":"c4048b9e47decf5482792d429502b39134ea4655"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5d2b2f83aa1264eca817bf0c390dbcad70c41efb","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        fail."},{"line_number":570,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":571,"context_line":"    \"\"\""},{"line_number":572,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-p\u0027, device, check_exit_code\u003d[0],"},{"line_number":573,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":574,"context_line":"    if isinstance(output, bytes):"},{"line_number":575,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_5b650c1c","line":573,"range":{"start_line":572,"start_character":33,"end_line":573,"end_character":74},"updated":"2016-03-23 10:52:43.000000000","message":"blkid -p /dev/sda -o value -s PTTYPE\n\nWill give you the value only: dos, gpt","commit_id":"241f89d99e1f444a88264a41ea78bbdc2713a1db"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"b06fb0b8b4090d3f259c1b42b20db3128eaa4ae8","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        fail."},{"line_number":570,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":571,"context_line":"    \"\"\""},{"line_number":572,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-p\u0027, device, check_exit_code\u003d[0],"},{"line_number":573,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":574,"context_line":"    if isinstance(output, bytes):"},{"line_number":575,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_f26a21ec","line":573,"range":{"start_line":572,"start_character":33,"end_line":573,"end_character":74},"in_reply_to":"fa0719c6_5b650c1c","updated":"2016-03-23 18:45:59.000000000","message":"+1","commit_id":"241f89d99e1f444a88264a41ea78bbdc2713a1db"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5d2b2f83aa1264eca817bf0c390dbcad70c41efb","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                # Check if disk already have 4 partitions. MBR based disk"},{"line_number":645,"context_line":"                # cannot have more than 4 partitions."},{"line_number":646,"context_line":"                num_parts \u003d len(list_partitions(device))"},{"line_number":647,"context_line":"                if num_parts \u003e 3:"},{"line_number":648,"context_line":"                    raise exception.InstanceDeployFailure("},{"line_number":649,"context_line":"                        _(\u0027Config drive cannot be created for node %(node)s. \u0027"},{"line_number":650,"context_line":"                          \u0027Disk already have %(parts)s partitions.\u0027)"},{"line_number":651,"context_line":"                        % {\u0027node\u0027: node_uuid, \u0027parts\u0027: num_parts})"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"                # Check if disk size exceeds 2TB msdos limit"},{"line_number":654,"context_line":"                startlimit \u003d \u0027-%dMiB\u0027 % MAX_CONFIG_DRIVE_SIZE_MB"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_3bbdb8b7","line":651,"range":{"start_line":647,"start_character":16,"end_line":651,"end_character":66},"updated":"2016-03-23 10:52:43.000000000","message":"Don\u0027t wanna be picky, but in theory the disk could have 3 primary partitions and 1 extended one which would allow you to create the config drive as a logical partition.\n\nSo the 4 partitions thing only is a blocker if they are 4 primary partitions\n\nhttps://en.wikipedia.org/wiki/Extended_boot_record","commit_id":"241f89d99e1f444a88264a41ea78bbdc2713a1db"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bd695ffc301515f87c6a012b87e284f8918b8055","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                # Check if disk already have 4 partitions. MBR based disk"},{"line_number":645,"context_line":"                # cannot have more than 4 partitions."},{"line_number":646,"context_line":"                num_parts \u003d len(list_partitions(device))"},{"line_number":647,"context_line":"                if num_parts \u003e 3:"},{"line_number":648,"context_line":"                    raise exception.InstanceDeployFailure("},{"line_number":649,"context_line":"                        _(\u0027Config drive cannot be created for node %(node)s. \u0027"},{"line_number":650,"context_line":"                          \u0027Disk already have %(parts)s partitions.\u0027)"},{"line_number":651,"context_line":"                        % {\u0027node\u0027: node_uuid, \u0027parts\u0027: num_parts})"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"                # Check if disk size exceeds 2TB msdos limit"},{"line_number":654,"context_line":"                startlimit \u003d \u0027-%dMiB\u0027 % MAX_CONFIG_DRIVE_SIZE_MB"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_7df8a1c3","line":651,"range":{"start_line":647,"start_character":16,"end_line":651,"end_character":66},"in_reply_to":"fa0719c6_3bbdb8b7","updated":"2016-03-23 20:10:23.000000000","message":"I think we ought to eventually check for extended partitions, since I\u0027ve known operators to partition systems very heavily, so I could conceivably see someone wanting to write out an extended partitioning scheme with a config drive.  It is an edge case, but could happen.","commit_id":"241f89d99e1f444a88264a41ea78bbdc2713a1db"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1e962ffb9c6d8d9aea7940dd9d91aa96e66ab34","unresolved":false,"context_lines":[{"line_number":66,"context_line":"_PARTED_PRINT_RE \u003d re.compile(r\"^(\\d+):([\\d\\.]+)MiB:\""},{"line_number":67,"context_line":"                              \"([\\d\\.]+)MiB:([\\d\\.]+)MiB:(\\w*)::(\\w*)\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"CONFDRIVE_LABEL \u003d \"config-2\""},{"line_number":70,"context_line":"MAX_CONFIG_DRIVE_SIZE_MB \u003d 64"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Maximum disk size supported by MBR is 2TB (2 * 1024 * 1024 MB)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba0121b8_d2a356b0","line":69,"updated":"2016-04-01 14:54:06.000000000","message":"nit: CONFIGDRIVE_LABLE","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1666ec83ff70218912c542593534fe1f80f101ab","unresolved":false,"context_lines":[{"line_number":66,"context_line":"_PARTED_PRINT_RE \u003d re.compile(r\"^(\\d+):([\\d\\.]+)MiB:\""},{"line_number":67,"context_line":"                              \"([\\d\\.]+)MiB:([\\d\\.]+)MiB:(\\w*)::(\\w*)\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"CONFDRIVE_LABEL \u003d \"config-2\""},{"line_number":70,"context_line":"MAX_CONFIG_DRIVE_SIZE_MB \u003d 64"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Maximum disk size supported by MBR is 2TB (2 * 1024 * 1024 MB)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a061dce_45687f87","line":69,"in_reply_to":"ba0121b8_d2a356b0","updated":"2016-04-14 15:24:48.000000000","message":"Done","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a067ab1908a1b58620529db2ff4c44a9cc05afc8","unresolved":false,"context_lines":[{"line_number":553,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":554,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":555,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":556,"context_line":"    if output is None:"},{"line_number":557,"context_line":"        return"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    if isinstance(output, bytes):"},{"line_number":560,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_e9900a98","line":557,"range":{"start_line":556,"start_character":0,"end_line":557,"end_character":14},"updated":"2016-03-25 07:44:47.000000000","message":"nits: it seems these two lines can be removed, because \"isinstance(None, bytes)\" at L.559 is False.","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"54b02f7478c27bd243fe22b0da236fbb0bb306be","unresolved":false,"context_lines":[{"line_number":553,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":554,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":555,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":556,"context_line":"    if output is None:"},{"line_number":557,"context_line":"        return"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    if isinstance(output, bytes):"},{"line_number":560,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_72195079","line":557,"range":{"start_line":556,"start_character":0,"end_line":557,"end_character":14},"in_reply_to":"da0c15f0_e9900a98","updated":"2016-03-27 13:00:21.000000000","message":"Yes. Will remove this if I have to post a new patch.","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1e962ffb9c6d8d9aea7940dd9d91aa96e66ab34","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        return"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    if isinstance(output, bytes):"},{"line_number":560,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":561,"context_line":"    return output"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba0121b8_b2a6a2be","line":560,"updated":"2016-04-01 14:54:06.000000000","message":"execute() will not return bytes, unless explicitly asked. also the assumption that local encoding is \u0027utf-8\u0027 may not be correct","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1666ec83ff70218912c542593534fe1f80f101ab","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        return"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    if isinstance(output, bytes):"},{"line_number":560,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":561,"context_line":"    return output"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5a18252c_2ba9d27b","line":560,"in_reply_to":"ba0121b8_b2a6a2be","updated":"2016-04-14 15:24:48.000000000","message":"Done","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1e962ffb9c6d8d9aea7940dd9d91aa96e66ab34","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":571,"context_line":"    \"\"\""},{"line_number":572,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-p\u0027, \u0027-o\u0027, \u0027value\u0027, \u0027-s\u0027, \u0027PTTYPE\u0027,"},{"line_number":573,"context_line":"                                device, check_exit_code\u003d[0],"},{"line_number":574,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":575,"context_line":"    if isinstance(output, bytes):"},{"line_number":576,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba0121b8_12aaee84","line":573,"updated":"2016-04-01 14:54:06.000000000","message":"check_exit_code\u003d[0] is the default IIRC (here and everywhere below)","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1666ec83ff70218912c542593534fe1f80f101ab","unresolved":false,"context_lines":[{"line_number":570,"context_line":"    :returns: Boolean. Returns True if disk is GPT partitioned"},{"line_number":571,"context_line":"    \"\"\""},{"line_number":572,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-p\u0027, \u0027-o\u0027, \u0027value\u0027, \u0027-s\u0027, \u0027PTTYPE\u0027,"},{"line_number":573,"context_line":"                                device, check_exit_code\u003d[0],"},{"line_number":574,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":575,"context_line":"    if isinstance(output, bytes):"},{"line_number":576,"context_line":"        output \u003d output.decode(\"utf-8\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a18252c_8b2d8600","line":573,"in_reply_to":"ba0121b8_12aaee84","updated":"2016-04-14 15:24:48.000000000","message":"Done","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1e962ffb9c6d8d9aea7940dd9d91aa96e66ab34","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                                device, check_exit_code\u003d[0],"},{"line_number":574,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":575,"context_line":"    if isinstance(output, bytes):"},{"line_number":576,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    return \u0027gpt\u0027 in output"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba0121b8_f2ac9aa0","line":576,"updated":"2016-04-01 14:54:06.000000000","message":"ditto (and below as well)","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1666ec83ff70218912c542593534fe1f80f101ab","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                                device, check_exit_code\u003d[0],"},{"line_number":574,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":575,"context_line":"    if isinstance(output, bytes):"},{"line_number":576,"context_line":"        output \u003d output.decode(\"utf-8\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    return \u0027gpt\u0027 in output"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5a18252c_ab38423e","line":576,"in_reply_to":"ba0121b8_f2ac9aa0","updated":"2016-04-14 15:24:48.000000000","message":"Done","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1e962ffb9c6d8d9aea7940dd9d91aa96e66ab34","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        err \u003d err.decode(\"utf-8\")"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":594,"context_line":"    if search_str in err:"},{"line_number":595,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-e\u0027, device, check_exit_code\u003d[0],"},{"line_number":596,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba0121b8_5298e677","line":594,"updated":"2016-04-01 14:54:06.000000000","message":"can\u0027t we do it unconditionally? relying on a user-visible string does not look robust to me","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1666ec83ff70218912c542593534fe1f80f101ab","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        err \u003d err.decode(\"utf-8\")"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":594,"context_line":"    if search_str in err:"},{"line_number":595,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-e\u0027, device, check_exit_code\u003d[0],"},{"line_number":596,"context_line":"                      run_as_root\u003dTrue)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"5a18252c_cbe65eaf","line":594,"in_reply_to":"ba0121b8_5298e677","updated":"2016-04-14 15:24:48.000000000","message":"No, \u0027sgdisk -e\u0027 command is applicable only if the disk has GPT data strcuctures. It does not return any other exit code to indicate this condition.","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1288a3013b797a7e6ab1febb2d8a429470729322","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                                                        node_uuid)"},{"line_number":621,"context_line":"        if confdrive_mb \u003e MAX_CONFIG_DRIVE_SIZE_MB:"},{"line_number":622,"context_line":"                raise exception.InstanceDeployFailure("},{"line_number":623,"context_line":"                    _(\u0027Config drive size exceeds maximum limit of 64MiB. \u0027"},{"line_number":624,"context_line":"                      \u0027Size of given Config drive is (%(size)d MiB) for \u0027"},{"line_number":625,"context_line":"                      \u0027node %(node)s.\u0027)"},{"line_number":626,"context_line":"                    % {\u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_b303380d","line":623,"updated":"2016-03-24 18:54:58.000000000","message":"Why is there a max of 64MB on configdrives?","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"54b02f7478c27bd243fe22b0da236fbb0bb306be","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                                                        node_uuid)"},{"line_number":621,"context_line":"        if confdrive_mb \u003e MAX_CONFIG_DRIVE_SIZE_MB:"},{"line_number":622,"context_line":"                raise exception.InstanceDeployFailure("},{"line_number":623,"context_line":"                    _(\u0027Config drive size exceeds maximum limit of 64MiB. \u0027"},{"line_number":624,"context_line":"                      \u0027Size of given Config drive is (%(size)d MiB) for \u0027"},{"line_number":625,"context_line":"                      \u0027node %(node)s.\u0027)"},{"line_number":626,"context_line":"                    % {\u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_921ea461","line":623,"in_reply_to":"da0c15f0_b303380d","updated":"2016-03-27 13:00:21.000000000","message":"This patch is port of IPA side code for config drive creation. \nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh#L62\n\nLucas has opened a bug to enhance this\nhttps://bugs.launchpad.net/ironic-python-agent/+bug/1435237","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b4e97e48d6e6d175d2fd13f5a9464a8333893572","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":559,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":560,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":561,"context_line":"    return output"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"def _is_disk_gpt_partitioned(device):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a18252c_5df16100","line":561,"updated":"2016-04-14 17:20:01.000000000","message":"I\u0027m pretty sure in the case of \u003e1 partition labelled config-2, the return for this function will be inconsistent.","commit_id":"357585b9606d489b610aaa0da7feba62d8849dd4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"328cd2dd4a5772ba11095c559d163de9a98085b8","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":559,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":560,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":561,"context_line":"    return output"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"def _is_disk_gpt_partitioned(device):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a18252c_c76d8acd","line":561,"in_reply_to":"5a18252c_5df16100","updated":"2016-04-15 01:46:07.000000000","message":"True. But what should be behavior if there multiple partition with same label? Should we error out?","commit_id":"357585b9606d489b610aaa0da7feba62d8849dd4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05fea1020af00a9fc1c7c32c2e081a6504bf2706","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    output, err \u003d utils.execute(\u0027blkid\u0027, \u0027-l\u0027, \u0027-o\u0027, \u0027device\u0027, device,"},{"line_number":559,"context_line":"                                \u0027-t\u0027, label_arg, check_exit_code\u003d[0, 2],"},{"line_number":560,"context_line":"                                use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":561,"context_line":"    return output"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"def _is_disk_gpt_partitioned(device):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a1531f4_7434e8dd","line":561,"in_reply_to":"5a18252c_c76d8acd","updated":"2016-04-15 08:15:13.000000000","message":"Done","commit_id":"357585b9606d489b610aaa0da7feba62d8849dd4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"92baf4ea0f326684dfb002ab0eaccd01174d7446","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                utils.execute(\u0027sgdisk\u0027, \u0027-n\u0027, create_option, device,"},{"line_number":648,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                # Check if disk already have 4 partitions. MBR based disk"},{"line_number":651,"context_line":"                # cannot have more than 4 partitions."},{"line_number":652,"context_line":"                num_parts \u003d len(list_partitions(device))"},{"line_number":653,"context_line":"                if num_parts \u003e 3:"},{"line_number":654,"context_line":"                    raise exception.InstanceDeployFailure("}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_526735ea","line":651,"range":{"start_line":650,"start_character":16,"end_line":651,"end_character":53},"updated":"2016-04-21 14:35:35.000000000","message":"nit: Maybe add a TODO here to check for primary partitions. The problem is having 4 primary partitions, if we had for example, 3 primary partitions and 1 extended partition we would still be able to add another logical partition.","commit_id":"fd07b9f0a6552ee7daa0d85a93fc97b32f73b056"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f917ee6abe613eb09d17c7b1af324869064a5a63","unresolved":false,"context_lines":[{"line_number":647,"context_line":"                utils.execute(\u0027sgdisk\u0027, \u0027-n\u0027, create_option, device,"},{"line_number":648,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":649,"context_line":"            else:"},{"line_number":650,"context_line":"                # Check if disk already have 4 partitions. MBR based disk"},{"line_number":651,"context_line":"                # cannot have more than 4 partitions."},{"line_number":652,"context_line":"                num_parts \u003d len(list_partitions(device))"},{"line_number":653,"context_line":"                if num_parts \u003e 3:"},{"line_number":654,"context_line":"                    raise exception.InstanceDeployFailure("}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_5e7e97e4","line":651,"range":{"start_line":650,"start_character":16,"end_line":651,"end_character":53},"in_reply_to":"1a122d0e_526735ea","updated":"2016-05-05 06:59:40.000000000","message":"Done","commit_id":"fd07b9f0a6552ee7daa0d85a93fc97b32f73b056"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559607577adc9e232dec010a97eaa45fb7940e64","unresolved":false,"context_lines":[{"line_number":526,"context_line":"    return [(\u0027disk_utils\u0027, opts)]"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"def _is_disk_larger_than_2T(device):"},{"line_number":530,"context_line":"    \"\"\"Check if total disk size exceeds 2TB msdos limit"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    :param device: device path."}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_bc03d80e","line":529,"updated":"2016-06-06 05:35:05.000000000","message":"nit: you don\u0027t hardcode 2T (using constant instead), so maybe it makes sense to not mention it in function name too.","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4440496b1cb2612e5495491e5ecf539b3c5a51fa","unresolved":false,"context_lines":[{"line_number":526,"context_line":"    return [(\u0027disk_utils\u0027, opts)]"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"def _is_disk_larger_than_2T(device):"},{"line_number":530,"context_line":"    \"\"\"Check if total disk size exceeds 2TB msdos limit"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    :param device: device path."}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_558f2223","line":529,"in_reply_to":"7aa08908_bc03d80e","updated":"2016-06-07 10:55:59.000000000","message":"Done","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559607577adc9e232dec010a97eaa45fb7940e64","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                                run_as_root\u003dTrue)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":599,"context_line":"    if search_str in err:"},{"line_number":600,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-e\u0027, device, run_as_root\u003dTrue)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_17ff6502","line":599,"updated":"2016-06-06 05:35:05.000000000","message":"I would if we can avoid searching for a user-visiable string.. can\u0027t we just always run sgdisk -e?","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4440496b1cb2612e5495491e5ecf539b3c5a51fa","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                                run_as_root\u003dTrue)"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"    search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":599,"context_line":"    if search_str in err:"},{"line_number":600,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-e\u0027, device, run_as_root\u003dTrue)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_5531e20a","line":599,"in_reply_to":"7aa08908_17ff6502","updated":"2016-06-07 10:55:59.000000000","message":"Its difficult. partprobe does not return failure error code upon hitting this condition. it just gives this warning message.  \nNot sure calling this option un-conditionally would be a good thing. There is not much of documentation available about it with regards to use it on non-GPT partitioned disks.\nWDYT?\n\nhttp://linux.die.net/man/8/sgdisk","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559607577adc9e232dec010a97eaa45fb7940e64","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        if confdrive_mb \u003e MAX_CONFIG_DRIVE_SIZE_MB:"},{"line_number":627,"context_line":"                raise exception.InstanceDeployFailure("},{"line_number":628,"context_line":"                    _(\u0027Config drive size exceeds maximum limit of 64MiB. \u0027"},{"line_number":629,"context_line":"                      \u0027Size of given Config drive is (%(size)d MiB) for \u0027"},{"line_number":630,"context_line":"                      \u0027node %(node)s.\u0027)"},{"line_number":631,"context_line":"                    % {\u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"},{"line_number":632,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_f703b90b","line":629,"updated":"2016-06-06 05:35:05.000000000","message":"nit: s/given Config/the given config/\n\nalso () are not needed around the size","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4440496b1cb2612e5495491e5ecf539b3c5a51fa","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        if confdrive_mb \u003e MAX_CONFIG_DRIVE_SIZE_MB:"},{"line_number":627,"context_line":"                raise exception.InstanceDeployFailure("},{"line_number":628,"context_line":"                    _(\u0027Config drive size exceeds maximum limit of 64MiB. \u0027"},{"line_number":629,"context_line":"                      \u0027Size of given Config drive is (%(size)d MiB) for \u0027"},{"line_number":630,"context_line":"                      \u0027node %(node)s.\u0027)"},{"line_number":631,"context_line":"                    % {\u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"},{"line_number":632,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_184cb16f","line":629,"in_reply_to":"7aa08908_f703b90b","updated":"2016-06-07 10:55:59.000000000","message":"Done","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559607577adc9e232dec010a97eaa45fb7940e64","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                      \u0027node %(node)s.\u0027)"},{"line_number":631,"context_line":"                    % {\u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        LOG.debug(\"Add config drive partition (%(size)d MiB) to \""},{"line_number":634,"context_line":"                  \"device: %(dev)s for node %(node)s\","},{"line_number":635,"context_line":"                  {\u0027dev\u0027: device, \u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_5709ed2b","line":633,"updated":"2016-06-06 05:35:05.000000000","message":"s/Add/Adding/","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4440496b1cb2612e5495491e5ecf539b3c5a51fa","unresolved":false,"context_lines":[{"line_number":630,"context_line":"                      \u0027node %(node)s.\u0027)"},{"line_number":631,"context_line":"                    % {\u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"        LOG.debug(\"Add config drive partition (%(size)d MiB) to \""},{"line_number":634,"context_line":"                  \"device: %(dev)s for node %(node)s\","},{"line_number":635,"context_line":"                  {\u0027dev\u0027: device, \u0027size\u0027: confdrive_mb, \u0027node\u0027: node_uuid})"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_38a08df4","line":633,"in_reply_to":"7aa08908_5709ed2b","updated":"2016-06-07 10:55:59.000000000","message":"Done","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559607577adc9e232dec010a97eaa45fb7940e64","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                if num_parts \u003e 3:"},{"line_number":657,"context_line":"                    raise exception.InstanceDeployFailure("},{"line_number":658,"context_line":"                        _(\u0027Config drive cannot be created for node %(node)s. \u0027"},{"line_number":659,"context_line":"                          \u0027Disk already have %(parts)s partitions.\u0027)"},{"line_number":660,"context_line":"                        % {\u0027node\u0027: node_uuid, \u0027parts\u0027: num_parts})"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"                # Check if disk size exceeds 2TB msdos limit"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_370ee134","line":659,"updated":"2016-06-06 05:35:05.000000000","message":"nit: \"Disk uses MBR partitioning and already has %(part)d primary partitions.\"","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4440496b1cb2612e5495491e5ecf539b3c5a51fa","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                if num_parts \u003e 3:"},{"line_number":657,"context_line":"                    raise exception.InstanceDeployFailure("},{"line_number":658,"context_line":"                        _(\u0027Config drive cannot be created for node %(node)s. \u0027"},{"line_number":659,"context_line":"                          \u0027Disk already have %(parts)s partitions.\u0027)"},{"line_number":660,"context_line":"                        % {\u0027node\u0027: node_uuid, \u0027parts\u0027: num_parts})"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"                # Check if disk size exceeds 2TB msdos limit"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_98f3810a","line":659,"in_reply_to":"7aa08908_370ee134","updated":"2016-06-07 10:55:59.000000000","message":"Done","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"559607577adc9e232dec010a97eaa45fb7940e64","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                    # Need to create a small partition at 2TB limit"},{"line_number":667,"context_line":"                    startlimit \u003d (MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR -"},{"line_number":668,"context_line":"                                  MAX_CONFIG_DRIVE_SIZE_MB - 1)"},{"line_number":669,"context_line":"                    endlimit \u003d MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR - 1"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":672,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, startlimit,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_9713555c","line":669,"updated":"2016-06-06 05:35:05.000000000","message":"this justifies issuing a warning","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4440496b1cb2612e5495491e5ecf539b3c5a51fa","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                    # Need to create a small partition at 2TB limit"},{"line_number":667,"context_line":"                    startlimit \u003d (MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR -"},{"line_number":668,"context_line":"                                  MAX_CONFIG_DRIVE_SIZE_MB - 1)"},{"line_number":669,"context_line":"                    endlimit \u003d MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR - 1"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":672,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027ext2\u0027, startlimit,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_e620224c","line":669,"in_reply_to":"7aa08908_9713555c","updated":"2016-06-07 10:55:59.000000000","message":"Done","commit_id":"5fcae0906f29be96dd1fe9b7feb17b6d098d5c19"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ca4e4d6f3a9b6eb45de51c62b52457985e61bbb5","unresolved":false,"context_lines":[{"line_number":628,"context_line":""},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"def _fix_gpt_structs(device, node_uuid):"},{"line_number":631,"context_line":"    \"\"\"Check and moves backup GPT data structures to end of device"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    :param device: The device path."},{"line_number":634,"context_line":"    :param node_uuid: UUID of the Node. Used for logging."}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_0cabea8a","line":631,"updated":"2016-06-19 20:49:33.000000000","message":"Nit: \"Checks\". I think \"Checks backup GPT data structures and moves them to end of device\" would be a bit clearer.","commit_id":"af10929d662e853fe8393a54fade5a4d5bb244c9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b806552b1b83a4c2096f041a9d5ef8bc26027c03","unresolved":false,"context_lines":[{"line_number":628,"context_line":""},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"def _fix_gpt_structs(device, node_uuid):"},{"line_number":631,"context_line":"    \"\"\"Check and moves backup GPT data structures to end of device"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    :param device: The device path."},{"line_number":634,"context_line":"    :param node_uuid: UUID of the Node. Used for logging."}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_c22648cd","line":631,"in_reply_to":"5a9d85d2_0cabea8a","updated":"2016-07-26 03:52:24.000000000","message":"Will address it if I have to post another patch.","commit_id":"af10929d662e853fe8393a54fade5a4d5bb244c9"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ca4e4d6f3a9b6eb45de51c62b52457985e61bbb5","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                utils.execute(\u0027sgdisk\u0027, \u0027-n\u0027, create_option, device,"},{"line_number":698,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":699,"context_line":"            else:"},{"line_number":700,"context_line":"                # Check if disk already have 4 partitions. MBR based disk"},{"line_number":701,"context_line":"                # cannot have more than 4 partitions."},{"line_number":702,"context_line":"                # TODO(stendulker): One can use logical partitions to create"},{"line_number":703,"context_line":"                # config drive if there are 4 primary partitions."}],"source_content_type":"text/x-python","patch_set":21,"id":"5a9d85d2_ecaf7e92","line":700,"updated":"2016-06-19 20:49:33.000000000","message":"Nits: \"has\", \"disks\"","commit_id":"af10929d662e853fe8393a54fade5a4d5bb244c9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b806552b1b83a4c2096f041a9d5ef8bc26027c03","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                utils.execute(\u0027sgdisk\u0027, \u0027-n\u0027, create_option, device,"},{"line_number":698,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":699,"context_line":"            else:"},{"line_number":700,"context_line":"                # Check if disk already have 4 partitions. MBR based disk"},{"line_number":701,"context_line":"                # cannot have more than 4 partitions."},{"line_number":702,"context_line":"                # TODO(stendulker): One can use logical partitions to create"},{"line_number":703,"context_line":"                # config drive if there are 4 primary partitions."}],"source_content_type":"text/x-python","patch_set":21,"id":"dada55a8_22376400","line":700,"in_reply_to":"5a9d85d2_ecaf7e92","updated":"2016-07-26 03:52:24.000000000","message":"Will address it if there I need to post another patch.","commit_id":"af10929d662e853fe8393a54fade5a4d5bb244c9"},{"author":{"_account_id":15333,"name":"Hao Li","email":"lihao@cmss.chinamobile.com","username":"lihao"},"change_message_id":"b637d00b2311442168a20d5eb0613e0aa84bab72","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        commands fail."},{"line_number":643,"context_line":"    \"\"\""},{"line_number":644,"context_line":"    try:"},{"line_number":645,"context_line":"        output, err \u003d utils.execute(\u0027partprobe\u0027, device,"},{"line_number":646,"context_line":"                                    use_standard_locale\u003dTrue,"},{"line_number":647,"context_line":"                                    run_as_root\u003dTrue)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        search_str \u003d \"fix the GPT to use all of the space\""},{"line_number":650,"context_line":"        if search_str in err:"}],"source_content_type":"text/x-python","patch_set":23,"id":"5ff73747_2ef525cc","line":647,"range":{"start_line":645,"start_character":0,"end_line":647,"end_character":53},"updated":"2017-04-24 06:20:12.000000000","message":"Hello, I have a question.\nI think if executing partprobe meets error. It will raise an exception and err will be not assigned. Maybe this is a big problem when execute failed.","commit_id":"7e926fd3fbb15b2e247e5bbc8c490d4c85857fbc"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        self.assertEqual(2, disk_utils.get_image_mb(\u0027x\u0027, True))"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"class GPTPartionTestCases(test_base.BaseTestCase):"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":549,"context_line":"    def test_get_partition_present(self, execute_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_8f530de2","line":546,"updated":"2015-10-08 01:15:35.000000000","message":"Put the:\n\n @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)\n\nOn the class, so don\u0027t need to put it on every function. Also safer as could add new function and forget to put in the mock.patch","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        self.assertEqual(2, disk_utils.get_image_mb(\u0027x\u0027, True))"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"class GPTPartionTestCases(test_base.BaseTestCase):"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":549,"context_line":"    def test_get_partition_present(self, execute_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_40f622fa","line":546,"in_reply_to":"7a2fa921_8f530de2","updated":"2015-10-08 04:47:10.000000000","message":"Done","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7315ca7ef6ae675555d8ab93eb88c820a1c3e06c","unresolved":false,"context_lines":[{"line_number":546,"context_line":"class GPTPartionTestCases(test_base.BaseTestCase):"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":549,"context_line":"    def test_get_partition_present(self, execute_mock):"},{"line_number":550,"context_line":"        blkid_output \u003d \u0027/dev/fake12\u0027"},{"line_number":551,"context_line":"        # execute_mock.return_value \u003d (blkid_output, \u0027\u0027)"},{"line_number":552,"context_line":"        execute_mock.side_effect \u003d [(None, \u0027\u0027), (blkid_output, \u0027\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_6f6551b3","line":549,"updated":"2015-10-08 01:15:35.000000000","message":"It seems it is usually done as:\n\n mock_execute instead of execute_mock","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bcd1a16f8fa5b4991eb5e78f9008e4ad352435c8","unresolved":false,"context_lines":[{"line_number":546,"context_line":"class GPTPartionTestCases(test_base.BaseTestCase):"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":549,"context_line":"    def test_get_partition_present(self, execute_mock):"},{"line_number":550,"context_line":"        blkid_output \u003d \u0027/dev/fake12\u0027"},{"line_number":551,"context_line":"        # execute_mock.return_value \u003d (blkid_output, \u0027\u0027)"},{"line_number":552,"context_line":"        execute_mock.side_effect \u003d [(None, \u0027\u0027), (blkid_output, \u0027\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_40cdc2b5","line":549,"in_reply_to":"7a2fa921_6f6551b3","updated":"2015-10-08 04:47:10.000000000","message":"I don\u0027t think there is any such precedence. Anyways have changed it...","commit_id":"216eaf5f709c94337793689fad2fb0fb3e6c0b64"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0ea3eab72e84deb41d883db5cac61c6f779bfbe0","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test_get_partition_present(self, mock_execute):"},{"line_number":550,"context_line":"        blkid_output \u003d \u0027/dev/fake12\u0027"},{"line_number":551,"context_line":"        # mock_execute.return_value \u003d (blkid_output, \u0027\u0027)"},{"line_number":552,"context_line":"        mock_execute.side_effect \u003d [(None, \u0027\u0027), (blkid_output, \u0027\u0027)]"},{"line_number":553,"context_line":"        result \u003d disk_utils.get_labelled_partition(\u0027/dev/fake\u0027,"},{"line_number":554,"context_line":"                                                   \u0027config-2\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_bba88b78","line":551,"updated":"2015-10-08 04:55:02.000000000","message":"If not needed, this should be removed.","commit_id":"00213b9677d8f137e9a02687c318e7b6fa1cef9e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f8ac4d63343b1f7b7b91e0305e72e337b6af7b28","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test_get_partition_present(self, mock_execute):"},{"line_number":550,"context_line":"        blkid_output \u003d \u0027/dev/fake12\u0027"},{"line_number":551,"context_line":"        # mock_execute.return_value \u003d (blkid_output, \u0027\u0027)"},{"line_number":552,"context_line":"        mock_execute.side_effect \u003d [(None, \u0027\u0027), (blkid_output, \u0027\u0027)]"},{"line_number":553,"context_line":"        result \u003d disk_utils.get_labelled_partition(\u0027/dev/fake\u0027,"},{"line_number":554,"context_line":"                                                   \u0027config-2\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_fb25a308","line":551,"in_reply_to":"7a2fa921_bba88b78","updated":"2015-10-08 05:00:17.000000000","message":"Yes. that\u0027s miss from my side.","commit_id":"00213b9677d8f137e9a02687c318e7b6fa1cef9e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b4e97e48d6e6d175d2fd13f5a9464a8333893572","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.dev \u003d \"/dev/fake\""},{"line_number":633,"context_line":"        self.config_part_label \u003d \"config-2\""},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_get_partition_present(self, mock_execute):"},{"line_number":636,"context_line":"        blkid_output \u003d \u0027/dev/fake12\u0027"},{"line_number":637,"context_line":"        mock_execute.side_effect \u003d [(None, \u0027\u0027), (blkid_output, \u0027\u0027)]"},{"line_number":638,"context_line":"        result \u003d disk_utils._get_labelled_partition(self.dev,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a18252c_1d6089a4","line":635,"updated":"2016-04-14 17:20:01.000000000","message":"Can we get a unit test for \u003e1 partition present that\u0027s labelled config-2?","commit_id":"357585b9606d489b610aaa0da7feba62d8849dd4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05fea1020af00a9fc1c7c32c2e081a6504bf2706","unresolved":false,"context_lines":[{"line_number":632,"context_line":"        self.dev \u003d \"/dev/fake\""},{"line_number":633,"context_line":"        self.config_part_label \u003d \"config-2\""},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_get_partition_present(self, mock_execute):"},{"line_number":636,"context_line":"        blkid_output \u003d \u0027/dev/fake12\u0027"},{"line_number":637,"context_line":"        mock_execute.side_effect \u003d [(None, \u0027\u0027), (blkid_output, \u0027\u0027)]"},{"line_number":638,"context_line":"        result \u003d disk_utils._get_labelled_partition(self.dev,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a1531f4_f4563805","line":635,"in_reply_to":"5a18252c_1d6089a4","updated":"2016-04-15 08:15:13.000000000","message":"Done","commit_id":"357585b9606d489b610aaa0da7feba62d8849dd4"}],"releasenotes/notes/config-drive-support-for-whole-disk-images-in-iscsi-deploy-10d74d74dcca807f.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3b3025691512416d2a77dcd8ae09a466434ea635","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa69d971_aeb8f475","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":10},"updated":"2016-01-06 13:01:04.000000000","message":"Nit: I would prefer this to be a little more verbose","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bd3f789d70bb52b0c940f60102e6e731f4319de8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Config drive support for whole disk images for"},{"line_number":4,"context_line":"    iscsi based deploy."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da6ed579_87d2f55a","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":10},"in_reply_to":"fa69d971_aeb8f475","updated":"2016-01-14 04:30:09.000000000","message":"Done","commit_id":"0b77088708c5f69798df380b340e9a5b1135d058"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"81e2dde357fe8864d39f84f6fee93362efe1157c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    is provisioned using iscsi based deploy drivers."},{"line_number":5,"context_line":"    Note: This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are capable of"},{"line_number":7,"context_line":"    boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a5ae5dd_523853a0","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":8},"updated":"2016-02-05 00:33:46.000000000","message":"nit: s/boot/booting/","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"976182db70b24801e4219b9c8fa22b2f2a84355f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    is provisioned using iscsi based deploy drivers."},{"line_number":5,"context_line":"    Note: This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are capable of"},{"line_number":7,"context_line":"    boot from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a5ae5dd_1cae3798","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":8},"in_reply_to":"5a5ae5dd_523853a0","updated":"2016-02-06 05:40:23.000000000","message":"Done","commit_id":"34938d849114411ce65a96cf5de3cbc91124be7a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c1e962ffb9c6d8d9aea7940dd9d91aa96e66ab34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support added to create Config drive when whole disk image"},{"line_number":4,"context_line":"    is provisioned using iscsi based deploy drivers."},{"line_number":5,"context_line":"    Note: This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are capable of"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba0121b8_72c24a54","line":3,"updated":"2016-04-01 14:54:06.000000000","message":"nit: lower case config drive","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1666ec83ff70218912c542593534fe1f80f101ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support added to create Config drive when whole disk image"},{"line_number":4,"context_line":"    is provisioned using iscsi based deploy drivers."},{"line_number":5,"context_line":"    Note: This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are capable of"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5a18252c_8639fda6","line":3,"in_reply_to":"ba0121b8_72c24a54","updated":"2016-04-14 15:24:48.000000000","message":"Done","commit_id":"d483680800248dcb181dd14d41b282d34174532d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"de822eb0f55d7dd7e82a9360702141f6dcece0b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    is provisioned using iscsi based deploy drivers."},{"line_number":5,"context_line":"    Note: This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are capable of"},{"line_number":7,"context_line":"    booting from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bacf61ea_4a1e4164","line":7,"updated":"2016-07-28 11:05:55.000000000","message":"How was this generated? There\u0027s no reno support for ironic-lib. No releasenotes/source/conf.py, no gate jobs, etc...\n\nWe probably should have it, I will open a bug and put a patch for it. But for now, I think we should delete this file.","commit_id":"994fe3b34b8690aeabf0a034c93cfad354220a1b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4718cf671fc9b745cc359c95fd9befbac03b2b3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    is provisioned using iscsi based deploy drivers."},{"line_number":5,"context_line":"    Note: This will work for UEFI only or BIOS only images."},{"line_number":6,"context_line":"    It will not work for hybrid images; which are capable of"},{"line_number":7,"context_line":"    booting from BIOS and UEFI boot mode."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bacf61ea_8a7959ff","line":7,"in_reply_to":"bacf61ea_4a1e4164","updated":"2016-07-28 11:13:04.000000000","message":"My bad. Had generated when reno was first introduced. Created using \u0027reno\u0027 CLI","commit_id":"994fe3b34b8690aeabf0a034c93cfad354220a1b"}]}
