)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"01a020986cc934cd4f5da05b4bdd73773f5cc613","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        if configdrive:"},{"line_number":438,"context_line":"            configdrive_mb, configdrive_file \u003d _get_configdrive(configdrive,"},{"line_number":439,"context_line":"                                                                node_uuid,"},{"line_number":440,"context_line":"                                                                tempdir)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        part_dict \u003d make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":443,"context_line":"                                    configdrive_mb, node_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d305e410","line":440,"updated":"2015-11-11 23:29:42.000000000","message":"Probably just a quirk of mine but I would have preferred:\n\n tempdir\u003dtempdir\n\n:)","commit_id":"17312e8171a89f71c505cd7cb9e1490d30982577"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"141b546a94fa0abab0e3f598b6d362fd40aac7f1","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        if configdrive:"},{"line_number":438,"context_line":"            configdrive_mb, configdrive_file \u003d _get_configdrive(configdrive,"},{"line_number":439,"context_line":"                                                                node_uuid,"},{"line_number":440,"context_line":"                                                                tempdir)"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        part_dict \u003d make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":443,"context_line":"                                    configdrive_mb, node_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_2eb4037e","line":440,"in_reply_to":"da85f559_d305e410","updated":"2015-11-12 00:30:25.000000000","message":"I hate%#@#$@ dealing with indentation stuff. But since you caught me...","commit_id":"17312e8171a89f71c505cd7cb9e1490d30982577"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"12c5fe784cf514e5df6934d8b9a94c9a9b723fd4","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    @mock.patch.object(gzip, \u0027GzipFile\u0027)"},{"line_number":450,"context_line":"    def test_get_configdrive(self, mock_gzip, mock_requests, mock_copy):"},{"line_number":451,"context_line":"        mock_requests.return_value \u003d mock.MagicMock(content\u003d\u0027Zm9vYmFy\u0027)"},{"line_number":452,"context_line":"        tempdir \u003d tempfile.gettempdir()"},{"line_number":453,"context_line":"        (size, path) \u003d disk_utils._get_configdrive(\u0027http://1.2.3.4/cd\u0027,"},{"line_number":454,"context_line":"                                                   \u0027fake-node-uuid\u0027,"},{"line_number":455,"context_line":"                                                   tempdir\u003dtempdir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_b171aaaa","line":452,"updated":"2015-11-10 01:46:30.000000000","message":"This test case passes without the changes made to disk_utils.\n\nI don\u0027t have a great idea on how to fix it though.\n\nIf had the ironic.utils.tempdir function it would be easier. As I think need to create directory in order to really test this.\n\nSomething like this:\n\n with ironic.utils.tempdir() as tempdir:\n   (size, path) \u003d ....\n\nBut we don\u0027t have the ironic.utils.tempdir function here :(","commit_id":"3097531430ae12e0cb51d57f75659f8f549fdecd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"941a3eeddc175f6380143b8182bc9e6a5f898878","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    @mock.patch.object(gzip, \u0027GzipFile\u0027)"},{"line_number":450,"context_line":"    def test_get_configdrive(self, mock_gzip, mock_requests, mock_copy):"},{"line_number":451,"context_line":"        mock_requests.return_value \u003d mock.MagicMock(content\u003d\u0027Zm9vYmFy\u0027)"},{"line_number":452,"context_line":"        tempdir \u003d tempfile.gettempdir()"},{"line_number":453,"context_line":"        (size, path) \u003d disk_utils._get_configdrive(\u0027http://1.2.3.4/cd\u0027,"},{"line_number":454,"context_line":"                                                   \u0027fake-node-uuid\u0027,"},{"line_number":455,"context_line":"                                                   tempdir\u003dtempdir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_1c22efb9","line":452,"in_reply_to":"da85f559_b171aaaa","updated":"2015-11-10 14:45:20.000000000","message":"Oh, right. The default is to use tempfile.gettempdir(). (Which happens to be the default value if that tempdir config wasn\u0027t specified, so that is good I guess.)\n\nI\u0027ll just create a temporary directory.","commit_id":"3097531430ae12e0cb51d57f75659f8f549fdecd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"12c5fe784cf514e5df6934d8b9a94c9a9b723fd4","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        (size, path) \u003d disk_utils._get_configdrive(\u0027http://1.2.3.4/cd\u0027,"},{"line_number":454,"context_line":"                                                   \u0027fake-node-uuid\u0027,"},{"line_number":455,"context_line":"                                                   tempdir\u003dtempdir)"},{"line_number":456,"context_line":"        self.assertIn(tempdir, path)"},{"line_number":457,"context_line":"        mock_requests.assert_called_once_with(\u0027http://1.2.3.4/cd\u0027)"},{"line_number":458,"context_line":"        mock_gzip.assert_called_once_with(\u0027configdrive\u0027, \u0027rb\u0027,"},{"line_number":459,"context_line":"                                          fileobj\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_d1746e9d","line":456,"updated":"2015-11-10 01:46:30.000000000","message":"Would some sort of \u0027startswith\u0027 be better?\n\n self.assertTrue(path.startswith(tempdir))\n\nor maybe:\n\n self.assertThat(path, StartsWith(tempdir))","commit_id":"3097531430ae12e0cb51d57f75659f8f549fdecd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"941a3eeddc175f6380143b8182bc9e6a5f898878","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        (size, path) \u003d disk_utils._get_configdrive(\u0027http://1.2.3.4/cd\u0027,"},{"line_number":454,"context_line":"                                                   \u0027fake-node-uuid\u0027,"},{"line_number":455,"context_line":"                                                   tempdir\u003dtempdir)"},{"line_number":456,"context_line":"        self.assertIn(tempdir, path)"},{"line_number":457,"context_line":"        mock_requests.assert_called_once_with(\u0027http://1.2.3.4/cd\u0027)"},{"line_number":458,"context_line":"        mock_gzip.assert_called_once_with(\u0027configdrive\u0027, \u0027rb\u0027,"},{"line_number":459,"context_line":"                                          fileobj\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_470d0036","line":456,"in_reply_to":"da85f559_d1746e9d","updated":"2015-11-10 14:45:20.000000000","message":"Yuppers. Thx.","commit_id":"3097531430ae12e0cb51d57f75659f8f549fdecd"}]}