)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"faacfd3856faef8922434945e84895c0d668f7ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-26 10:13:16 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enables partition images for agent drvers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds support for naming the partitions over the baremetal"},{"line_number":10,"context_line":"device driver. This is required for supporting partition images in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aed3d3a_473ed98c","line":7,"updated":"2016-02-29 09:37:16.000000000","message":"/drvers./drivers","commit_id":"8370dcf283244129c272e2b7ce6923ca1b5355f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"055b3eee0e54fe77b6be06cbde0c5f06e7e411b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-29 09:37:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enables partition images for agent drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds support for naming the partitions over the baremetal"},{"line_number":10,"context_line":"device driver. This is required for supporting partition images in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_8555011f","line":7,"updated":"2016-03-01 12:54:36.000000000","message":"could you please be more specific? e.g. \"Fix partition naming for iSCSI devices\" or something? Then please explain how it is related to the partition image supposed, cause I still have no idea.","commit_id":"66b9c3cad73f269445ca30c8b45f707e0d1cde84"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1e9fe91666d4b89ccc359e9d4934b7eb8b28ff01","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-29 09:37:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enables partition images for agent drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds support for naming the partitions over the baremetal"},{"line_number":10,"context_line":"device driver. This is required for supporting partition images in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_63103ba9","line":7,"in_reply_to":"7af24918_8555011f","updated":"2016-03-02 20:31:34.000000000","message":"ok.","commit_id":"66b9c3cad73f269445ca30c8b45f707e0d1cde84"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"055b3eee0e54fe77b6be06cbde0c5f06e7e411b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds support for naming the partitions over the baremetal"},{"line_number":10,"context_line":"device driver. This is required for supporting partition images in"},{"line_number":11,"context_line":"ironic-python-agent. The ironic-python-agent should be able to"},{"line_number":12,"context_line":"name the device partitions as /dev/sda1, /dev/sda2, etc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I22bc29a39bf5c35f3eecb6d4e51cebd6aee0ce19"},{"line_number":15,"context_line":"Partial-bug: 1526289"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_e530450a","line":12,"updated":"2016-03-01 12:54:36.000000000","message":"I don\u0027t get the last question. We\u0027re adding suppose for iSCSI devices, how is /dev/sda1 related?","commit_id":"66b9c3cad73f269445ca30c8b45f707e0d1cde84"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1e9fe91666d4b89ccc359e9d4934b7eb8b28ff01","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds support for naming the partitions over the baremetal"},{"line_number":10,"context_line":"device driver. This is required for supporting partition images in"},{"line_number":11,"context_line":"ironic-python-agent. The ironic-python-agent should be able to"},{"line_number":12,"context_line":"name the device partitions as /dev/sda1, /dev/sda2, etc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I22bc29a39bf5c35f3eecb6d4e51cebd6aee0ce19"},{"line_number":15,"context_line":"Partial-bug: 1526289"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_a350835f","line":12,"in_reply_to":"7af24918_e530450a","updated":"2016-03-02 20:31:34.000000000","message":"No we are adding the naming for /dev/sda+1 for baremetal. For iSCSCI device, it is already \"device\" + \u0027part1\u0027 etc.","commit_id":"66b9c3cad73f269445ca30c8b45f707e0d1cde84"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1a64b456ce41ce98b7f8ef80647131ebdf190837","unresolved":false,"context_lines":[{"line_number":67,"context_line":"_PARTED_PRINT_RE \u003d re.compile(r\"^(\\d+):([\\d\\.]+)MiB:\""},{"line_number":68,"context_line":"                              \"([\\d\\.]+)MiB:([\\d\\.]+)MiB:(\\w*)::(\\w*)\")"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"_ISCSI_RE \u003d re.compile(r\"^ip-[\\d+.]*:\\w+-iscsi-[\\w+.]*-lun-\\d+\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def list_partitions(device):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_0d396ba4","line":70,"updated":"2016-02-23 16:53:52.000000000","message":"The regex doesn\u0027t seem to be valid [0], the iscsi name is something like:\n\niqn.yyyy-mm.naming-authority:unique name\n\n[0] http://logs.openstack.org/45/281045/2/check/gate-tempest-dsvm-ironic-lib-src-nv/ae6369f/logs/screen-ir-cond.txt.gz#_2016-02-17_19_52_06_358\n\n...\n\nIt makes me wonder if we actually need a regex for it, IMHO, since Ironic has the control over the iscsi what if we just search for the \"iqn.2008-10.org.openstack\" string in the device name? See comment at L129","commit_id":"06d6d95e1b2631064e8de73b265a921e5d6032b8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1a64b456ce41ce98b7f8ef80647131ebdf190837","unresolved":false,"context_lines":[{"line_number":126,"context_line":"def is_iscsi_device(dev):"},{"line_number":127,"context_line":"    \"\"\"check whether the device path belongs to an iscsi device. \"\"\""},{"line_number":128,"context_line":"    basename \u003d os.path.basename(dev)"},{"line_number":129,"context_line":"    return bool(_ISCSI_RE.match(basename))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_2d5b8ff7","line":129,"updated":"2016-02-23 16:53:52.000000000","message":"What about:\n\n def is_iscsi_device(dev, node_uuid):\n     \"\"\" \"\"\"\n     iscsi_id \u003d \"iqn.2008-10.org.openstack:%s\" % node_uuid\n     return iscsi_id in dev","commit_id":"06d6d95e1b2631064e8de73b265a921e5d6032b8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d96dc93d8a12877eb5537fac092d8471d29be6b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"def is_iscsi_device(dev):"},{"line_number":127,"context_line":"    \"\"\"check whether the device path belongs to an iscsi device. \"\"\""},{"line_number":128,"context_line":"    basename \u003d os.path.basename(dev)"},{"line_number":129,"context_line":"    return bool(_ISCSI_RE.match(basename))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3c498a8f","line":129,"in_reply_to":"bae84128_2d5b8ff7","updated":"2016-02-25 10:41:33.000000000","message":"+1\nThis simplies it .","commit_id":"06d6d95e1b2631064e8de73b265a921e5d6032b8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c7846d68520a2a237314bc46d9ff4128be1336a1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"def is_iscsi_device(dev, node_uuid):"},{"line_number":125,"context_line":"    \"\"\"check whether the device path belongs to an iscsi device. \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    iscsi_id \u003d \"iqn.2008-10.org.openstack.%s\" % node_uuid"},{"line_number":128,"context_line":"    return (iscsi_id in dev)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_25002d01","line":127,"updated":"2016-02-26 18:01:13.000000000","message":"The string here is wrong, there\u0027s a \":\" after openstack and before the UUID instead of the period (\".\")\n\niscsi_id \u003d \"iqn.2008-10.org.openstack:%s\" % node_uuid","commit_id":"84f052d8ac37a88eca34b74a738d4a878e6d94d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c7846d68520a2a237314bc46d9ff4128be1336a1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    \"\"\"check whether the device path belongs to an iscsi device. \"\"\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    iscsi_id \u003d \"iqn.2008-10.org.openstack.%s\" % node_uuid"},{"line_number":128,"context_line":"    return (iscsi_id in dev)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_e51e4562","line":128,"updated":"2016-02-26 18:01:13.000000000","message":"Parentheses \"()\" not needed","commit_id":"84f052d8ac37a88eca34b74a738d4a878e6d94d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"055b3eee0e54fe77b6be06cbde0c5f06e7e411b1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    LOG.debug(\"Starting to partition the disk device: %(dev)s \""},{"line_number":156,"context_line":"              \"for node %(node)s\","},{"line_number":157,"context_line":"              {\u0027dev\u0027: dev, \u0027node\u0027: node_uuid})"},{"line_number":158,"context_line":"    if is_iscsi_device(dev, node_uuid):"},{"line_number":159,"context_line":"        part_template \u003d dev + \u0027-part%d\u0027"},{"line_number":160,"context_line":"    else:"},{"line_number":161,"context_line":"        part_template \u003d dev + \u0027%d\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c53549f8","line":158,"updated":"2016-03-01 12:54:36.000000000","message":"nit: please leave comment on why we\u0027re doing this","commit_id":"66b9c3cad73f269445ca30c8b45f707e0d1cde84"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1e9fe91666d4b89ccc359e9d4934b7eb8b28ff01","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    LOG.debug(\"Starting to partition the disk device: %(dev)s \""},{"line_number":156,"context_line":"              \"for node %(node)s\","},{"line_number":157,"context_line":"              {\u0027dev\u0027: dev, \u0027node\u0027: node_uuid})"},{"line_number":158,"context_line":"    if is_iscsi_device(dev, node_uuid):"},{"line_number":159,"context_line":"        part_template \u003d dev + \u0027-part%d\u0027"},{"line_number":160,"context_line":"    else:"},{"line_number":161,"context_line":"        part_template \u003d dev + \u0027%d\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_83362750","line":158,"in_reply_to":"7af24918_c53549f8","updated":"2016-03-02 20:31:34.000000000","message":"Ok will add teh comment.","commit_id":"66b9c3cad73f269445ca30c8b45f707e0d1cde84"}]}