)]}'
{"ironic_lib/disk_partitioner.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"90b410e67475f41d060506a64c15762abd268907","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      bootable\u003dFalse):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_901fca08","side":"PARENT","line":83,"updated":"2016-05-03 17:17:09.000000000","message":"The name \"bootable\" strongly implies a boolean value; I think you should change the name to something else. \"boot_mode\", maybe?","commit_id":"9eaad70080bcc29171d71c02fbdfc42809be6057"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"c64727ceeba1d7be2926b228221fd28100578436","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      bootable\u003dFalse):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1646037b","side":"PARENT","line":83,"in_reply_to":"1a122d0e_901fca08","updated":"2016-05-04 04:31:11.000000000","message":"+1.\nWill make changes in the next patch.","commit_id":"9eaad70080bcc29171d71c02fbdfc42809be6057"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"90b410e67475f41d060506a64c15762abd268907","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                        fat16, HFS, linux-swap, NTFS, reiserfs, ufs."},{"line_number":91,"context_line":"                        If blank (\u0027\u0027), it will create a Linux native"},{"line_number":92,"context_line":"                        partition (83)."},{"line_number":93,"context_line":"        :param bootable: Boolean value; whether the partition is bootable"},{"line_number":94,"context_line":"                         or not."},{"line_number":95,"context_line":"        :returns: The partition number."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_701aee19","side":"PARENT","line":93,"updated":"2016-05-03 17:17:09.000000000","message":"Please update this to reflect the new type, and preferably the new name. If possible, list the allowed values here.","commit_id":"9eaad70080bcc29171d71c02fbdfc42809be6057"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"c64727ceeba1d7be2926b228221fd28100578436","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                        fat16, HFS, linux-swap, NTFS, reiserfs, ufs."},{"line_number":91,"context_line":"                        If blank (\u0027\u0027), it will create a Linux native"},{"line_number":92,"context_line":"                        partition (83)."},{"line_number":93,"context_line":"        :param bootable: Boolean value; whether the partition is bootable"},{"line_number":94,"context_line":"                         or not."},{"line_number":95,"context_line":"        :returns: The partition number."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b6574f25","side":"PARENT","line":93,"in_reply_to":"1a122d0e_701aee19","updated":"2016-05-04 04:31:11.000000000","message":"+1.\nWill change it.","commit_id":"9eaad70080bcc29171d71c02fbdfc42809be6057"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"248400e3b6dfc733a27cf7ce1923096460b4ac19","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      boot_flag\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_417e30af","line":83,"updated":"2016-05-12 23:46:16.000000000","message":"This is a method that is available in this library, right? So if you remove the bootable parameter, won\u0027t you break anything that actually calls this method with bootable\u003dsomething?","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"534000cc84b4c04f8fde22715dbdcecc3ac3aaf4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      boot_flag\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_efd29d33","line":83,"in_reply_to":"dab17558_1a55aa1c","updated":"2016-05-13 08:53:29.000000000","message":"Hi Runy, Vinay,\n\n@Vinay I think @Ruby understand the change but she\u0027s worried that by removing the \"bootable\" parameter we will break projects that may be calling add_partition() with the bootable parameter.\n\nSo @Ruby, the view on this (and reason why I +2 it) is because we have in the Ironic umbrella 2 projects that does partitioning of disks: Ironic itself and ironic-python-agent. None of them calls add_partition() directly [0] they do call disk_utils.work_on_disk() which then invoke add_partition() internally.\n\nSince in my understand the ironic-lib is a project to share code between Ironic projects *only* I don\u0027t see the problem of changing this parameter.\n\nIt is possible that someone might be importing ironic-lib and calling add_partition() and this change will break his/her program, but that\u0027s outside of the scope of the ironic-lib to be a public library for disk manipulation or other things it does.\n\n[0] http://paste.openstack.org/show/497013/","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7e53edee1dbcb39653cfd214f749674f5c5f4c25","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      boot_flag\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_1a55aa1c","line":83,"in_reply_to":"dab17558_417e30af","updated":"2016-05-13 05:20:44.000000000","message":"I am not sure if i got your question correctly. \nEarlier the \u0027bootable\u0027 parameter is boolean. When parted is executed to partion the disk, it will look for this flag and if it\u0027s true it adds \u0027set 1 boot on\u0027 to the argument list marking it as boot partition. If it is false it just creates the partition.\n    If the disk is partitioned with GPT and the boot_mode is \u0027bios\u0027 we need a BIOS boot partition with boot flag set as \u0027bios_grub\u0027. This adds the argument \u0027set 1 bios_grub on\u0027 to the parted command. The \u0027boot_flag\u0027 parameter is not a function. It\u0027s a dictionary and any method that calls it knows what flag it is going to set else it simply ignores.\nMay be we need validation before parted is executed like below:\nboot_flag \u003d boot_flag if boot_flag in (\u0027boot\u0027, \u0027bios_grub\u0027) else None","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bdc810e1ac36d7a17643d71450451c6b86104930","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      boot_flag\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_40c23c86","line":83,"in_reply_to":"dab17558_8b4bfc2a","updated":"2016-05-16 14:01:33.000000000","message":"@Lucas, Vinay. OH. I think there is a misunderstanding (either on my part or Lucas) wrt this library. I\u0027ve started an email thread about it [1].\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-May/095090.html","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"b7aaa2a3afaa0a94a2bc2dfa19f460567ab38b0e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      use_standard_locale\u003dTrue, run_as_root\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_partition(self, size, part_type\u003d\u0027primary\u0027, fs_type\u003d\u0027\u0027,"},{"line_number":83,"context_line":"                      boot_flag\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Add a partition."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param size: The size of the partition in MiB."}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_8b4bfc2a","line":83,"in_reply_to":"dab17558_efd29d33","updated":"2016-05-13 11:15:39.000000000","message":"Thanks Lucas. My mistake i have misinterpreted it thinking in terms of the text selected. i have looked into other areas where it can impact after this change. work_on_disk is called by IPA during agent deploy or by conductor during iscsi deploy.","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7727538097ae96804766ffb7f7ec55a7c2478849","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Size of EFI system partition in MiB when configuring \u0027"},{"line_number":48,"context_line":"                    \u0027UEFI systems for local boot.\u0027,"},{"line_number":49,"context_line":"               deprecated_group\u003d\u0027deploy\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027bios_boot_partition_size\u0027,"},{"line_number":51,"context_line":"               default\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Size of BIOS Boot partition in MiB when configuring \u0027"},{"line_number":53,"context_line":"                    \u0027GPT partitioned systems for local boot in BIOS.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_64a3a79f","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":42},"updated":"2016-05-06 05:46:03.000000000","message":"Do we really needs this to be configurable? I think it hard coding the size to 512 bytes or 1 MiB in first sector should do.","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"4da15734e27238782be658507d56a88ceecf0fd2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Size of EFI system partition in MiB when configuring \u0027"},{"line_number":48,"context_line":"                    \u0027UEFI systems for local boot.\u0027,"},{"line_number":49,"context_line":"               deprecated_group\u003d\u0027deploy\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027bios_boot_partition_size\u0027,"},{"line_number":51,"context_line":"               default\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Size of BIOS Boot partition in MiB when configuring \u0027"},{"line_number":53,"context_line":"                    \u0027GPT partitioned systems for local boot in BIOS.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_19ac789f","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":42},"in_reply_to":"dab17558_64a3a79f","updated":"2016-05-09 11:43:37.000000000","message":"I think it\u0027d be better to keep it as configurable parameter. So keeping this change as is.","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c773858d9b6c6ec12b79e655482b22d1376a03d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027Size of EFI system partition in MiB when configuring \u0027"},{"line_number":48,"context_line":"                    \u0027UEFI systems for local boot.\u0027,"},{"line_number":49,"context_line":"               deprecated_group\u003d\u0027deploy\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027bios_boot_partition_size\u0027,"},{"line_number":51,"context_line":"               default\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Size of BIOS Boot partition in MiB when configuring \u0027"},{"line_number":53,"context_line":"                    \u0027GPT partitioned systems for local boot in BIOS.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_abe71211","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":42},"in_reply_to":"dab17558_64a3a79f","updated":"2016-05-06 11:01:45.000000000","message":"Yeah the documentation recommends 1 MiB [0] even tho only 31KiB is actually required.\n\n[0] https://www.gnu.org/software/grub/manual/html_node/BIOS-installation.html","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7727538097ae96804766ffb7f7ec55a7c2478849","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        part_dict[\u0027efi system partition\u0027] \u003d part_template % part_num"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if boot_mode \u003d\u003d \"bios\" and boot_option \u003d\u003d \"local\" and disk_label \u003d\u003d \"gpt\":"},{"line_number":192,"context_line":"        part_num \u003d dp.add_partition(CONF.disk_utils.bios_boot_partition_size,"},{"line_number":193,"context_line":"                                    boot_flag\u003d\u0027bios_grub\u0027)"},{"line_number":194,"context_line":"        part_dict[\u0027BIOS Boot partition\u0027] \u003d part_template % part_num"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_84aa0b6f","line":192,"range":{"start_line":192,"start_character":36,"end_line":192,"end_character":77},"updated":"2016-05-06 05:46:03.000000000","message":"ditto","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c773858d9b6c6ec12b79e655482b22d1376a03d2","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    boot_val \u003d None"},{"line_number":223,"context_line":"    if boot_option \u003d\u003d \"local\" and boot_mode \u003d\u003d \"bios\":"},{"line_number":224,"context_line":"        boot_val \u003d \u0027boot\u0027 if disk_label \u003d\u003d \u0027msdos\u0027 else None"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    part_num \u003d dp.add_partition(root_mb, boot_flag\u003dboot_val)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2b884222","line":224,"updated":"2016-05-06 11:01:45.000000000","message":"nit (to be similar to the L191):\n\n root_boot_val \u003d None\n if boot_option \u003d\u003d \u0027local\u0027 and boot_mode \u003d\u003d \u0027bios\u0027 and disk_label \u003d\u003d \u0027msdos\u0027:\n     root_boot_val \u003d \u0027boot\u0027","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"4da15734e27238782be658507d56a88ceecf0fd2","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    boot_val \u003d None"},{"line_number":223,"context_line":"    if boot_option \u003d\u003d \"local\" and boot_mode \u003d\u003d \"bios\":"},{"line_number":224,"context_line":"        boot_val \u003d \u0027boot\u0027 if disk_label \u003d\u003d \u0027msdos\u0027 else None"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    part_num \u003d dp.add_partition(root_mb, boot_flag\u003dboot_val)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_9a29838c","line":224,"in_reply_to":"dab17558_2b884222","updated":"2016-05-09 11:43:37.000000000","message":"Done","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"248400e3b6dfc733a27cf7ce1923096460b4ac19","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Size of BIOS Boot partition in MiB when configuring \u0027"},{"line_number":53,"context_line":"                    \u0027GPT partitioned systems for local boot in BIOS.\u0027,"},{"line_number":54,"context_line":"               deprecated_group\u003d\u0027deploy\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"},{"line_number":56,"context_line":"               default\u003d\u00271M\u0027,"},{"line_number":57,"context_line":"               help\u003d\u0027Block size to use when writing to the nodes disk.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_8403060d","line":54,"updated":"2016-05-12 23:46:16.000000000","message":"I don\u0027t see where this config came from. Was it from ironic? Because I don\u0027t see it in the \u0027deploy\u0027 group and there isn\u0027t any \u0027deploy\u0027 group in this library.","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bdc810e1ac36d7a17643d71450451c6b86104930","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Size of BIOS Boot partition in MiB when configuring \u0027"},{"line_number":53,"context_line":"                    \u0027GPT partitioned systems for local boot in BIOS.\u0027,"},{"line_number":54,"context_line":"               deprecated_group\u003d\u0027deploy\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"},{"line_number":56,"context_line":"               default\u003d\u00271M\u0027,"},{"line_number":57,"context_line":"               help\u003d\u0027Block size to use when writing to the nodes disk.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_9d61303c","line":54,"in_reply_to":"dab17558_5d860c66","updated":"2016-05-16 14:01:33.000000000","message":"If this is a new config, why do you have the \u0027deprecated_group\u003d...\u0027 part? That is meant to indicate that the config is deprecated from the group \u0027deploy\u0027.","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7e53edee1dbcb39653cfd214f749674f5c5f4c25","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Size of BIOS Boot partition in MiB when configuring \u0027"},{"line_number":53,"context_line":"                    \u0027GPT partitioned systems for local boot in BIOS.\u0027,"},{"line_number":54,"context_line":"               deprecated_group\u003d\u0027deploy\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"},{"line_number":56,"context_line":"               default\u003d\u00271M\u0027,"},{"line_number":57,"context_line":"               help\u003d\u0027Block size to use when writing to the nodes disk.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_5d860c66","line":54,"in_reply_to":"dab17558_8403060d","updated":"2016-05-13 05:20:44.000000000","message":"+1. \nThis option doesn\u0027t exist earlier in ironic deploy group. i just added one. Honestly, i just tried to copy it the way it was defined for \u0027efi_system_partition_size\u0027 and failed to notice. But my point is, as you said \u0027deploy\u0027 group is not in this library, ideally it is not OK with other config options as well be used in this library this way. Can you suggest what would be the better way to define it?","commit_id":"75f1caccfde9080bf6da8c739d27d7f93f4c223d"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"de1ba5b50053d8d7626c58d1a2f94d1576f130c9","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        _s \u003d lambda x, sz: x + sz"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        if boot_option \u003d\u003d \"local\" and boot_mode \u003d\u003d \"uefi\":"},{"line_number":264,"context_line":"            add_efi_sz \u003d lambda x: str(_s(x, self.efi_size))"},{"line_number":265,"context_line":"            expected_mkpart \u003d [\u0027mkpart\u0027, \u0027primary\u0027, \u0027fat32\u0027, \u00271\u0027,"},{"line_number":266,"context_line":"                               add_efi_sz(1),"},{"line_number":267,"context_line":"                               \u0027set\u0027, \u00271\u0027, \u0027boot\u0027, \u0027on\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e6605ca7","line":264,"updated":"2016-05-23 14:41:15.000000000","message":"lambda x: str(x + self.efi_size)","commit_id":"c6d4f0f463974a3a88eadb22c175c796556cc755"}],"releasenotes/notes/gpt-bios-425e703770fae46d.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c773858d9b6c6ec12b79e655482b22d1376a03d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug when node boots in BIOS mode and disk label is"},{"line_number":4,"context_line":"    set as gpt."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_ab89d2cc","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":15},"updated":"2016-05-06 11:01:45.000000000","message":"I find this description a bit vague/misleading, BIOS + GPT is fine if used without local boot. May I suggest:\n\n\"Fixes a problem where nodes being configured in BIOS mode to boot from the local disk with a GPT partition table would fail at boot time\"","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"4da15734e27238782be658507d56a88ceecf0fd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug when node boots in BIOS mode and disk label is"},{"line_number":4,"context_line":"    set as gpt."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_3a3b37d3","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":15},"in_reply_to":"dab17558_ab89d2cc","updated":"2016-05-09 11:43:37.000000000","message":"Done","commit_id":"5b57b924afc9682983d8811029b265efce5865bf"}]}