)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"eb66aefd7221d5711656590da136589c50504d25","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include wipefs --force option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wipefs sometimes failed with errors like \u0027Device or resource busy\u0027,"},{"line_number":10,"context_line":"include --force option to fix the problems."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad864d7ae9ab67286853f3c533a9c385ffe2cb05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_93c2b732","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":23},"updated":"2016-06-08 08:18:07.000000000","message":"often fails","commit_id":"17483238ede7e2bcd6a5af697b803a6d8a448308"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d8ae54ad649a13a744b6a2811f3aca03a09f4d4a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Include wipefs --force option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wipefs sometimes failed with errors like \u0027Device or resource busy\u0027,"},{"line_number":10,"context_line":"include --force option to fix the problems."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad864d7ae9ab67286853f3c533a9c385ffe2cb05"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_10d7da4b","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":23},"in_reply_to":"7aa08908_93c2b732","updated":"2016-06-08 08:22:58.000000000","message":"in fact, it\u0027s not often fails, just in some cases with specific partitions on the disk and cleaning is disabled.","commit_id":"17483238ede7e2bcd6a5af697b803a6d8a448308"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"eb66aefd7221d5711656590da136589c50504d25","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Include wipefs --force option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wipefs sometimes failed with errors like \u0027Device or resource busy\u0027,"},{"line_number":10,"context_line":"include --force option to fix the problems."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iad864d7ae9ab67286853f3c533a9c385ffe2cb05"},{"line_number":13,"context_line":"Closes-Bug: #1590304"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_2e127857","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":42},"updated":"2016-06-08 08:18:07.000000000","message":"May be read better if rephrased as \nThis fix passes --force option to wipefs.","commit_id":"17483238ede7e2bcd6a5af697b803a6d8a448308"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"98c32f5c77d50c4d0efc6978790692461d59de4e","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    # https://bugs.launchpad.net/ironic/+bug/1317647"},{"line_number":317,"context_line":"    LOG.debug(\"Start destroy disk metadata for node %(node)s.\","},{"line_number":318,"context_line":"              {\u0027node\u0027: node_uuid})"},{"line_number":319,"context_line":"    utils.execute(\u0027wipefs\u0027, \u0027--force\u0027, \u0027--all\u0027, dev,"},{"line_number":320,"context_line":"                  run_as_root\u003dTrue,"},{"line_number":321,"context_line":"                  check_exit_code\u003d[0],"},{"line_number":322,"context_line":"                  use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_cdf01094","line":319,"range":{"start_line":319,"start_character":29,"end_line":319,"end_character":36},"updated":"2016-06-08 10:22:42.000000000","message":"Looks like \u0027--force\u0027 option is not supported on Ubuntu.\n\nhttp://manpages.ubuntu.com/manpages/trusty/man8/wipefs.8.html","commit_id":"17483238ede7e2bcd6a5af697b803a6d8a448308"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"659fc11a8e5343fd1829c11bdbf7d167f179d620","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    try:"},{"line_number":320,"context_line":"        utils.execute(\u0027wipefs\u0027, \u0027--force\u0027, \u0027--all\u0027, dev,"},{"line_number":321,"context_line":"                      run_as_root\u003dTrue,"},{"line_number":322,"context_line":"                      check_exit_code\u003d[0],"},{"line_number":323,"context_line":"                      use_standard_locale\u003dTrue)"},{"line_number":324,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":325,"context_line":"        # NOTE(zhenguo): Check if --force option is supported for wipefs,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f8df3e38","line":322,"range":{"start_line":322,"start_character":22,"end_line":322,"end_character":42},"updated":"2016-06-15 10:18:05.000000000","message":"check_exit_code\u003d[0] is the default","commit_id":"4eb19a0f91283cb3f30bc0cce7cf00eb74821ef7"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9def7c0c01fd0fa9504193a2800636b49f7897fa","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    try:"},{"line_number":320,"context_line":"        utils.execute(\u0027wipefs\u0027, \u0027--force\u0027, \u0027--all\u0027, dev,"},{"line_number":321,"context_line":"                      run_as_root\u003dTrue,"},{"line_number":322,"context_line":"                      check_exit_code\u003d[0],"},{"line_number":323,"context_line":"                      use_standard_locale\u003dTrue)"},{"line_number":324,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":325,"context_line":"        # NOTE(zhenguo): Check if --force option is supported for wipefs,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_be16e152","line":322,"range":{"start_line":322,"start_character":22,"end_line":322,"end_character":42},"in_reply_to":"7aa08908_f8df3e38","updated":"2016-06-22 15:29:18.000000000","message":"Done","commit_id":"4eb19a0f91283cb3f30bc0cce7cf00eb74821ef7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"659fc11a8e5343fd1829c11bdbf7d167f179d620","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if \u0027--force\u0027 in str(e):"},{"line_number":328,"context_line":"            utils.execute(\u0027wipefs\u0027, \u0027--all\u0027, dev,"},{"line_number":329,"context_line":"                          run_as_root\u003dTrue,"},{"line_number":330,"context_line":"                          check_exit_code\u003d[0],"},{"line_number":331,"context_line":"                          use_standard_locale\u003dTrue)"},{"line_number":332,"context_line":"        else:"},{"line_number":333,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f8845e0c","line":330,"range":{"start_line":330,"start_character":26,"end_line":330,"end_character":46},"updated":"2016-06-15 10:18:05.000000000","message":"ditto.","commit_id":"4eb19a0f91283cb3f30bc0cce7cf00eb74821ef7"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9def7c0c01fd0fa9504193a2800636b49f7897fa","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if \u0027--force\u0027 in str(e):"},{"line_number":328,"context_line":"            utils.execute(\u0027wipefs\u0027, \u0027--all\u0027, dev,"},{"line_number":329,"context_line":"                          run_as_root\u003dTrue,"},{"line_number":330,"context_line":"                          check_exit_code\u003d[0],"},{"line_number":331,"context_line":"                          use_standard_locale\u003dTrue)"},{"line_number":332,"context_line":"        else:"},{"line_number":333,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_5e089d2c","line":330,"range":{"start_line":330,"start_character":26,"end_line":330,"end_character":46},"in_reply_to":"7aa08908_f8845e0c","updated":"2016-06-22 15:29:18.000000000","message":"Done","commit_id":"4eb19a0f91283cb3f30bc0cce7cf00eb74821ef7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5f8efb3d8cf8e4bc9db124025b3a9249bfb07b13","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                          run_as_root\u003dTrue,"},{"line_number":329,"context_line":"                          use_standard_locale\u003dTrue)"},{"line_number":330,"context_line":"        else:"},{"line_number":331,"context_line":"            raise e"},{"line_number":332,"context_line":"    LOG.info(_LI(\"Disk metadata on %(dev)s successfully destroyed for node \""},{"line_number":333,"context_line":"                 \"%(node)s\"), {\u0027dev\u0027: dev, \u0027node\u0027: node_uuid})"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_f214d54d","line":331,"updated":"2016-07-06 16:23:39.000000000","message":"Apparently --force was introduced in 2012 [0] sad ubuntu trusty still does not support it :-/\n\n[0] https://github.com/karelzak/util-linux/commit/2968c3fc7388f88b8debe64d61d9785601c16436","commit_id":"9b5cb2062dc5589eab829e7a92fcb84c1336636c"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"659fc11a8e5343fd1829c11bdbf7d167f179d620","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        disk_utils.destroy_disk_metadata(self.dev, self.node_uuid)"},{"line_number":358,"context_line":"        mock_exec.assert_has_calls(expected_calls)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def test_destroy_disk_metadata_wipefs_fail(self, mock_exec):"},{"line_number":361,"context_line":"        mock_exec.side_effect \u003d processutils.ProcessExecutionError"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        expected_call \u003d [mock.call(\u0027wipefs\u0027, \u0027--force\u0027, \u0027--all\u0027, \u0027fake-dev\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_583db22b","line":360,"range":{"start_line":360,"start_character":8,"end_line":360,"end_character":45},"updated":"2016-06-15 10:18:05.000000000","message":"this testcase needs to be further improved to make sure that \u0027wipefs --all\u0027 is called upon receiving exception processutils.ProcessExecutionError when \u0027--force\u0027 option is used.","commit_id":"4eb19a0f91283cb3f30bc0cce7cf00eb74821ef7"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9def7c0c01fd0fa9504193a2800636b49f7897fa","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        disk_utils.destroy_disk_metadata(self.dev, self.node_uuid)"},{"line_number":358,"context_line":"        mock_exec.assert_has_calls(expected_calls)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def test_destroy_disk_metadata_wipefs_fail(self, mock_exec):"},{"line_number":361,"context_line":"        mock_exec.side_effect \u003d processutils.ProcessExecutionError"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        expected_call \u003d [mock.call(\u0027wipefs\u0027, \u0027--force\u0027, \u0027--all\u0027, \u0027fake-dev\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_380a2922","line":360,"range":{"start_line":360,"start_character":8,"end_line":360,"end_character":45},"in_reply_to":"7aa08908_583db22b","updated":"2016-06-22 15:29:18.000000000","message":"Done","commit_id":"4eb19a0f91283cb3f30bc0cce7cf00eb74821ef7"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"20c091eb584583bc9a0725882df35b8324c631a9","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def test_destroy_disk_metadata_wipefs_not_support_force(self, mock_exec):"},{"line_number":372,"context_line":"        mock_exec.side_effect \u003d iter("},{"line_number":373,"context_line":"            [processutils.ProcessExecutionError(description\u003d\u0027--force\u0027),"},{"line_number":374,"context_line":"             (None, None)])"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        expected_call \u003d [mock.call(\u0027wipefs\u0027, \u0027--force\u0027, \u0027--all\u0027, \u0027fake-dev\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_7fbf1baa","line":373,"range":{"start_line":373,"start_character":48,"end_line":373,"end_character":71},"updated":"2016-07-06 12:45:43.000000000","message":"nit: I would prefer slightly more text for the fake error since the error would be normally contained with-in an entire error message, but it does what is needed, so I\u0027m okay with it as-is.","commit_id":"9b5cb2062dc5589eab829e7a92fcb84c1336636c"}]}
