)]}'
{"ironic_lib/exception.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"21a31519faa0b81898dac93c171629aea70ef32e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                message \u003d self.message % kwargs"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            except Exception:"},{"line_number":75,"context_line":"                # kwargs doesn\u0027t match a variable in the message"},{"line_number":76,"context_line":"                # log the issue and the kwargs"},{"line_number":77,"context_line":"                LOG.exception(_LE(\u0027Exception in string format operation\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_40c49291","line":74,"updated":"2016-08-12 23:52:52.000000000","message":"As others said, the with statement should follow this line\n\nSee: http://docs.openstack.org/developer/oslo.utils/api/excutils.html\n\nMaybe something like this:\n\n with save_and_reraise_exception() as ctxt:\n\nAnd then what Sam proposed.","commit_id":"a96df83460870ffda769cd0ef6e305aab9804843"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"182cb59e2cc2a06fb589315a51504540f3210d14","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            try:"},{"line_number":72,"context_line":"                message \u003d self.message % kwargs"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            except Exception:"},{"line_number":75,"context_line":"                # kwargs doesn\u0027t match a variable in the message"},{"line_number":76,"context_line":"                # log the issue and the kwargs"},{"line_number":77,"context_line":"                LOG.exception(_LE(\u0027Exception in string format operation\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_e3e14500","line":74,"in_reply_to":"7ac969e8_40c49291","updated":"2016-08-13 02:51:18.000000000","message":"Done","commit_id":"a96df83460870ffda769cd0ef6e305aab9804843"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fff12fe76a706d376b98e01a2a0ed8aa1154eea6","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"                if CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":82,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":83,"context_line":"                        pass"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    # at least get the core message out if something happened"},{"line_number":86,"context_line":"                    message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_820ae377","line":83,"updated":"2016-07-14 13:23:08.000000000","message":"this is no-op. the whole block should be covered in save_and_reraise_exception","commit_id":"a96df83460870ffda769cd0ef6e305aab9804843"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"31f15808b8df36be4aaa69c3b625b362f75290f2","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"                if CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":82,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":83,"context_line":"                        pass"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    # at least get the core message out if something happened"},{"line_number":86,"context_line":"                    message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_bc2495b2","line":83,"in_reply_to":"1aa78d24_820ae377","updated":"2016-08-12 10:24:33.000000000","message":"+1, and the if statement can become:\n\n    if not CONF.ironic_lib.fatal_exception_format_errors:\n        message \u003d self.message\n        ctxt.reraise \u003d False","commit_id":"a96df83460870ffda769cd0ef6e305aab9804843"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"182cb59e2cc2a06fb589315a51504540f3210d14","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"                if CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":82,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":83,"context_line":"                        pass"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    # at least get the core message out if something happened"},{"line_number":86,"context_line":"                    message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_43e77912","line":83,"in_reply_to":"1aa78d24_820ae377","updated":"2016-08-13 02:51:18.000000000","message":"Done","commit_id":"a96df83460870ffda769cd0ef6e305aab9804843"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"182cb59e2cc2a06fb589315a51504540f3210d14","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"                if CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":82,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":83,"context_line":"                        pass"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    # at least get the core message out if something happened"},{"line_number":86,"context_line":"                    message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_23e4fd0b","line":83,"in_reply_to":"9ad45d7e_bc2495b2","updated":"2016-08-13 02:51:18.000000000","message":"Done","commit_id":"a96df83460870ffda769cd0ef6e305aab9804843"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a40e81946e0ec9c5f651f9ba96246db9bc75b7ad","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    # log the issue and the kwargs"},{"line_number":78,"context_line":"                    LOG.exception(_LE(\u0027Exception in string format operation\u0027))"},{"line_number":79,"context_line":"                    for name, value in kwargs.items():"},{"line_number":80,"context_line":"                        LOG.error(\"%s: %s\" % (name, value))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"                    if not CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":83,"context_line":"                        message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac969e8_3786f7b9","line":80,"updated":"2016-08-13 08:53:28.000000000","message":"while you\u0027re on it, please improve this bit as well. these separate error messages are going to be really confusing, let\u0027s better have\n\n LOG.exception(_LE(\u0027Exception in string format operation (arguments %s)\u0027),\n               \u0027, \u0027.join(\u0027%s\u003d%s\u0027 % pair for pair in kwargs.items())","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"8f78f419bc9ace58b9d62f5c86b946cdc409f946","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    # log the issue and the kwargs"},{"line_number":78,"context_line":"                    LOG.exception(_LE(\u0027Exception in string format operation\u0027))"},{"line_number":79,"context_line":"                    for name, value in kwargs.items():"},{"line_number":80,"context_line":"                        LOG.error(\"%s: %s\" % (name, value))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"                    if not CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":83,"context_line":"                        message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_ff072415","line":80,"in_reply_to":"7ac969e8_3786f7b9","updated":"2016-08-24 11:37:56.000000000","message":"Done","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fb621faaf59dbbf088ae4c064e56535cd86bb4c0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    if not CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":83,"context_line":"                        message \u003d self.message"},{"line_number":84,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_43ef52e8","line":85,"updated":"2016-08-15 16:57:43.000000000","message":"This else statement can be dropped. Just move the comment as Dmitry suggested.","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"8f78f419bc9ace58b9d62f5c86b946cdc409f946","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    if not CONF.ironic_lib.fatal_exception_format_errors:"},{"line_number":83,"context_line":"                        message \u003d self.message"},{"line_number":84,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_3f16dc4b","line":85,"in_reply_to":"3ac371cc_43ef52e8","updated":"2016-08-24 11:37:56.000000000","message":"Done","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fb621faaf59dbbf088ae4c064e56535cd86bb4c0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        super(IronicException, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_a3ba86df","line":87,"updated":"2016-08-15 16:57:43.000000000","message":"+1","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a40e81946e0ec9c5f651f9ba96246db9bc75b7ad","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        super(IronicException, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac969e8_97936bfa","line":87,"updated":"2016-08-13 08:53:28.000000000","message":"this comment should go to the previous branch","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"8f78f419bc9ace58b9d62f5c86b946cdc409f946","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        super(IronicException, self).__init__(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_1f116052","line":87,"in_reply_to":"3ac371cc_a3ba86df","updated":"2016-08-24 11:37:56.000000000","message":"Done","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fb621faaf59dbbf088ae4c064e56535cd86bb4c0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        super(IronicException, self).__init__(message)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_83bf8acf","line":88,"updated":"2016-08-15 16:57:43.000000000","message":"+1","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a40e81946e0ec9c5f651f9ba96246db9bc75b7ad","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        super(IronicException, self).__init__(message)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac969e8_77906fed","line":88,"updated":"2016-08-13 08:53:28.000000000","message":"this is not needed at all, as we\u0027re going to raise on this code path","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"8f78f419bc9ace58b9d62f5c86b946cdc409f946","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    else:"},{"line_number":86,"context_line":"                        # at least get the core message out if something"},{"line_number":87,"context_line":"                        # happened"},{"line_number":88,"context_line":"                        message \u003d self.message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        super(IronicException, self).__init__(message)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_7f1cd469","line":88,"in_reply_to":"3ac371cc_83bf8acf","updated":"2016-08-24 11:37:56.000000000","message":"Done","commit_id":"6cf9eed140e961df89674b4fcc83d4156d4b6eb7"}]}