)]}'
{"ironic_lib/tests/test_utils.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ef298276688614aa33c8568c9af6157bc68b676b","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    def test_parse_root_device_hints_invalid_size(self):"},{"line_number":307,"context_line":"        self.assertRaises(ValueError,"},{"line_number":308,"context_line":"                          utils.parse_root_device_hints, {\u0027size\u0027: \u0027not-int\u0027})"},{"line_number":309,"context_line":"        # Negative values are not valid size"},{"line_number":310,"context_line":"        self.assertRaises(ValueError,"},{"line_number":311,"context_line":"                          utils.parse_root_device_hints, {\u0027size\u0027: -123})"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_d69e7762","line":309,"updated":"2016-07-22 14:54:27.000000000","message":"How about zero?","commit_id":"96757e691f59f65054910c56246a176306482b2b"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ef298276688614aa33c8568c9af6157bc68b676b","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        self.assertRaises(ValueError,"},{"line_number":311,"context_line":"                          utils.parse_root_device_hints, {\u0027size\u0027: -123})"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _parse_root_device_hints_convert_rotatitional(self, values,"},{"line_number":314,"context_line":"                                                      expected_value):"},{"line_number":315,"context_line":"        for value in values:"},{"line_number":316,"context_line":"            result \u003d utils.parse_root_device_hints({\u0027rotational\u0027: value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f68bbb1c","line":313,"updated":"2016-07-22 14:54:27.000000000","message":"Typo: \"rotational\"","commit_id":"96757e691f59f65054910c56246a176306482b2b"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ef298276688614aa33c8568c9af6157bc68b676b","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        self._parse_root_device_hints_convert_rotatitional("},{"line_number":321,"context_line":"            (True, \u0027true\u0027, \u0027on\u0027, \u0027y\u0027, \u0027yes\u0027), True)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        self._parse_root_device_hints_convert_rotatitional("},{"line_number":324,"context_line":"            (False, \u0027false\u0027, \u0027off\u0027, \u0027n\u0027, \u0027no\u0027), False)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def test_parse_root_device_hints_invalid_rootational(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_d675d732","line":323,"updated":"2016-07-22 14:54:27.000000000","message":"Typo: \"rotational\"","commit_id":"96757e691f59f65054910c56246a176306482b2b"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ef298276688614aa33c8568c9af6157bc68b676b","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        self._parse_root_device_hints_convert_rotatitional("},{"line_number":324,"context_line":"            (False, \u0027false\u0027, \u0027off\u0027, \u0027n\u0027, \u0027no\u0027), False)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def test_parse_root_device_hints_invalid_rootational(self):"},{"line_number":327,"context_line":"        self.assertRaises(ValueError, utils.parse_root_device_hints,"},{"line_number":328,"context_line":"                          {\u0027rotational\u0027: \u0027not-bool\u0027})"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f6929b4a","line":326,"updated":"2016-07-22 14:54:27.000000000","message":"And again :-)","commit_id":"96757e691f59f65054910c56246a176306482b2b"}],"ironic_lib/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79685d989365173b7999841ec20478ad1c9d5a31","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def parse_root_device_hints(root_device):"},{"line_number":173,"context_line":"    \"\"\"Parse the root_device property of a node."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    :param root_device: the root_device dictionary from the node\u0027s property."},{"line_number":176,"context_line":"    :returns: a dictionary with the root device hints parsed or"},{"line_number":177,"context_line":"              None if there are no hints."}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dcd12dcf","line":174,"updated":"2016-07-25 15:49:01.000000000","message":"Now that we\u0027re moving this into a library, maybe we should elaborate a bit more about what this parsing does.  Eg:\n\nParses and validates the root_device property of a node. These are hints for how a node\u0027s root device is created. The \u0027size\u0027 hint should be a positive integer. The \u0027rotational\u0027 hint should be a Boolean value.\n\nOr maybe the above is too detailed. After reading the code, I don\u0027t need the description, but it would have been useful before I read the code :)","commit_id":"89ce381f36ccc820b7923f195042a4bf54962d40"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ed261e41feb8faf6b1e35ce5a937b3c463fb5ed","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def parse_root_device_hints(root_device):"},{"line_number":173,"context_line":"    \"\"\"Parse the root_device property of a node."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    :param root_device: the root_device dictionary from the node\u0027s property."},{"line_number":176,"context_line":"    :returns: a dictionary with the root device hints parsed or"},{"line_number":177,"context_line":"              None if there are no hints."}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8708feda","line":174,"in_reply_to":"dada55a8_dcd12dcf","updated":"2016-07-25 16:03:35.000000000","message":"+1\n\nI don\u0027t think it\u0027s too detailed, I agree we should improve this docstring. I will change","commit_id":"89ce381f36ccc820b7923f195042a4bf54962d40"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79685d989365173b7999841ec20478ad1c9d5a31","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                root_device[\u0027rotational\u0027], strict\u003dTrue)"},{"line_number":211,"context_line":"        except ValueError:"},{"line_number":212,"context_line":"            raise ValueError("},{"line_number":213,"context_line":"                _(\u0027Root device hint \"rotational\" is not a boolean value.\u0027))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    return root_device"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_7c3ac199","line":213,"updated":"2016-07-25 15:49:01.000000000","message":"s/boolean/Boolean/","commit_id":"89ce381f36ccc820b7923f195042a4bf54962d40"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ed261e41feb8faf6b1e35ce5a937b3c463fb5ed","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                root_device[\u0027rotational\u0027], strict\u003dTrue)"},{"line_number":211,"context_line":"        except ValueError:"},{"line_number":212,"context_line":"            raise ValueError("},{"line_number":213,"context_line":"                _(\u0027Root device hint \"rotational\" is not a boolean value.\u0027))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    return root_device"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c712f608","line":213,"in_reply_to":"dada55a8_7c3ac199","updated":"2016-07-25 16:03:35.000000000","message":"Done","commit_id":"89ce381f36ccc820b7923f195042a4bf54962d40"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79685d989365173b7999841ec20478ad1c9d5a31","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        except ValueError:"},{"line_number":212,"context_line":"            raise ValueError("},{"line_number":213,"context_line":"                _(\u0027Root device hint \"rotational\" is not a boolean value.\u0027))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    return root_device"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dc580dfd","line":214,"updated":"2016-07-25 15:49:01.000000000","message":"for all these errors, should we also output the incorrect value?","commit_id":"89ce381f36ccc820b7923f195042a4bf54962d40"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ed261e41feb8faf6b1e35ce5a937b3c463fb5ed","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        except ValueError:"},{"line_number":212,"context_line":"            raise ValueError("},{"line_number":213,"context_line":"                _(\u0027Root device hint \"rotational\" is not a boolean value.\u0027))"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    return root_device"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e7261a67","line":214,"in_reply_to":"dada55a8_dc580dfd","updated":"2016-07-25 16:03:35.000000000","message":"+1, I guess that would help on the debug.","commit_id":"89ce381f36ccc820b7923f195042a4bf54962d40"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bcaca259b9543660b23514c488ad831df89cd9eb","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        except ValueError:"},{"line_number":219,"context_line":"            raise ValueError("},{"line_number":220,"context_line":"                _(\u0027Root device hint \"rotational\" is not a Boolean value. \u0027"},{"line_number":221,"context_line":"                  \u0027Current type: %s\u0027) % type(root_device[\u0027rotational\u0027]))"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    return root_device"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_2a8f52cd","line":221,"updated":"2016-07-25 17:46:09.000000000","message":"I\u0027d rather include the value here, as it can be a string.","commit_id":"6161178738e42108aa6584dc69bd8d54c3af2f59"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f986e56b71d9fa05b3b5cf51e3ae6b132de4f32f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        except ValueError:"},{"line_number":219,"context_line":"            raise ValueError("},{"line_number":220,"context_line":"                _(\u0027Root device hint \"rotational\" is not a Boolean value. \u0027"},{"line_number":221,"context_line":"                  \u0027Current type: %s\u0027) % type(root_device[\u0027rotational\u0027]))"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    return root_device"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d1cc4f8b","line":221,"in_reply_to":"dada55a8_2a8f52cd","updated":"2016-07-26 08:51:31.000000000","message":"Will change both \"types\" to be values instead. It may be better indeed.","commit_id":"6161178738e42108aa6584dc69bd8d54c3af2f59"}]}
