)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fea9354a6724cdf61d9ee4d01d033d9167dacdc5","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                    endlimit \u003d MAX_DISK_SIZE_MB_SUPPORTED_BY_MBR - 1"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"                utils.execute(\u0027parted\u0027, \u0027-a\u0027, \u0027optimal\u0027, \u0027-s\u0027, \u0027--\u0027, device,"},{"line_number":760,"context_line":"                              \u0027mkpart\u0027, \u0027primary\u0027, \u0027vfat\u0027, startlimit,"},{"line_number":761,"context_line":"                              endlimit, run_as_root\u003dTrue)"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"            upd_parts \u003d set(part[\u0027number\u0027] for part in list_partitions(device))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_be037eb7","line":760,"updated":"2017-01-10 16:34:12.000000000","message":"apparently vfat is not a valid fstype for parted [0], you are looking at \"fat32\"\n\nhttps://www.gnu.org/software/parted/manual/html_node/mkpart.html","commit_id":"2af3a84ab7afab377c2655ba0b76d7a29976a61e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1cae7b5068658a3cce201d1a216b08e43e9c8827","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        # partition.  Create a fat filesystem on it."},{"line_number":513,"context_line":"        if boot_mode \u003d\u003d \"uefi\" and boot_option \u003d\u003d \"local\":"},{"line_number":514,"context_line":"            efi_system_part \u003d part_dict.get(\u0027efi system partition\u0027)"},{"line_number":515,"context_line":"            utils.mkfs(fs\u003d\u0027fat32\u0027, path\u003defi_system_part, label\u003d\u0027efi-part\u0027)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if configdrive_part:"},{"line_number":518,"context_line":"            # Copy the configdrive content to the configdrive partition"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_f99a80c4","line":515,"range":{"start_line":515,"start_character":23,"end_line":515,"end_character":33},"updated":"2017-01-10 16:47:03.000000000","message":"I think he it should be vfat ? Cause it\u0027s not parted, it\u0027s mkfs.\n\n(Also this is not the config drive partition but the EFI partition)","commit_id":"fc3193c19b2da634f1c52de2d65420eea7ab6fbb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5954007de405971f8554d3094f486b729c248551","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        # partition.  Create a fat filesystem on it."},{"line_number":513,"context_line":"        if boot_mode \u003d\u003d \"uefi\" and boot_option \u003d\u003d \"local\":"},{"line_number":514,"context_line":"            efi_system_part \u003d part_dict.get(\u0027efi system partition\u0027)"},{"line_number":515,"context_line":"            utils.mkfs(fs\u003d\u0027fat32\u0027, path\u003defi_system_part, label\u003d\u0027efi-part\u0027)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if configdrive_part:"},{"line_number":518,"context_line":"            # Copy the configdrive content to the configdrive partition"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_59a8ecdb","line":515,"updated":"2017-01-10 16:46:52.000000000","message":"Wondering does it have any benefit to use fat16, considering our constraints to configdrive size (64KiB if stored in DB)","commit_id":"fc3193c19b2da634f1c52de2d65420eea7ab6fbb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3dbaa426adce8a60e9a343e59cd95addddf5054f","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        # partition.  Create a fat filesystem on it."},{"line_number":513,"context_line":"        if boot_mode \u003d\u003d \"uefi\" and boot_option \u003d\u003d \"local\":"},{"line_number":514,"context_line":"            efi_system_part \u003d part_dict.get(\u0027efi system partition\u0027)"},{"line_number":515,"context_line":"            utils.mkfs(fs\u003d\u0027fat32\u0027, path\u003defi_system_part, label\u003d\u0027efi-part\u0027)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if configdrive_part:"},{"line_number":518,"context_line":"            # Copy the configdrive content to the configdrive partition"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_3999686f","line":515,"in_reply_to":"ba5201f7_59a8ecdb","updated":"2017-01-10 16:51:39.000000000","message":"Only if we wanted it readable by DOS 3.3 ;)\n\nJust kidding! The real reason we use fat32 here is that uses the \"vfat\" driver present in almost all kernels, I\u0027m less certain about the prevalence of the msdos driver used for older fat filesystems.","commit_id":"fc3193c19b2da634f1c52de2d65420eea7ab6fbb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"335576e2bcf04297b6d23747022afbdb305f3aee","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        # partition.  Create a fat filesystem on it."},{"line_number":513,"context_line":"        if boot_mode \u003d\u003d \"uefi\" and boot_option \u003d\u003d \"local\":"},{"line_number":514,"context_line":"            efi_system_part \u003d part_dict.get(\u0027efi system partition\u0027)"},{"line_number":515,"context_line":"            utils.mkfs(fs\u003d\u0027fat32\u0027, path\u003defi_system_part, label\u003d\u0027efi-part\u0027)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if configdrive_part:"},{"line_number":518,"context_line":"            # Copy the configdrive content to the configdrive partition"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_b91ab815","line":515,"range":{"start_line":515,"start_character":23,"end_line":515,"end_character":33},"in_reply_to":"ba5201f7_f99a80c4","updated":"2017-01-10 16:50:10.000000000","message":"Oh, right, my question refers to L760 then :)","commit_id":"fc3193c19b2da634f1c52de2d65420eea7ab6fbb"}]}