)]}'
{"ironic_lib/utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee242acabd1b30d759388ae4f4eb557d905110f4","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                {\u0027attr\u0027: hint, \u0027value\u0027: device_value,"},{"line_number":391,"context_line":"                                 \u0027dev\u0027: dev})"},{"line_number":392,"context_line":"                    break"},{"line_number":393,"context_line":"                if device_value \u003d\u003d hint_value:"},{"line_number":394,"context_line":"                    continue"},{"line_number":395,"context_line":"                break"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_c3e9371c","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":28},"updated":"2017-03-08 15:00:24.000000000","message":"I guess you have to move this bit down or move your logging up, otherwise it won\u0027t catch boolean values","commit_id":"c68252c5c2a5fdada3d2fb0110e1fe635a44275e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"32e43a575bf82970a236e3e808b7f86c25bad2bc","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                {\u0027attr\u0027: hint, \u0027value\u0027: device_value,"},{"line_number":391,"context_line":"                                 \u0027dev\u0027: dev})"},{"line_number":392,"context_line":"                    break"},{"line_number":393,"context_line":"                if device_value \u003d\u003d hint_value:"},{"line_number":394,"context_line":"                    continue"},{"line_number":395,"context_line":"                break"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_3eb14690","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":28},"in_reply_to":"9a30ddce_c3e9371c","updated":"2017-03-08 15:37:14.000000000","message":"True that!","commit_id":"c68252c5c2a5fdada3d2fb0110e1fe635a44275e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ee242acabd1b30d759388ae4f4eb557d905110f4","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" with \u0027"},{"line_number":403,"context_line":"                      \u0027a value of \"%(hint_value)s\" against the device %(dev)s \u0027"},{"line_number":404,"context_line":"                      \u0027attribute \"%(hint)s\" with a value of \"%(dev_value)s\"\u0027,"},{"line_number":405,"context_line":"                      {\u0027hint\u0027: hint, \u0027dev\u0027: dev, \u0027hint_value\u0027: hint_value,"},{"line_number":406,"context_line":"                       \u0027dev_value\u0027: device_value})"},{"line_number":407,"context_line":"            if not specs_matcher.match(device_value, hint_value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_63924ba1","line":404,"range":{"start_line":404,"start_character":34,"end_line":404,"end_character":44},"updated":"2017-03-08 15:00:24.000000000","message":"you can safely skip this one, you already have it logged above","commit_id":"c68252c5c2a5fdada3d2fb0110e1fe635a44275e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"32e43a575bf82970a236e3e808b7f86c25bad2bc","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" with \u0027"},{"line_number":403,"context_line":"                      \u0027a value of \"%(hint_value)s\" against the device %(dev)s \u0027"},{"line_number":404,"context_line":"                      \u0027attribute \"%(hint)s\" with a value of \"%(dev_value)s\"\u0027,"},{"line_number":405,"context_line":"                      {\u0027hint\u0027: hint, \u0027dev\u0027: dev, \u0027hint_value\u0027: hint_value,"},{"line_number":406,"context_line":"                       \u0027dev_value\u0027: device_value})"},{"line_number":407,"context_line":"            if not specs_matcher.match(device_value, hint_value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_feb6ce88","line":404,"range":{"start_line":404,"start_character":34,"end_line":404,"end_character":44},"in_reply_to":"9a30ddce_63924ba1","updated":"2017-03-08 15:37:14.000000000","message":"Right, yeah because we current use the same name for the hints and the device\u0027s attribute. But yeah I will word it differently","commit_id":"c68252c5c2a5fdada3d2fb0110e1fe635a44275e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14454209b2aecf00e48d1b69a256f8356076c79","unresolved":false,"context_lines":[{"line_number":33,"context_line":"import six"},{"line_number":34,"context_line":"from six.moves.urllib import parse"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from ironic_lib.common.i18n import _"},{"line_number":37,"context_line":"from ironic_lib.common.i18n import _LE"},{"line_number":38,"context_line":"from ironic_lib.common.i18n import _LI"},{"line_number":39,"context_line":"from ironic_lib.common.i18n import _LW"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_2bd2c15c","line":36,"updated":"2017-03-09 13:39:33.000000000","message":"nit: may combine 4 line import into single line that is comma separated","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f737685845261e6ca1981c5578523a1ca561e316","unresolved":false,"context_lines":[{"line_number":33,"context_line":"import six"},{"line_number":34,"context_line":"from six.moves.urllib import parse"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from ironic_lib.common.i18n import _"},{"line_number":37,"context_line":"from ironic_lib.common.i18n import _LE"},{"line_number":38,"context_line":"from ironic_lib.common.i18n import _LI"},{"line_number":39,"context_line":"from ironic_lib.common.i18n import _LW"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_a8bdc0b8","line":36,"in_reply_to":"9a30ddce_2bd2c15c","updated":"2017-03-09 21:29:54.000000000","message":"True that, if I happen to submit a new patch-set I\u0027ll change it. \n\nThanks","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"58112413398788f682a0c04a3899c82d4ba565e7","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"},{"line_number":384,"context_line":"                # Since we don\u0027t support units yet we expect the size"},{"line_number":385,"context_line":"                # in GiB for now"},{"line_number":386,"context_line":"                device_value \u003d device_value / units.Gi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" \u0027"},{"line_number":389,"context_line":"                      \u0027with a value of \"%(hint_value)s\" against the same \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_578cdd7e","line":386,"range":{"start_line":386,"start_character":31,"end_line":386,"end_character":43},"updated":"2017-03-09 22:53:27.000000000","message":"This should be float(device_value) / units.Gi\n\nor else you get:\n\n\u003e\u003e\u003e 1273741824 / (1024 ** 3)\n1\n\ninstead of:\n\n\u003e\u003e\u003e float(1273741824) / (1024 ** 3)\n1.1862645149230957\n\nMaybe trim the output to 2 significant digits or so also.","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"35e138b756e952d7ea165fd364b6674273ffb3f5","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"},{"line_number":384,"context_line":"                # Since we don\u0027t support units yet we expect the size"},{"line_number":385,"context_line":"                # in GiB for now"},{"line_number":386,"context_line":"                device_value \u003d device_value / units.Gi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" \u0027"},{"line_number":389,"context_line":"                      \u0027with a value of \"%(hint_value)s\" against the same \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_dfed2db8","line":386,"updated":"2017-03-10 12:32:39.000000000","message":"actually, this code should be changed to device_value // units.Gi, otherwise it behaves differently on Python 3. But let\u0027s do it in a separate patch.","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a0657fb476f3327ff61f4536636addcbcdfd4099","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"},{"line_number":384,"context_line":"                # Since we don\u0027t support units yet we expect the size"},{"line_number":385,"context_line":"                # in GiB for now"},{"line_number":386,"context_line":"                device_value \u003d device_value / units.Gi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" \u0027"},{"line_number":389,"context_line":"                      \u0027with a value of \"%(hint_value)s\" against the same \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_f7607103","line":386,"range":{"start_line":386,"start_character":31,"end_line":386,"end_character":43},"in_reply_to":"9a30ddce_578cdd7e","updated":"2017-03-09 23:16:10.000000000","message":"I\u0027ve just moved this bit up from L397, so I can log the converted value (before it compares).\n\nBut in any case, the current code seems correct because we will try to match the hint with the input from the user, so it\u0027s easier for the user to match a disk that has an integer as size (1, 25, 500, etc..) GiB instead of a float.","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0f2c83f8c59e346a8cf93f3c2095c811e8b51c87","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"},{"line_number":384,"context_line":"                # Since we don\u0027t support units yet we expect the size"},{"line_number":385,"context_line":"                # in GiB for now"},{"line_number":386,"context_line":"                device_value \u003d device_value / units.Gi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" \u0027"},{"line_number":389,"context_line":"                      \u0027with a value of \"%(hint_value)s\" against the same \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_d3d44121","line":386,"in_reply_to":"9a30ddce_dfed2db8","updated":"2017-03-10 15:36:29.000000000","message":"That\u0027s true, yeah it seems unrelated to improving the logs. So I will push a new patch for it.","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0b12fd78930eeef683ce4e3d7ddcd4c7d9e2190a","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            if hint \u003d\u003d \u0027size\u0027:"},{"line_number":384,"context_line":"                # Since we don\u0027t support units yet we expect the size"},{"line_number":385,"context_line":"                # in GiB for now"},{"line_number":386,"context_line":"                device_value \u003d device_value / units.Gi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            LOG.debug(\u0027Trying to match the root device hint \"%(hint)s\" \u0027"},{"line_number":389,"context_line":"                      \u0027with a value of \"%(hint_value)s\" against the same \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_f97a11f0","line":386,"range":{"start_line":386,"start_character":31,"end_line":386,"end_character":43},"in_reply_to":"9a30ddce_f7607103","updated":"2017-03-10 11:47:00.000000000","message":"I agree with Lucas. As we pass the hint value as ints.","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"afd46216386d11f7c320b33f52e14801f5926fed","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            # ourselves"},{"line_number":398,"context_line":"            if hint_type is bool:"},{"line_number":399,"context_line":"                try:"},{"line_number":400,"context_line":"                    device_value \u003d strutils.bool_from_string(device_value,"},{"line_number":401,"context_line":"                                                             strict\u003dTrue)"},{"line_number":402,"context_line":"                except ValueError:"},{"line_number":403,"context_line":"                    LOG.warning(_LW(\u0027The attribute \"%(attr)s\" (with value \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a1ff146_b4cada9f","line":400,"updated":"2017-03-15 14:47:10.000000000","message":"This is a dumb question (since this has already merged), but in this case, there is no need to check if device_value is in GiB? (if hint \u003d\u003d size, hint_type won\u0027t be bool?)","commit_id":"352dd8b4dcc30827f738fe3dce1ee0346a904bf8"}]}