)]}'
{"ironic_lib/tests/hacking/mock_checks.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08cd4ba861be97d6eadfb3cb0bcd26a25b903e79","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, autospec\u003dFalse)"},{"line_number":24,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, autospec\u003dNone)"},{"line_number":25,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, defined_mock)"},{"line_number":26,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, new\u003ddefined_mock)"},{"line_number":27,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, new_callable\u003dSomeFunc)"},{"line_number":28,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, spec\u003d1000)"},{"line_number":29,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, spec_set\u003d[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_fd114355","line":26,"updated":"2017-05-17 11:28:23.000000000","message":"should also be Okay:\n\n mock.patch(\u0027target_module_1\u0027, defined_mock)\n\n(i.e. without explicit new\u003d)","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c0486eb0c11cc7bd429dcf59f29ffe3935ef4522","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, autospec\u003dFalse)"},{"line_number":24,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, autospec\u003dNone)"},{"line_number":25,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, defined_mock)"},{"line_number":26,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, new\u003ddefined_mock)"},{"line_number":27,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, new_callable\u003dSomeFunc)"},{"line_number":28,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, spec\u003d1000)"},{"line_number":29,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, spec_set\u003d[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_e6507ed7","line":26,"in_reply_to":"ff0f0b1f_fd114355","updated":"2017-06-20 22:39:06.000000000","message":"Done","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08cd4ba861be97d6eadfb3cb0bcd26a25b903e79","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, spec_set\u003d[\u0027data\u0027])"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    H210: mock.patch(\u0027target_module_1\u0027)"},{"line_number":32,"context_line":"    H210: mock.patch(\u0027target_module_1\u0027)"},{"line_number":33,"context_line":"    H210: mock.patch(\u0027target_module_1\u0027, somearg\u003d23)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_dd0e7f31","line":32,"updated":"2017-05-17 11:28:23.000000000","message":"there 2 lines are the same","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c0486eb0c11cc7bd429dcf59f29ffe3935ef4522","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    Okay: mock.patch(\u0027target_module_1\u0027, spec_set\u003d[\u0027data\u0027])"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    H210: mock.patch(\u0027target_module_1\u0027)"},{"line_number":32,"context_line":"    H210: mock.patch(\u0027target_module_1\u0027)"},{"line_number":33,"context_line":"    H210: mock.patch(\u0027target_module_1\u0027, somearg\u003d23)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_a664c6ba","line":32,"in_reply_to":"ff0f0b1f_dd0e7f31","updated":"2017-06-20 22:39:06.000000000","message":"Done","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08cd4ba861be97d6eadfb3cb0bcd26a25b903e79","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, autospec\u003dTrue)"},{"line_number":37,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, autospec\u003dFalse)"},{"line_number":38,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, autospec\u003dNone)"},{"line_number":39,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, new\u003ddefined_mock)"},{"line_number":40,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, new_callable\u003dSomeFunc)"},{"line_number":41,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec\u003d3)"},{"line_number":42,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec_set\u003d[3])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_bd1bcb71","line":39,"updated":"2017-05-17 11:28:23.000000000","message":"first, all invokations of mock.patch.object require the \u0027attribute\u0027 argument IIRC.\n\nsecond, this should also be Okay:\n\n mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, defined_mock)\n\n(i.e. the same as this, but without explicit new\u003d)","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c0486eb0c11cc7bd429dcf59f29ffe3935ef4522","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, autospec\u003dTrue)"},{"line_number":37,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, autospec\u003dFalse)"},{"line_number":38,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, autospec\u003dNone)"},{"line_number":39,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, new\u003ddefined_mock)"},{"line_number":40,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, new_callable\u003dSomeFunc)"},{"line_number":41,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec\u003d3)"},{"line_number":42,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec_set\u003d[3])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_8659caff","line":39,"in_reply_to":"ff0f0b1f_bd1bcb71","updated":"2017-06-20 22:39:06.000000000","message":"Done","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08cd4ba861be97d6eadfb3cb0bcd26a25b903e79","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec\u003d3)"},{"line_number":42,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec_set\u003d[3])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    H210: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, somearg\u003d2)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_9d180776","line":44,"updated":"2017-05-17 11:28:23.000000000","message":"also H210:\n\n mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027)","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c0486eb0c11cc7bd429dcf59f29ffe3935ef4522","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec\u003d3)"},{"line_number":42,"context_line":"    Okay: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, spec_set\u003d[3])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    H210: mock.patch.object(\u0027target_module_2\u0027, \u0027attribute\u0027, somearg\u003d2)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_4673b281","line":44,"in_reply_to":"ff0f0b1f_9d180776","updated":"2017-06-20 22:39:06.000000000","message":"Done","commit_id":"73a142e57bd820dfde1c1df7d61f3762d10ccf58"}]}