)]}'
{"ironic_lib/tests/test_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8f18cc6315483c169a5b99cc1a2a32b20311f3b2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            fp.close()"},{"line_number":128,"context_line":"            os.chmod(tmpfilename, 0o755)"},{"line_number":129,"context_line":"            try:"},{"line_number":130,"context_line":"                utils.execute(tmpfilename,"},{"line_number":131,"context_line":"                              tmpfilename2,"},{"line_number":132,"context_line":"                              process_input\u003db\u0027foo\u0027,"},{"line_number":133,"context_line":"                              attempts\u003d2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_707751d6","side":"PARENT","line":130,"updated":"2017-05-16 18:51:39.000000000","message":"just to be sure cuz i don\u0027t want to go through this in detail. if we replaced this call with processutils.execute(), we\u0027d be testing the same stuff?\n\nThere isn\u0027t anything here that is testing utils.execute() wrapper code?","commit_id":"87c196d670e5cebe355ac74a7ea7ba319cbfc4bb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3fcff9ef954ba453d06c55fec874d95a399d64cd","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            fp.close()"},{"line_number":128,"context_line":"            os.chmod(tmpfilename, 0o755)"},{"line_number":129,"context_line":"            try:"},{"line_number":130,"context_line":"                utils.execute(tmpfilename,"},{"line_number":131,"context_line":"                              tmpfilename2,"},{"line_number":132,"context_line":"                              process_input\u003db\u0027foo\u0027,"},{"line_number":133,"context_line":"                              attempts\u003d2)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_66dd5b6f","side":"PARENT","line":130,"in_reply_to":"1f013ff3_707751d6","updated":"2017-05-16 19:50:03.000000000","message":"Correct. The retry logic is done in processutils.execute(). Not in utils.execute()","commit_id":"87c196d670e5cebe355ac74a7ea7ba319cbfc4bb"}]}