)]}'
{"ironic_lib/disk_partitioner.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6e85696f39e5e2069ecdcf85f4276651068068be","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        fat16, HFS, linux-swap, NTFS, reiserfs, ufs."},{"line_number":85,"context_line":"                        If blank (\u0027\u0027), it will create a Linux native"},{"line_number":86,"context_line":"                        partition (83)."},{"line_number":87,"context_line":"        :param boot_flags: Boot flags that needs to be configured on the"},{"line_number":88,"context_line":"                           partition. Ignored if None. It can take values"},{"line_number":89,"context_line":"                           \u0027bios_grub\u0027, \u0027boot\u0027, and \u0027prep\u0027."},{"line_number":90,"context_line":"        :returns: The partition number."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_233be9c8","line":87,"updated":"2018-06-04 13:52:42.000000000","message":"This would be a breaking change. Would it make sense to make this a bool as a separate value?","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"0dfebd1fe2e01c9172fe3759a986f26ce23e3097","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        fat16, HFS, linux-swap, NTFS, reiserfs, ufs."},{"line_number":85,"context_line":"                        If blank (\u0027\u0027), it will create a Linux native"},{"line_number":86,"context_line":"                        partition (83)."},{"line_number":87,"context_line":"        :param boot_flags: Boot flags that needs to be configured on the"},{"line_number":88,"context_line":"                           partition. Ignored if None. It can take values"},{"line_number":89,"context_line":"                           \u0027bios_grub\u0027, \u0027boot\u0027, and \u0027prep\u0027."},{"line_number":90,"context_line":"        :returns: The partition number."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6de5f437","line":87,"in_reply_to":"5f7c97a3_19316fa3","updated":"2018-06-07 15:56:48.000000000","message":"Done","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"e136ec3911440c8029d62ab4729b73e18ea14632","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        fat16, HFS, linux-swap, NTFS, reiserfs, ufs."},{"line_number":85,"context_line":"                        If blank (\u0027\u0027), it will create a Linux native"},{"line_number":86,"context_line":"                        partition (83)."},{"line_number":87,"context_line":"        :param boot_flags: Boot flags that needs to be configured on the"},{"line_number":88,"context_line":"                           partition. Ignored if None. It can take values"},{"line_number":89,"context_line":"                           \u0027bios_grub\u0027, \u0027boot\u0027, and \u0027prep\u0027."},{"line_number":90,"context_line":"        :returns: The partition number."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_632a412d","line":87,"in_reply_to":"5f7c97a3_233be9c8","updated":"2018-06-04 15:24:42.000000000","message":"yep that would work! I\u0027ll do that in the next rev but could we also consider something more extensible?\n\nMaybe adding something like an extra_flags entry?\n\nThis would allow current consumers of ironic-lib to keep using their existing calls to the function but would account for any future need for multiple flags on the partition.\n\nCould be missing something, but food for thought.","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"caf345e216e9752cb2c461b17de8671b4d1c48e8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        fat16, HFS, linux-swap, NTFS, reiserfs, ufs."},{"line_number":85,"context_line":"                        If blank (\u0027\u0027), it will create a Linux native"},{"line_number":86,"context_line":"                        partition (83)."},{"line_number":87,"context_line":"        :param boot_flags: Boot flags that needs to be configured on the"},{"line_number":88,"context_line":"                           partition. Ignored if None. It can take values"},{"line_number":89,"context_line":"                           \u0027bios_grub\u0027, \u0027boot\u0027, and \u0027prep\u0027."},{"line_number":90,"context_line":"        :returns: The partition number."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_19316fa3","line":87,"in_reply_to":"5f7c97a3_632a412d","updated":"2018-06-05 07:38:48.000000000","message":"I like the extra_flags setting idea!","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6e85696f39e5e2069ecdcf85f4276651068068be","unresolved":false,"context_lines":[{"line_number":172,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":173,"context_line":"                    configdrive_mb, node_uuid, commit\u003dTrue,"},{"line_number":174,"context_line":"                    boot_option\u003d\"netboot\", boot_mode\u003d\"bios\","},{"line_number":175,"context_line":"                    cpu_arch\u003dNone, disk_label\u003dNone):"},{"line_number":176,"context_line":"    \"\"\"Partition the disk device."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    Create partitions for root, swap, ephemeral and configdrive on a"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a3eb7910","line":175,"range":{"start_line":175,"start_character":20,"end_line":175,"end_character":34},"updated":"2018-06-04 13:52:42.000000000","message":"to be on the safe side, we should add this to the end of as it can be referenced as a positional field. method(\u0027/dev/a\u0027, 100, 0, True, \u0027magical_cpu_mk1\u0027, \u0027magical_disk_label\u0027) would work, but removing the cpu flag would be result in the caller being broken.","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"e136ec3911440c8029d62ab4729b73e18ea14632","unresolved":false,"context_lines":[{"line_number":172,"context_line":"def make_partitions(dev, root_mb, swap_mb, ephemeral_mb,"},{"line_number":173,"context_line":"                    configdrive_mb, node_uuid, commit\u003dTrue,"},{"line_number":174,"context_line":"                    boot_option\u003d\"netboot\", boot_mode\u003d\"bios\","},{"line_number":175,"context_line":"                    cpu_arch\u003dNone, disk_label\u003dNone):"},{"line_number":176,"context_line":"    \"\"\"Partition the disk device."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    Create partitions for root, swap, ephemeral and configdrive on a"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_23ca096e","line":175,"range":{"start_line":175,"start_character":20,"end_line":175,"end_character":34},"in_reply_to":"5f7c97a3_a3eb7910","updated":"2018-06-04 15:24:42.000000000","message":"very good point. Fixing in next rev","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6e85696f39e5e2069ecdcf85f4276651068068be","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    Create partitions for root, swap, ephemeral and configdrive on a"},{"line_number":179,"context_line":"    disk device."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    :param dev: Path for the device to work on."},{"line_number":182,"context_line":"    :param root_mb: Size of the root partition in mebibytes (MiB)."},{"line_number":183,"context_line":"    :param swap_mb: Size of the swap partition in mebibytes (MiB). If 0,"},{"line_number":184,"context_line":"        no partition will be created."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_43a2a5fe","line":181,"updated":"2018-06-04 13:52:42.000000000","message":"Thanks!","commit_id":"aefbacdb7d98d518a2abba0fc23a5178f286f893"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4bcc1ef82d19ce392c99a54d616f48c91ca68a32","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        Ironic will figure it out according to the boot_mode parameter."},{"line_number":197,"context_line":"    :param cpu_arch: Architecture of the node the disk device belongs to."},{"line_number":198,"context_line":"        When using the default value of None, no architecture specific"},{"line_number":199,"context_line":"        steps will be taken."},{"line_number":200,"context_line":"    :returns: A dictionary containing the partition type as Key and partition"},{"line_number":201,"context_line":"        path as Value for the partitions created by this method."},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1992cf4c","line":199,"updated":"2018-06-05 07:45:24.000000000","message":"This feels super nitty, but we might want to explicitly state that the patterns taken were x86*, and ppc64* is supported as well.","commit_id":"b614c51a4e8aa23b4a1a9f3fbd62649aca0f0fac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"15584ae8a922203e6969a42b7a1a330e941fd9a4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        partition image locally."},{"line_number":202,"context_line":"    :returns: A dictionary containing the partition type as Key and partition"},{"line_number":203,"context_line":"        path as Value for the partitions created by this method."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    \"\"\""},{"line_number":206,"context_line":"    LOG.debug(\"Starting to partition the disk device: %(dev)s \""},{"line_number":207,"context_line":"              \"for node %(node)s\","}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_9a584df9","line":204,"updated":"2018-06-26 13:57:19.000000000","message":"It looks like the tests are tossing a error on this, likely a sphinx issue. We may end up fixing this to fix the gate, or it could be fixed here. only time will tell.","commit_id":"0e11a10f92fc0051bd8b449115c4a3cfc2a4cc6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"15584ae8a922203e6969a42b7a1a330e941fd9a4","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                    boot_flag\u003d\u0027boot\u0027)"},{"line_number":234,"context_line":"        part_dict[\u0027efi system partition\u0027] \u003d part_template % part_num"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    if (boot_mode \u003d\u003d \"bios\" and boot_option \u003d\u003d \"local\" and disk_label \u003d\u003d \"gpt\" and"},{"line_number":237,"context_line":"        not cpu_arch.startswith(\u0027ppc64\u0027)):"},{"line_number":238,"context_line":"        part_num \u003d dp.add_partition(CONF.disk_utils.bios_boot_partition_size,"},{"line_number":239,"context_line":"                                    boot_flag\u003d\u0027bios_grub\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_fa4f0132","line":236,"range":{"start_line":236,"start_character":79,"end_line":236,"end_character":82},"updated":"2018-06-26 13:57:19.000000000","message":"Lets wrap the and to the next line.","commit_id":"0e11a10f92fc0051bd8b449115c4a3cfc2a4cc6e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"2bfa3b7bec53fafdde188e979975aea679b1d43d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                    boot_flag\u003d\u0027boot\u0027)"},{"line_number":234,"context_line":"        part_dict[\u0027efi system partition\u0027] \u003d part_template % part_num"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    if (boot_mode \u003d\u003d \"bios\" and boot_option \u003d\u003d \"local\" and disk_label \u003d\u003d \"gpt\" and"},{"line_number":237,"context_line":"        not cpu_arch.startswith(\u0027ppc64\u0027)):"},{"line_number":238,"context_line":"        part_num \u003d dp.add_partition(CONF.disk_utils.bios_boot_partition_size,"},{"line_number":239,"context_line":"                                    boot_flag\u003d\u0027bios_grub\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_15e2b4d5","line":236,"range":{"start_line":236,"start_character":79,"end_line":236,"end_character":82},"in_reply_to":"5f7c97a3_fa4f0132","updated":"2018-06-28 13:44:26.000000000","message":"Done.","commit_id":"0e11a10f92fc0051bd8b449115c4a3cfc2a4cc6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"15584ae8a922203e6969a42b7a1a330e941fd9a4","unresolved":false,"context_lines":[{"line_number":278,"context_line":"              \"for node %(node)s\","},{"line_number":279,"context_line":"              {\u0027dev\u0027: dev, \u0027size\u0027: root_mb, \u0027node\u0027: node_uuid})"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    boot_val \u003d \u0027boot\u0027 if (not cpu_arch.startswith(\"ppc64\") and boot_mode \u003d\u003d \"bios\" and"},{"line_number":282,"context_line":"                          boot_option \u003d\u003d \"local\" and disk_label \u003d\u003d \"msdos\") else None"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    part_num \u003d dp.add_partition(root_mb, boot_flag\u003dboot_val)"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_3a4a5926","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":85},"updated":"2018-06-26 13:57:19.000000000","message":"Perhaps ?\n\n    boot_val \u003d \u0027boot\u0027 if (not cpu_arch.startswith(\"ppc64\") \n                          and boot_mode \u003d\u003d \"bios\"\n                          and boot_option \u003d\u003d \"local\"\n                          and disk_label \u003d\u003d \"msdos\") else None\n\nThat seems like it should wrap as needed?","commit_id":"0e11a10f92fc0051bd8b449115c4a3cfc2a4cc6e"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"2bfa3b7bec53fafdde188e979975aea679b1d43d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"              \"for node %(node)s\","},{"line_number":279,"context_line":"              {\u0027dev\u0027: dev, \u0027size\u0027: root_mb, \u0027node\u0027: node_uuid})"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    boot_val \u003d \u0027boot\u0027 if (not cpu_arch.startswith(\"ppc64\") and boot_mode \u003d\u003d \"bios\" and"},{"line_number":282,"context_line":"                          boot_option \u003d\u003d \"local\" and disk_label \u003d\u003d \"msdos\") else None"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    part_num \u003d dp.add_partition(root_mb, boot_flag\u003dboot_val)"},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_55d82c23","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":85},"in_reply_to":"5f7c97a3_3a4a5926","updated":"2018-06-28 13:44:26.000000000","message":"Yeah this is way more readable. Done!","commit_id":"0e11a10f92fc0051bd8b449115c4a3cfc2a4cc6e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194304a016b5288c0ef943603be1681935ee70b6","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    if cpu_arch.startswith(\u0027ppc\u0027):"},{"line_number":605,"context_line":"        uuids_to_return[\u0027PReP Boot partition uuid\u0027] \u003d part_dict.get(\u0027PReP Boot partition\u0027)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    try:"},{"line_number":608,"context_line":"        for part, part_dev in uuids_to_return.items():"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_9fbebffe","line":605,"range":{"start_line":605,"start_character":79,"end_line":605,"end_character":80},"updated":"2018-06-28 16:19:47.000000000","message":"This needs to be wrapped\n\nThis might work?  If all else fails noqa it I guess.\n    if cpu_arch.startswith(\u0027ppc\u0027):\n        uuids_to_return[\n            \u0027PReP Boot partition uuid\u0027\n        ] \u003d part_dict.get(\u0027PReP Boot partition\u0027)","commit_id":"680d6ae74c3ec6e7463c9e71d46a839b81b58397"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"b91413cf4d0fcb310e44830e1e25c2799d35274a","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    if cpu_arch.startswith(\u0027ppc\u0027):"},{"line_number":605,"context_line":"        uuids_to_return[\u0027PReP Boot partition uuid\u0027] \u003d part_dict.get(\u0027PReP Boot partition\u0027)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    try:"},{"line_number":608,"context_line":"        for part, part_dev in uuids_to_return.items():"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_421dacbc","line":605,"range":{"start_line":605,"start_character":79,"end_line":605,"end_character":80},"in_reply_to":"5f7c97a3_9fbebffe","updated":"2018-06-28 17:15:02.000000000","message":"Done","commit_id":"680d6ae74c3ec6e7463c9e71d46a839b81b58397"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4010aa7c0e58bbd004a43fed52c56e727d0388d8","unresolved":false,"context_lines":[{"line_number":498,"context_line":"    :param boot_option: Can be \"local\" or \"netboot\". \"netboot\" by default."},{"line_number":499,"context_line":"    :param boot_mode: Can be \"bios\" or \"uefi\". \"bios\" by default."},{"line_number":500,"context_line":"    :param tempdir: A temporary directory"},{"line_number":501,"context_line":"    param disk_label: The disk label to be used when creating the"},{"line_number":502,"context_line":"        partition table. Valid values are: \"msdos\", \"gpt\" or None; If None"},{"line_number":503,"context_line":"        Ironic will figure it out according to the boot_mode parameter."},{"line_number":504,"context_line":"    :param cpu_arch: Architecture of the node the disk device belongs to."}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_c7e2ee02","line":501,"range":{"start_line":501,"start_character":4,"end_line":501,"end_character":5},"updated":"2018-07-15 13:27:40.000000000","message":"Missing :","commit_id":"1672b7dedddc87b5a345389c677ab4b5e838ba88"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4010aa7c0e58bbd004a43fed52c56e727d0388d8","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        \u0027efi system partition uuid\u0027: UUID of the uefi system partition"},{"line_number":512,"context_line":"        (if boot mode is uefi)."},{"line_number":513,"context_line":"        NOTE: If key exists but value is None, it means partition doesn\u0027t"},{"line_number":514,"context_line":"        exist."},{"line_number":515,"context_line":"    \"\"\""},{"line_number":516,"context_line":"    # the only way for preserve_ephemeral to be set to true is if we are"},{"line_number":517,"context_line":"    # rebuilding an instance with --preserve_ephemeral."}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_a7e7b20f","line":514,"updated":"2018-07-15 13:27:40.000000000","message":"2018-06-28 18:26:30.127968 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/ironic-lib/ironic_lib/disk_utils.py:docstring of ironic_lib.disk_utils.work_on_disk:20:Field list ends without a blank line; unexpected unindent.\n2018-06-28 18:26:30.608822 | ubuntu-xenial | ERROR\n\nSee line 501. :)","commit_id":"1672b7dedddc87b5a345389c677ab4b5e838ba88"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"900e7874a6e6baa56eb923cf2bf47cb43605e8f8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                                    boot_flag\u003d\u0027bios_grub\u0027)"},{"line_number":240,"context_line":"        part_dict[\u0027BIOS Boot partition\u0027] \u003d part_template % part_num"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    # NOTE(mjturek): With ppc64* nodes, partition images are expected to have"},{"line_number":243,"context_line":"    # a PrEP partition at the start of the disk. This is an 8 MiB partition"},{"line_number":244,"context_line":"    # with the boot and prep flags set. The bootloader should be installed"},{"line_number":245,"context_line":"    # here."}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_db82b4ff","line":242,"range":{"start_line":242,"start_character":39,"end_line":242,"end_character":57},"updated":"2018-07-16 17:39:22.000000000","message":"just partition? not whole disk? This is slightly confusing, but I think I understand.","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"527203a13d7ab7a3cb9fa186639fb0f29a0b42ed","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                                    boot_flag\u003d\u0027bios_grub\u0027)"},{"line_number":240,"context_line":"        part_dict[\u0027BIOS Boot partition\u0027] \u003d part_template % part_num"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    # NOTE(mjturek): With ppc64* nodes, partition images are expected to have"},{"line_number":243,"context_line":"    # a PrEP partition at the start of the disk. This is an 8 MiB partition"},{"line_number":244,"context_line":"    # with the boot and prep flags set. The bootloader should be installed"},{"line_number":245,"context_line":"    # here."}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0bb8d10f","line":242,"range":{"start_line":242,"start_character":39,"end_line":242,"end_character":57},"in_reply_to":"5f7c97a3_db82b4ff","updated":"2018-07-17 00:30:15.000000000","message":"I think Mike means when ironic is given a single partition image ironic is responsible for creating the prep partition.  IN the case it\u0027s given a whole disk image the image itself will (well should) contain the prep partition so nothing additional is needed.","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"900e7874a6e6baa56eb923cf2bf47cb43605e8f8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    # here."},{"line_number":246,"context_line":"    if (cpu_arch.startswith(\"ppc64\") and boot_mode \u003d\u003d \"bios\" and"},{"line_number":247,"context_line":"        boot_option \u003d\u003d \"local\"):"},{"line_number":248,"context_line":"        LOG.debug(\"Add PReP boot partition (8 MB) to device: \""},{"line_number":249,"context_line":"                  \"%(dev)s for node %(node)s\","},{"line_number":250,"context_line":"                  {\u0027dev\u0027: dev, \u0027node\u0027: node_uuid})"},{"line_number":251,"context_line":"        boot_flag \u003d \u0027boot\u0027 if disk_label \u003d\u003d \u0027msdos\u0027 else None"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_bb949837","line":248,"range":{"start_line":248,"start_character":19,"end_line":248,"end_character":22},"updated":"2018-07-16 17:39:22.000000000","message":"nit: s/Add/Adding/ ?","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"900e7874a6e6baa56eb923cf2bf47cb43605e8f8","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        When using the default value of None, no architecture specific"},{"line_number":506,"context_line":"        steps will be taken. This default should be used for x86_64. When"},{"line_number":507,"context_line":"        set to ppc64*, architecture specific steps are taken for booting a"},{"line_number":508,"context_line":"        partition image locally."},{"line_number":509,"context_line":"    :returns: a dictionary containing the following keys:"},{"line_number":510,"context_line":"        \u0027root uuid\u0027: UUID of root partition"},{"line_number":511,"context_line":"        \u0027efi system partition uuid\u0027: UUID of the uefi system partition"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_dbb074df","line":508,"updated":"2018-07-16 17:39:22.000000000","message":"Aside: so reading this, I assume there is nothing that needs to happen for whole disk images as hey would already have a PrEP partition.","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"527203a13d7ab7a3cb9fa186639fb0f29a0b42ed","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        When using the default value of None, no architecture specific"},{"line_number":506,"context_line":"        steps will be taken. This default should be used for x86_64. When"},{"line_number":507,"context_line":"        set to ppc64*, architecture specific steps are taken for booting a"},{"line_number":508,"context_line":"        partition image locally."},{"line_number":509,"context_line":"    :returns: a dictionary containing the following keys:"},{"line_number":510,"context_line":"        \u0027root uuid\u0027: UUID of root partition"},{"line_number":511,"context_line":"        \u0027efi system partition uuid\u0027: UUID of the uefi system partition"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_cb33b9c3","line":508,"in_reply_to":"5f7c97a3_dbb074df","updated":"2018-07-17 00:30:15.000000000","message":"Correct.  That\u0027s how we\u0027re working today.  Just give ironic a whole disk image and it\u0027s winning all round :)","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f378f1d536f6915386d37e133d0d512bc5025eb9","unresolved":false,"context_lines":[{"line_number":554,"context_line":"            part_device \u003d part_dict.get(part)"},{"line_number":555,"context_line":"            LOG.debug(\"Checking for %(part)s device (%(dev)s) on node \""},{"line_number":556,"context_line":"                      \"%(node)s.\", {\u0027part\u0027: part, \u0027dev\u0027: part_device,"},{"line_number":557,"context_line":"                                    \u0027node\u0027: node_uuid})"},{"line_number":558,"context_line":"            if part_device and not is_block_device(part_device):"},{"line_number":559,"context_line":"                raise exception.InstanceDeployFailure("},{"line_number":560,"context_line":"                    _(\"\u0027%(partition)s\u0027 device \u0027%(part_device)s\u0027 not found\") %"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_e79d816c","line":557,"updated":"2018-07-17 09:01:48.000000000","message":"nit: this message will appear even if part_device is None","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"900e7874a6e6baa56eb923cf2bf47cb43605e8f8","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \u0027efi system partition uuid\u0027: part_dict.get(\u0027efi system partition\u0027),"},{"line_number":602,"context_line":"    }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    if cpu_arch.startswith(\u0027ppc\u0027):"},{"line_number":605,"context_line":"        uuids_to_return["},{"line_number":606,"context_line":"            \u0027PReP Boot partition uuid\u0027"},{"line_number":607,"context_line":"        ] \u003d part_dict.get(\u0027PReP Boot partition\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_9bc75c3e","line":604,"updated":"2018-07-16 17:39:22.000000000","message":"I can\u0027t help but wonder if people might accidently type out cpu details in upper case...","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f378f1d536f6915386d37e133d0d512bc5025eb9","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \u0027efi system partition uuid\u0027: part_dict.get(\u0027efi system partition\u0027),"},{"line_number":602,"context_line":"    }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    if cpu_arch.startswith(\u0027ppc\u0027):"},{"line_number":605,"context_line":"        uuids_to_return["},{"line_number":606,"context_line":"            \u0027PReP Boot partition uuid\u0027"},{"line_number":607,"context_line":"        ] \u003d part_dict.get(\u0027PReP Boot partition\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_07a3ddb2","line":604,"updated":"2018-07-17 09:01:48.000000000","message":"let\u0027s follow up with lower()?","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"527203a13d7ab7a3cb9fa186639fb0f29a0b42ed","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        \u0027efi system partition uuid\u0027: part_dict.get(\u0027efi system partition\u0027),"},{"line_number":602,"context_line":"    }"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    if cpu_arch.startswith(\u0027ppc\u0027):"},{"line_number":605,"context_line":"        uuids_to_return["},{"line_number":606,"context_line":"            \u0027PReP Boot partition uuid\u0027"},{"line_number":607,"context_line":"        ] \u003d part_dict.get(\u0027PReP Boot partition\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_eb06b5cd","line":604,"in_reply_to":"5f7c97a3_9bc75c3e","updated":"2018-07-17 00:30:15.000000000","message":"That is indeed possible :( silly humans ;P","commit_id":"2b540a00bb9f16f8e6341e4089582f21c3160ced"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"194304a016b5288c0ef943603be1681935ee70b6","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    def test_make_partitions_gpt_with_prep(self, mock_exc):"},{"line_number":437,"context_line":"        self._test_make_partitions(mock_exc, boot_option\u003d\"local\","},{"line_number":438,"context_line":"                                   disk_label\u003d\"gpt\", cpu_arch\u003d\"ppc64le\")"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def test_make_partitions_with_ephemeral(self, mock_exc):"},{"line_number":442,"context_line":"        self.ephemeral_mb \u003d 2048"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_1f614fa9","line":439,"updated":"2018-06-28 16:19:47.000000000","message":"One too many blank lines.","commit_id":"680d6ae74c3ec6e7463c9e71d46a839b81b58397"}]}