)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a3a6a066a3ddf4e0a7f1147ff419ff1c6b689ff9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support streaming raw partition images we need to fetch the image"},{"line_number":10,"context_line":"directly from HTTP. To avoid copying this logic from IPA to ironic-lib,"},{"line_number":11,"context_line":"enable work_on_disk to skip flashing the image by passing image_path\u003dNone."},{"line_number":12,"context_line":"To simplify life for the caller, return partitions dictionary in result."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3189a2de115ae4bf47ad911161c2f5f3f062ef3c"},{"line_number":15,"context_line":"Story: #2003809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_c01304b7","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":72},"updated":"2018-10-05 12:34:25.000000000","message":"Is this change coupled with the topic of this patch sufficiently tightly to justify a single patch?","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e1691aa518650291f2082d74083442da1c070e37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support streaming raw partition images we need to fetch the image"},{"line_number":10,"context_line":"directly from HTTP. To avoid copying this logic from IPA to ironic-lib,"},{"line_number":11,"context_line":"enable work_on_disk to skip flashing the image by passing image_path\u003dNone."},{"line_number":12,"context_line":"To simplify life for the caller, return partitions dictionary in result."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3189a2de115ae4bf47ad911161c2f5f3f062ef3c"},{"line_number":15,"context_line":"Story: #2003809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0d72944b","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":72},"in_reply_to":"3f79a3b5_c01304b7","updated":"2018-10-05 13:48:09.000000000","message":"One is useless without the other. We cannot populate the empty partition if we don\u0027t know it.","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"a3a6a066a3ddf4e0a7f1147ff419ff1c6b689ff9","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        LOG.info(\"Image for %(node)s successfully populated\","},{"line_number":603,"context_line":"                 {\u0027node\u0027: node_uuid})"},{"line_number":604,"context_line":"    else:"},{"line_number":605,"context_line":"        LOG.debug(\"Root partition for %s was created, but not populated\","},{"line_number":606,"context_line":"                  node_uuid)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    if swap_part:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a089281f","line":605,"range":{"start_line":605,"start_character":38,"end_line":605,"end_character":40},"updated":"2018-10-05 12:34:25.000000000","message":"nit: the interpolation syntax is different from #602","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b5744e0f0c439beeff8cc07885aaeda69dd0b6ec","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        LOG.info(\"Image for %(node)s successfully populated\","},{"line_number":603,"context_line":"                 {\u0027node\u0027: node_uuid})"},{"line_number":604,"context_line":"    else:"},{"line_number":605,"context_line":"        LOG.debug(\"Root partition for %s was created, but not populated\","},{"line_number":606,"context_line":"                  node_uuid)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    if swap_part:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d7daace4","line":605,"range":{"start_line":605,"start_character":38,"end_line":605,"end_character":40},"in_reply_to":"3f79a3b5_719088f4","updated":"2018-10-09 11:28:37.000000000","message":"there is a wrong syntax which will cause no output, i just forget which one, and get this wrong vision *facepalm*","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d3cbe6f3b5da236d6d95f26ea9870333f73e4684","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        LOG.info(\"Image for %(node)s successfully populated\","},{"line_number":603,"context_line":"                 {\u0027node\u0027: node_uuid})"},{"line_number":604,"context_line":"    else:"},{"line_number":605,"context_line":"        LOG.debug(\"Root partition for %s was created, but not populated\","},{"line_number":606,"context_line":"                  node_uuid)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    if swap_part:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_719088f4","line":605,"range":{"start_line":605,"start_character":38,"end_line":605,"end_character":40},"in_reply_to":"3f79a3b5_8e2665b9","updated":"2018-10-09 09:56:54.000000000","message":"No, this just uses a lighter syntax.","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"7899846794b1048f2a5440421961e269d200da87","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        LOG.info(\"Image for %(node)s successfully populated\","},{"line_number":603,"context_line":"                 {\u0027node\u0027: node_uuid})"},{"line_number":604,"context_line":"    else:"},{"line_number":605,"context_line":"        LOG.debug(\"Root partition for %s was created, but not populated\","},{"line_number":606,"context_line":"                  node_uuid)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    if swap_part:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8e2665b9","line":605,"range":{"start_line":605,"start_character":38,"end_line":605,"end_character":40},"in_reply_to":"3f79a3b5_a089281f","updated":"2018-10-09 08:52:05.000000000","message":"++ for this, it could be problem if memory serves.","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"68e6b2594d3d1aaf6a20a12f8b420bd587c973c5","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        LOG.info(\"Image for %(node)s successfully populated\","},{"line_number":603,"context_line":"                 {\u0027node\u0027: node_uuid})"},{"line_number":604,"context_line":"    else:"},{"line_number":605,"context_line":"        LOG.debug(\"Root partition for %s was created, but not populated\","},{"line_number":606,"context_line":"                  node_uuid)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    if swap_part:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b7a61054","line":605,"range":{"start_line":605,"start_character":38,"end_line":605,"end_character":40},"in_reply_to":"3f79a3b5_d7daace4","updated":"2018-10-09 11:35:16.000000000","message":"Valid options are:\n\n LOG.debug(\u0027%s\u0027, node_uuid)\n LOG.debug(\u0027%(node)s\u0027, {\u0027node\u0027: node_uuid})\n\ntheir combinations are invalid, e.g. this one:\n\n LOG.debug(\u0027%(node)s\u0027, node_uuid)","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8f2309b19a8705107870496473e9cc14469b5650","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                                             disk_label\u003dNone,"},{"line_number":231,"context_line":"                                             cpu_arch\u003d\"\")"},{"line_number":232,"context_line":"        self.assertEqual(root_part, res[\u0027partitions\u0027][\u0027root\u0027])"},{"line_number":233,"context_line":"        self.assertEqual(\u0027uuid\u0027, res[\u0027root uuid\u0027])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch.object(utils, \u0027mkfs\u0027, lambda fs, path, label\u003dNone: None)"},{"line_number":236,"context_line":"    @mock.patch.object(disk_utils, \u0027block_uuid\u0027, lambda p: \u0027uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_45d118ca","line":233,"updated":"2018-10-08 19:31:54.000000000","message":"I feel silly, but I think we should ensure that populate_image is not called in the unit test, that way we\u0027re ensuring that the behavior doesn\u0027t change when it is called with None for the image.","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d3cbe6f3b5da236d6d95f26ea9870333f73e4684","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                                             disk_label\u003dNone,"},{"line_number":231,"context_line":"                                             cpu_arch\u003d\"\")"},{"line_number":232,"context_line":"        self.assertEqual(root_part, res[\u0027partitions\u0027][\u0027root\u0027])"},{"line_number":233,"context_line":"        self.assertEqual(\u0027uuid\u0027, res[\u0027root uuid\u0027])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @mock.patch.object(utils, \u0027mkfs\u0027, lambda fs, path, label\u003dNone: None)"},{"line_number":236,"context_line":"    @mock.patch.object(disk_utils, \u0027block_uuid\u0027, lambda p: \u0027uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_319a1013","line":233,"in_reply_to":"3f79a3b5_45d118ca","updated":"2018-10-09 09:56:54.000000000","message":"Done","commit_id":"33a2daafb300462315d11eff6e8491f4b3020937"}]}