)]}'
{"id":"openstack%2Fironic-lib~655700","triplet_id":"openstack%2Fironic-lib~master~I49340bfedd3e63316a79f166ce0874d5020b862a","project":"openstack/ironic-lib","branch":"master","topic":"tests","hashtags":[],"change_id":"I49340bfedd3e63316a79f166ce0874d5020b862a","subject":"Tests: replace mocking loopingcall with zero interval","status":"MERGED","created":"2019-04-25 14:07:18.000000000","updated":"2019-05-17 07:51:13.000000000","submitted":"2019-05-17 05:52:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"655700-1558072376995-16b933f0","meta_rev_id":"a9f1e87e514b43a73c57e96852865db9e642aad6","_number":655700,"virtual_id_number":655700,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2019-05-17 05:52:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":2,"date":"2019-05-17 05:43:51.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":2,"date":"2019-05-16 19:26:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":1,"date":"2019-05-17 05:43:51.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-16 19:26:08.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2019-05-17 05:43:51.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2019-05-17 05:52:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fe0adfeee5ac3f1cfb05ac24801f39f894d4e22a","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-04-25 14:07:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69e31946824e78649e485ef4285970bc8f9fcd6e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-25 14:21:22.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/00/655700/1/check/openstack-tox-cover/93a631f/cover/ : SUCCESS in 4m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/00/655700/1/check/openstack-tox-lower-constraints/73d2b2d/ : FAILURE in 5m 17s\n- openstack-tox-pep8 http://logs.openstack.org/00/655700/1/check/openstack-tox-pep8/dcc105b/ : SUCCESS in 4m 28s\n- openstack-tox-py27 http://logs.openstack.org/00/655700/1/check/openstack-tox-py27/15d8027/ : SUCCESS in 4m 39s\n- openstack-tox-py36 http://logs.openstack.org/00/655700/1/check/openstack-tox-py36/3a239f7/ : SUCCESS in 3m 54s\n- openstack-tox-py37 http://logs.openstack.org/00/655700/1/check/openstack-tox-py37/b2ab05f/ : SUCCESS in 4m 13s\n- openstack-tox-docs http://logs.openstack.org/00/655700/1/check/openstack-tox-docs/1f2a4ce/html/ : SUCCESS in 4m 04s","accounts_in_message":[],"_revision_number":1},{"id":"57300d80331198e13cbd660bd62d6fb429de31c2","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-04-25 15:01:54.000000000","message":"Patch Set 1:\n\ninteresting, EventletEvent was introduced in oslo_utils v3.38.0\nwe use 3.33.0 in lower-constraints test, so I think this change is incompatible if we leave that version","accounts_in_message":[],"_revision_number":1},{"id":"198d0fb97723c03b2223982ff4a729215ab98e9f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-15 10:45:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5143663825527aaab3e83ca9fce1383aedae1cb3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 10:52:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/00/655700/2/check/openstack-tox-cover/302b456/cover/ : SUCCESS in 4m 55s\n- openstack-tox-lower-constraints http://logs.openstack.org/00/655700/2/check/openstack-tox-lower-constraints/2168754/ : SUCCESS in 6m 00s\n- openstack-tox-pep8 http://logs.openstack.org/00/655700/2/check/openstack-tox-pep8/0bf2598/ : SUCCESS in 4m 54s\n- openstack-tox-py27 http://logs.openstack.org/00/655700/2/check/openstack-tox-py27/ce71622/ : SUCCESS in 5m 31s\n- openstack-tox-py36 http://logs.openstack.org/00/655700/2/check/openstack-tox-py36/a74a9df/ : SUCCESS in 5m 01s\n- openstack-tox-py37 http://logs.openstack.org/00/655700/2/check/openstack-tox-py37/e29ebd3/ : SUCCESS in 5m 10s\n- openstack-tox-docs http://logs.openstack.org/00/655700/2/check/openstack-tox-docs/fab18c3/html/ : SUCCESS in 4m 32s","accounts_in_message":[],"_revision_number":2},{"id":"566f70e64ca3844057c816aad9904486a62cd0ef","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-05-16 19:26:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3e38a225c5be4844d98524326f8e99eaff6c6b69","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2019-05-17 05:43:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThank you Dmitry.","accounts_in_message":[],"_revision_number":2},{"id":"84b24b4f75ca01b9ef5cec0324ae99ea6f601349","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 05:44:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"33f06d3529e9e03a16e114cdb97ed20c0bf2fb48","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 05:52:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"ebdbb5e6472ec8678fe13765b36fa2272dacdc20","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 05:52:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/00/655700/2/gate/openstack-tox-lower-constraints/f454fb3/ : SUCCESS in 5m 30s\n- openstack-tox-pep8 http://logs.openstack.org/00/655700/2/gate/openstack-tox-pep8/0543f2b/ : SUCCESS in 3m 45s\n- openstack-tox-py27 http://logs.openstack.org/00/655700/2/gate/openstack-tox-py27/43cb1cd/ : SUCCESS in 3m 41s\n- openstack-tox-py36 http://logs.openstack.org/00/655700/2/gate/openstack-tox-py36/b112dbf/ : SUCCESS in 3m 49s\n- openstack-tox-py37 http://logs.openstack.org/00/655700/2/gate/openstack-tox-py37/05756a6/ : SUCCESS in 4m 12s\n- openstack-tox-docs http://logs.openstack.org/00/655700/2/gate/openstack-tox-docs/7399313/html/ : SUCCESS in 3m 48s","accounts_in_message":[],"_revision_number":2},{"id":"f8fb69a7d96d376d84c04b6f6587a5e18a3f0a3c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-17 07:51:13.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit ee3cc40d07ebd29d8a207b7fd002d91714e98c74","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"93d3a75039b767d6c02cf89ac8e8d82df4715278","revisions":{"3e0c645b07bd29c120a58f6ccb5a5921b207ad49":{"kind":"REWORK","_number":1,"created":"2019-04-25 14:07:18.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/00/655700/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/00/655700/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/1"}}},"commit":{"parents":[{"commit":"899d255b4aeac40cae1feaaad468dc1741ef6020","subject":"Replace git.openstack.org URLs with opendev.org URLs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/899d255b4aeac40cae1feaaad468dc1741ef6020"}]}],"author":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-04-25 14:06:25.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-04-25 14:06:25.000000000","tz":120},"subject":"Correctly mock loopingcall in unit tests","message":"Correctly mock loopingcall in unit tests\n\nWe mock sleep(), but it actually uses EventletEvent.wait from oslo.utils.\n\nChange-Id: I49340bfedd3e63316a79f166ce0874d5020b862a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/3e0c645b07bd29c120a58f6ccb5a5921b207ad49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/3e0c645b07bd29c120a58f6ccb5a5921b207ad49"}]},"branch":"refs/heads/master"},"93d3a75039b767d6c02cf89ac8e8d82df4715278":{"kind":"REWORK","_number":2,"created":"2019-05-15 10:45:26.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/00/655700/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/00/655700/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/00/655700/2"}}},"commit":{"parents":[{"commit":"899d255b4aeac40cae1feaaad468dc1741ef6020","subject":"Replace git.openstack.org URLs with opendev.org URLs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/899d255b4aeac40cae1feaaad468dc1741ef6020"}]}],"author":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-04-25 14:06:25.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-05-15 10:44:58.000000000","tz":120},"subject":"Tests: replace mocking loopingcall with zero interval","message":"Tests: replace mocking loopingcall with zero interval\n\nWe mock sleep(), but LoopingCall, depending on version either uses\na private wrapper around eventlet.Event or one from oslo_utils.\nSince mocking them correctly requires mocking private methods, this\nchange sets the loop interval to zero, bypassing waiting.\n\nThis reduces the time required for running disk_partitioner tests\nfrom 20 seconds to less than 1 second.\n\nChange-Id: I49340bfedd3e63316a79f166ce0874d5020b862a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/93d3a75039b767d6c02cf89ac8e8d82df4715278"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/93d3a75039b767d6c02cf89ac8e8d82df4715278"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}