)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1d754864","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":61},"updated":"2019-06-12 11:33:09.000000000","message":"I think if you pass the device name to \u0027fdisk -l\u0027, it does not report \"EFI System\" (it does when you omit the device).","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"61b929e11b6be3c2aaf86b670e032f695d3f6713","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7324b5af","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":61},"in_reply_to":"9fb8cfa7_1d754864","updated":"2019-06-12 12:59:23.000000000","message":"it will show the partitions on the disk, \"EFI System\" will be reported under the type column\ne.g.\n\nDisk /dev/nvme0n1: 953.9 GiB, 1024209543168 bytes, 2000409264 sectors\n\nDevice               Start        End   Sectors   Size Type\n[...]\n/dev/nvme0n1p2     1024000    1228799    204800   100M EFI System","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"a2f46980a2cb0ca1d724255080cf5421e478681e","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d3a9e17b","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":61},"in_reply_to":"9fb8cfa7_7324b5af","updated":"2019-06-12 13:18:26.000000000","message":"Right, sorry: I was trying with the partition, not the device.","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":168,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_dd6a507f","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":29},"updated":"2019-06-12 11:33:09.000000000","message":"How about\n\nreport, _ \u003d utils...\n\ninstead? This way you don\u0027t need \u0027efi_partition\u0027.","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"cd523cebe5c4e00c616bf5641c07c6950638e6fe","unresolved":false,"context_lines":[{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":168,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_4492e358","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":29},"in_reply_to":"9fb8cfa7_dd6a507f","updated":"2019-06-14 11:24:09.000000000","message":"Done","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":168,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":169,"context_line":"            part \u003d {}"},{"line_number":170,"context_line":"            # Split into KEY\u003dVAL pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_bd343c94","line":167,"range":{"start_line":167,"start_character":15,"end_line":167,"end_character":34},"updated":"2019-06-12 11:33:09.000000000","message":"I think \u0027splitlines()\u0027 is more robust.","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"cd523cebe5c4e00c616bf5641c07c6950638e6fe","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    efi_partition \u003d utils.execute(\u0027sudo\u0027,\u0027fdisk\u0027 , \u0027-l\u0027, dev)"},{"line_number":165,"context_line":"    report \u003d efi_partition[0]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":168,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":169,"context_line":"            part \u003d {}"},{"line_number":170,"context_line":"            # Split into KEY\u003dVAL pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_e49c376b","line":167,"range":{"start_line":167,"start_character":15,"end_line":167,"end_character":34},"in_reply_to":"9fb8cfa7_bd343c94","updated":"2019-06-14 11:24:09.000000000","message":"Done","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":168,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":169,"context_line":"            part \u003d {}"},{"line_number":170,"context_line":"            # Split into KEY\u003dVAL pairs"},{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1dfa28bc","line":169,"range":{"start_line":169,"start_character":12,"end_line":169,"end_character":21},"updated":"2019-06-12 11:33:09.000000000","message":"This is unused, it seems, no?","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"cd523cebe5c4e00c616bf5641c07c6950638e6fe","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    for line in report.split(\u0027\\n\u0027):"},{"line_number":168,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":169,"context_line":"            part \u003d {}"},{"line_number":170,"context_line":"            # Split into KEY\u003dVAL pairs"},{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_04986b72","line":169,"range":{"start_line":169,"start_character":12,"end_line":169,"end_character":21},"in_reply_to":"9fb8cfa7_1dfa28bc","updated":"2019-06-14 11:24:09.000000000","message":"removed it","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            part \u003d {}"},{"line_number":170,"context_line":"            # Split into KEY\u003dVAL pairs"},{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_dded70f0","line":172,"range":{"start_line":172,"start_character":12,"end_line":172,"end_character":34},"updated":"2019-06-12 11:33:09.000000000","message":"Isn\u0027t this \u0027dev\u0027?","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"cd523cebe5c4e00c616bf5641c07c6950638e6fe","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            part \u003d {}"},{"line_number":170,"context_line":"            # Split into KEY\u003dVAL pairs"},{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_04714b44","line":172,"range":{"start_line":172,"start_character":12,"end_line":172,"end_character":34},"in_reply_to":"9fb8cfa7_dded70f0","updated":"2019-06-14 11:24:09.000000000","message":"dev and the vals[0] is different.\nIf we use dev in the below line, will list all the partition uuid\u0027s but we want it for \"EFI System\u0027","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"},{"line_number":176,"context_line":"    disk_identifier \u003d (lsblk_data.split(\"\u003d\")[1]).strip()"},{"line_number":177,"context_line":"    return disk_identifier"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_bd0bdcd3","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":61},"updated":"2019-06-12 11:33:09.000000000","message":"What happens if the above \u0027if\u0027 was never true and partition_id is now undefined?","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"cd523cebe5c4e00c616bf5641c07c6950638e6fe","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"},{"line_number":176,"context_line":"    disk_identifier \u003d (lsblk_data.split(\"\u003d\")[1]).strip()"},{"line_number":177,"context_line":"    return disk_identifier"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a4915f49","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":61},"in_reply_to":"9fb8cfa7_b8c44af6","updated":"2019-06-14 11:24:09.000000000","message":"Done","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"61b929e11b6be3c2aaf86b670e032f695d3f6713","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"},{"line_number":176,"context_line":"    disk_identifier \u003d (lsblk_data.split(\"\u003d\")[1]).strip()"},{"line_number":177,"context_line":"    return disk_identifier"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b8c44af6","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":61},"in_reply_to":"9fb8cfa7_bd0bdcd3","updated":"2019-06-12 12:59:23.000000000","message":"also please don\u0027t call a variable with the name of the command, use something like lsblk_output or similar","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"cd523cebe5c4e00c616bf5641c07c6950638e6fe","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"},{"line_number":176,"context_line":"    disk_identifier \u003d (lsblk_data.split(\"\u003d\")[1]).strip()"},{"line_number":177,"context_line":"    return disk_identifier"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_64e8477b","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":61},"in_reply_to":"9fb8cfa7_bd0bdcd3","updated":"2019-06-14 11:24:09.000000000","message":"lsblk function will not execute on non block device images and non block device images will not boot in UEFI boot mode","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"5831f8fc3b33fc6e6e32a5aef1618ab6121ddc73","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            partition_id \u003d vals[0]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    lsblk \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":175,"context_line":"    lsblk_data \u003d lsblk[0]"},{"line_number":176,"context_line":"    disk_identifier \u003d (lsblk_data.split(\"\u003d\")[1]).strip()"},{"line_number":177,"context_line":"    return disk_identifier"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5d25005b","line":175,"range":{"start_line":175,"start_character":4,"end_line":175,"end_character":25},"updated":"2019-06-12 11:33:09.000000000","message":"See above.","commit_id":"13bd88e1b9242e3a56e35de208b01d723bdf1aae"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6783e91a48bb62f87833fa7751f2d120299ef71f","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    report, _ \u003d utils.execute(\u0027sudo\u0027, \u0027fdisk\u0027, \u0027-l\u0027, dev)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for line in report.splitlines():"},{"line_number":167,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_5a82b801","line":164,"updated":"2019-06-14 11:30:33.000000000","message":"sudo is not needed and probably won\u0027t work anyway. please use run_as_root\u003dTrue as above. also use use_standard_locale\u003dTrue since you\u0027re trying to find English words in the output.","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"195e4ec8dd769783e3f180b3ca4e254d11278e58","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    report, _ \u003d utils.execute(\u0027sudo\u0027, \u0027fdisk\u0027, \u0027-l\u0027, dev)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for line in report.splitlines():"},{"line_number":167,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7663feb2","line":164,"in_reply_to":"9fb8cfa7_5a82b801","updated":"2019-06-17 07:55:35.000000000","message":"Done","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6783e91a48bb62f87833fa7751f2d120299ef71f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    for line in report.splitlines():"},{"line_number":167,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":168,"context_line":"            # Split into KEY\u003dVAL pairs"},{"line_number":169,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7a853c06","line":169,"updated":"2019-06-14 11:30:33.000000000","message":"it seems that you can use the regular split","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6783e91a48bb62f87833fa7751f2d120299ef71f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":173,"context_line":"    disk_identifier \u003d (lsblk_output.split(\"\u003d\")[1]).strip()"},{"line_number":174,"context_line":"    return disk_identifier"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_1a80c0f4","line":172,"updated":"2019-06-14 11:30:33.000000000","message":"you may need run_as_root here as well","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"195e4ec8dd769783e3f180b3ca4e254d11278e58","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":173,"context_line":"    disk_identifier \u003d (lsblk_output.split(\"\u003d\")[1]).strip()"},{"line_number":174,"context_line":"    return disk_identifier"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_165882f8","line":172,"in_reply_to":"9fb8cfa7_1a80c0f4","updated":"2019-06-17 07:55:35.000000000","message":"Done","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6783e91a48bb62f87833fa7751f2d120299ef71f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":173,"context_line":"    disk_identifier \u003d (lsblk_output.split(\"\u003d\")[1]).strip()"},{"line_number":174,"context_line":"    return disk_identifier"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_3a7b4428","line":173,"updated":"2019-06-14 11:30:33.000000000","message":"on my system this looks like\n\n UUID\u003d\"...\"\n\nso you probably need to add .strip(\u0027\"\u0027)\n\nalso nit: redundant brackets","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"195e4ec8dd769783e3f180b3ca4e254d11278e58","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id)"},{"line_number":173,"context_line":"    disk_identifier \u003d (lsblk_output.split(\"\u003d\")[1]).strip()"},{"line_number":174,"context_line":"    return disk_identifier"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_365d86e9","line":173,"in_reply_to":"9fb8cfa7_3a7b4428","updated":"2019-06-17 07:55:35.000000000","message":"Done","commit_id":"0f2580ca0a8fffb55ac278c2b7f87f684f25cc43"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c398bc7bfb71d344f11a7fa539654fe81998ba82","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    return disk_identifier[0]"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_fc082d2e","line":162,"range":{"start_line":162,"start_character":4,"end_line":162,"end_character":28},"updated":"2019-06-17 11:08:33.000000000","message":"Add doc string","commit_id":"c45aea363f67af7f336f2eb97b00fd92f695ddc6"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"586022b3c69f5632bb3536c4594f1f4261c6c3b2","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_uefi_disk_identifier(dev):"},{"line_number":163,"context_line":"    partition_id \u003d \u0027\u0027"},{"line_number":164,"context_line":"    report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for line in report.splitlines():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_76e0decd","line":163,"range":{"start_line":163,"start_character":4,"end_line":163,"end_character":21},"updated":"2019-06-17 08:27:02.000000000","message":"Nit: not needed","commit_id":"c45aea363f67af7f336f2eb97b00fd92f695ddc6"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"586022b3c69f5632bb3536c4594f1f4261c6c3b2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":173,"context_line":"                                    run_as_root\u003dTrue)"},{"line_number":174,"context_line":"    disk_identifier \u003d lsblk_output.split(\"\u003d\")[1].strip()"},{"line_number":175,"context_line":"    disk_identifier \u003d disk_identifier.strip(\u0027\"\u0027)"},{"line_number":176,"context_line":"    return disk_identifier"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_d66aea19","line":173,"range":{"start_line":172,"start_character":0,"end_line":173,"end_character":53},"updated":"2019-06-17 08:27:02.000000000","message":"I\u0027m still wondering if it wouldn\u0027t be beneficial to have some error handling here in case the parsing does not find partition_id, e.g. when the device passed does not have an EFI system partition.","commit_id":"c45aea363f67af7f336f2eb97b00fd92f695ddc6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c398bc7bfb71d344f11a7fa539654fe81998ba82","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            vals \u003d shlex.split(line)"},{"line_number":170,"context_line":"            partition_id \u003d vals[0]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":173,"context_line":"                                    run_as_root\u003dTrue)"},{"line_number":174,"context_line":"    disk_identifier \u003d lsblk_output.split(\"\u003d\")[1].strip()"},{"line_number":175,"context_line":"    disk_identifier \u003d disk_identifier.strip(\u0027\"\u0027)"},{"line_number":176,"context_line":"    return disk_identifier"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_dc0be928","line":173,"range":{"start_line":172,"start_character":0,"end_line":173,"end_character":53},"in_reply_to":"9fb8cfa7_d66aea19","updated":"2019-06-17 11:08:33.000000000","message":"+1","commit_id":"c45aea363f67af7f336f2eb97b00fd92f695ddc6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9c10908cfbdd100361d74ee88de1d6750efb4f6d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    :returns: The UUID of the partition."},{"line_number":174,"context_line":"    \"\"\""},{"line_number":175,"context_line":"    partition_id \u003d None"},{"line_number":176,"context_line":"    report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":177,"context_line":"    for line in report.splitlines():"},{"line_number":178,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":179,"context_line":"            vals \u003d line.split()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_4ce11d2a","line":176,"range":{"start_line":176,"start_character":4,"end_line":176,"end_character":29},"updated":"2019-06-24 04:29:37.000000000","message":"This needs to be in try/except block to catch any processutils and raise them as InstanceDeployFailure with appropriate error message.","commit_id":"aa1efb23d0c5ba447b73ebc3af489a7e0df90192"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9c10908cfbdd100361d74ee88de1d6750efb4f6d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            vals \u003d line.split()"},{"line_number":180,"context_line":"            partition_id \u003d vals[0]"},{"line_number":181,"context_line":"    if partition_id is not None:"},{"line_number":182,"context_line":"        lsblk_output, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":183,"context_line":"                                        run_as_root\u003dTrue)"},{"line_number":184,"context_line":"        disk_identifier \u003d lsblk_output.split(\"\u003d\")[1].strip()"},{"line_number":185,"context_line":"        disk_identifier \u003d disk_identifier.strip(\u0027\"\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_ecd1f158","line":182,"range":{"start_line":182,"start_character":26,"end_line":182,"end_character":39},"updated":"2019-06-24 04:29:37.000000000","message":"ditto","commit_id":"aa1efb23d0c5ba447b73ebc3af489a7e0df90192"}],"ironic_lib/tests/test_disk_utils.py":[{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"0d417b09b1b2ff7b28bb48483b68fa65a650a5ee","unresolved":false,"context_lines":[{"line_number":450,"context_line":"/dev/fake-part2     1050624 1920172031 1919121408 915.1G Linux filesystem"},{"line_number":451,"context_line":"/dev/fake-part3  1920172032 1953458175   33286144  15.9G Linux swap"},{"line_number":452,"context_line":"\"\"\""},{"line_number":453,"context_line":"        for line in fdisk_output.splitlines():"},{"line_number":454,"context_line":"            if line.startswith(self.dev) and \u0027EFI System\u0027 in line:"},{"line_number":455,"context_line":"                vals \u003d line.split()"},{"line_number":456,"context_line":"                partition_id \u003d vals[0]"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        lsblk_output \u003d \u0027UUID\u003d\"ABCD-B05B\"\\n\u0027"},{"line_number":459,"context_line":"        part_result \u003d \u0027ABCD-B05B\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_87e639e8","line":456,"range":{"start_line":453,"start_character":0,"end_line":456,"end_character":38},"updated":"2019-06-20 13:06:22.000000000","message":"I think you should simply set partition_id here. The parsing code will be checked by making sure get_uefi_disk_indentifier() calls lsblk with the correct partition_id. I don\u0027t think it is a good idea to replicate (part of) the code to be tested in the test.","commit_id":"44e9d7f9d6ac413a76dc686e4d0e3a1fae105671"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"bbe3948945ddf21061e9ee4765f59b001ecc792e","unresolved":false,"context_lines":[{"line_number":450,"context_line":"/dev/fake-part2     1050624 1920172031 1919121408 915.1G Linux filesystem"},{"line_number":451,"context_line":"/dev/fake-part3  1920172032 1953458175   33286144  15.9G Linux swap"},{"line_number":452,"context_line":"\"\"\""},{"line_number":453,"context_line":"        for line in fdisk_output.splitlines():"},{"line_number":454,"context_line":"            if line.startswith(self.dev) and \u0027EFI System\u0027 in line:"},{"line_number":455,"context_line":"                vals \u003d line.split()"},{"line_number":456,"context_line":"                partition_id \u003d vals[0]"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        lsblk_output \u003d \u0027UUID\u003d\"ABCD-B05B\"\\n\u0027"},{"line_number":459,"context_line":"        part_result \u003d \u0027ABCD-B05B\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_91fd00b3","line":456,"range":{"start_line":453,"start_character":0,"end_line":456,"end_character":38},"in_reply_to":"9fb8cfa7_87e639e8","updated":"2019-06-21 12:04:58.000000000","message":"Done","commit_id":"44e9d7f9d6ac413a76dc686e4d0e3a1fae105671"}]}