)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"864294068cec0bf3c75bc9d0897b64d03d441480","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3a5c9337424649f4250af008a101a4a6437ae5cc"},{"line_number":14,"context_line":"Story: 2005533"},{"line_number":15,"context_line":"Task: 35723"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_09b3e999","line":15,"updated":"2019-07-15 14:37:14.000000000","message":"Would we get a needed-by tag for this? Since there is no topic I\u0027m not sure what patch needs this.","commit_id":"f025611cfe7c140c1634b5e568c71baed446ae2d"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"864294068cec0bf3c75bc9d0897b64d03d441480","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        root_uuid \u003d root_uuid.strip(\u0027\"\u0027)"},{"line_number":228,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":229,"context_line":"        raise exception.InstanceDeployFailure(\"Image is not UEFI bootable. \""},{"line_number":230,"context_line":"                                              \"Error: %s \" % e)"},{"line_number":231,"context_line":"    try:"},{"line_number":232,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioPARTUUID\u0027, efi_partition_id,"},{"line_number":233,"context_line":"                                  run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_295ee543","line":230,"updated":"2019-07-15 14:37:14.000000000","message":"Would this not cause all UEFI windows deployments to fail? or UEFI non-standard linux deployments at that?","commit_id":"f025611cfe7c140c1634b5e568c71baed446ae2d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"582f5633010f0af6b45974dd7b46ec57e398e21f","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    efi_partition_id \u003d None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    try:"},{"line_number":211,"context_line":"        report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":212,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":213,"context_line":"        msg \u003d _(\u0027Failed to find the partition on the disk %s \u0027) % e"},{"line_number":214,"context_line":"        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_48c93b4f","line":211,"range":{"start_line":211,"start_character":35,"end_line":211,"end_character":46},"updated":"2019-08-27 10:03:30.000000000","message":"fdisk -l doesnt give the output for image copied as per the logic given in lines 216-223 for CentOS deploy image.","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"ead759a8c76fcce62fdabe2fe148e0395464aadf","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    efi_partition_id \u003d None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    try:"},{"line_number":211,"context_line":"        report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":212,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":213,"context_line":"        msg \u003d _(\u0027Failed to find the partition on the disk %s \u0027) % e"},{"line_number":214,"context_line":"        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_847afb85","line":211,"range":{"start_line":211,"start_character":35,"end_line":211,"end_character":46},"in_reply_to":"7faddb67_48c93b4f","updated":"2019-09-06 10:21:20.000000000","message":"I\u0027ve tested the same code with centos deploy images. It is working fine","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b9f4fff28c82a354498fdd289f8dce7a109cbe9c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    try:"},{"line_number":211,"context_line":"        report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":212,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":213,"context_line":"        msg \u003d _(\u0027Failed to find the partition on the disk %s \u0027) % e"},{"line_number":214,"context_line":"        LOG.error(msg)"},{"line_number":215,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":216,"context_line":"    for line in report.splitlines():"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5ddb0a7c","line":213,"range":{"start_line":213,"start_character":53,"end_line":213,"end_character":57},"updated":"2019-08-14 10:39:11.000000000","message":"s/ \u0027disk %s\u0027 / \u0027disk %(disk)s. Error: %(error)s\u0027 /","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b07bf450c7c94a7db0333afea7e6fcac72f4232","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        msg \u003d _(\u0027Failed to find the partition on the disk %s \u0027) % e"},{"line_number":214,"context_line":"        LOG.error(msg)"},{"line_number":215,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":216,"context_line":"    for line in report.splitlines():"},{"line_number":217,"context_line":"        if line.startswith(dev) and (\u0027Linux filesystem\u0027 in line) or ("},{"line_number":218,"context_line":"                \u0027Microsoft basic data\u0027 in line):"},{"line_number":219,"context_line":"            vals \u003d line.split()"},{"line_number":220,"context_line":"            partition_id \u003d vals[0]"},{"line_number":221,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_90c66e68","line":218,"range":{"start_line":216,"start_character":0,"end_line":218,"end_character":48},"updated":"2019-08-27 18:54:13.000000000","message":"Is there any way we can do type matching instead of string matching? The IDs should be relatively set based upon the standard, otherwise maybe evaluating the actual FS contents?","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"ead759a8c76fcce62fdabe2fe148e0395464aadf","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        msg \u003d _(\u0027Failed to find the partition on the disk %s \u0027) % e"},{"line_number":214,"context_line":"        LOG.error(msg)"},{"line_number":215,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":216,"context_line":"    for line in report.splitlines():"},{"line_number":217,"context_line":"        if line.startswith(dev) and (\u0027Linux filesystem\u0027 in line) or ("},{"line_number":218,"context_line":"                \u0027Microsoft basic data\u0027 in line):"},{"line_number":219,"context_line":"            vals \u003d line.split()"},{"line_number":220,"context_line":"            partition_id \u003d vals[0]"},{"line_number":221,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_c7feb5ad","line":218,"range":{"start_line":216,"start_character":0,"end_line":218,"end_character":48},"in_reply_to":"7faddb67_90c66e68","updated":"2019-09-06 10:21:20.000000000","message":"Actually when we perform \u0027fdisk -l\u0027 for a disk we shall get the below output\n1) In case of Linux based OSX\nDevice          Start        End    Sectors   Size Type\n/dev/fake-part1        2048    1050623    1048576   512M EFI System\n/dev/fake-part2     1050624 1920172031 1919121408 915.1G Linux filesystem\n/dev/fake-part3  1920172032 1953458175   33286144  15.9G Linux swap\n\"\"\"\n\n2)Incase of Windows OS\nDevice          Start        End    Sectors   Size Type\n/dev/fake-part1    2048   923647   921600  450M Windows recovery environment\n/dev/fake-part2  923648  1126399   202752   99M EFI System\n/dev/fake-part3 1126400  1159167    32768   16M Microsoft reserved\n/dev/fake-part4 1159168 81917951 80758784 38.5G Microsoft basic data\n\nInstead of splitting and checking, i was just checking it if it is present in that line.","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b9f4fff28c82a354498fdd289f8dce7a109cbe9c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":222,"context_line":"            vals \u003d line.split()"},{"line_number":223,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_1d903295","line":224,"range":{"start_line":224,"start_character":3,"end_line":224,"end_character":8},"updated":"2019-08-14 10:39:11.000000000","message":"Better to check and fail if \u0027partition_id\u0027 or \u0027efi_partition_id\u0027 are \u0027None\u0027 before using them.","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"582f5633010f0af6b45974dd7b46ec57e398e21f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":222,"context_line":"            vals \u003d line.split()"},{"line_number":223,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_353e97b9","line":224,"range":{"start_line":224,"start_character":3,"end_line":224,"end_character":8},"in_reply_to":"7faddb67_1d903295","updated":"2019-08-27 10:03:30.000000000","message":"+1, as if the deploy ramdisk is CentOS based then both will be None.","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"ead759a8c76fcce62fdabe2fe148e0395464aadf","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":222,"context_line":"            vals \u003d line.split()"},{"line_number":223,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_442c0347","line":224,"range":{"start_line":224,"start_character":3,"end_line":224,"end_character":8},"in_reply_to":"7faddb67_1d903295","updated":"2019-09-06 10:21:20.000000000","message":"Done","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"ead759a8c76fcce62fdabe2fe148e0395464aadf","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":222,"context_line":"            vals \u003d line.split()"},{"line_number":223,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_e4e5ef0b","line":224,"range":{"start_line":224,"start_character":3,"end_line":224,"end_character":8},"in_reply_to":"7faddb67_353e97b9","updated":"2019-09-06 10:21:20.000000000","message":"Values are getting populated for CentoOS based deploy ramdisk","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b07bf450c7c94a7db0333afea7e6fcac72f4232","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            vals \u003d line.split()"},{"line_number":223,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"},{"line_number":228,"context_line":"        root_uuid \u003d root_uuid.strip(\u0027\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_d09f064f","line":225,"range":{"start_line":225,"start_character":56,"end_line":225,"end_character":69},"updated":"2019-08-27 18:54:13.000000000","message":"If a partition is not found, it doesn\u0027t seem like the matching code below is really going to find the right entry.","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"ead759a8c76fcce62fdabe2fe148e0395464aadf","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            vals \u003d line.split()"},{"line_number":223,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":224,"context_line":"    try:"},{"line_number":225,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"},{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"},{"line_number":228,"context_line":"        root_uuid \u003d root_uuid.strip(\u0027\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_04cccb87","line":225,"range":{"start_line":225,"start_character":56,"end_line":225,"end_character":69},"in_reply_to":"7faddb67_d09f064f","updated":"2019-09-06 10:21:20.000000000","message":"Checking partition_id and efi_partition_id. If either one of them is \u0027None\u0027. I\u0027m raising the InstanceDeployFailure exception","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b07bf450c7c94a7db0333afea7e6fcac72f4232","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"},{"line_number":228,"context_line":"        root_uuid \u003d root_uuid.strip(\u0027\"\u0027)"},{"line_number":229,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":230,"context_line":"        raise exception.InstanceDeployFailure(\"Image is not UEFI bootable. \""},{"line_number":231,"context_line":"                                              \"Error: %s \" % e)"},{"line_number":232,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_10afde7d","line":229,"updated":"2019-08-27 18:54:13.000000000","message":"?KeyError? (or it\u0027s array equivalent) could also occur if there is nothing to split from line 227.","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"ead759a8c76fcce62fdabe2fe148e0395464aadf","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                  run_as_root\u003dTrue)"},{"line_number":227,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"},{"line_number":228,"context_line":"        root_uuid \u003d root_uuid.strip(\u0027\"\u0027)"},{"line_number":229,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":230,"context_line":"        raise exception.InstanceDeployFailure(\"Image is not UEFI bootable. \""},{"line_number":231,"context_line":"                                              \"Error: %s \" % e)"},{"line_number":232,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_e4a16f97","line":229,"in_reply_to":"7faddb67_10afde7d","updated":"2019-09-06 10:21:20.000000000","message":"Done","commit_id":"e43b930d44b25d8918f9c7228adbf96a76638356"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ae7c6b1e25adc930a0a7721aa1a57944c34de87","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    efi_partition_id \u003d None"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    try:"},{"line_number":211,"context_line":"        report, _ \u003d utils.execute(\u0027fdisk\u0027, \u0027-l\u0027, dev, run_as_root\u003dTrue)"},{"line_number":212,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":213,"context_line":"        msg \u003d (_(\u0027Failed to find the partition on the disk %(disk)s. \u0027"},{"line_number":214,"context_line":"                 \u0027Error: %(error)s\u0027) % {\u0027disk\u0027: dev, \u0027error\u0027: e})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_126fd1c5","line":211,"updated":"2020-05-05 12:24:35.000000000","message":"this needs use_standard_locale\u003dTrue since you\u0027re trying to find human-readable English strings","commit_id":"e0a70055af8bc307f82a985d3d2b4ff2482530d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ae7c6b1e25adc930a0a7721aa1a57944c34de87","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        raise exception.InstanceDeployFailure(msg)"},{"line_number":217,"context_line":"    for line in report.splitlines():"},{"line_number":218,"context_line":"        if line.startswith(dev) and (\u0027Linux filesystem\u0027 in line) or ("},{"line_number":219,"context_line":"                \u0027Microsoft basic data\u0027 in line):"},{"line_number":220,"context_line":"            vals \u003d line.split()"},{"line_number":221,"context_line":"            partition_id \u003d vals[0]"},{"line_number":222,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_f27345b0","line":219,"updated":"2020-05-05 12:24:35.000000000","message":"This is a strong assumption IMO, the root partition may be inside LVM, software RAID, the OS may be more exotic, etc.","commit_id":"e0a70055af8bc307f82a985d3d2b4ff2482530d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ae7c6b1e25adc930a0a7721aa1a57944c34de87","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        if line.startswith(dev) and \u0027EFI System\u0027 in line:"},{"line_number":223,"context_line":"            vals \u003d line.split()"},{"line_number":224,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":225,"context_line":"    if (partition_id is None) or (efi_partition_id is None):"},{"line_number":226,"context_line":"        raise exception.InstanceDeployFailure("},{"line_number":227,"context_line":"            \"Cannot find root_uuid or efi_sys_par_uuid on the Disk. \""},{"line_number":228,"context_line":"            \"Image is not UEFI bootable.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_526839b9","line":225,"updated":"2020-05-05 12:24:35.000000000","message":"nit: redundant brackets","commit_id":"e0a70055af8bc307f82a985d3d2b4ff2482530d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ae7c6b1e25adc930a0a7721aa1a57944c34de87","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            efi_partition_id \u003d vals[0]"},{"line_number":225,"context_line":"    if (partition_id is None) or (efi_partition_id is None):"},{"line_number":226,"context_line":"        raise exception.InstanceDeployFailure("},{"line_number":227,"context_line":"            \"Cannot find root_uuid or efi_sys_par_uuid on the Disk. \""},{"line_number":228,"context_line":"            \"Image is not UEFI bootable.\")"},{"line_number":229,"context_line":"    try:"},{"line_number":230,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioUUID\u0027, partition_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_3265ade2","line":227,"updated":"2020-05-05 12:24:35.000000000","message":"Please provide a human-readable explanation, operators are not supposed to know variable names","commit_id":"e0a70055af8bc307f82a985d3d2b4ff2482530d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ae7c6b1e25adc930a0a7721aa1a57944c34de87","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        root_uuid \u003d (report.split(\"\u003d\")[1]).strip()"},{"line_number":233,"context_line":"        root_uuid \u003d root_uuid.strip(\u0027\"\u0027)"},{"line_number":234,"context_line":"    except (processutils.ProcessExecutionError, IndexError) as e:"},{"line_number":235,"context_line":"        raise exception.InstanceDeployFailure(\"Image is not UEFI bootable. \""},{"line_number":236,"context_line":"                                              \"Error: %s \" % e)"},{"line_number":237,"context_line":"    try:"},{"line_number":238,"context_line":"        report, _ \u003d utils.execute(\u0027lsblk\u0027, \u0027-PbioPARTUUID\u0027, efi_partition_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_9262c1d7","line":235,"updated":"2020-05-05 12:24:35.000000000","message":"Please be more specific","commit_id":"e0a70055af8bc307f82a985d3d2b4ff2482530d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ae7c6b1e25adc930a0a7721aa1a57944c34de87","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        efi_sys_part_uuid \u003d (report.split(\"\u003d\")[1]).strip()"},{"line_number":241,"context_line":"        efi_sys_part_uuid \u003d efi_sys_part_uuid.strip(\u0027\"\u0027)"},{"line_number":242,"context_line":"    except (processutils.ProcessExecutionError, IndexError) as e:"},{"line_number":243,"context_line":"        raise exception.InstanceDeployFailure(\"Image is not UEFI bootable. \""},{"line_number":244,"context_line":"                                              \"Error: %s \" % e)"},{"line_number":245,"context_line":"    return {\u0027root_uuid\u0027: root_uuid, \u0027efi_sys_part_uuid\u0027: efi_sys_part_uuid}"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_725f350e","line":243,"updated":"2020-05-05 12:24:35.000000000","message":"ditto","commit_id":"e0a70055af8bc307f82a985d3d2b4ff2482530d2"}]}