)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"cbc0c5d29d82c02ee21ed41b6f8b7d4a688d945d","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    # NOTE(TheJulia): sgdisk attempts to load and make sense of the"},{"line_number":455,"context_line":"    # partition tables in advance of wiping the partition data."},{"line_number":456,"context_line":"    # This means when a CRC error is found on the existing data"},{"line_number":457,"context_line":"    # on disk that has been found."},{"line_number":458,"context_line":"    # This is the same bug as"},{"line_number":459,"context_line":"    # https://bugs.launchpad.net/ironic-python-agent/+bug/1737556"},{"line_number":460,"context_line":"    dd_device \u003d \u0027of\u003d%s\u0027 % dev"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_adfac171","line":457,"range":{"start_line":457,"start_character":4,"end_line":457,"end_character":34},"updated":"2019-08-19 19:34:41.000000000","message":"This is a bit unclear.","commit_id":"ff7aa6a6d8b264bfd566317cf2df166fc93b7c9b"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"e11cf46aacbee68e980e1e74d68e1acca502e79a","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    dd_device \u003d \u0027of\u003d%s\u0027 % dev"},{"line_number":461,"context_line":"    gpt_backup \u003d get_dev_block_size(dev) - 33"},{"line_number":462,"context_line":"    dd_seek \u003d \u0027seek\u003d%i\u0027 % gpt_backup"},{"line_number":463,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, dd_device, \u0027count\u003d33\u0027,"},{"line_number":464,"context_line":"                  run_as_root\u003dTrue,"},{"line_number":465,"context_line":"                  use_standard_locale\u003dTrue)"},{"line_number":466,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, dd_device, \u0027count\u003d33\u0027, dd_seek,"},{"line_number":467,"context_line":"                  run_as_root\u003dTrue,"},{"line_number":468,"context_line":"                  use_standard_locale\u003dTrue)"},{"line_number":469,"context_line":"    # Go ahead and let sgdisk run as well."},{"line_number":470,"context_line":"    utils.execute(\u0027sgdisk\u0027, \u0027-Z\u0027, dev, run_as_root\u003dTrue,"},{"line_number":471,"context_line":"                  use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_9bb29105","line":468,"range":{"start_line":463,"start_character":0,"end_line":468,"end_character":43},"updated":"2019-08-20 14:15:24.000000000","message":"I think these two miss a \"if\u003d/dev/zero\": dd would try to read from stdin without this option.","commit_id":"55201d384f00439667c058350ccff3cae0822eac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4edf05b5405f2c063e062815174f50aa42da8dda","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    dd_device \u003d \u0027of\u003d%s\u0027 % dev"},{"line_number":461,"context_line":"    gpt_backup \u003d get_dev_block_size(dev) - 33"},{"line_number":462,"context_line":"    dd_seek \u003d \u0027seek\u003d%i\u0027 % gpt_backup"},{"line_number":463,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, dd_device, \u0027count\u003d33\u0027,"},{"line_number":464,"context_line":"                  run_as_root\u003dTrue,"},{"line_number":465,"context_line":"                  use_standard_locale\u003dTrue)"},{"line_number":466,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, dd_device, \u0027count\u003d33\u0027, dd_seek,"},{"line_number":467,"context_line":"                  run_as_root\u003dTrue,"},{"line_number":468,"context_line":"                  use_standard_locale\u003dTrue)"},{"line_number":469,"context_line":"    # Go ahead and let sgdisk run as well."},{"line_number":470,"context_line":"    utils.execute(\u0027sgdisk\u0027, \u0027-Z\u0027, dev, run_as_root\u003dTrue,"},{"line_number":471,"context_line":"                  use_standard_locale\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5b2899e0","line":468,"range":{"start_line":463,"start_character":0,"end_line":468,"end_character":43},"in_reply_to":"7faddb67_9bb29105","updated":"2019-08-20 20:17:52.000000000","message":"SUPER good point. DOH!","commit_id":"55201d384f00439667c058350ccff3cae0822eac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2a3e438151a2c5a3e5737f8b6cc4973e0401112d","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    # This means when a CRC error is found, sgdisk fails before"},{"line_number":457,"context_line":"    # erasing partition data."},{"line_number":458,"context_line":"    # This is the same bug as"},{"line_number":459,"context_line":"    # https://bugs.launchpad.net/ironic-python-agent/+bug/1737556"},{"line_number":460,"context_line":"    dd_device \u003d \u0027of\u003d%s\u0027 % dev"},{"line_number":461,"context_line":"    gpt_backup \u003d get_dev_block_size(dev) - 33"},{"line_number":462,"context_line":"    dd_seek \u003d \u0027seek\u003d%i\u0027 % gpt_backup"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e2e98d7e","line":459,"updated":"2019-08-20 20:07:51.000000000","message":"Shouldn\u0027t we be using storyboard: https://storyboard.openstack.org/#!/story/1737556 ?","commit_id":"28a2ed1a90cd14e5dad20c51e05b20d0232477dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4edf05b5405f2c063e062815174f50aa42da8dda","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    # This means when a CRC error is found, sgdisk fails before"},{"line_number":457,"context_line":"    # erasing partition data."},{"line_number":458,"context_line":"    # This is the same bug as"},{"line_number":459,"context_line":"    # https://bugs.launchpad.net/ironic-python-agent/+bug/1737556"},{"line_number":460,"context_line":"    dd_device \u003d \u0027of\u003d%s\u0027 % dev"},{"line_number":461,"context_line":"    gpt_backup \u003d get_dev_block_size(dev) - 33"},{"line_number":462,"context_line":"    dd_seek \u003d \u0027seek\u003d%i\u0027 % gpt_backup"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5db08640","line":459,"in_reply_to":"7faddb67_e2e98d7e","updated":"2019-08-20 20:17:52.000000000","message":"The existing bugs point back there *shrug*","commit_id":"28a2ed1a90cd14e5dad20c51e05b20d0232477dc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cc5aadbb9bc809e6e22177b78404ef79f7240a00","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    dd_seek \u003d \u0027seek\u003d%i\u0027 % gpt_backup"},{"line_number":463,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, \u0027if\u003d/dev/zero\u0027, dd_device, \u0027count\u003d33\u0027,"},{"line_number":464,"context_line":"                  run_as_root\u003dTrue, use_standard_locale\u003dTrue)"},{"line_number":465,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, \u0027if\u003d/dev/zero\u0027, dd_device, \u0027count\u003d33\u0027,"},{"line_number":466,"context_line":"                  dd_seek, run_as_root\u003dTrue, use_standard_locale\u003dTrue)"},{"line_number":467,"context_line":"    # Go ahead and let sgdisk run as well."},{"line_number":468,"context_line":"    utils.execute(\u0027sgdisk\u0027, \u0027-Z\u0027, dev, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_1d7a0e87","line":465,"updated":"2019-08-20 20:12:56.000000000","message":"i just noticed that utils.py has a dd() method. Since we have that method, maybe we should use it. There\u0027s also a dd() in this file too (but I don\u0027t think we want to use this one) :D","commit_id":"28a2ed1a90cd14e5dad20c51e05b20d0232477dc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4edf05b5405f2c063e062815174f50aa42da8dda","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    dd_seek \u003d \u0027seek\u003d%i\u0027 % gpt_backup"},{"line_number":463,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, \u0027if\u003d/dev/zero\u0027, dd_device, \u0027count\u003d33\u0027,"},{"line_number":464,"context_line":"                  run_as_root\u003dTrue, use_standard_locale\u003dTrue)"},{"line_number":465,"context_line":"    utils.execute(\u0027dd\u0027, \u0027bs\u003d512\u0027, \u0027if\u003d/dev/zero\u0027, dd_device, \u0027count\u003d33\u0027,"},{"line_number":466,"context_line":"                  dd_seek, run_as_root\u003dTrue, use_standard_locale\u003dTrue)"},{"line_number":467,"context_line":"    # Go ahead and let sgdisk run as well."},{"line_number":468,"context_line":"    utils.execute(\u0027sgdisk\u0027, \u0027-Z\u0027, dev, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3d8eea78","line":465,"in_reply_to":"7faddb67_1d7a0e87","updated":"2019-08-20 20:17:52.000000000","message":"we likely could, but maybe as a follow-up.","commit_id":"28a2ed1a90cd14e5dad20c51e05b20d0232477dc"}],"releasenotes/notes/wipe-gpt-on-metadata-wipe-ac0a93b16e00893f.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"cbc0c5d29d82c02ee21ed41b6f8b7d4a688d945d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    cause cleaning to fail. A similar issue was previously encountered with"},{"line_number":6,"context_line":"    ironic-python-agent. See `Story 1737556 \u003chttps://storyboard.openstack.org/#!/story/1737556\u003e`_"},{"line_number":7,"context_line":"    for details."},{"line_number":8,"context_line":" "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_8d4025a4","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"updated":"2019-08-19 19:34:41.000000000","message":"space","commit_id":"ff7aa6a6d8b264bfd566317cf2df166fc93b7c9b"}]}