)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"da990141e8473ce59eaf19f25c2346f86d079137","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is not used in ironic-lib for anything explicitly iscsi-related."},{"line_number":10,"context_line":"Rename it, keeping the option present since ironic uses it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I86f52dc7e36a35ebcd44eee4f317fe93b5d67cd6"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/679463"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_57e2cc02","line":11,"updated":"2019-09-03 15:23:05.000000000","message":"worth mentioning the new config option too: partition_detection_attempts","commit_id":"2c7d1cfea0c9f83fb96831e289095debece9ecd2"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ca98ba6a42339b32e534b4c64bd09bb64d14bad4","unresolved":false,"context_lines":[{"line_number":335,"context_line":"def is_block_device(dev):"},{"line_number":336,"context_line":"    \"\"\"Check whether a device is block or not.\"\"\""},{"line_number":337,"context_line":"    # TODO(TheJulia): iscsi verify attempts is misleading when"},{"line_number":338,"context_line":"    # this error is returned by the agent sa well in order to"},{"line_number":339,"context_line":"    # write partition images."},{"line_number":340,"context_line":"    attempts \u003d CONF.disk_utils.iscsi_verify_attempts"},{"line_number":341,"context_line":"    for attempt in range(attempts):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5c56415e","line":338,"range":{"start_line":338,"start_character":42,"end_line":338,"end_character":44},"updated":"2019-08-21 08:01:14.000000000","message":"s/sa/as","commit_id":"b21645ac7f20955d1a2c57400a8b786655ba15b1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"127c26bae030c676fcad39d26c66682849e67e8f","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    \"\"\"Check whether a device is block or not.\"\"\""},{"line_number":337,"context_line":"    # TODO(TheJulia): iscsi verify attempts is misleading when"},{"line_number":338,"context_line":"    # this error is returned by the agent as well in order to"},{"line_number":339,"context_line":"    # write partition images. We should deprecate the config"},{"line_number":340,"context_line":"    # to limit confusion."},{"line_number":341,"context_line":"    attempts \u003d CONF.disk_utils.iscsi_verify_attempts"},{"line_number":342,"context_line":"    for attempt in range(attempts):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_bd9f90b1","line":339,"updated":"2019-08-30 08:22:27.000000000","message":"s/deprecate/rename/","commit_id":"713f806da858259c30d39c7ebddb00803c771479"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"488396c531173d3238bb2d893fcb9f7fa4e8e16b","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    \"\"\"Check whether a device is block or not.\"\"\""},{"line_number":337,"context_line":"    # TODO(TheJulia): iscsi verify attempts is misleading when"},{"line_number":338,"context_line":"    # this error is returned by the agent as well in order to"},{"line_number":339,"context_line":"    # write partition images. We should deprecate the config"},{"line_number":340,"context_line":"    # to limit confusion."},{"line_number":341,"context_line":"    attempts \u003d CONF.disk_utils.iscsi_verify_attempts"},{"line_number":342,"context_line":"    for attempt in range(attempts):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4c5ee813","line":339,"in_reply_to":"7faddb67_7d0cb841","updated":"2019-08-30 13:14:33.000000000","message":"It is a matter of time at the moment.","commit_id":"713f806da858259c30d39c7ebddb00803c771479"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c972c38662a364519c79327edfdfb9b49d616754","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    \"\"\"Check whether a device is block or not.\"\"\""},{"line_number":337,"context_line":"    # TODO(TheJulia): iscsi verify attempts is misleading when"},{"line_number":338,"context_line":"    # this error is returned by the agent as well in order to"},{"line_number":339,"context_line":"    # write partition images. We should deprecate the config"},{"line_number":340,"context_line":"    # to limit confusion."},{"line_number":341,"context_line":"    attempts \u003d CONF.disk_utils.iscsi_verify_attempts"},{"line_number":342,"context_line":"    for attempt in range(attempts):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7d0cb841","line":339,"in_reply_to":"7faddb67_bd9f90b1","updated":"2019-08-30 09:13:44.000000000","message":"Just for my information, can\u0027t we deprecate/rename this config option right away rather than adding TODO.","commit_id":"713f806da858259c30d39c7ebddb00803c771479"}]}