)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"e0e4e6bf332b48689d5fbfdc6c171ee47699f080","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        utils.execute(\u0027partprobe\u0027, device, run_as_root\u003dTrue,"},{"line_number":816,"context_line":"                      attempts\u003dCONF.disk_utils.partprobe_attempts)"},{"line_number":817,"context_line":"        # Also verify that the partitioning is correct now."},{"line_number":818,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-v\u0027, device, run_as_root\u003dTrue)"},{"line_number":819,"context_line":"    except processutils.ProcessExecutionError as exc:"},{"line_number":820,"context_line":"        LOG.warning(\u0027Failed to verify partitioning after creating \u0027"},{"line_number":821,"context_line":"                    \u0027partition(s): %s\u0027, exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_edcd805e","line":818,"updated":"2019-08-28 08:06:28.000000000","message":"this sgdisk call will only succeed in the gpt partition table case (looks like it exits 1 in the mbr case), won\u0027t it ? However, from create_config_drive_partition code, the mbr code is supported, and _trigger_device_rescan is called in a mbr/gpt mutual code part","commit_id":"a8b84e8b7f35e6968aa3c5a176d0ca0d878a60a4"},{"author":{"_account_id":15064,"name":"raphael.glon","email":"raphael.glon@corp.ovh.com","username":"raphael"},"change_message_id":"6c82d96a58769c4188379114d1569a3b2f1452e5","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        utils.execute(\u0027partprobe\u0027, device, run_as_root\u003dTrue,"},{"line_number":816,"context_line":"                      attempts\u003dCONF.disk_utils.partprobe_attempts)"},{"line_number":817,"context_line":"        # Also verify that the partitioning is correct now."},{"line_number":818,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-v\u0027, device, run_as_root\u003dTrue)"},{"line_number":819,"context_line":"    except processutils.ProcessExecutionError as exc:"},{"line_number":820,"context_line":"        LOG.warning(\u0027Failed to verify partitioning after creating \u0027"},{"line_number":821,"context_line":"                    \u0027partition(s): %s\u0027, exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_35775e0b","line":818,"in_reply_to":"7faddb67_487042a5","updated":"2019-08-28 12:38:14.000000000","message":"Right, my bad, warning out but the code still exits 0","commit_id":"a8b84e8b7f35e6968aa3c5a176d0ca0d878a60a4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"104a64667f598d0c2c95f9f52d39a2b852b0104d","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        utils.execute(\u0027partprobe\u0027, device, run_as_root\u003dTrue,"},{"line_number":816,"context_line":"                      attempts\u003dCONF.disk_utils.partprobe_attempts)"},{"line_number":817,"context_line":"        # Also verify that the partitioning is correct now."},{"line_number":818,"context_line":"        utils.execute(\u0027sgdisk\u0027, \u0027-v\u0027, device, run_as_root\u003dTrue)"},{"line_number":819,"context_line":"    except processutils.ProcessExecutionError as exc:"},{"line_number":820,"context_line":"        LOG.warning(\u0027Failed to verify partitioning after creating \u0027"},{"line_number":821,"context_line":"                    \u0027partition(s): %s\u0027, exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_487042a5","line":818,"in_reply_to":"7faddb67_edcd805e","updated":"2019-08-28 08:36:58.000000000","message":"Seems to work for me:\n\n sudo sgdisk -v /dev/sda\n\n ***************************************************************\n Found invalid GPT and valid MBR; converting MBR to GPT format\nin memory. \n ***************************************************************\n\n\n No problems found. 2029 free sectors (1014.5 KiB) available in 2\n segments, the largest of which is 2014 (1007.0 KiB) in size.","commit_id":"a8b84e8b7f35e6968aa3c5a176d0ca0d878a60a4"}]}