)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b3b59f144045e8e49315b18ed36a32d10528c2fa","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"},{"line_number":52,"context_line":"               default\u003d\u00271M\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Block size to use when writing to the nodes disk.\u0027),"},{"line_number":54,"context_line":"    # TODO(dtantsur): remove in Ussuri, then clean up ironic from it."},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027iscsi_verify_attempts\u0027,"},{"line_number":56,"context_line":"               default\u003d3,"},{"line_number":57,"context_line":"               help\u003d\u0027Maximum attempts to verify an iSCSI connection is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b263d218","side":"PARENT","line":54,"updated":"2020-01-10 03:36:39.000000000","message":"do we have a patch up for this clean up?","commit_id":"b849d0ff4241cad4e63d0e2075496b1a61b7abae"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7ccc252c80c1ed9e2731e61f01ff217c7d8ac400","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    cfg.StrOpt(\u0027dd_block_size\u0027,"},{"line_number":52,"context_line":"               default\u003d\u00271M\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Block size to use when writing to the nodes disk.\u0027),"},{"line_number":54,"context_line":"    # TODO(dtantsur): remove in Ussuri, then clean up ironic from it."},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027iscsi_verify_attempts\u0027,"},{"line_number":56,"context_line":"               default\u003d3,"},{"line_number":57,"context_line":"               help\u003d\u0027Maximum attempts to verify an iSCSI connection is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_587cffe8","side":"PARENT","line":54,"in_reply_to":"3fa7e38b_b263d218","updated":"2020-01-10 09:03:27.000000000","message":"added https://review.opendev.org/701908","commit_id":"b849d0ff4241cad4e63d0e2075496b1a61b7abae"}],"releasenotes/notes/remove-iscsi-verify-attempts-ff9eb5b7a28e6143.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"badad6accb53b03c7a51ea53d08741ec99921397","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option ``[disk_utils]iscsi_verify_attempts was"},{"line_number":5,"context_line":"    deprecated and now removed, please use"},{"line_number":6,"context_line":"    ``[disk_utils]partition_detection_attempts`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9925d95d","line":5,"updated":"2020-01-06 20:30:58.000000000","message":"I like it when we mention when something was deprecated. For my own interest, I need to know. The release note for this deprecation was done 4 months ago (https://review.opendev.org/#/c/679792/) so we\u0027re good with removing it.","commit_id":"e9d47e8dd7d228c802d6b8aa386d8f0c7accf863"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"43b34edf29e8e4844f6306bc3d440880f50fe597","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option ``[disk_utils]iscsi_verify_attempts was"},{"line_number":5,"context_line":"    deprecated and now removed, please use"},{"line_number":6,"context_line":"    ``[disk_utils]partition_detection_attempts`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f75dd8eb","line":5,"in_reply_to":"3fa7e38b_9925d95d","updated":"2020-01-08 16:27:49.000000000","message":"I will add a note saying that was deprecated in Train.","commit_id":"e9d47e8dd7d228c802d6b8aa386d8f0c7accf863"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"badad6accb53b03c7a51ea53d08741ec99921397","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option ``[disk_utils]iscsi_verify_attempts was"},{"line_number":5,"context_line":"    deprecated and now removed, please use"},{"line_number":6,"context_line":"    ``[disk_utils]partition_detection_attempts`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f913ad00","line":6,"updated":"2020-01-06 20:30:58.000000000","message":"wonder if we should mention that the default is now 3.","commit_id":"e9d47e8dd7d228c802d6b8aa386d8f0c7accf863"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"43b34edf29e8e4844f6306bc3d440880f50fe597","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option ``[disk_utils]iscsi_verify_attempts was"},{"line_number":5,"context_line":"    deprecated and now removed, please use"},{"line_number":6,"context_line":"    ``[disk_utils]partition_detection_attempts`` instead."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d7569ccd","line":6,"in_reply_to":"3fa7e38b_f913ad00","updated":"2020-01-08 16:27:49.000000000","message":"Don\u0027t think it\u0027s necessary, the default for the old option was also 3.","commit_id":"e9d47e8dd7d228c802d6b8aa386d8f0c7accf863"}]}