)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6b3a74c52581ca85e26aa15187a2b63a52a30bd1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               default\u003d10,"},{"line_number":60,"context_line":"               help\u003d\u0027Maximum number of attempts to try to read the \u0027"},{"line_number":61,"context_line":"                    \u0027partition.\u0027),"},{"line_number":62,"context_line":"    cfg.IntOpt(\u0027image_convert_address_space_limit\u0027,"},{"line_number":63,"context_line":"               default\u003d1024,"},{"line_number":64,"context_line":"               help\u003d\u0027Address space RLIMIT for qemu-img in MiB\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027image_convert_retries\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_2ea8d11d","line":62,"updated":"2020-05-11 10:05:45.000000000","message":"Maybe. RLIMIT also supports RSS, so I guess I\u0027ll need to keep the clarification in the message","commit_id":"0c83ed921aab124be9e7a8e04dd291436a753b94"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ecc5743451c5181a4dc35b0bf01f74d4af9dc610","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               default\u003d10,"},{"line_number":60,"context_line":"               help\u003d\u0027Maximum number of attempts to try to read the \u0027"},{"line_number":61,"context_line":"                    \u0027partition.\u0027),"},{"line_number":62,"context_line":"    cfg.IntOpt(\u0027image_convert_address_space_limit\u0027,"},{"line_number":63,"context_line":"               default\u003d1024,"},{"line_number":64,"context_line":"               help\u003d\u0027Address space RLIMIT for qemu-img in MiB\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027image_convert_retries\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_ce20434d","line":62,"range":{"start_line":62,"start_character":30,"end_line":62,"end_character":43},"updated":"2020-05-09 00:59:57.000000000","message":"maybe change to memory?\naddress space seems too developer oriented.","commit_id":"0c83ed921aab124be9e7a8e04dd291436a753b94"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ecc5743451c5181a4dc35b0bf01f74d4af9dc610","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                          use_standard_locale\u003dTrue)"},{"line_number":402,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":403,"context_line":"            if (\u0027Resource temporarily unavailable\u0027 in e.stderr"},{"line_number":404,"context_line":"                    and attempt !\u003d CONF.disk_utils.image_convert_retries - 1):"},{"line_number":405,"context_line":"                LOG.debug(\u0027Failed to convert image, retrying. Error: %s\u0027, e)"},{"line_number":406,"context_line":"                # Sync disk caches before the next attempt"},{"line_number":407,"context_line":"                utils.execute(\u0027sync\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_ee1707ed","line":404,"range":{"start_line":404,"start_character":32,"end_line":404,"end_character":77},"updated":"2020-05-09 00:59:57.000000000","message":"Can be just attempt \u003c CONF.disk_utils.image_convert_retries","commit_id":"0c83ed921aab124be9e7a8e04dd291436a753b94"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3479958ab166263ed2d84f6609bafbda21de2308","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                    and attempt \u003c CONF.disk_utils.image_convert_attempts - 1):"},{"line_number":406,"context_line":"                LOG.debug(\u0027Failed to convert image, retrying. Error: %s\u0027, e)"},{"line_number":407,"context_line":"                # Sync disk caches before the next attempt"},{"line_number":408,"context_line":"                utils.execute(\u0027sync\u0027)"},{"line_number":409,"context_line":"            else:"},{"line_number":410,"context_line":"                raise"},{"line_number":411,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_1647cd1f","line":408,"range":{"start_line":408,"start_character":16,"end_line":408,"end_character":37},"updated":"2020-05-12 08:04:48.000000000","message":"I wonder why it is needed for a failed attempt? Also we didn\u0027t sync after a successful conversion.","commit_id":"555c4948dc271ab882525d030303b3eca83585dd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"313577c1521ad355740682cab3fc3c209903beb4","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                    and attempt \u003c CONF.disk_utils.image_convert_attempts - 1):"},{"line_number":406,"context_line":"                LOG.debug(\u0027Failed to convert image, retrying. Error: %s\u0027, e)"},{"line_number":407,"context_line":"                # Sync disk caches before the next attempt"},{"line_number":408,"context_line":"                utils.execute(\u0027sync\u0027)"},{"line_number":409,"context_line":"            else:"},{"line_number":410,"context_line":"                raise"},{"line_number":411,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_71745336","line":408,"range":{"start_line":408,"start_character":16,"end_line":408,"end_character":37},"in_reply_to":"ff570b3c_1647cd1f","updated":"2020-05-12 09:04:07.000000000","message":"It was suggested by Julia (on IRC) to try syncing caches to free up some usable memory for the next attempt.","commit_id":"555c4948dc271ab882525d030303b3eca83585dd"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"39c7b76546815aeb2722529e6e1a79876c5bd5a5","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                    and attempt \u003c CONF.disk_utils.image_convert_attempts - 1):"},{"line_number":406,"context_line":"                LOG.debug(\u0027Failed to convert image, retrying. Error: %s\u0027, e)"},{"line_number":407,"context_line":"                # Sync disk caches before the next attempt"},{"line_number":408,"context_line":"                utils.execute(\u0027sync\u0027)"},{"line_number":409,"context_line":"            else:"},{"line_number":410,"context_line":"                raise"},{"line_number":411,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_8a0a8923","line":408,"range":{"start_line":408,"start_character":16,"end_line":408,"end_character":37},"in_reply_to":"ff570b3c_71745336","updated":"2020-05-12 13:47:14.000000000","message":"make sense","commit_id":"555c4948dc271ab882525d030303b3eca83585dd"}]}