)]}'
{"id":"openstack%2Fironic-lib~774914","triplet_id":"openstack%2Fironic-lib~master~I424d04adb6ccbb3daa99daa5c860cbb81332c02e","project":"openstack/ironic-lib","branch":"master","topic":"find-efi","hashtags":[],"change_id":"I424d04adb6ccbb3daa99daa5c860cbb81332c02e","subject":"Add find_efi_partition, deprecate get_uefi_disk_identifier","status":"MERGED","created":"2021-02-10 17:54:53.000000000","updated":"2021-02-22 15:25:31.000000000","submitted":"2021-02-18 06:52:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"774914-find-efi","meta_rev_id":"1acb0417e8fed1e0e1635a9ba9f6ef945c66dc5b","_number":774914,"virtual_id_number":774914,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-18 06:52:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":2,"date":"2021-02-18 05:13:12.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2021-02-17 02:29:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":1,"date":"2021-02-18 05:13:12.000000000","_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-10 20:31:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-17 02:29:34.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2021-02-18 05:13:12.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"}],"messages":[{"id":"560c2ff7101e35d97cacad9f514886942994df19","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-02-10 17:54:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6a865400f57e7acb1d78d3511239f8c515357a69","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-02-10 18:00:26.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"7907e11c43c6d799c12a7927713cb8a30fa7b2af","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-02-10 18:38:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"99a832af3cc96b43efa818bb9ea13235d3bfa3cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-02-10 18:54:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d037556e321865f779c146b920b82c385d9a7eb0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 20:31:23.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/23074085dc5d4cd0b27a9093694a16dd : FAILURE in 4m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/78db48b832a44b428d549d07a411f9b5 : SUCCESS in 3m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bdfbd40494fe4820923c2c834d11aae7 : FAILURE in 3m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8b49b9102596471da489cc7a6672be4f : FAILURE in 4m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/654694ff185244d0b5953a96b9bec340 : FAILURE in 3m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e2d1d969fe87450481aa020f76c03ba1 : SUCCESS in 10m 51s\n- ironic-lib-wholedisk-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/cf326e122da44513b917a2fefc5a699a : SUCCESS in 1h 18m 50s\n- ironic-lib-partition-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/107527b6fbe24df5900af45beab540a6 : SUCCESS in 1h 17m 35s\n- ironic-lib-partition-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/b9dfc58a45c6491080ef7dedab0cbc13 : SUCCESS in 1h 15m 38s\n- ironic-lib-wholedisk-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/af8c0f347c634ae0933d5b451edfc317 : SUCCESS in 1h 29m 32s","accounts_in_message":[],"_revision_number":3},{"id":"1c7dd381c6ecf5cbf79a3cbf511271bb7264db9d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-02-11 17:09:17.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"c6c15221221ca31c70e140edd29d5d1937684397","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-11 18:39:01.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/01fcc6eed4f34cb984be94a4e32d07ee : SUCCESS in 8m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/036b66553f4344d391ad20f8e1ee7c72 : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c521edd58c0145e89783112746d5c433 : SUCCESS in 6m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/08c2871095244eac86fa4b99fad8931e : SUCCESS in 4m 25s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1647c49e30a1406fbf8c8ccb470881f0 : SUCCESS in 4m 19s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab6998bcf002475490c48a665ec664f2 : SUCCESS in 6m 52s\n- ironic-lib-wholedisk-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/adbdb333a8274e83aa3c6e9e7716f7ec : SUCCESS in 1h 16m 25s\n- ironic-lib-partition-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/283fc77a59844be282ed773fa42e3170 : SUCCESS in 1h 22m 21s\n- ironic-lib-partition-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/2fa221d4d3f447ee8543b792b58b1102 : SUCCESS in 1h 11m 34s\n- ironic-lib-wholedisk-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/b11c3608a6e748ad92b286ce563d6bdd : SUCCESS in 1h 14m 45s","accounts_in_message":[],"_revision_number":4},{"id":"291926ddddf98205e8ee4d5865b06078ff797226","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2021-02-16 14:58:59.000000000","message":"Hashtag added: ironic-week-prio","accounts_in_message":[],"_revision_number":4},{"id":"57b9178c1bce1f75b05966729855578e4055a05f","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2021-02-17 02:29:34.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"b427c1628835c4c05b13531c4bd9ce6475fe2e2d","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2021-02-18 05:13:12.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nThank you Dmitry.","accounts_in_message":[],"_revision_number":4},{"id":"05b2a034373a425255aa593f9822f89268ed75c4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 05:13:25.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"5e3bfbaf3d5e1d20f7091afa006461d2d10cef82","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 06:52:29.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/872dc5d832f24279ab7c17f7c7ee9c9f : SUCCESS in 3m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5052777e4315449b8bdf478b9e073966 : SUCCESS in 3m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e01c20f6566b487ba1cf59cc13c8116d : SUCCESS in 3m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a0989056b47a455ca6274c2a28c3c62a : SUCCESS in 5m 43s\n- ironic-lib-wholedisk-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/68426715d9c24c358838c0355d0ab835 : SUCCESS in 1h 23m 33s\n- ironic-lib-partition-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/40bd9fd4df8c475dbeaf5a8809d0ffc0 : SUCCESS in 1h 21m 38s\n- ironic-lib-partition-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/7a158d1391da4c7dbdd79bc4a0c3a9eb : SUCCESS in 1h 21m 53s\n- ironic-lib-wholedisk-bios-ipmi-iscsi-src https://zuul.opendev.org/t/openstack/build/5f1e92e1e13640d8b3ee4c2c36435211 : SUCCESS in 1h 32m 58s","accounts_in_message":[],"_revision_number":4},{"id":"d2ae02a5e679fdb11e55f3772f748963903d3684","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 06:52:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"defe49db4ae3c9ee61885b08f9cc907588e61ef9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 06:53:53.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2de3d2cb40694993b5d955c2a07d1520 : SUCCESS in 58s","accounts_in_message":[],"_revision_number":4},{"id":"1acb0417e8fed1e0e1635a9ba9f6ef945c66dc5b","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-02-22 15:25:31.000000000","message":"Hashtag removed: ironic-week-prio","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c2786caa1ba9ba5aa9cae2133299554b0a1368a7","revisions":{"62df72fa646f5184a0aba287436beca99693ab64":{"kind":"REWORK","_number":1,"created":"2021-02-10 17:54:53.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/14/774914/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/14/774914/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/1"}}},"commit":{"parents":[{"commit":"7fa890fb01f7f7f716070d4b59ec5e70ed336fbc","subject":"Merge \"Get rid of oslo.serialization\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/7fa890fb01f7f7f716070d4b59ec5e70ed336fbc"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 17:51:34.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 17:54:30.000000000","tz":60},"subject":"Add find_efi_partition, deprecate get_uefi_disk_identifier","message":"Add find_efi_partition, deprecate get_uefi_disk_identifier\n\nThe get_uefi_disk_identifier function is currently unused in both\nironic and IPA. Furthermore, its name is confusing: it returns\nthe UEFI partition UUID, not the disk identifier, unlike the\nsimilarly named get_disk_identifier.\n\nThis change imports get_efi_part_on_device from IPA as\nfind_efi_partition. The only difference is that it returns\na complete partition record rather than only the number.\n\nAs a dependency, scan_partition_table_type\nis imported under the name get_partition_table_type.\nThe new version returns None instead of \u0027unknown\u0027.\n\nChange-Id: I424d04adb6ccbb3daa99daa5c860cbb81332c02e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/62df72fa646f5184a0aba287436beca99693ab64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/62df72fa646f5184a0aba287436beca99693ab64"}]},"branch":"refs/heads/master"},"f8c7e76e3312026222a4c7dd90c0747677d1225f":{"kind":"REWORK","_number":2,"created":"2021-02-10 18:38:49.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/14/774914/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/14/774914/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/2"}}},"commit":{"parents":[{"commit":"7fa890fb01f7f7f716070d4b59ec5e70ed336fbc","subject":"Merge \"Get rid of oslo.serialization\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/7fa890fb01f7f7f716070d4b59ec5e70ed336fbc"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 17:51:34.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 18:38:21.000000000","tz":60},"subject":"[WIP] Clean up partition functions in disk_utils","message":"[WIP] Clean up partition functions in disk_utils\n\nThe get_uefi_disk_identifier function is currently unused in both\nironic and IPA. Furthermore, its name is confusing: it returns\nthe UEFI partition UUID, not the disk identifier, unlike the\nsimilarly named get_disk_identifier.\n\nThis change imports get_efi_part_on_device from IPA as\nfind_efi_partition. The only difference is that it returns\na complete partition record rather than only the number.\n\nA new public function is added to fetch information from blkid.\nA new get_partition_table_type call is implemented using it.\n\nChange-Id: I424d04adb6ccbb3daa99daa5c860cbb81332c02e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/f8c7e76e3312026222a4c7dd90c0747677d1225f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/f8c7e76e3312026222a4c7dd90c0747677d1225f"}]},"branch":"refs/heads/master"},"585b314b51d9b1bf7d916db8e82a84920a13dd07":{"kind":"REWORK","_number":3,"created":"2021-02-10 18:54:48.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/14/774914/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/14/774914/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/3"}}},"commit":{"parents":[{"commit":"dd9224b7e47449eddbf80c5e80eee3231b969d20","subject":"[WIP] Split out a common helper for blkid","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/dd9224b7e47449eddbf80c5e80eee3231b969d20"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 17:51:34.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 18:54:37.000000000","tz":60},"subject":"Add find_efi_partition, deprecate get_uefi_disk_identifier","message":"Add find_efi_partition, deprecate get_uefi_disk_identifier\n\nThe get_uefi_disk_identifier function is currently unused in both\nironic and IPA. Furthermore, its name is confusing: it returns\nthe UEFI partition UUID, not the disk identifier, unlike the\nsimilarly named get_disk_identifier.\n\nThis change imports get_efi_part_on_device from IPA as\nfind_efi_partition. The only difference is that it returns\na complete partition record rather than only the number.\n\nChange-Id: I424d04adb6ccbb3daa99daa5c860cbb81332c02e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/585b314b51d9b1bf7d916db8e82a84920a13dd07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/585b314b51d9b1bf7d916db8e82a84920a13dd07"}]},"branch":"refs/heads/master"},"c2786caa1ba9ba5aa9cae2133299554b0a1368a7":{"kind":"REWORK","_number":4,"created":"2021-02-11 17:09:17.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/14/774914/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/14/774914/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/14/774914/4"}}},"commit":{"parents":[{"commit":"97affbf5967735fae2077b8dd35a9a1b03a9873b","subject":"Split out a common helper for blkid","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/97affbf5967735fae2077b8dd35a9a1b03a9873b"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-10 17:51:34.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2021-02-11 17:08:12.000000000","tz":60},"subject":"Add find_efi_partition, deprecate get_uefi_disk_identifier","message":"Add find_efi_partition, deprecate get_uefi_disk_identifier\n\nThe get_uefi_disk_identifier function is currently unused in both\nironic and IPA. Furthermore, its name is confusing: it returns\nthe UEFI partition UUID, not the disk identifier, unlike the\nsimilarly named get_disk_identifier.\n\nThis change imports get_efi_part_on_device from IPA as\nfind_efi_partition. The only difference is that it returns\na complete partition record rather than only the number.\n\nChange-Id: I424d04adb6ccbb3daa99daa5c860cbb81332c02e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/c2786caa1ba9ba5aa9cae2133299554b0a1368a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/c2786caa1ba9ba5aa9cae2133299554b0a1368a7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}