)]}'
{"id":"openstack%2Fironic-lib~776936","triplet_id":"openstack%2Fironic-lib~stable%2Fussuri~Ie9809b3e4fe2bea6b66ee95c442111942e85d618","project":"openstack/ironic-lib","branch":"stable/ussuri","hashtags":[],"change_id":"Ie9809b3e4fe2bea6b66ee95c442111942e85d618","subject":"Handle EBRs and tiny partitions when removing metadata","status":"MERGED","created":"2021-02-22 13:51:17.000000000","updated":"2021-02-23 17:23:18.000000000","submitted":"2021-02-23 17:21:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"776936","meta_rev_id":"75bb86bcfbd809242d96a13daf37e3b3c7e5af94","_number":776936,"virtual_id_number":776936,"owner":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-23 17:21:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2021-02-22 13:56:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-23 15:48:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-02-23 15:48:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-22 13:56:39.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2021-02-22 15:19:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-23 15:48:24.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"8e382179e3718b78804a768edf2f548d1942120e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"date":"2021-02-22 13:51:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ad090be7d05cfc2eaf2af59fda2a6b09445c42e","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-02-22 13:56:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7f244c60e5f6aad7cb1ab5db668df4744db7f2fe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-22 15:19:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/47afe27015784eb7b10565a7409d01aa : SUCCESS in 4m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0fbb50fe58c646169a5d5e74ccd3aba6 : SUCCESS in 4m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3f99f6265db74238a1176af37bc46be1 : SUCCESS in 4m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/62f05a32015c4f608182a485a2a1a3e3 : SUCCESS in 4m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b9c45b7f3084ce4bf94ee4cda212e94 : SUCCESS in 6m 05s\n- ironic-lib-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/0fc32fc5999843d1909e337fa44d0636 : SUCCESS in 1h 05m 02s\n- ironic-lib-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/ba8d7717c67641ef9a82dbdb30791eec : SUCCESS in 1h 24m 25s\n- ironic-lib-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/c416f382702b49afb7317bc06e4bc166 : SUCCESS in 1h 24m 09s\n- ironic-lib-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/23f6457eaeb6435fa1f9f4623eccb2c6 : SUCCESS in 59m 46s","accounts_in_message":[],"_revision_number":1},{"id":"522906ef33731777a57442eba710244c9c1a9376","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-02-23 15:48:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a5ffe25d901784a5db9dd623362b649e791e682b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 15:48:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e64994745fe9f98ed2e18febdff0faa7d2c772f9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 17:21:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9038cccfd0744d1a9e15f4154f1dd73d : SUCCESS in 3m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9f6536b9f74d463393406eebe103be5c : SUCCESS in 4m 57s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/26d85211eee74a6dbd355a8d7a3c728a : SUCCESS in 4m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/871dee1b1b3041b5a0d3805e975ca5d3 : SUCCESS in 5m 58s\n- ironic-lib-wholedisk-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/7503e110a7204c1f9231cbcd265a528f : SUCCESS in 1h 13m 17s\n- ironic-lib-partition-bios-ipmi-direct-tinyipa-src https://zuul.opendev.org/t/openstack/build/3f8d3d905f8a4aaeabfdfe4164d5813a : SUCCESS in 1h 09m 31s\n- ironic-lib-partition-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/20244dd846974800b16a3c4594eb22be : SUCCESS in 1h 05m 35s\n- ironic-lib-wholedisk-bios-ipmi-iscsi-tinyipa-src https://zuul.opendev.org/t/openstack/build/b161fee30b1c454c826f26564aa14543 : SUCCESS in 1h 29m 44s","accounts_in_message":[],"_revision_number":1},{"id":"e4b29285696171a72c6431090db678c784cc78a3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 17:21:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"75bb86bcfbd809242d96a13daf37e3b3c7e5af94","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 17:23:18.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5873a32436ae4e3f8dff11c803ea44b8 : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d2e477d39638d3fa9230e16f93b6a7c48092e365","revisions":{"d2e477d39638d3fa9230e16f93b6a7c48092e365":{"kind":"REWORK","_number":1,"created":"2021-02-22 13:51:17.000000000","uploader":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"ref":"refs/changes/36/776936/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/36/776936/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/36/776936/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/36/776936/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/36/776936/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/36/776936/1"}}},"commit":{"parents":[{"commit":"5d37bf431f9bf3bd391161bc8c50c28ff811cfbe","subject":"Merge \"Fix other out of memory error for qemu-img convert\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/5d37bf431f9bf3bd391161bc8c50c28ff811cfbe"}]}],"author":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2021-01-20 18:03:07.000000000","tz":60},"committer":{"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","date":"2021-02-22 13:49:53.000000000","tz":60},"subject":"Handle EBRs and tiny partitions when removing metadata","message":"Handle EBRs and tiny partitions when removing metadata\n\nExtended boot records (EBRs) are used in the MSDOS partitioning\nscheme to manage extended partitions. EBRs are small partitions\nthemselves and Ironic will therefore treat them like any other\npartition during cleaning. Since EBRs are smaller than a GPT\n(33 sectors), dd\u0027ing 33 sectors will fail. This patch proposes\na fix to handle EBRs (and other tiny paritions) by adjusting\nthe number of blocks writtent to be the partition size at max.\n\nStory: #2008539\nTask: #41628\nChange-Id: Ie9809b3e4fe2bea6b66ee95c442111942e85d618\n(cherry picked from commit 9a60d3853fc5b36cd3715e9419568cc9c51f5a8e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/d2e477d39638d3fa9230e16f93b6a7c48092e365"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/d2e477d39638d3fa9230e16f93b6a7c48092e365"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}