)]}'
{"id":"openstack%2Fironic-lib~799664","triplet_id":"openstack%2Fironic-lib~master~I4c9bdbccb9345e2259ddb0737f37c09d99dd1c4f","project":"openstack/ironic-lib","branch":"master","topic":"qemu-img-info-json","hashtags":[],"change_id":"I4c9bdbccb9345e2259ddb0737f37c09d99dd1c4f","subject":"Use the json format output of qemu-img info","status":"MERGED","created":"2021-07-06 12:58:02.000000000","updated":"2021-07-07 15:05:48.000000000","submitted":"2021-07-07 15:04:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"799664-qemu-img-info-json","meta_rev_id":"837cdb70c985a28ab2582a0561ad43c3eccc8a1d","_number":799664,"virtual_id_number":799664,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-07 15:04:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2021-07-07 13:25:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-07-06 15:55:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2021-07-07 13:25:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-06 14:42:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-06 15:02:25.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2021-07-07 13:25:31.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"4a96700a0d2ce5b7d95f4b875451f68cca104c53","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-06 12:58:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"454a2b855e4bc382af77ae4aea3d405859803076","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-06 14:42:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c9f37bf6968a4873a832d12dc8b3ce01 : SUCCESS in 5m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/55c3a5ed559e4b5690da877ba47dec46 : SUCCESS in 4m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/028c8a0b855e44ceb5289fe53c184747 : SUCCESS in 4m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d0b8e60c3b7e4478ae0627acb072c663 : SUCCESS in 4m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6fc78ae5a1a142bd82a9373099730e69 : SUCCESS in 4m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a7dee560e84b44d38f803b589b0a4adc : SUCCESS in 6m 09s\n- ironic-lib-wholedisk-bios-ipmi-src https://zuul.opendev.org/t/openstack/build/bd5ae55dd1804d56befdfc9e48b2a532 : FAILURE in 1h 12m 29s\n- ironic-lib-partition-bios-ipmi-src https://zuul.opendev.org/t/openstack/build/22ae2583af3845edabde02eb7387022f : FAILURE in 1h 43m 26s","accounts_in_message":[],"_revision_number":1},{"id":"23fb6a247db5d50c85c0a0c5684c05d287d0b09b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-07-06 15:02:25.000000000","message":"Patch Set 1: Code-Review-1\n\nI think we have to keep it because of CentOS 7 compatibility.","accounts_in_message":[],"_revision_number":1},{"id":"26b600c5f2fe61bc58a44f4d94d3eea313d3121b","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-06 15:37:00.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e I think we have to keep it because of CentOS 7 compatibility.\n\nThe format parameter of qemu-img command is available since 1.5.0.\n https://github.com/qemu/qemu/commit/8599ea4c42c098d2657ed632ad569f7a665706a4\n\nAnd CentOS7 provides qemu-img 1.5.3.\n https://rpmfind.net/linux/rpm2html/search.php?query\u003dqemu-img\u0026submit\u003dSearch+...\u0026system\u003dcentos\u0026arch\u003d\n\nSo this is compatible with CentOS7.","accounts_in_message":[],"_revision_number":1},{"id":"c2eaeb92dee2d0c87c77327bd377fb1634999297","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-06 15:41:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"43663b43f686941009b181bc68c51cd537d78e32","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-07-06 15:42:17.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e The format parameter of qemu-img command is available since 1.5.0.\n\nSorry but I intended the \"output\" option instead.","accounts_in_message":[],"_revision_number":2},{"id":"371e82021764473afd49abdb352fd762b203ecdf","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-07-06 15:55:10.000000000","message":"Patch Set 2: Code-Review+2\n\nSeems like you\u0027re right, let\u0027s see what the CI says.","accounts_in_message":[],"_revision_number":2},{"id":"d7c01be4e318f87422bf888aee6465422fc1966d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-06 17:12:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/222d0ae01e4c4b61b4209f18282d9aa7 : SUCCESS in 5m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8fe7f08bc4e0464e845cb54f8aeff1e6 : SUCCESS in 4m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d3defbb1361644aa91f19d88d29d13d6 : SUCCESS in 5m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a78ae68ba7a24ae8822ee7684c48313b : SUCCESS in 4m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/1ef78823c7a5443a8c8e9971c80e64a7 : SUCCESS in 8m 12s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bdcbf4bbddb64180981db9498cb8d30c : SUCCESS in 11m 28s\n- ironic-lib-wholedisk-bios-ipmi-src https://zuul.opendev.org/t/openstack/build/8e2ff776b61c4ad7b248399199378e16 : SUCCESS in 1h 28m 25s\n- ironic-lib-partition-bios-ipmi-src https://zuul.opendev.org/t/openstack/build/2e50d15357634e98977e8401d69455f4 : SUCCESS in 1h 30m 24s","accounts_in_message":[],"_revision_number":2},{"id":"d7a632634b74b40ed36f62c4bd5c95679682b599","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2021-07-07 13:25:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6c64c56b27d53ffedeba681ac83aea23d991594e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-07 13:25:54.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ecf00a1c59f7f4a66109f87513970adf92d6f0c0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-07 15:04:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/984a713b1fcc4e91ad8cc3b35d6e6660 : SUCCESS in 4m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/87a23e4a290141baace996d44377cb4a : SUCCESS in 4m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ada89a42c32949e9a651e8c66851e7a2 : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d259adb3704c49bf8ffe0b28fd3f1ed5 : SUCCESS in 6m 47s\n- ironic-lib-wholedisk-bios-ipmi-src https://zuul.opendev.org/t/openstack/build/a43346b810384a35a4a228f55d65fe35 : SUCCESS in 1h 33m 09s\n- ironic-lib-partition-bios-ipmi-src https://zuul.opendev.org/t/openstack/build/f9a4ae8d2f9f446caccaa21ac43f138d : SUCCESS in 1h 21m 56s","accounts_in_message":[],"_revision_number":2},{"id":"b5b6e0820658689c3abea24f0b5257cd299f87fb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-07 15:04:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"837cdb70c985a28ab2582a0561ad43c3eccc8a1d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-07 15:05:48.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6f93c4662b624536b58d3eb44c849e8d : SUCCESS in 1m 07s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d33cf3e0332da7be400fc769eb6f51b6d4e84575","revisions":{"a07f89eadf462874f7bba58dab62139a13427860":{"kind":"REWORK","_number":1,"created":"2021-07-06 12:58:02.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/64/799664/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/64/799664/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/1"}}},"commit":{"parents":[{"commit":"f7db05cc9d60d469377550459ae65f99f3506aaa","subject":"Update min version of tox to use allowlist","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/f7db05cc9d60d469377550459ae65f99f3506aaa"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-07-06 12:57:18.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-07-06 12:58:00.000000000","tz":540},"subject":"Use the json format output of qemu-img info","message":"Use the json format output of qemu-img info\n\nSupport for the human format by oslo_utils.imageutils.QemuImgInfo was\ndeprecated since oslo.utils 4.9.1 [1]. This change replaces the human\nformat with the json format which will be used by default.\n\n[1] 73eb0673f627aad382e08a816191b637af436465\n\nChange-Id: I4c9bdbccb9345e2259ddb0737f37c09d99dd1c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/a07f89eadf462874f7bba58dab62139a13427860"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/a07f89eadf462874f7bba58dab62139a13427860"}]},"branch":"refs/heads/master"},"d33cf3e0332da7be400fc769eb6f51b6d4e84575":{"kind":"REWORK","_number":2,"created":"2021-07-06 15:41:10.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/64/799664/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-lib","ref":"refs/changes/64/799664/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-lib refs/changes/64/799664/2"}}},"commit":{"parents":[{"commit":"f7db05cc9d60d469377550459ae65f99f3506aaa","subject":"Update min version of tox to use allowlist","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/f7db05cc9d60d469377550459ae65f99f3506aaa"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-07-06 12:57:18.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-07-06 15:41:00.000000000","tz":540},"subject":"Use the json format output of qemu-img info","message":"Use the json format output of qemu-img info\n\nSupport for the human format by oslo_utils.imageutils.QemuImgInfo was\ndeprecated since oslo.utils 4.9.1 [1]. This change replaces the human\nformat with the json format which will be used by default.\n\n[1] 73eb0673f627aad382e08a816191b637af436465\n\nChange-Id: I4c9bdbccb9345e2259ddb0737f37c09d99dd1c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/d33cf3e0332da7be400fc769eb6f51b6d4e84575"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-lib/commit/d33cf3e0332da7be400fc769eb6f51b6d4e84575"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}