)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"a152180aee99b371d6fe39ba4e1a1dd50e0a13da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c21ef774_6ca10dd7","updated":"2021-10-20 10:15:07.000000000","message":"recheck","commit_id":"b6416eee71b35d44b623cbef3d7df2a2935a9a54"}],"ironic_lib/disk_utils.py":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"81add3f705b1a83a742f0a22e3220a3025cd9a99","unresolved":true,"context_lines":[{"line_number":507,"context_line":"    stop\u003dtenacity.stop_after_attempt(CONF.disk_utils.image_convert_attempts),"},{"line_number":508,"context_line":"    reraise\u003dTrue)"},{"line_number":509,"context_line":"def convert_image(source, dest, out_format, run_as_root\u003dFalse, cache\u003dNone,"},{"line_number":510,"context_line":"                  out_of_order\u003dFalse, sparse_size\u003dNone):"},{"line_number":511,"context_line":"    \"\"\"Convert image to other format.\"\"\""},{"line_number":512,"context_line":"    cmd \u003d [\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format]"},{"line_number":513,"context_line":"    if cache is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f385234_f3937d52","line":510,"updated":"2021-09-14 16:05:15.000000000","message":"I\u0027m hoping to set this in IPA, not sure if changing the default would be preferred, depends on what else uses this function","commit_id":"3e109f00e80edccced53d1f9fe304e0eabae097f"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"8af696ab80a43d5ba55fc00913f9e01ed6d4ed9d","unresolved":true,"context_lines":[{"line_number":507,"context_line":"    stop\u003dtenacity.stop_after_attempt(CONF.disk_utils.image_convert_attempts),"},{"line_number":508,"context_line":"    reraise\u003dTrue)"},{"line_number":509,"context_line":"def convert_image(source, dest, out_format, run_as_root\u003dFalse, cache\u003dNone,"},{"line_number":510,"context_line":"                  out_of_order\u003dFalse, sparse_size\u003dNone):"},{"line_number":511,"context_line":"    \"\"\"Convert image to other format.\"\"\""},{"line_number":512,"context_line":"    cmd \u003d [\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format]"},{"line_number":513,"context_line":"    if cache is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ee25fcd_5903efdb","line":510,"in_reply_to":"2f43ea74_937cd0c2","updated":"2021-09-15 15:04:26.000000000","message":"\u003e For spinning disks, we\u0027re reliant upon the disk being pre-cleaned and the filesystem not becoming corrupt..... That is the use risk which comes to mind.\n\nIf we were to set sparse_size\u003d0 (\"-S 0\" in qemu-img) then the entire image would be written to disk, including the zeros, AIUI we would not be relying on the disk to be clean. The only preexisting bits left untouched on the disk would be after the end of the image written the disk, wouldn\u0027t this be ok?","commit_id":"3e109f00e80edccced53d1f9fe304e0eabae097f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"957cf8ebd3077f68ff1e2b8b8dae3cb78f3712d2","unresolved":true,"context_lines":[{"line_number":507,"context_line":"    stop\u003dtenacity.stop_after_attempt(CONF.disk_utils.image_convert_attempts),"},{"line_number":508,"context_line":"    reraise\u003dTrue)"},{"line_number":509,"context_line":"def convert_image(source, dest, out_format, run_as_root\u003dFalse, cache\u003dNone,"},{"line_number":510,"context_line":"                  out_of_order\u003dFalse, sparse_size\u003dNone):"},{"line_number":511,"context_line":"    \"\"\"Convert image to other format.\"\"\""},{"line_number":512,"context_line":"    cmd \u003d [\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-O\u0027, out_format]"},{"line_number":513,"context_line":"    if cache is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f43ea74_937cd0c2","line":510,"in_reply_to":"9f385234_f3937d52","updated":"2021-09-15 14:04:21.000000000","message":"If memory serves the conductor also uses this function, so having a behavior change here is not ideal, and I guess we woudl also run the risk of increasing conductor load.  Then again for sparse file ops, as long as we don\u0027t actually write a zero, we\u0027re good. For spinning disks, we\u0027re reliant upon the disk being pre-cleaned and the filesystem not becoming corrupt..... That is the use risk which comes to mind.","commit_id":"3e109f00e80edccced53d1f9fe304e0eabae097f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e35deb611d43bbfb1398e215d950f407d1dc70d8","unresolved":false,"context_lines":[{"line_number":548,"context_line":"    if data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":549,"context_line":"        dd(src, dst, conv_flags\u003dconv_flags)"},{"line_number":550,"context_line":"    else:"},{"line_number":551,"context_line":"        convert_image(src, dst, \u0027raw\u0027, True)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def block_uuid(dev):"}],"source_content_type":"text/x-python","patch_set":2,"id":"b67a20f4_56e22af2","line":551,"updated":"2021-09-20 13:00:32.000000000","message":"Update this maybe?","commit_id":"7a1aaf57b5b792b77de32d0863770cad3b3757fb"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"a16712e2937cd8d28cfa4b3b845dbb8801717953","unresolved":false,"context_lines":[{"line_number":548,"context_line":"    if data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":549,"context_line":"        dd(src, dst, conv_flags\u003dconv_flags)"},{"line_number":550,"context_line":"    else:"},{"line_number":551,"context_line":"        convert_image(src, dst, \u0027raw\u0027, True)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def block_uuid(dev):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b735f87_ecccb4ba","line":551,"in_reply_to":"b67a20f4_56e22af2","updated":"2021-09-23 08:00:14.000000000","message":"Will do, This isn\u0027t on the code path where I hit the bug but makes sense to do it here also","commit_id":"7a1aaf57b5b792b77de32d0863770cad3b3757fb"}]}