)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b3cd98df1552c9ec3a767928d9336da0a88f4b0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2491b809_e95aa4c5","updated":"2024-02-13 15:46:28.000000000","message":"Hey Adam,\n\nI, and it seems others, in IRC are a little worried by this change. Any chance we can get more details as to what exactly is driving this, because failing to wipe out metadata is a huge issue we need to understand and we can\u0027t just let that fail without consequence to the overall operation. Hence, the need to understand what is going on. Is there a bug we can review?\n\nThanks in advance!\n\n-Julia","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8da0b100b961910ba02d0d7266563b86ce9e2a60","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1cffde80_2afb7348","updated":"2024-02-13 15:49:18.000000000","message":"It\u0027ll take an incredibly strong use case and justification to make it OK to ignore failures on disk cleaning. In fact, I\u0027d suggest that most things that fail disk cleaning are unlikely to deploy in the future -- either due to the cleaning itself failing (leaving behind things on disk) or due to it seeing another error when deploying.\n\nPlease include some details (maybe a bug ticket?) with the exact cases you\u0027re running into. We should try to find alternative solutions -- I consider it a security risk to permit cleaning to fail silently.","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":35233,"name":"Adam Rozman","email":"adam.rozman@est.tech","username":"rozzix"},"change_message_id":"1dddea0dbdb09431fea37784e9a1e844409b45d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0957bb33_2808fcff","updated":"2024-02-13 09:18:09.000000000","message":"This branch is used for testing don\u0027t review jet!","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":35233,"name":"Adam Rozman","email":"adam.rozman@est.tech","username":"rozzix"},"change_message_id":"907da40bc22a8a253d476b1ec29fb846ad9d1d05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1fb996ff_cca7b380","in_reply_to":"1cffde80_2afb7348","updated":"2024-02-13 18:03:33.000000000","message":"I have no intention to change this code along the current logic, I needed a public branch to share code with some folks who have special hardware problems and I am investigating, that is why I put a -1 on the PR, tagged as a WIP and wrote a comment to please don\u0027t review it. It wasn\u0027t my intention to cause worry or to submit a half baked change without a bug ticket, I will put this info to the commit message also.\n\nSorry for the troubles!","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":35233,"name":"Adam Rozman","email":"adam.rozman@est.tech","username":"rozzix"},"change_message_id":"907da40bc22a8a253d476b1ec29fb846ad9d1d05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a63e73f_bff6f018","in_reply_to":"2491b809_e95aa4c5","updated":"2024-02-13 18:03:33.000000000","message":"Don\u0027t worry this was not a proposal neither a real feature I put -1 on it and it was taged as a draft, I assume something is wrong with gerrit because it has lost the WIP flag and if you check the history I set it to WIP I have also mentioned to please don\u0027t\n review it I will write a more detailed description. \n\nThe story of this PR is that I am investigation a wierd issue but I can\u0027t run the tests myself so I have made a draft PR and shared with the folks who has the hardware.\n\nI am sorry, It wasn\u0027t my intention to worry anyone.","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"324423daeedcad9b8478f065e18ee0a314e10bfc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70598beb_e0915ecc","in_reply_to":"6472020b_b59913b3","updated":"2024-02-16 17:21:51.000000000","message":"Any time you revise something, it drops all reviews *except* -2\u0027s.  Now worries!\n\nSo I\u0027m super curious as to what your seeing, maybe too many years running storage area networks! 😊","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":35233,"name":"Adam Rozman","email":"adam.rozman@est.tech","username":"rozzix"},"change_message_id":"344b63ae65c034097213dd62de0429fa2f655d5d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6472020b_b59913b3","in_reply_to":"7a63e73f_bff6f018","updated":"2024-02-13 18:30:17.000000000","message":"I guess it has lost my -1 and the WIP label because Zuul added a -1, I didn\u0027t know this works in such a way... 😞","commit_id":"28e15032779f98242e6291b2975952483115a1e8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2b724524a036a814f557ad1cb0b6afc787854205","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4242c0dd_ed96f43e","updated":"2024-02-13 21:00:53.000000000","message":"Don\u0027t worry Adam, we only put the -2 on it to make sure it didn\u0027t land. Also we\u0027re totally onboard to help support the weird hardware if we can figure out how to detect it (or even make a conditional skip).","commit_id":"4c437e99811978efd3abda932ee21ded299eaf49"}]}