)]}'
{"ironic_lib/disk_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"35a2e48f106834427209bb01d2e0f289b6c93c9a","unresolved":true,"context_lines":[{"line_number":505,"context_line":"    return image_mb"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def get_dev_block_size(dev):"},{"line_number":509,"context_line":"    \"\"\"Get the device size in 512 byte sectors.\"\"\""},{"line_number":510,"context_line":"    block_sz, cmderr \u003d utils.execute(\u0027blockdev\u0027, \u0027--getsz\u0027, dev,"},{"line_number":511,"context_line":"                                     run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3e88677_5792d29f","side":"PARENT","line":508,"updated":"2024-05-02 12:24:58.000000000","message":"Since this is a library, we cannot simply remove public API. Master works fine because it no longer uses this module, when you try to backport this change, it will break IPA immediately.\n\nLet\u0027s keep this one around. Can we calculate its value using the new functions? Like get_dev_byte_size() / get_dev_sector_size()?","commit_id":"11dc763c476a9761f1cebfacb78f1d4641b2dc90"},{"author":{"_account_id":36976,"name":"Tudor Domnescu","display_name":"Tudor Domnescu","email":"tdomnesc@redhat.com","username":"tdomnesc"},"change_message_id":"049b292133edd3a270d13fac9a3ffe4f6c7d4848","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    return image_mb"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"def get_dev_block_size(dev):"},{"line_number":509,"context_line":"    \"\"\"Get the device size in 512 byte sectors.\"\"\""},{"line_number":510,"context_line":"    block_sz, cmderr \u003d utils.execute(\u0027blockdev\u0027, \u0027--getsz\u0027, dev,"},{"line_number":511,"context_line":"                                     run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3c5cd70_c5231b7b","side":"PARENT","line":508,"in_reply_to":"f3e88677_5792d29f","updated":"2024-05-02 13:37:54.000000000","message":"Sorry, I wasn\u0027t thinking.\n\nWe could get the block size like that, but the function specifically got the device size in 512 byte sectors (man blocked --getsz Get size in 512-byte sectors) - so I restored it in the original form not break anybody relying on it just like that.","commit_id":"11dc763c476a9761f1cebfacb78f1d4641b2dc90"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0835d8e62d66cf78608f046c4ee308131fc8ab2","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    # be greater than or equal to 6"},{"line_number":565,"context_line":"    if sector_size \u003d\u003d 512:"},{"line_number":566,"context_line":"        gpt_sectors \u003d 33"},{"line_number":567,"context_line":"    elif sector_size \u003d\u003d 4096:"},{"line_number":568,"context_line":"        gpt_sectors \u003d 5"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    # Overwrite the Primary GPT, catch very small partitions (like EBRs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0204de48_cb7b7508","line":567,"updated":"2024-05-03 14:46:54.000000000","message":"I hope we never get any other sector sizes or this will end up with gpt_sectors undefined","commit_id":"571b074a101725b0bdd4eeb29c9366d635808ad2"},{"author":{"_account_id":36976,"name":"Tudor Domnescu","display_name":"Tudor Domnescu","email":"tdomnesc@redhat.com","username":"tdomnesc"},"change_message_id":"86694755a7e14fe325ea04fc38688b6918e34b24","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    # be greater than or equal to 6"},{"line_number":565,"context_line":"    if sector_size \u003d\u003d 512:"},{"line_number":566,"context_line":"        gpt_sectors \u003d 33"},{"line_number":567,"context_line":"    elif sector_size \u003d\u003d 4096:"},{"line_number":568,"context_line":"        gpt_sectors \u003d 5"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    # Overwrite the Primary GPT, catch very small partitions (like EBRs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4e35be81_71381f86","line":567,"in_reply_to":"0204de48_cb7b7508","updated":"2024-05-03 14:50:25.000000000","message":"The only sector sizes that exists for disks are 512 and 4096. Even GPT spec only has these.","commit_id":"571b074a101725b0bdd4eeb29c9366d635808ad2"}]}