)]}'
{"ironic_prometheus_exporter/parsers/ipmi.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07a9159501193b85770836a482dd11987e2a7504","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            e \u003d re.sub(r\u0027([\\d+]v)|([\\d+].[\\d*]v)\u0027, \u0027\u0027, entry.lower())"},{"line_number":87,"context_line":"            # NOTE (iurygregory): regex to remove all numbers"},{"line_number":88,"context_line":"            # e.g: \u0027Voltage 1 (0x6d)\u0027 will turn into [\u0027voltage\u0027, \u0027(xd)\u0027]"},{"line_number":89,"context_line":"            e \u003d re.sub(r\"[\\d]+\", \"\", e).lower().split()"},{"line_number":90,"context_line":"            label \u003d \u0027_\u0027.join(e[:-1]).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":91,"context_line":"        else:"},{"line_number":92,"context_line":"            # NOTE (iurygregory): regex to remove all numbers"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bd396ca4","line":89,"updated":"2019-07-19 04:37:19.000000000","message":"nit: being very picky here, but it\u0027s me :)\nuse single quotes in the regex expr","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fdba6aa5b72737a38b89f27b24ccc6b9cf2f1788","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            e \u003d re.sub(r\u0027([\\d+]v)|([\\d+].[\\d*]v)\u0027, \u0027\u0027, entry.lower())"},{"line_number":87,"context_line":"            # NOTE (iurygregory): regex to remove all numbers"},{"line_number":88,"context_line":"            # e.g: \u0027Voltage 1 (0x6d)\u0027 will turn into [\u0027voltage\u0027, \u0027(xd)\u0027]"},{"line_number":89,"context_line":"            e \u003d re.sub(r\"[\\d]+\", \"\", e).lower().split()"},{"line_number":90,"context_line":"            label \u003d \u0027_\u0027.join(e[:-1]).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":91,"context_line":"        else:"},{"line_number":92,"context_line":"            # NOTE (iurygregory): regex to remove all numbers"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f65cde19","line":89,"in_reply_to":"7faddb67_bd396ca4","updated":"2019-07-19 13:41:27.000000000","message":"No problem o/ I will update","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"29c55607c39aaf067cd9471650a101b7e46af0ff","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            e \u003d re.sub(r\u0027([\\d+]v)|([\\d+].[\\d*]v)\u0027, \u0027\u0027, entry.lower())"},{"line_number":87,"context_line":"            # NOTE (iurygregory): regex to remove all numbers"},{"line_number":88,"context_line":"            # e.g: \u0027Voltage 1 (0x6d)\u0027 will turn into [\u0027voltage\u0027, \u0027(xd)\u0027]"},{"line_number":89,"context_line":"            e \u003d re.sub(r\"[\\d]+\", \"\", e).lower().split()"},{"line_number":90,"context_line":"            label \u003d \u0027_\u0027.join(e[:-1]).replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":91,"context_line":"        else:"},{"line_number":92,"context_line":"            # NOTE (iurygregory): regex to remove all numbers"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9750eb0c","line":89,"in_reply_to":"7faddb67_f65cde19","updated":"2019-07-22 16:21:26.000000000","message":"Done, I\u0027ve also updated the others that I\u0027ve found here","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"}],"ironic_prometheus_exporter/tests/test_ipmi_parser.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07a9159501193b85770836a482dd11987e2a7504","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                                 prefix, sufix, **extra)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.assertEqual(len(voltage_metrics_name), 19)"},{"line_number":564,"context_line":"        self.assertIn(\u0027baremetal_mem_vtt_pg\u0027, voltage_metrics_name)"},{"line_number":565,"context_line":"        self.assertIn(\u0027baremetal_sw_pg\u0027, voltage_metrics_name)"},{"line_number":566,"context_line":"        self.assertIn(\u0027baremetal_vsa_pg\u0027, voltage_metrics_name)"},{"line_number":567,"context_line":"        self.assertIn(\u0027baremetal_vcore_pg\u0027, voltage_metrics_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3d4d7c3d","line":564,"updated":"2019-07-19 04:37:19.000000000","message":"I think you can use an iteration for all these assertIn or maybe use set and assertTrue","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d79d11f19c2a09b01147389473ee1f6ce85408f3","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                                 prefix, sufix, **extra)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.assertEqual(len(voltage_metrics_name), 19)"},{"line_number":564,"context_line":"        self.assertIn(\u0027baremetal_mem_vtt_pg\u0027, voltage_metrics_name)"},{"line_number":565,"context_line":"        self.assertIn(\u0027baremetal_sw_pg\u0027, voltage_metrics_name)"},{"line_number":566,"context_line":"        self.assertIn(\u0027baremetal_vsa_pg\u0027, voltage_metrics_name)"},{"line_number":567,"context_line":"        self.assertIn(\u0027baremetal_vcore_pg\u0027, voltage_metrics_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_992a7d7c","line":564,"in_reply_to":"7faddb67_36959687","updated":"2019-07-19 14:11:20.000000000","message":"exactly, the iteration is fine","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fdba6aa5b72737a38b89f27b24ccc6b9cf2f1788","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                                 prefix, sufix, **extra)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.assertEqual(len(voltage_metrics_name), 19)"},{"line_number":564,"context_line":"        self.assertIn(\u0027baremetal_mem_vtt_pg\u0027, voltage_metrics_name)"},{"line_number":565,"context_line":"        self.assertIn(\u0027baremetal_sw_pg\u0027, voltage_metrics_name)"},{"line_number":566,"context_line":"        self.assertIn(\u0027baremetal_vsa_pg\u0027, voltage_metrics_name)"},{"line_number":567,"context_line":"        self.assertIn(\u0027baremetal_vcore_pg\u0027, voltage_metrics_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_36959687","line":564,"in_reply_to":"7faddb67_3d4d7c3d","updated":"2019-07-19 13:41:27.000000000","message":"you mean create a list with the expected metrics name and do something like:\nfor metric_name in expected_metrics:\n    self.assertIn(metric_name, voltage_metrics_name)\n? \n\nFor the assertTrue I didn\u0027t get it","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"907a963dac5b3b30ea4a9d31ebb13fdfa5d7ac92","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                                 prefix, sufix, **extra)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.assertEqual(len(voltage_metrics_name), 19)"},{"line_number":564,"context_line":"        self.assertIn(\u0027baremetal_mem_vtt_pg\u0027, voltage_metrics_name)"},{"line_number":565,"context_line":"        self.assertIn(\u0027baremetal_sw_pg\u0027, voltage_metrics_name)"},{"line_number":566,"context_line":"        self.assertIn(\u0027baremetal_vsa_pg\u0027, voltage_metrics_name)"},{"line_number":567,"context_line":"        self.assertIn(\u0027baremetal_vcore_pg\u0027, voltage_metrics_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b9897975","line":564,"in_reply_to":"7faddb67_992a7d7c","updated":"2019-07-19 14:16:45.000000000","message":"Ack, I will update \u003d)","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"29c55607c39aaf067cd9471650a101b7e46af0ff","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                                                 prefix, sufix, **extra)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.assertEqual(len(voltage_metrics_name), 19)"},{"line_number":564,"context_line":"        self.assertIn(\u0027baremetal_mem_vtt_pg\u0027, voltage_metrics_name)"},{"line_number":565,"context_line":"        self.assertIn(\u0027baremetal_sw_pg\u0027, voltage_metrics_name)"},{"line_number":566,"context_line":"        self.assertIn(\u0027baremetal_vsa_pg\u0027, voltage_metrics_name)"},{"line_number":567,"context_line":"        self.assertIn(\u0027baremetal_vcore_pg\u0027, voltage_metrics_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_97022b09","line":564,"in_reply_to":"7faddb67_b9897975","updated":"2019-07-22 16:21:26.000000000","message":"Done","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"233f15b85f54efbeeaec5ba5090583438929158a","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                               ipmi_format)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        self.assertEqual(0.0, self.metric_registry.get_sample_value("},{"line_number":590,"context_line":"            \u0027baremetal_mem_vddq_pg\u0027,"},{"line_number":591,"context_line":"            {\u0027node_name\u0027: self.node_name,"},{"line_number":592,"context_line":"             \u0027entity_id\u0027: \u00273.1 (Processor)\u0027,"},{"line_number":593,"context_line":"             \u0027node_uuid\u0027: self.node_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d3745400","line":590,"updated":"2019-07-19 13:17:15.000000000","message":"this doesn\u0027t make really readable names. Maybe you can namespace a bit like `baremetal_voltage_mem_vddq_pg`?","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"f4ad90dfc08abc38295a67102dca7f8b431fbe06","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                               ipmi_format)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        self.assertEqual(0.0, self.metric_registry.get_sample_value("},{"line_number":590,"context_line":"            \u0027baremetal_mem_vddq_pg\u0027,"},{"line_number":591,"context_line":"            {\u0027node_name\u0027: self.node_name,"},{"line_number":592,"context_line":"             \u0027entity_id\u0027: \u00273.1 (Processor)\u0027,"},{"line_number":593,"context_line":"             \u0027node_uuid\u0027: self.node_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f64dbe3a","line":590,"in_reply_to":"7faddb67_16c89aa3","updated":"2019-07-19 13:43:49.000000000","message":"This would be my intuition but I\u0027m not knowledgeable enough about Ironic and IPMI to be absolutely positive.","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"29c55607c39aaf067cd9471650a101b7e46af0ff","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                               ipmi_format)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        self.assertEqual(0.0, self.metric_registry.get_sample_value("},{"line_number":590,"context_line":"            \u0027baremetal_mem_vddq_pg\u0027,"},{"line_number":591,"context_line":"            {\u0027node_name\u0027: self.node_name,"},{"line_number":592,"context_line":"             \u0027entity_id\u0027: \u00273.1 (Processor)\u0027,"},{"line_number":593,"context_line":"             \u0027node_uuid\u0027: self.node_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_570cb33a","line":590,"in_reply_to":"7faddb67_c18f8173","updated":"2019-07-22 16:21:26.000000000","message":"Done","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fdba6aa5b72737a38b89f27b24ccc6b9cf2f1788","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                               ipmi_format)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        self.assertEqual(0.0, self.metric_registry.get_sample_value("},{"line_number":590,"context_line":"            \u0027baremetal_mem_vddq_pg\u0027,"},{"line_number":591,"context_line":"            {\u0027node_name\u0027: self.node_name,"},{"line_number":592,"context_line":"             \u0027entity_id\u0027: \u00273.1 (Processor)\u0027,"},{"line_number":593,"context_line":"             \u0027node_uuid\u0027: self.node_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_16c89aa3","line":590,"in_reply_to":"7faddb67_d3745400","updated":"2019-07-19 13:41:27.000000000","message":"You this would apply to all other metrics under the Voltage category? Just checking before update the code \u003d)","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"907a963dac5b3b30ea4a9d31ebb13fdfa5d7ac92","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                               ipmi_format)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        self.assertEqual(0.0, self.metric_registry.get_sample_value("},{"line_number":590,"context_line":"            \u0027baremetal_mem_vddq_pg\u0027,"},{"line_number":591,"context_line":"            {\u0027node_name\u0027: self.node_name,"},{"line_number":592,"context_line":"             \u0027entity_id\u0027: \u00273.1 (Processor)\u0027,"},{"line_number":593,"context_line":"             \u0027node_uuid\u0027: self.node_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f98a9161","line":590,"in_reply_to":"7faddb67_f64dbe3a","updated":"2019-07-19 14:16:45.000000000","message":"Gotcha, I will get more information about this.","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8ea6232aa15786f4a5fc80aff46aa0ceaa02074d","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                               ipmi_format)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        self.assertEqual(0.0, self.metric_registry.get_sample_value("},{"line_number":590,"context_line":"            \u0027baremetal_mem_vddq_pg\u0027,"},{"line_number":591,"context_line":"            {\u0027node_name\u0027: self.node_name,"},{"line_number":592,"context_line":"             \u0027entity_id\u0027: \u00273.1 (Processor)\u0027,"},{"line_number":593,"context_line":"             \u0027node_uuid\u0027: self.node_uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c18f8173","line":590,"in_reply_to":"7faddb67_f98a9161","updated":"2019-07-22 14:50:56.000000000","message":"+1, best to try and categorize everything together as it makes sense.","commit_id":"d7e4e5085ebb167207627aceb94efe08cd2fcd15"}]}