)]}'
{"ironic_prometheus_exporter/messaging.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0f7374b0b1c4ce0e474c1d0e3e2945e640679ed","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            node_message \u003d message[\u0027payload\u0027]"},{"line_number":51,"context_line":"            header.timestamp_registry(node_message, registry)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            if message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.ipmi.metrics\u0027:"},{"line_number":54,"context_line":"                ipmi.category_registry(node_message, registry)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            elif message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.redfish.metrics\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_2b05ebc2","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":36},"updated":"2019-09-09 15:44:38.000000000","message":"Maybe use event_type variable since we are changing the file names to be node_name + event_type?","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            node_message \u003d message[\u0027payload\u0027]"},{"line_number":51,"context_line":"            header.timestamp_registry(node_message, registry)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            if message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.ipmi.metrics\u0027:"},{"line_number":54,"context_line":"                ipmi.category_registry(node_message, registry)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            elif message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.redfish.metrics\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_413cbabe","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":36},"in_reply_to":"5faad753_2b05ebc2","updated":"2019-09-10 08:01:00.000000000","message":"++","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            node_message \u003d message[\u0027payload\u0027]"},{"line_number":51,"context_line":"            header.timestamp_registry(node_message, registry)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            if message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.ipmi.metrics\u0027:"},{"line_number":54,"context_line":"                ipmi.category_registry(node_message, registry)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            elif message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.redfish.metrics\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_a276cca3","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":36},"in_reply_to":"5faad753_2b05ebc2","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            node_message \u003d message[\u0027payload\u0027]"},{"line_number":51,"context_line":"            header.timestamp_registry(node_message, registry)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            if message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.ipmi.metrics\u0027:"},{"line_number":54,"context_line":"                ipmi.category_registry(node_message, registry)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            elif message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.redfish.metrics\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_c2798893","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":36},"in_reply_to":"5faad753_413cbabe","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            if message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.ipmi.metrics\u0027:"},{"line_number":54,"context_line":"                ipmi.category_registry(node_message, registry)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            elif message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.redfish.metrics\u0027:"},{"line_number":57,"context_line":"                redfish.category_registry(node_message, registry)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            nodeFile \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_a176cea3","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":38},"updated":"2019-09-10 08:01:00.000000000","message":"same here","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            if message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.ipmi.metrics\u0027:"},{"line_number":54,"context_line":"                ipmi.category_registry(node_message, registry)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            elif message[\u0027event_type\u0027] \u003d\u003d \u0027hardware.redfish.metrics\u0027:"},{"line_number":57,"context_line":"                redfish.category_registry(node_message, registry)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            nodeFile \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_6270d4a6","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":38},"in_reply_to":"5faad753_a176cea3","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"}],"ironic_prometheus_exporter/parsers/redfish.py":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"456bbb760a30ed2b5de331b58edeb44a3beb9ff7","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        for value, labels in details:"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            gauge \u003d Gauge(metric, \u0027\u0027, labelnames\u003dlabels,"},{"line_number":254,"context_line":"                          registry\u003dmetrics_registry)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            gauge.labels(**labels).set(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_8b0e68e3","line":253,"updated":"2019-09-09 08:24:51.000000000","message":"Metric description is missing here.","commit_id":"87ef87a51dc5b43e2ddecf4758b3e3b95510444b"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"b3efb635022d1f1d3563d6257d4702e9dbf4c36b","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        for value, labels in details:"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            gauge \u003d Gauge(metric, \u0027\u0027, labelnames\u003dlabels,"},{"line_number":254,"context_line":"                          registry\u003dmetrics_registry)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            gauge.labels(**labels).set(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_d75f23e3","line":253,"in_reply_to":"5faad753_06a02ff4","updated":"2019-09-09 12:09:23.000000000","message":"Not having a description will make life harder for people consuming the metrics (they\u0027ll have to dig into the source code of the exporter).\nJust looking at \u0027baremetal_drive_status\u0027, you could expand that the metric reports the drive status, 0 means OK and any other value that the drive has errors.\nRegarding IPMI metrics, there\u0027s work in progress \u003d\u003e https://review.opendev.org/#/c/675345","commit_id":"87ef87a51dc5b43e2ddecf4758b3e3b95510444b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"51e84b9144a8b6de577abdefa0fb64d575ee7485","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        for value, labels in details:"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            gauge \u003d Gauge(metric, \u0027\u0027, labelnames\u003dlabels,"},{"line_number":254,"context_line":"                          registry\u003dmetrics_registry)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            gauge.labels(**labels).set(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_06a02ff4","line":253,"in_reply_to":"5faad753_8b0e68e3","updated":"2019-09-09 09:21:37.000000000","message":"I am not sure we have anything reasonable to put in the description here... The metrics that come in, they do not have much of the human-friendly text.\n\nBTW, it\u0027s done similarly for IPMI.","commit_id":"87ef87a51dc5b43e2ddecf4758b3e3b95510444b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"1033bf03503c4def8af84e82554f4df195357b19","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        for value, labels in details:"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            gauge \u003d Gauge(metric, \u0027\u0027, labelnames\u003dlabels,"},{"line_number":254,"context_line":"                          registry\u003dmetrics_registry)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            gauge.labels(**labels).set(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_9a322ff1","line":253,"in_reply_to":"5faad753_d75f23e3","updated":"2019-09-09 13:37:42.000000000","message":"Added in the follow-up [1].\n\n1. https://review.opendev.org/#/c/681007/","commit_id":"87ef87a51dc5b43e2ddecf4758b3e3b95510444b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            ]"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    payload \u003d node_message"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for key in (\u0027payload\u0027, \u0027Temperature\u0027):"},{"line_number":62,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_21af3ee4","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":26},"updated":"2019-09-10 08:01:00.000000000","message":"can\u0027t we just use node_message ?","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            ]"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    payload \u003d node_message"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for key in (\u0027payload\u0027, \u0027Temperature\u0027):"},{"line_number":62,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_82a870db","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":26},"in_reply_to":"5faad753_21af3ee4","updated":"2019-09-10 10:30:25.000000000","message":"Well, here `payload` gets initialized for the tree walking loop at L#61, the value of the `payload` will change because of that.\n\nWe can\u0027t override `node_message` (tree root) instead because we still need its original value elsewhere (L#70).","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ce4fe2629b36c2a69316a6715f1fa0040f7d9961","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            ]"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    payload \u003d node_message"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for key in (\u0027payload\u0027, \u0027Temperature\u0027):"},{"line_number":62,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_0217a0ef","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":26},"in_reply_to":"5faad753_82a870db","updated":"2019-09-10 10:37:58.000000000","message":"right, thank you","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            ]"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"    \"\"\""},{"line_number":112,"context_line":"    payload \u003d node_message"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    for key in (\u0027payload\u0027, \u0027Power\u0027):"},{"line_number":115,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_41aa7ad2","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":26},"updated":"2019-09-10 08:01:00.000000000","message":"ditto","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            ]"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"    \"\"\""},{"line_number":112,"context_line":"    payload \u003d node_message"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    for key in (\u0027payload\u0027, \u0027Power\u0027):"},{"line_number":115,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_42aa78d2","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":26},"in_reply_to":"5faad753_41aa7ad2","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            ]"},{"line_number":162,"context_line":"        }"},{"line_number":163,"context_line":"    \"\"\""},{"line_number":164,"context_line":"    payload \u003d node_message"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for key in (\u0027payload\u0027, \u0027Fan\u0027):"},{"line_number":167,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_e1b8462b","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":26},"updated":"2019-09-10 08:01:00.000000000","message":"ditto","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            ]"},{"line_number":162,"context_line":"        }"},{"line_number":163,"context_line":"    \"\"\""},{"line_number":164,"context_line":"    payload \u003d node_message"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for key in (\u0027payload\u0027, \u0027Fan\u0027):"},{"line_number":167,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_028d607a","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":26},"in_reply_to":"5faad753_e1b8462b","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            ]"},{"line_number":214,"context_line":"        }"},{"line_number":215,"context_line":"    \"\"\""},{"line_number":216,"context_line":"    payload \u003d node_message"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    for key in (\u0027payload\u0027, \u0027Drive\u0027):"},{"line_number":219,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_a1848e5f","line":216,"range":{"start_line":216,"start_character":4,"end_line":216,"end_character":26},"updated":"2019-09-10 08:01:00.000000000","message":"ditto","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            ]"},{"line_number":214,"context_line":"        }"},{"line_number":215,"context_line":"    \"\"\""},{"line_number":216,"context_line":"    payload \u003d node_message"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    for key in (\u0027payload\u0027, \u0027Drive\u0027):"},{"line_number":219,"context_line":"        payload \u003d payload.get(key, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_429358a4","line":216,"range":{"start_line":216,"start_character":4,"end_line":216,"end_character":26},"in_reply_to":"5faad753_a1848e5f","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2460d3e5b192490f25ea5e3c030cfe4d32edb217","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def build_temperature_metrics(node_message):"},{"line_number":30,"context_line":"    \"\"\"Build Prometheus temperature metrics from Oslo message."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Takes Oslo notification message carrying Redfish sensor data and"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_6fdd1841","line":29,"updated":"2019-09-10 13:05:49.000000000","message":"I\u0027d still prefer to find a way to avoid giant copy-pastes..","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ce4fe2629b36c2a69316a6715f1fa0040f7d9961","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def build_temperature_metrics(node_message):"},{"line_number":30,"context_line":"    \"\"\"Build Prometheus temperature metrics from Oslo message."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Takes Oslo notification message carrying Redfish sensor data and"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_c28d0832","line":29,"updated":"2019-09-10 10:37:58.000000000","message":"would be interesting to try to compress all these functions into one, but maybe in a follow-up","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"2a493aa969b1fb95ca588c6d0572f104be6ac6d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def build_temperature_metrics(node_message):"},{"line_number":30,"context_line":"    \"\"\"Build Prometheus temperature metrics from Oslo message."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Takes Oslo notification message carrying Redfish sensor data and"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_62e774e6","line":29,"in_reply_to":"5faad753_c28d0832","updated":"2019-09-10 10:41:15.000000000","message":"That\u0027s what IPMI parser does, but it seems generalization in this case does more harm than good - the data is not  sufficiently uniform to benefit some common infrastructure (I tried that design initially)...","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2460d3e5b192490f25ea5e3c030cfe4d32edb217","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Examples::"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        .. code-block:: python"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        {"},{"line_number":42,"context_line":"            # metric name"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_8fe094fc","line":39,"updated":"2019-09-10 13:05:49.000000000","message":"Incorrect syntax here: you don\u0027t need :: before code-block, and code-block directive should not be indented","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2460d3e5b192490f25ea5e3c030cfe4d32edb217","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    :param node_message: Oslo notification message"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    Examples::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        .. code-block:: python"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_2fe72015","line":90,"updated":"2019-09-10 13:05:49.000000000","message":"ditto","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ce4fe2629b36c2a69316a6715f1fa0040f7d9961","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # metric name"},{"line_number":96,"context_line":"            \u0027baremetal_power_status\u0027:"},{"line_number":97,"context_line":"                ["},{"line_number":98,"context_line":"                    # metric value (0 - OK, 1 - on fire)"},{"line_number":99,"context_line":"                    0,"},{"line_number":100,"context_line":"                    # metric instance in form of Prometheus labels"},{"line_number":101,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_82871010","line":98,"range":{"start_line":98,"start_character":44,"end_line":98,"end_character":55},"updated":"2019-09-10 10:37:58.000000000","message":"oO","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2460d3e5b192490f25ea5e3c030cfe4d32edb217","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    :param node_message: Oslo notification message"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    Examples::"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        .. code-block:: python"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_4fe29c03","line":142,"updated":"2019-09-10 13:05:49.000000000","message":"ditto","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2460d3e5b192490f25ea5e3c030cfe4d32edb217","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    :param node_message: Oslo notification message"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    Examples::"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        .. code-block:: python"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_eff028cc","line":194,"updated":"2019-09-10 13:05:49.000000000","message":"ditto","commit_id":"9959cf36bc5949196e23ba10487cfeeaf2263582"}],"ironic_prometheus_exporter/tests/test_redfish_parser.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0f7374b0b1c4ce0e474c1d0e3e2945e640679ed","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def test_build_temperature_metrics(self):"},{"line_number":26,"context_line":"        metrics \u003d redfish.build_temperature_metrics(self.node_message)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        expected_metric \u003d \u0027baremetal_temp_cpu_celsius\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.assertIn(expected_metric, metrics)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_0b882fe5","line":28,"range":{"start_line":28,"start_character":27,"end_line":28,"end_character":53},"updated":"2019-09-09 15:44:38.000000000","message":"I\u0027m not sure if we should put the entity in the metric name or if we should have the label.\n\n@Simon do you have any thoughts on this? what would be better?","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"e062943da8431356e0b9190335ac6aeea470b1af","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def test_build_temperature_metrics(self):"},{"line_number":26,"context_line":"        metrics \u003d redfish.build_temperature_metrics(self.node_message)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        expected_metric \u003d \u0027baremetal_temp_cpu_celsius\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.assertIn(expected_metric, metrics)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_8632d6f0","line":28,"range":{"start_line":28,"start_character":27,"end_line":28,"end_character":53},"in_reply_to":"5faad753_0b882fe5","updated":"2019-09-09 15:56:27.000000000","message":"For IPMI we seem to include some context into temperature metric name:\n\n    \"baremetal_temp_celsius\":\n        \"The temperature of each Processor\",\n    \"baremetal_exhaust_temp_celsius\":\n        \"The exhaust temperature for the Systeam Board\",\n    \"baremetal_inlet_temp_celsius\":\n        \"The inlet temperature for the Systeam Board\",\n\nBut not for other metrics, afaik.","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"90e56c79ea71505d482b6ead66b59d387758f7fe","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def test_build_temperature_metrics(self):"},{"line_number":26,"context_line":"        metrics \u003d redfish.build_temperature_metrics(self.node_message)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        expected_metric \u003d \u0027baremetal_temp_cpu_celsius\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.assertIn(expected_metric, metrics)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_420ef832","line":28,"range":{"start_line":28,"start_character":27,"end_line":28,"end_character":53},"in_reply_to":"5faad753_36678f50","updated":"2019-09-10 10:20:39.000000000","message":"Then it sounds like we should better collapse all temp metrics under a single name...?\n\nOn the other hand, I think it would be better in the long run to have compatible metrics across the parsers. So that the user could switch BMC protocol IPMI/Redfish and still get more or less the same metrics. Or, from NMS perspective, I believe it would be a big hassle for NMS to map IPMI\u003c-\u003eRedfish originated metrics into some common one for the same of comparison, for instance.","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"799346ad5d879e02cdfe21fc1700c8fd10228425","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def test_build_temperature_metrics(self):"},{"line_number":26,"context_line":"        metrics \u003d redfish.build_temperature_metrics(self.node_message)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        expected_metric \u003d \u0027baremetal_temp_cpu_celsius\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        self.assertIn(expected_metric, metrics)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_36678f50","line":28,"range":{"start_line":28,"start_character":27,"end_line":28,"end_character":53},"in_reply_to":"5faad753_8632d6f0","updated":"2019-09-09 20:22:54.000000000","message":"I did this for ipmi because when we collected the metrics we didnt get \u0027baremetal_temp_celsius\u0027 for other entity only for the Processor, this is the description of the metric, if we would have for others entity would be \"for the entities ....\"","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"}],"releasenotes/notes/add-redfish-parser-af5b3b01a4e5d02d.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for handling Redfish-originated metrics in alongside with"},{"line_number":5,"context_line":"    IPMI ones."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_21989ebe","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2019-09-10 08:01:00.000000000","message":"nit: Adds","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2940e5560e91014665180e8fa42ddad929a03b74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for handling Redfish-originated metrics in alongside with"},{"line_number":5,"context_line":"    IPMI ones."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_41d83a7e","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":75},"updated":"2019-09-10 08:01:00.000000000","message":"remove in\nalso either alongside or along with","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for handling Redfish-originated metrics in alongside with"},{"line_number":5,"context_line":"    IPMI ones."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_82f630f9","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"in_reply_to":"5faad753_21989ebe","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"721b2e07471cb0a23e217741db3ea4cb2425cd48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for handling Redfish-originated metrics in alongside with"},{"line_number":5,"context_line":"    IPMI ones."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_02bb200e","line":4,"range":{"start_line":4,"start_character":58,"end_line":4,"end_character":75},"in_reply_to":"5faad753_41d83a7e","updated":"2019-09-10 10:30:25.000000000","message":"Done","commit_id":"5def60459b3a61474ec629c30b7066771accaa4a"}]}