)]}'
{".zuul.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3fa7e38b_b5da3875","side":"PARENT","updated":"2019-10-10 11:29:48.000000000","message":"nit: I\u0027d prefer you keep .zuul.yaml for such a small project","commit_id":"c932c72969b9d224af47bfdcb5f574001eb04528"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3fa7e38b_55742436","side":"PARENT","in_reply_to":"3fa7e38b_b5da3875","updated":"2019-10-10 12:09:37.000000000","message":"Ack","commit_id":"c932c72969b9d224af47bfdcb5f574001eb04528"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0b2635543fb91f54f7a3079f029dd4a0b5d4b77b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      devstack_plugins:"},{"line_number":17,"context_line":"        ironic-prometheus-exporter: https://opendev.org/openstack/ironic-prometheus-exporter"},{"line_number":18,"context_line":"      devstack_services:"},{"line_number":19,"context_line":"        ironic_prometheus_exporter: True"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- project:"},{"line_number":22,"context_line":"    templates:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_fd347dfc","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":34},"updated":"2020-01-15 08:55:18.000000000","message":"I would also change this to ironic-prometheus-exporter","commit_id":"2f07b3df5cdf0e03c1f153ce1525447f4a0ca066"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"af71d502b580a6f3be4f35078bfa63d4ca189b4f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      devstack_plugins:"},{"line_number":17,"context_line":"        ironic-prometheus-exporter: https://opendev.org/openstack/ironic-prometheus-exporter"},{"line_number":18,"context_line":"      devstack_services:"},{"line_number":19,"context_line":"        ironic_prometheus_exporter: True"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- project:"},{"line_number":22,"context_line":"    templates:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3fa7e38b_20342c49","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":34},"in_reply_to":"3fa7e38b_fd347dfc","updated":"2020-01-15 09:29:24.000000000","message":"Done","commit_id":"2f07b3df5cdf0e03c1f153ce1525447f4a0ca066"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"42fcc7d9b992c5677254bf48740a9381e2a0d943","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - release-notes-jobs-python3"},{"line_number":26,"context_line":"    check:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - ironic-prometheus-exporter-tempest-redfish"},{"line_number":29,"context_line":"    gate:"},{"line_number":30,"context_line":"      queue: ironic"},{"line_number":31,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_3f89fe6e","line":28,"range":{"start_line":28,"start_character":37,"end_line":28,"end_character":44},"updated":"2020-02-13 16:48:34.000000000","message":"I\u0027d prefer we turn off tempest from running, it adds extra test time and we can validate data is being exported even with the node off. We have the knob. :)","commit_id":"c8be1e47093856fa14052663a83f6834a7fabe89"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"93f4d876ad3ea5b78f56dceec8aeda5fa31f4476","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - release-notes-jobs-python3"},{"line_number":26,"context_line":"    check:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - ironic-prometheus-exporter-tempest-redfish"},{"line_number":29,"context_line":"    gate:"},{"line_number":30,"context_line":"      queue: ironic"},{"line_number":31,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3fa7e38b_a03b8e97","line":28,"range":{"start_line":28,"start_character":37,"end_line":28,"end_character":44},"in_reply_to":"3fa7e38b_3f89fe6e","updated":"2020-02-13 17:48:20.000000000","message":"Done","commit_id":"c8be1e47093856fa14052663a83f6834a7fabe89"}],"bindep.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"libvirt-dev [platform:dpkg]"},{"line_number":2,"context_line":"pkg-config [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":11,"id":"3fa7e38b_95ddbc71","line":2,"updated":"2019-10-10 11:29:48.000000000","message":"nit: please provide something for other platforms","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"libvirt-dev [platform:dpkg]"},{"line_number":2,"context_line":"pkg-config [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":11,"id":"3fa7e38b_3595e833","line":2,"in_reply_to":"3fa7e38b_95ddbc71","updated":"2019-10-10 12:09:37.000000000","message":"ok","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"}],"devstack/plugin.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"42f7970c54d33b1fd83e848813fc9bd03574bec0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    stop_ironic_prometheus_exporter"},{"line_number":61,"context_line":"    sudo rm -rf $IRONIC_PROMETHEUS_EXPORTER_DATA_DIR"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    disable_service $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE\""},{"line_number":66,"context_line":"    sudo rm -f $unitfile"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_1968adb8","line":63,"updated":"2019-10-02 08:48:32.000000000","message":"nit: I would move this before L61","commit_id":"9702914dcf2583a1a574734726ba44172a0bdfbe"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"47ce43190d68e46d84aaae931b5b9e91c6a64b31","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    stop_ironic_prometheus_exporter"},{"line_number":61,"context_line":"    sudo rm -rf $IRONIC_PROMETHEUS_EXPORTER_DATA_DIR"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    disable_service $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    local unitfile\u003d\"$SYSTEMD_DIR/$IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE\""},{"line_number":66,"context_line":"    sudo rm -f $unitfile"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_3946c923","line":63,"in_reply_to":"3fa7e38b_1968adb8","updated":"2019-10-02 08:52:16.000000000","message":"ack","commit_id":"9702914dcf2583a1a574734726ba44172a0bdfbe"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"42f7970c54d33b1fd83e848813fc9bd03574bec0","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"if is_service_enabled ironic_prometheus_exporter; then"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":77,"context_line":"        echo_summary \"Installing Ironic Prometheus Exporter\""},{"line_number":78,"context_line":"        install_ironic_prometheus_exporter"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_59a38501","line":76,"updated":"2019-10-02 08:48:32.000000000","message":"maybe use \u0027case\u0027 instead of \u0027if\u0027 for the second parameter, will be cleaner and shorter","commit_id":"9702914dcf2583a1a574734726ba44172a0bdfbe"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"47ce43190d68e46d84aaae931b5b9e91c6a64b31","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"if is_service_enabled ironic_prometheus_exporter; then"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":77,"context_line":"        echo_summary \"Installing Ironic Prometheus Exporter\""},{"line_number":78,"context_line":"        install_ironic_prometheus_exporter"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_d95215df","line":76,"in_reply_to":"3fa7e38b_59a38501","updated":"2019-10-02 08:52:16.000000000","message":"Sure!","commit_id":"9702914dcf2583a1a574734726ba44172a0bdfbe"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a246d77d48c1f71e9ab84f0da5b53fddc9ff03c0","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DIR\u003d${IRONIC_PROMETHEUS_EXPORTER_DIR:-$DEST/ironic-prometheus-exporter}"},{"line_number":5,"context_line":"IRONIC_PROMETHEUS_EXPORTER_PORT\u003d${IRONIC_PROMETHEUS_EXPORTER_PORT:-9608}"},{"line_number":6,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DATA_DIR\u003d\"\"$DATA_DIR/ironic-prometheus-exporter\"\""},{"line_number":7,"context_line":"IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE\u003d\"devstack@ironic-prometheus-exporter.service\""},{"line_number":8,"context_line":"# Location where the metrics from the baremetal nodes will be stored"},{"line_number":9,"context_line":"IRONIC_PROMETHEUS_EXPORTER_LOCATION\u003d${IRONIC_VM_LOG_DIR:-/tmp/ironic_prometheus_exporter}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_975bf252","line":6,"range":{"start_line":6,"start_character":74,"end_line":6,"end_character":76},"updated":"2019-10-03 08:56:33.000000000","message":"ditto","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a246d77d48c1f71e9ab84f0da5b53fddc9ff03c0","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DIR\u003d${IRONIC_PROMETHEUS_EXPORTER_DIR:-$DEST/ironic-prometheus-exporter}"},{"line_number":5,"context_line":"IRONIC_PROMETHEUS_EXPORTER_PORT\u003d${IRONIC_PROMETHEUS_EXPORTER_PORT:-9608}"},{"line_number":6,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DATA_DIR\u003d\"\"$DATA_DIR/ironic-prometheus-exporter\"\""},{"line_number":7,"context_line":"IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE\u003d\"devstack@ironic-prometheus-exporter.service\""},{"line_number":8,"context_line":"# Location where the metrics from the baremetal nodes will be stored"},{"line_number":9,"context_line":"IRONIC_PROMETHEUS_EXPORTER_LOCATION\u003d${IRONIC_VM_LOG_DIR:-/tmp/ironic_prometheus_exporter}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_775e7646","line":6,"range":{"start_line":6,"start_character":36,"end_line":6,"end_character":38},"updated":"2019-10-03 08:56:33.000000000","message":"you should be ok with just one double-quotes :)","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8de151ed619817e3a376ece5ae66508b1c209b2c","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DIR\u003d${IRONIC_PROMETHEUS_EXPORTER_DIR:-$DEST/ironic-prometheus-exporter}"},{"line_number":5,"context_line":"IRONIC_PROMETHEUS_EXPORTER_PORT\u003d${IRONIC_PROMETHEUS_EXPORTER_PORT:-9608}"},{"line_number":6,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DATA_DIR\u003d\"\"$DATA_DIR/ironic-prometheus-exporter\"\""},{"line_number":7,"context_line":"IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE\u003d\"devstack@ironic-prometheus-exporter.service\""},{"line_number":8,"context_line":"# Location where the metrics from the baremetal nodes will be stored"},{"line_number":9,"context_line":"IRONIC_PROMETHEUS_EXPORTER_LOCATION\u003d${IRONIC_VM_LOG_DIR:-/tmp/ironic_prometheus_exporter}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_a2658ee3","line":6,"range":{"start_line":6,"start_character":74,"end_line":6,"end_character":76},"in_reply_to":"3fa7e38b_975bf252","updated":"2019-10-03 09:04:56.000000000","message":"Only here in IRONIC_PROMETHEUS_EXPORTER_DATA_DIR right? Since you posted \"ditto\" I got a little confused","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9e09782c3253157ab1d77326ed15dcf0f92012a5","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DIR\u003d${IRONIC_PROMETHEUS_EXPORTER_DIR:-$DEST/ironic-prometheus-exporter}"},{"line_number":5,"context_line":"IRONIC_PROMETHEUS_EXPORTER_PORT\u003d${IRONIC_PROMETHEUS_EXPORTER_PORT:-9608}"},{"line_number":6,"context_line":"IRONIC_PROMETHEUS_EXPORTER_DATA_DIR\u003d\"\"$DATA_DIR/ironic-prometheus-exporter\"\""},{"line_number":7,"context_line":"IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE\u003d\"devstack@ironic-prometheus-exporter.service\""},{"line_number":8,"context_line":"# Location where the metrics from the baremetal nodes will be stored"},{"line_number":9,"context_line":"IRONIC_PROMETHEUS_EXPORTER_LOCATION\u003d${IRONIC_VM_LOG_DIR:-/tmp/ironic_prometheus_exporter}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_82dbb27b","line":6,"range":{"start_line":6,"start_character":74,"end_line":6,"end_character":76},"in_reply_to":"3fa7e38b_a2658ee3","updated":"2019-10-03 09:09:37.000000000","message":"yes, sorry, just this line","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a246d77d48c1f71e9ab84f0da5b53fddc9ff03c0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"function stop_ironic_prometheus_exporter {"},{"line_number":57,"context_line":"    start_service stop $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function cleanup_ironic_prometheus_exporter {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_b76b8eef","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":22},"updated":"2019-10-03 08:56:33.000000000","message":"mmmm I think you mean this?\nhttps://opendev.org/openstack/devstack/src/branch/master/functions-common#L2252","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9e09782c3253157ab1d77326ed15dcf0f92012a5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"function stop_ironic_prometheus_exporter {"},{"line_number":57,"context_line":"    start_service stop $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function cleanup_ironic_prometheus_exporter {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_e2cf06ae","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":22},"in_reply_to":"3fa7e38b_a23caebf","updated":"2019-10-03 09:09:37.000000000","message":"oh, interesting, yes please do if you have time, it doesn\u0027t look right","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8de151ed619817e3a376ece5ae66508b1c209b2c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"function stop_ironic_prometheus_exporter {"},{"line_number":57,"context_line":"    start_service stop $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function cleanup_ironic_prometheus_exporter {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_a23caebf","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":22},"in_reply_to":"3fa7e38b_b76b8eef","updated":"2019-10-03 09:04:56.000000000","message":"I\u0027ve copy and paste from https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L887-L889\n\nGoing push a patch to fix in ironic also XD","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a246d77d48c1f71e9ab84f0da5b53fddc9ff03c0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"echo_summary \"ironic-prometheus-exporter devstack plugin.sh called: $1/$2\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"if is_service_enabled ironic_prometheus_exporter; then"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"},{"line_number":84,"context_line":"        case \"$2\" in"},{"line_number":85,"context_line":"            install)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_2203de0f","line":82,"updated":"2019-10-03 08:56:33.000000000","message":"nit: I\u0027m being super picky here, sorry, this blank line is not needed :D","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8de151ed619817e3a376ece5ae66508b1c209b2c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"echo_summary \"ironic-prometheus-exporter devstack plugin.sh called: $1/$2\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"if is_service_enabled ironic_prometheus_exporter; then"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"},{"line_number":84,"context_line":"        case \"$2\" in"},{"line_number":85,"context_line":"            install)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_42493a5e","line":82,"in_reply_to":"3fa7e38b_2203de0f","updated":"2019-10-03 09:04:56.000000000","message":"Np o/","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a246d77d48c1f71e9ab84f0da5b53fddc9ff03c0","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":103,"context_line":"        echo_summary \"Stopping Ironic Prometheus Exporter Application\""},{"line_number":104,"context_line":"        stop_ironic_prometheus_exporter"},{"line_number":105,"context_line":"        echo_summary \"Cleaning Ironic Prometheus Exporter\""},{"line_number":106,"context_line":"        cleanup_ironic_prometheus_exporter"},{"line_number":107,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_f7182685","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":39},"updated":"2019-10-03 08:56:33.000000000","message":"this is already included in the cleanup L106\nyou probably don\u0027t need it here, unless you remove it from the cleanup, which might be even better thinking about it","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8de151ed619817e3a376ece5ae66508b1c209b2c","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":103,"context_line":"        echo_summary \"Stopping Ironic Prometheus Exporter Application\""},{"line_number":104,"context_line":"        stop_ironic_prometheus_exporter"},{"line_number":105,"context_line":"        echo_summary \"Cleaning Ironic Prometheus Exporter\""},{"line_number":106,"context_line":"        cleanup_ironic_prometheus_exporter"},{"line_number":107,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3fa7e38b_227afe87","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":39},"in_reply_to":"3fa7e38b_f7182685","updated":"2019-10-03 09:04:56.000000000","message":"I\u0027ll remove from cleanup o/","commit_id":"c25607572e9e95e83fc2e9859fa886a2f53f7c29"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    if is_ubuntu; then"},{"line_number":19,"context_line":"        install_package \"gunicorn\""},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        pip_install_gr \"gunicorn\""},{"line_number":22,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_f57f5063","line":19,"updated":"2019-10-10 11:29:48.000000000","message":"I\u0027d prefer we stay consistent in how we install it. Which probably means sticking to pip. The most important upside is that you\u0027ll use upper-constraints.","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    if is_ubuntu; then"},{"line_number":19,"context_line":"        install_package \"gunicorn\""},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        pip_install_gr \"gunicorn\""},{"line_number":22,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_b5a0f891","line":19,"in_reply_to":"3fa7e38b_f57f5063","updated":"2019-10-10 12:09:37.000000000","message":"ack","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        pip_install_gr \"gunicorn\""},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if use_library_from_git \"ironic-prometheus-exporter\"; then"},{"line_number":25,"context_line":"        git_clone_by_name \"ironic-prometheus-exporter\""},{"line_number":26,"context_line":"        setup_dev_lib \"ironic-prometheus-exporter\""},{"line_number":27,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_95985cc0","line":24,"updated":"2019-10-10 11:29:48.000000000","message":"Let\u0027s not handle it as a library and always install from git. This dance is for things that are treated as libraries by the release team and requirements.","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        pip_install_gr \"gunicorn\""},{"line_number":22,"context_line":"    fi"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if use_library_from_git \"ironic-prometheus-exporter\"; then"},{"line_number":25,"context_line":"        git_clone_by_name \"ironic-prometheus-exporter\""},{"line_number":26,"context_line":"        setup_dev_lib \"ironic-prometheus-exporter\""},{"line_number":27,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_95a37c9e","line":24,"in_reply_to":"3fa7e38b_95985cc0","updated":"2019-10-10 12:09:37.000000000","message":"ok","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"function configure_ironic_prometheus_exporter {"},{"line_number":33,"context_line":"    # Update ironic configuration file to use the exporter"},{"line_number":34,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data true"},{"line_number":35,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data_for_undeployed_nodes true"},{"line_number":36,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data_interval 180"},{"line_number":37,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications driver prometheus_exporter"},{"line_number":38,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications transport_url fake://"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_b5955889","line":35,"updated":"2019-10-10 11:29:48.000000000","message":"nit: make this configurable","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # Update ironic configuration file to use the exporter"},{"line_number":34,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data true"},{"line_number":35,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data_for_undeployed_nodes true"},{"line_number":36,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data_interval 180"},{"line_number":37,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications driver prometheus_exporter"},{"line_number":38,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications transport_url fake://"},{"line_number":39,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications location $IRONIC_PROMETHEUS_EXPORTER_LOCATION"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_558e6479","line":36,"updated":"2019-10-10 11:29:48.000000000","message":"Why is it changed here? If the default is bad, let\u0027s update ironic. Otherwise let\u0027s keep the default.","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # Update ironic configuration file to use the exporter"},{"line_number":34,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data true"},{"line_number":35,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data_for_undeployed_nodes true"},{"line_number":36,"context_line":"    iniset $IRONIC_CONF_FILE conductor send_sensor_data_interval 180"},{"line_number":37,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications driver prometheus_exporter"},{"line_number":38,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications transport_url fake://"},{"line_number":39,"context_line":"    iniset $IRONIC_CONF_FILE oslo_messaging_notifications location $IRONIC_PROMETHEUS_EXPORTER_LOCATION"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_b53c782f","line":36,"in_reply_to":"3fa7e38b_558e6479","updated":"2019-10-10 12:09:37.000000000","message":"The idea is that we would collect data from the baremetal, but  there are some problems in redfish sensor_data \"Failed to get sensor data for node f3ab12b4-d07d-4718-8e28-3d65fac26bbf\" [1]\n\nIf we don\u0027t change the default we would need to wait 10 minutes to get a sample of data I would say.\n\n[1] https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c83/685888/11/check/ironic-prometheus-exporter-functional-redfish/c83735c/controller/logs/screen-ir-cond.txt.gz","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"function stop_ironic_prometheus_exporter {"},{"line_number":58,"context_line":"    start_service stop $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"function cleanup_ironic_prometheus_exporter {"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_758b6067","line":58,"updated":"2019-10-10 11:29:48.000000000","message":"stop_service","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"function wait_for_data {"},{"line_number":75,"context_line":"    # Sleep for more than the [conductor]send_sensor_data_interval value"},{"line_number":76,"context_line":"    # to verify if we can get data from the baremetal"},{"line_number":77,"context_line":"    sleep 240"},{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"echo_summary \"ironic-prometheus-exporter devstack plugin.sh called: $1/$2\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_15ea2c0e","line":77,"updated":"2019-10-10 11:29:48.000000000","message":"a FIXME to make it smarter?","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                echo_summary \"Starting Ironic Prometheus Exporter Application\""},{"line_number":96,"context_line":"                start_ironic_prometheus_exporter"},{"line_number":97,"context_line":"                echo_summary \"Give time to baremetal to provide data\""},{"line_number":98,"context_line":"                wait_for_data"},{"line_number":99,"context_line":"                ;;"},{"line_number":100,"context_line":"        esac"},{"line_number":101,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_35ef281f","line":98,"updated":"2019-10-10 11:29:48.000000000","message":"Why do we even need this? I\u0027d prefer to avoid making devstack take 4 minutes longer.","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                echo_summary \"Starting Ironic Prometheus Exporter Application\""},{"line_number":96,"context_line":"                start_ironic_prometheus_exporter"},{"line_number":97,"context_line":"                echo_summary \"Give time to baremetal to provide data\""},{"line_number":98,"context_line":"                wait_for_data"},{"line_number":99,"context_line":"                ;;"},{"line_number":100,"context_line":"        esac"},{"line_number":101,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_956dbc33","line":98,"in_reply_to":"3fa7e38b_35ef281f","updated":"2019-10-10 12:09:37.000000000","message":"I\u0027m still working to collect the data (the wait would be necessary to see if we are able to collect, the value is higher then send_sensor_data_interval to make sure we would collect)\n\nAfter verify that it\u0027s possible to collect I would add a test to try to request the data to Flask","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"da76ed488047f4d460b27350d39f6beb9c1add52","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                echo_summary \"Starting Ironic Prometheus Exporter Application\""},{"line_number":96,"context_line":"                start_ironic_prometheus_exporter"},{"line_number":97,"context_line":"                echo_summary \"Give time to baremetal to provide data\""},{"line_number":98,"context_line":"                wait_for_data"},{"line_number":99,"context_line":"                ;;"},{"line_number":100,"context_line":"        esac"},{"line_number":101,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_232c3dab","line":98,"in_reply_to":"3fa7e38b_956dbc33","updated":"2019-10-21 15:39:18.000000000","message":"Let\u0027s not delay devstack by waiting for data. It takes long enough already. There seems to be nothing preventing devstack from finishing before we get the first information.","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"77149a77f9285dddb3edb44e05e945daa578f37a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"COLLECT_DATA_UNDEPLOYED_NODES\u003d$(trueorfalse True COLLECT_DATA_UNDEPLOYED_NODES)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"function install_ironic_prometheus_exporter {"},{"line_number":13,"context_line":"    pip_install_gr \"gunicorn\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    git_clone_by_name \"ironic-prometheus-exporter\""},{"line_number":16,"context_line":"    setup_dev_lib \"ironic-prometheus-exporter\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"3fa7e38b_0b928fa1","line":13,"updated":"2019-12-16 16:48:55.000000000","message":"let\u0027s try removing this line, it may cause conflict with the system installation of gunicorn","commit_id":"edbf5ee1dbb5e1d35e6f8b9e8e2454e2eea468eb"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"162b603c9f30094258013a5b607553be5d9ca7c0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        gunicorn\u003d${gunicorn}3"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    cmd\u003d$(which gunicorn)"},{"line_number":34,"context_line":"    cmd+\u003d\" -b ${HOST_IP}:${IRONIC_PROMETHEUS_EXPORTER_PORT}\""},{"line_number":35,"context_line":"    cmd+\u003d\" --env FLASK_DEBUG\u003d1\""},{"line_number":36,"context_line":"    cmd+\u003d\" -w 4 ironic_prometheus_exporter.app.wsgi:application\""}],"source_content_type":"text/x-sh","patch_set":17,"id":"3fa7e38b_e698616a","line":33,"updated":"2019-12-18 17:11:42.000000000","message":"so this is probably $(which ${gunicorn}) as it could be gunicorn3\nmaybe also rename gunicorn to GUNICORN_COMMAND or somthing like that ?","commit_id":"cd9d24ab0e5c3e213f261152bf73ba1c0a63cd01"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0b2635543fb91f54f7a3079f029dd4a0b5d4b77b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"echo_summary \"ironic-prometheus-exporter devstack plugin.sh called: $1/$2\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if is_service_enabled ironic_prometheus_exporter; then"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"},{"line_number":71,"context_line":"        case \"$2\" in"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3fa7e38b_60e8e414","line":68,"range":{"start_line":68,"start_character":22,"end_line":68,"end_character":48},"updated":"2020-01-15 08:55:18.000000000","message":"and change this also to ironic-prometheus-exporter","commit_id":"2f07b3df5cdf0e03c1f153ce1525447f4a0ca066"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"af71d502b580a6f3be4f35078bfa63d4ca189b4f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"echo_summary \"ironic-prometheus-exporter devstack plugin.sh called: $1/$2\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if is_service_enabled ironic_prometheus_exporter; then"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"},{"line_number":71,"context_line":"        case \"$2\" in"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3fa7e38b_8042c0ab","line":68,"range":{"start_line":68,"start_character":22,"end_line":68,"end_character":48},"in_reply_to":"3fa7e38b_60e8e414","updated":"2020-01-15 09:29:24.000000000","message":"Done","commit_id":"2f07b3df5cdf0e03c1f153ce1525447f4a0ca066"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"42fcc7d9b992c5677254bf48740a9381e2a0d943","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                echo_summary \"Starting Ironic Prometheus Exporter Application\""},{"line_number":82,"context_line":"                start_ironic_prometheus_exporter"},{"line_number":83,"context_line":"                echo_summary \"Give time to baremetal to provide data\""},{"line_number":84,"context_line":"                wait_for_data"},{"line_number":85,"context_line":"                ;;"},{"line_number":86,"context_line":"        esac"},{"line_number":87,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":20,"id":"3fa7e38b_1f9a02c3","line":84,"updated":"2020-02-13 16:48:34.000000000","message":"seems like right after waiting for data you should check if this works or not. Exit 1 if it fails to collect data that way we don\u0027t try to wire in tempest which is kind of heavy weight for this purpose of just doing basic integration testing when this should be a http get for data.","commit_id":"c8be1e47093856fa14052663a83f6834a7fabe89"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"93f4d876ad3ea5b78f56dceec8aeda5fa31f4476","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                echo_summary \"Starting Ironic Prometheus Exporter Application\""},{"line_number":82,"context_line":"                start_ironic_prometheus_exporter"},{"line_number":83,"context_line":"                echo_summary \"Give time to baremetal to provide data\""},{"line_number":84,"context_line":"                wait_for_data"},{"line_number":85,"context_line":"                ;;"},{"line_number":86,"context_line":"        esac"},{"line_number":87,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":20,"id":"3fa7e38b_a054eec5","line":84,"in_reply_to":"3fa7e38b_1f9a02c3","updated":"2020-02-13 17:48:20.000000000","message":"I added a check to see if the file exists first, let\u0027s see how it goes \u003d)","commit_id":"c8be1e47093856fa14052663a83f6834a7fabe89"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"301f0410cad0d8e9671225c6d839773635c2739c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    local node_file\u003d\"node-0-hardware.redfish.metrics\""},{"line_number":68,"context_line":"    if [ -f \"$IRONIC_PROMETHEUS_EXPORTER_LOCATION/$node_file\" ]; then"},{"line_number":69,"context_line":"        echo \"Found $node_file in $IRONIC_PROMETHEUS_EXPORTER_LOCATION\""},{"line_number":70,"context_line":"    else"},{"line_number":71,"context_line":"        die $LINENO \"Couldn\u0027t find $node_file in $IRONIC_PROMETHEUS_EXPORTER_LOCATION\""},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":25,"id":"3fa7e38b_21378edd","line":70,"updated":"2020-02-14 23:06:11.000000000","message":"So in addition to finding the file, do we want to validate that the data is available via the http port roughly as expected?","commit_id":"72ce6ee436885bb617ccf764c26f672d4a34a6f2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fad0970800c1c467798969b9058c5568d9ee19f2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    gunicorn_ipe_cmd\u003d$(which gunicorn3)"},{"line_number":29,"context_line":"    gunicorn_ipe_cmd+\u003d\" -b ${HOST_IP}:${IRONIC_PROMETHEUS_EXPORTER_PORT}\""},{"line_number":30,"context_line":"    gunicorn_ipe_cmd+\u003d\" --env FLASK_DEBUG\u003d1\""},{"line_number":31,"context_line":"    gunicorn_ipe_cmd+\u003d\" -w 4 ironic_prometheus_exporter.app.wsgi:application\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    write_user_unit_file $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE \"$gunicorn_ipe_cmd\" \"\" \"$STACK_USER\""}],"source_content_type":"text/x-sh","patch_set":29,"id":"3fa7e38b_d9569f2d","line":30,"updated":"2020-02-17 16:55:52.000000000","message":"add the ironic configuration file as environment variable and it should work fine","commit_id":"e3dbf817ae6754d4ef9b65bc06d4fd23b385f0bd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d79532ecb7e0d1a782838d5b4596660aa6a2a67c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    gunicorn_ipe_cmd\u003d$(which gunicorn3)"},{"line_number":29,"context_line":"    gunicorn_ipe_cmd+\u003d\" -b ${HOST_IP}:${IRONIC_PROMETHEUS_EXPORTER_PORT}\""},{"line_number":30,"context_line":"    gunicorn_ipe_cmd+\u003d\" --env FLASK_DEBUG\u003d1\""},{"line_number":31,"context_line":"    gunicorn_ipe_cmd+\u003d\" -w 4 ironic_prometheus_exporter.app.wsgi:application\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    write_user_unit_file $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE \"$gunicorn_ipe_cmd\" \"\" \"$STACK_USER\""}],"source_content_type":"text/x-sh","patch_set":29,"id":"3fa7e38b_cefb3414","line":30,"in_reply_to":"3fa7e38b_2b9c3abd","updated":"2020-02-17 19:19:48.000000000","message":"Doesn\u0027t work .-.\n\nI did a new deployment and even with the config file it doesn\u0027t work \u003d(\n\npaste","commit_id":"e3dbf817ae6754d4ef9b65bc06d4fd23b385f0bd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ec0a76547d642141b03b0ab53918fa23fa39e142","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    gunicorn_ipe_cmd\u003d$(which gunicorn3)"},{"line_number":29,"context_line":"    gunicorn_ipe_cmd+\u003d\" -b ${HOST_IP}:${IRONIC_PROMETHEUS_EXPORTER_PORT}\""},{"line_number":30,"context_line":"    gunicorn_ipe_cmd+\u003d\" --env FLASK_DEBUG\u003d1\""},{"line_number":31,"context_line":"    gunicorn_ipe_cmd+\u003d\" -w 4 ironic_prometheus_exporter.app.wsgi:application\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    write_user_unit_file $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE \"$gunicorn_ipe_cmd\" \"\" \"$STACK_USER\""}],"source_content_type":"text/x-sh","patch_set":29,"id":"3fa7e38b_df0f5cd2","line":30,"in_reply_to":"3fa7e38b_cefb3414","updated":"2020-02-17 20:50:15.000000000","message":"I tested it and it was working, did you use the correct variable?\nit should be:\n--env IRONIC_CONF_FILE\u003d/etc/ironic/ironic.conf\n\nit seems to be working now though, using IRONIC_CONFIG","commit_id":"e3dbf817ae6754d4ef9b65bc06d4fd23b385f0bd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cc45df73571760d81b25e8a2881965aa70fc9636","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    gunicorn_ipe_cmd\u003d$(which gunicorn3)"},{"line_number":29,"context_line":"    gunicorn_ipe_cmd+\u003d\" -b ${HOST_IP}:${IRONIC_PROMETHEUS_EXPORTER_PORT}\""},{"line_number":30,"context_line":"    gunicorn_ipe_cmd+\u003d\" --env FLASK_DEBUG\u003d1\""},{"line_number":31,"context_line":"    gunicorn_ipe_cmd+\u003d\" -w 4 ironic_prometheus_exporter.app.wsgi:application\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    write_user_unit_file $IRONIC_PROMETHEUS_EXPORTER_SYSTEMD_SERVICE \"$gunicorn_ipe_cmd\" \"\" \"$STACK_USER\""}],"source_content_type":"text/x-sh","patch_set":29,"id":"3fa7e38b_2b9c3abd","line":30,"in_reply_to":"3fa7e38b_d9569f2d","updated":"2020-02-17 16:59:44.000000000","message":"Done","commit_id":"e3dbf817ae6754d4ef9b65bc06d4fd23b385f0bd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0be4f8dfa1d9c02840e109a6f99cbc277571c294","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    local node_file\u003d\"node-0-hardware.redfish.metrics\""},{"line_number":73,"context_line":"    if [ -f \"$IRONIC_PROMETHEUS_EXPORTER_LOCATION/$node_file\" ]; then"},{"line_number":74,"context_line":"        echo \"Found $node_file in $IRONIC_PROMETHEUS_EXPORTER_LOCATION\""},{"line_number":75,"context_line":"        if curl -s --head  --request  GET \"http://$HOST_IP:$IRONIC_PROMETHEUS_EXPORTER_PORT/metrics\" | grep \"200 OK\" \u003e /dev/null; then"},{"line_number":76,"context_line":"            echo \"Data successfully retrived from ironic-prometheus-exporter application\""},{"line_number":77,"context_line":"        else"},{"line_number":78,"context_line":"            die $LINENO \"Couldn\u0027t get data from ironic-prometheus-exporter application\""}],"source_content_type":"text/x-sh","patch_set":34,"id":"1fa4df85_ec4e9b36","line":75,"updated":"2020-03-04 20:31:00.000000000","message":"I can roll with this. Thanks!","commit_id":"1765f44faaca43eb9274544c2e6aa33e44635920"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a654d0b0d8c1765c5874b981c3e2d2d6d326d185","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    local node_file\u003d\"node-0-hardware.redfish.metrics\""},{"line_number":73,"context_line":"    if [ -f \"$IRONIC_PROMETHEUS_EXPORTER_LOCATION/$node_file\" ]; then"},{"line_number":74,"context_line":"        echo \"Found $node_file in $IRONIC_PROMETHEUS_EXPORTER_LOCATION\""},{"line_number":75,"context_line":"        if curl -s --head  --request  GET \"http://$HOST_IP:$IRONIC_PROMETHEUS_EXPORTER_PORT/metrics\" | grep \"200 OK\" \u003e /dev/null; then"},{"line_number":76,"context_line":"            echo \"Data successfully retrived from ironic-prometheus-exporter application\""},{"line_number":77,"context_line":"        else"},{"line_number":78,"context_line":"            die $LINENO \"Couldn\u0027t get data from ironic-prometheus-exporter application\""}],"source_content_type":"text/x-sh","patch_set":34,"id":"1fa4df85_8aa7c2bd","line":75,"in_reply_to":"1fa4df85_ec4e9b36","updated":"2020-03-05 08:51:59.000000000","message":"Hey Julia, I can update here but I\u0027m not sure what problem you see \u003d)","commit_id":"1765f44faaca43eb9274544c2e6aa33e44635920"}],"devstack/settings":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0b2635543fb91f54f7a3079f029dd4a0b5d4b77b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"define_plugin ironic-prometheus-exporter"},{"line_number":2,"context_line":"plugin_requires ironic-prometheus-exporter ironic"},{"line_number":3,"context_line":"enable_service ironic_prometheus_exporter"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3fa7e38b_7df72d5c","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":41},"updated":"2020-01-15 08:55:18.000000000","message":"this probably needs to change to ironic-prometheus-exporter","commit_id":"2f07b3df5cdf0e03c1f153ce1525447f4a0ca066"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"af71d502b580a6f3be4f35078bfa63d4ca189b4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"define_plugin ironic-prometheus-exporter"},{"line_number":2,"context_line":"plugin_requires ironic-prometheus-exporter ironic"},{"line_number":3,"context_line":"enable_service ironic_prometheus_exporter"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3fa7e38b_e035b444","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":41},"in_reply_to":"3fa7e38b_7df72d5c","updated":"2020-01-15 09:29:24.000000000","message":"Done","commit_id":"2f07b3df5cdf0e03c1f153ce1525447f4a0ca066"}],"zuul.d/ironic-prometheus-exporter-jobs.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d537b225961cba2fbc8bb3fd0bc0077729a43c5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: ironic-prometheus-exporter-redfish"},{"line_number":3,"context_line":"    description:"},{"line_number":4,"context_line":"    parent: sushy-tools-tempest-ironic-partition-redfish-src"},{"line_number":5,"context_line":"    irrelevant-files:"},{"line_number":6,"context_line":"      - ^.*\\.rst$"},{"line_number":7,"context_line":"      - ^doc/.*$"},{"line_number":8,"context_line":"      - ^ironic_prometheus_exporter/tests/*$"},{"line_number":9,"context_line":"      - ^releasenotes/.$"},{"line_number":10,"context_line":"      - ^setup.cfg$"},{"line_number":11,"context_line":"      - ^tox.ini$"},{"line_number":12,"context_line":"    vars:"},{"line_number":13,"context_line":"      devstack_plugins:"},{"line_number":14,"context_line":"        ironic-prometheus-exporter: https://opendev.org/openstack/ironic-prometheus-exporter"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_03a04f8f","line":14,"range":{"start_line":1,"start_character":2,"end_line":14,"end_character":0},"updated":"2019-10-01 07:54:51.000000000","message":"expected str for dictionary value @ data[\u0027description\u0027]","commit_id":"fc3709351e3c488b955fb8a78f338cc629970449"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: ironic-prometheus-exporter-functional-redfish"},{"line_number":3,"context_line":"    description: Job that installs the exporter with redfish driver."},{"line_number":4,"context_line":"    parent: sushy-tools-tempest-ironic-partition-redfish-src"},{"line_number":5,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_d5efb41a","line":2,"updated":"2019-10-10 11:29:48.000000000","message":"s/functional-// (to avoid confusion) or even s/functional/tempest/ similar to other jobs.","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"da76ed488047f4d460b27350d39f6beb9c1add52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: ironic-prometheus-exporter-functional-redfish"},{"line_number":3,"context_line":"    description: Job that installs the exporter with redfish driver."},{"line_number":4,"context_line":"    parent: sushy-tools-tempest-ironic-partition-redfish-src"},{"line_number":5,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_e32e25aa","line":2,"in_reply_to":"3fa7e38b_35cde830","updated":"2019-10-21 15:39:18.000000000","message":"The parent job uses \"tempest\", so let\u0027s call this one with \"tempest\" as well","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: ironic-prometheus-exporter-functional-redfish"},{"line_number":3,"context_line":"    description: Job that installs the exporter with redfish driver."},{"line_number":4,"context_line":"    parent: sushy-tools-tempest-ironic-partition-redfish-src"},{"line_number":5,"context_line":"    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_35cde830","line":2,"in_reply_to":"3fa7e38b_d5efb41a","updated":"2019-10-10 12:09:37.000000000","message":"The tempests tests are only running for now, not sure if is worth it, or if the test to verify the exporter is working should be a tempest test wdyt?","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97e3fc7407630dab43c4eee4d082cdd315b0a05f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - ^ironic_prometheus_exporter/tests/*$"},{"line_number":9,"context_line":"      - ^releasenotes/.$"},{"line_number":10,"context_line":"      - ^setup.cfg$"},{"line_number":11,"context_line":"      - ^tox.ini$"},{"line_number":12,"context_line":"    vars:"},{"line_number":13,"context_line":"      devstack_plugins:"},{"line_number":14,"context_line":"        ironic-prometheus-exporter: https://opendev.org/openstack/ironic-prometheus-exporter"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_f5f430f3","line":11,"updated":"2019-10-10 11:29:48.000000000","message":"nit: also test-requirements.txt","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"200dbf9370b3b93a561273ea197542c4f9bd3bee","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - ^ironic_prometheus_exporter/tests/*$"},{"line_number":9,"context_line":"      - ^releasenotes/.$"},{"line_number":10,"context_line":"      - ^setup.cfg$"},{"line_number":11,"context_line":"      - ^tox.ini$"},{"line_number":12,"context_line":"    vars:"},{"line_number":13,"context_line":"      devstack_plugins:"},{"line_number":14,"context_line":"        ironic-prometheus-exporter: https://opendev.org/openstack/ironic-prometheus-exporter"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_d5cd7430","line":11,"in_reply_to":"3fa7e38b_f5f430f3","updated":"2019-10-10 12:09:37.000000000","message":"ack","commit_id":"1e647b25d2ff13b9ce0c20d4074720476ede8903"}],"zuul.d/project.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d537b225961cba2fbc8bb3fd0bc0077729a43c5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - check-requirements"},{"line_number":4,"context_line":"      - openstack-python-jobs"},{"line_number":5,"context_line":"      - openstack-python3-train-jobs"},{"line_number":6,"context_line":"      - release-notes-jobs-python3"},{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - ironic-prometheus-exporter-redfish"},{"line_number":10,"context_line":"    gate:"},{"line_number":11,"context_line":"      queue: ironic"},{"line_number":12,"context_line":"      jobs:"},{"line_number":13,"context_line":"        - ironic-prometheus-exporter-redfish"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_a3aa9b6d","line":13,"range":{"start_line":1,"start_character":2,"end_line":13,"end_character":0},"updated":"2019-10-01 07:54:51.000000000","message":"Job ironic-prometheus-exporter-redfish not defined","commit_id":"fc3709351e3c488b955fb8a78f338cc629970449"}]}