)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3a297ce8b1fc476f0d6f0025146e795bda2785b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"336c1757_3c73e3b9","updated":"2025-06-26 04:21:01.000000000","message":"Dmitry, \n\nI\u0027ve found a way to fix things in ironic\n\nActual sensor data sent by ironic: https://paste.opendev.org/show/b2rSBH7qTw7HqFCpLayA/\n\nData with a fix in ironic: https://paste.opendev.org/show/be4hOjoCKpWCoThUDQPu/\n\nI\u0027ve pushed  https://review.opendev.org/c/openstack/ironic/+/953395 , let me know which way you think we should proceed.\n\nThanks!","commit_id":"1ca75b5fcac85c2208b2d9a728c2618223d96bd7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f816281309236090d74c3774eceea8b39e8c3969","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a56e7a8f_2eff093e","updated":"2025-07-07 16:25:10.000000000","message":"This change is superseded by the enum fix in Ironic, right?","commit_id":"1ca75b5fcac85c2208b2d9a728c2618223d96bd7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cc3d381fd2159e380647bad429d1910b8baa76d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f835339_d88d86c0","updated":"2025-07-09 16:12:26.000000000","message":"Yeah, I will use this change for the idrac metrics,so I don\u0027t have to close this one \u003d)","commit_id":"1ca75b5fcac85c2208b2d9a728c2618223d96bd7"}],"ironic_prometheus_exporter/parsers/redfish.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"241e9b9ba1b954282d479536ef9c6933f2dbdf1f","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        labels[\u0027entity_id\u0027] \u003d \u0027PSU\u0027"},{"line_number":130,"context_line":"        labels[\u0027sensor_id\u0027] \u003d sensor_id"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if isinstance(sensor_data[\u0027health\u0027], dict):"},{"line_number":133,"context_line":"            value \u003d sensor_data[\u0027health\u0027].get(\u0027_value_\u0027) !\u003d \u0027OK\u0027 and 1 or 0"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            value \u003d sensor_data[\u0027health\u0027] !\u003d \u0027OK\u0027 and 1 or 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"5231d917_74e3620d","line":132,"updated":"2025-06-11 12:51:22.000000000","message":"this works, but I was wondering if we could use an EAFP approach instead, also since the code is the same everywhere maybe add an helper function?","commit_id":"1ca75b5fcac85c2208b2d9a728c2618223d96bd7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bad65965fa25bd0a762b40f712ccf06b90e6a055","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        labels[\u0027entity_id\u0027] \u003d \u0027PSU\u0027"},{"line_number":130,"context_line":"        labels[\u0027sensor_id\u0027] \u003d sensor_id"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if isinstance(sensor_data[\u0027health\u0027], dict):"},{"line_number":133,"context_line":"            value \u003d sensor_data[\u0027health\u0027].get(\u0027_value_\u0027) !\u003d \u0027OK\u0027 and 1 or 0"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            value \u003d sensor_data[\u0027health\u0027] !\u003d \u0027OK\u0027 and 1 or 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1adcd5e_4f5d8758","line":132,"in_reply_to":"5231d917_74e3620d","updated":"2025-06-11 12:55:50.000000000","message":"Thanks Riccardo, I will do that after finishing my investigation on the ironic side, Dmitry mentioned yesterday on irc.\n\"you may want to consider fixing it in Ironic either way. IPE may not be the only consumer of these values.\"","commit_id":"1ca75b5fcac85c2208b2d9a728c2618223d96bd7"}]}