)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b15f11c2e7f719c2f6d52ec5df41bf8218827e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69c3f1fe_ed9eb50f","updated":"2025-11-14 19:07:59.000000000","message":"-1 for now, we probably need to come up with an approach for the Drive metrics...","commit_id":"a411ba772989b6872d89d30e353331c0ed818504"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"f928ee38ced5d18e53d3b93479e1580c86bd8988","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12ae0a51_ca158e09","updated":"2025-11-17 15:14:01.000000000","message":"I\u0027m going to remove ironic-week-prio since it\u0027s been pointed out there is some rework needed here for drives.","commit_id":"a411ba772989b6872d89d30e353331c0ed818504"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ddf95db7e6cf07b0dc4daf3c89a952bff011838e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88ad6a3e_0388684c","updated":"2025-11-05 23:11:47.000000000","message":"Ideally Iury reviews this before it lands.","commit_id":"a411ba772989b6872d89d30e353331c0ed818504"}],"ironic_prometheus_exporter/parsers/redfish.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8ae813ee25c872515ceae89bce6400faa37e1949","unresolved":true,"context_lines":[{"line_number":292,"context_line":"        ignore \u003d []"},{"line_number":293,"context_line":"        labels \u003d _build_labels(node_message)"},{"line_number":294,"context_line":"        _build_sensor_labels(labels, sensor_id, sensor_data, ignore,"},{"line_number":295,"context_line":"                             entity_id\u003d\u0027HDD\u0027)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        value \u003d HEALTH_MAP.get(sensor_data[\u0027health\u0027])"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"879e746a_32d5d94b","line":295,"updated":"2025-11-04 15:05:00.000000000","message":"Was the value \"HDD\" in the original version that got removed? If not, maybe use something that does not imply a spinning disk.","commit_id":"a411ba772989b6872d89d30e353331c0ed818504"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b15f11c2e7f719c2f6d52ec5df41bf8218827e52","unresolved":true,"context_lines":[{"line_number":292,"context_line":"        ignore \u003d []"},{"line_number":293,"context_line":"        labels \u003d _build_labels(node_message)"},{"line_number":294,"context_line":"        _build_sensor_labels(labels, sensor_id, sensor_data, ignore,"},{"line_number":295,"context_line":"                             entity_id\u003d\u0027HDD\u0027)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        value \u003d HEALTH_MAP.get(sensor_data[\u0027health\u0027])"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c0c94ffa_34cb4422","line":295,"in_reply_to":"2f9eee99_60999cbe","updated":"2025-11-14 19:07:59.000000000","message":"Now I remember why I removed, before we had entity_id hard coded, this caused some confusion because we always reported HDD for Drive.\nFor example in case we only have NVME in the machine, we would report them as HDD, and this would cause confusion for the end user.\nMaybe we need to think on how to deal with the case where the Drive metrics ...","commit_id":"a411ba772989b6872d89d30e353331c0ed818504"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"338c28e4ff3b9f90d74d330e9ef5739a17842288","unresolved":true,"context_lines":[{"line_number":292,"context_line":"        ignore \u003d []"},{"line_number":293,"context_line":"        labels \u003d _build_labels(node_message)"},{"line_number":294,"context_line":"        _build_sensor_labels(labels, sensor_id, sensor_data, ignore,"},{"line_number":295,"context_line":"                             entity_id\u003d\u0027HDD\u0027)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        value \u003d HEALTH_MAP.get(sensor_data[\u0027health\u0027])"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2f9eee99_60999cbe","line":295,"in_reply_to":"879e746a_32d5d94b","updated":"2025-11-04 16:44:36.000000000","message":"HDD was in the original version. https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/954870","commit_id":"a411ba772989b6872d89d30e353331c0ed818504"}]}
