)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"39c1a8ba1065c6e47be87243cd8319b17b78b764","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c5429a2_a20177f6","updated":"2026-02-10 23:45:58.000000000","message":"Ideally we\u0027d have coverage added for timestamp_conductor_registry too. A follow up to fix the test issue pointed at and adding a test case for the conductor registry too would be nice.","commit_id":"a2df54abeb8e606b80a224e85748941ab5044099"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"960d61950470695b79667384de08cd81026518fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c06a28ac_428245c7","updated":"2026-02-10 09:53:45.000000000","message":"thanks","commit_id":"a2df54abeb8e606b80a224e85748941ab5044099"},{"author":{"_account_id":37774,"name":"Luca Del Monte","display_name":"Luca Del Monte","email":"luca.delmonte5@gmail.com","username":"lucadelmonte"},"change_message_id":"99fab68195744f126d63e83dc07b33af6a7c28fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8461a8d5_6720cde3","in_reply_to":"7c5429a2_a20177f6","updated":"2026-02-11 13:16:43.000000000","message":"Submitted a new patchset to address also this issue","commit_id":"a2df54abeb8e606b80a224e85748941ab5044099"}],"ironic_prometheus_exporter/tests/test_header_parser.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"39c1a8ba1065c6e47be87243cd8319b17b78b764","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        sample_file_2 \u003d os.path.join("},{"line_number":100,"context_line":"            os.path.dirname(ironic_prometheus_exporter.__file__),"},{"line_number":101,"context_line":"            \u0027tests\u0027, \u0027json_samples\u0027, \u0027notification-missing-timestamp.json\u0027)"},{"line_number":102,"context_line":"        msg2 \u003d json.load(open(sample_file_2))"},{"line_number":103,"context_line":"        self.assertNotIn(\u0027timestamp\u0027, msg2[\u0027payload\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        header.timestamp_registry(msg2[\u0027payload\u0027], self.metric_registry)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f0d42f75_32e3a8f3","line":102,"updated":"2026-02-10 23:45:58.000000000","message":"this leaks file descriptors; we should use a `with open(sample_file_2):` so it gets closed. This already exists in other tests in this file, and isn\u0027t blocking feedback","commit_id":"a2df54abeb8e606b80a224e85748941ab5044099"},{"author":{"_account_id":37774,"name":"Luca Del Monte","display_name":"Luca Del Monte","email":"luca.delmonte5@gmail.com","username":"lucadelmonte"},"change_message_id":"99fab68195744f126d63e83dc07b33af6a7c28fb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        sample_file_2 \u003d os.path.join("},{"line_number":100,"context_line":"            os.path.dirname(ironic_prometheus_exporter.__file__),"},{"line_number":101,"context_line":"            \u0027tests\u0027, \u0027json_samples\u0027, \u0027notification-missing-timestamp.json\u0027)"},{"line_number":102,"context_line":"        msg2 \u003d json.load(open(sample_file_2))"},{"line_number":103,"context_line":"        self.assertNotIn(\u0027timestamp\u0027, msg2[\u0027payload\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        header.timestamp_registry(msg2[\u0027payload\u0027], self.metric_registry)"}],"source_content_type":"text/x-python","patch_set":4,"id":"39659c98_98d9ad68","line":102,"in_reply_to":"f0d42f75_32e3a8f3","updated":"2026-02-11 13:16:43.000000000","message":"Fixed all instances of this in the test file, let me know if there are others instances where this should be fixed.","commit_id":"a2df54abeb8e606b80a224e85748941ab5044099"}]}