)]}'
{"build.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1822d9a01f6e8c28a413d5469fcc09e237226d34","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#The path for location of ironic-python-agent-ramdisk in ironic-python-image-builder"},{"line_number":4,"context_line":"#is set using environment variable."},{"line_number":5,"context_line":"cd .."},{"line_number":6,"context_line":"export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`/ironic-python-agent-builder/element}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#The command to build image using disk-image-builder."},{"line_number":9,"context_line":"#Run the command to build the image giving the argument(OS name)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_c97cbc73","line":6,"range":{"start_line":6,"start_character":43,"end_line":6,"end_character":71},"updated":"2019-07-18 09:04:15.000000000","message":"I think we should expect the user to be inside the ironic-python-agent-builder directory. SO this can be shorted to just\n\n export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-./element}","commit_id":"aa53962e83c1ee33ed109c841f2b9ea15a48f3f6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5490d85dbf21ee9c8173b5729059e43403f01df6","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#The path for location of ironic-python-agent-ramdisk in ironic-python-image-builder"},{"line_number":4,"context_line":"#is set using environment variable."},{"line_number":5,"context_line":"export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`/element}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"#The command to build image using disk-image-builder."},{"line_number":8,"context_line":"#Run the command to build the image giving the argument(OS name)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7faddb67_7839c2ef","line":5,"range":{"start_line":5,"start_character":38,"end_line":5,"end_character":51},"updated":"2019-07-19 08:37:24.000000000","message":"this won\u0027t work, you can change it to ./element as suggested by Dmitry","commit_id":"2d1cf71bdc42065a07bc3a82790dca0595635e44"}],"dib/build.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d308212b57e372efc347a0ae9a4d47315cf400e0","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#The path for location of ironic-python-agent-ramdisk in ironic-python-image-builder"},{"line_number":4,"context_line":"#is set using environment variable."},{"line_number":5,"context_line":"export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-`pwd`}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"#The command to build image using disk-image-builder."},{"line_number":8,"context_line":"#Run the command to build the image giving the argument(OS name)"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7faddb67_4658e32f","line":5,"updated":"2019-08-01 13:58:09.000000000","message":"nit: just use . instead of `pwd`","commit_id":"3d219c2790f6d124874b7040cf4fbeaba296c146"}],"dib/ironic-python-agent-ramdisk/README.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d308212b57e372efc347a0ae9a4d47315cf400e0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"More information can be found at:"},{"line_number":7,"context_line":"https://opendev.org/openstack/ironic-python-agent/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Beyond installing the ironic-python-agent, this element does the following:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_26536718","line":7,"updated":"2019-08-01 13:58:09.000000000","message":"nit: the canonical documentation link is https://docs.openstack.org/ironic-python-agent/latest/","commit_id":"3d219c2790f6d124874b7040cf4fbeaba296c146"}],"element/ironic-python-agent-ramdisk/README.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac174a6722e8df784fb79fff00d9dacc5eecb607","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"ironic-agent"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://opendev.org/openstack/ironic-python-agent/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_cd522b68","line":2,"updated":"2019-07-08 13:29:15.000000000","message":"needs changing","commit_id":"1d7dd61ee9c8c353020509e6c634ef9a5d4e1961"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3667b39413704b0327e5ebb55011c95a396ec60a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"ironic-agent"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://opendev.org/openstack/ironic-python-agent/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_d55951fe","line":2,"in_reply_to":"7faddb67_cd522b68","updated":"2019-07-08 15:28:54.000000000","message":"++\ngood opportunity to change all \"ironic-agent\" to \"ironic-python-agent\" everywhere, there are some left in script names and comments","commit_id":"1d7dd61ee9c8c353020509e6c634ef9a5d4e1961"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1822d9a01f6e8c28a413d5469fcc09e237226d34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"ironic-python-agent"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://opendev.org/openstack/ironic-python-agent/"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_899a44b6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":19},"updated":"2019-07-18 09:04:15.000000000","message":"ironic-python-agent-ramdisk (it has to be the name of the element)","commit_id":"aa53962e83c1ee33ed109c841f2b9ea15a48f3f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1822d9a01f6e8c28a413d5469fcc09e237226d34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"ironic-python-agent"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://opendev.org/openstack/ironic-python-agent/"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_a995c088","line":3,"updated":"2019-07-18 09:04:15.000000000","message":"The \u003d\u003d line must have the same length as the title","commit_id":"aa53962e83c1ee33ed109c841f2b9ea15a48f3f6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5490d85dbf21ee9c8173b5729059e43403f01df6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"ironic-python-agent-ramdisk"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Builds a ramdisk with ironic-python-agent.  More information can be found at:"},{"line_number":5,"context_line":"    https://opendev.org/openstack/ironic-python-agent/"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Beyond installing the ironic-python-agent, this element does the following:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_786b02f0","line":4,"updated":"2019-07-19 08:37:24.000000000","message":"nit: I would split this line and leave a blank one after the title","commit_id":"2d1cf71bdc42065a07bc3a82790dca0595635e44"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5490d85dbf21ee9c8173b5729059e43403f01df6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  ``DIB_IPA_CERT`` for validating the authenticity by ironic-python-agent. The"},{"line_number":20,"context_line":"  certificate can be self-signed certificate or CA certificate."},{"line_number":21,"context_line":"* Compresses initramfs with command specified in environment variable"},{"line_number":22,"context_line":"  ``DIB_IPA_COMPRESS_CMD``, which is \u0027gzip\u0027 by default. This command should listen"},{"line_number":23,"context_line":"  for raw data from stdin and write compressed data to stdout. Command can be"},{"line_number":24,"context_line":"  with arguments."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7faddb67_f8a93223","line":22,"updated":"2019-07-19 08:37:24.000000000","message":"nit: line over 80 characters length","commit_id":"2d1cf71bdc42065a07bc3a82790dca0595635e44"}],"element/ironic-python-agent-ramdisk/build.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac174a6722e8df784fb79fff00d9dacc5eecb607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7faddb67_ed5b6784","updated":"2019-07-08 13:29:15.000000000","message":"This should be outside of the element, probably in the top level","commit_id":"1d7dd61ee9c8c353020509e6c634ef9a5d4e1961"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac174a6722e8df784fb79fff00d9dacc5eecb607","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#The path for location of ironic-python-agent-ramdisk in ironic-python-image-builder "},{"line_number":4,"context_line":"#is set using environment variable."},{"line_number":5,"context_line":"export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-/opt/stack/ironic-python-agent-builder/element}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"#The command to build image using disk-image-builder."},{"line_number":8,"context_line":"disk-image-create -o op.qcow ironic-python-agent-ramdisk ubuntu"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_0d612337","line":5,"updated":"2019-07-08 13:29:15.000000000","message":"this should be relative to the current directory, not in /opt (imagine somebody running this on their laptop)","commit_id":"1d7dd61ee9c8c353020509e6c634ef9a5d4e1961"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ac174a6722e8df784fb79fff00d9dacc5eecb607","unresolved":false,"context_lines":[{"line_number":5,"context_line":"export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-/opt/stack/ironic-python-agent-builder/element}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"#The command to build image using disk-image-builder."},{"line_number":8,"context_line":"disk-image-create -o op.qcow ironic-python-agent-ramdisk ubuntu"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_ad556f52","line":8,"updated":"2019-07-08 13:29:15.000000000","message":"ubuntu should be customizable","commit_id":"1d7dd61ee9c8c353020509e6c634ef9a5d4e1961"}],"element/ironic-python-agent-ramdisk/environment.d/01-ironic-agent.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3667b39413704b0327e5ebb55011c95a396ec60a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# backwards compatibility with the previous environment"},{"line_number":2,"context_line":"# variable for the ironic-agent source repository"},{"line_number":3,"context_line":"if [ -n \"${DIB_REPOREF_agent:-}\" ]; then"},{"line_number":4,"context_line":"  echo \"WARNING: DIB_REPOREF_agent is deprecated. Please update to use DIB_REPOREF_ironic_agent instead.\""},{"line_number":5,"context_line":"  export DIB_REPOREF_ironic_agent\u003d${DIB_REPOREF_agent}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_75b5fd30","line":2,"range":{"start_line":2,"start_character":19,"end_line":2,"end_character":31},"updated":"2019-07-08 15:28:54.000000000","message":"nit: ironic-python-agent","commit_id":"1d7dd61ee9c8c353020509e6c634ef9a5d4e1961"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1822d9a01f6e8c28a413d5469fcc09e237226d34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_29ef901e","updated":"2019-07-18 09:04:15.000000000","message":"Let\u0027s remove this, everything in this file seems deprecated","commit_id":"aa53962e83c1ee33ed109c841f2b9ea15a48f3f6"}]}